TracksAbstract - Code Metrics - Inspection of "Dev issue 6 tracks pr" - maqe/laravel-qwatcher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

unknown

created 2016-10-31 06:15 UTC

TracksAbstract A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	3
dl	0
loc	49
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
	pushToTracks()	1	?
A	create()	4	1
A	update()	4	1
A	prepareRecord()	10	1

<?php namespace Maqe\Qwatcher\Tracks;

use Illuminate\Queue\Queue;
use Carbon\Carbon;
use Maqe\Qwatcher\Tracks\Enums\StatusType;

abstract class TracksAbstract extends Queue
{
    /**
     * Push job to tracks table
     *
     * @return mixed
     */
    abstract public function pushToTracks($id, $job = null);

    /**
     * Create tracks record from job
     *
     * @param  mixed    $job        The queue job object
     * @return integer  $id         The new tracks id
     */
    protected function create($id, $job = null)
    {
        return Tracks::create($this->prepareRecord($id, $job))->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Update status tracks record by queue id and status type
     *
     * @param  integer  $id         The queue id to track queue record
     * @param  enum     $status     The status tracks type
     * @return boolean|mixed        The update result
     */
    protected function update($id, $job, $status)
    {
        return Tracks::where('queue_id', $id)->update(['attempts' => $job->attempts(), "{$status}_at" => Carbon::now()]);
    }

    /**
     * Prepare record before create new record
     *
     * @param  mixed $job           The queue job object
     * @return array                The array for input to database
     */
    protected function prepareRecord($id, $job)
    {
        return [
            'driver' => config('qwatcher.driver'),
            'queue_id' => $id,
            'payload' => $this->createPayload($job),
            'attempts' => 0,
            'queue_at' => Carbon::now()
        ];
    }
}


1			<?php namespace Maqe\Qwatcher\Tracks;
2
3			use Illuminate\Queue\Queue;
4			use Carbon\Carbon;
5			use Maqe\Qwatcher\Tracks\Enums\StatusType;
6
7			abstract class TracksAbstract extends Queue
8			{
9			/**
10			* Push job to tracks table
11			*
12			* @return mixed
13			*/
14			abstract public function pushToTracks($id, $job = null);
15
16			/**
17			* Create tracks record from job
18			*
19			* @param mixed $job The queue job object
20			* @return integer $id The new tracks id
21			*/
22			protected function create($id, $job = null)
23			{
24			return Tracks::create($this->prepareRecord($id, $job))->id;
			0 ignored issues – show Documentation introduced 2016-10-31 06:19 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<Maqe\Qwatcher\Tracks\Tracks>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25			}
26
27			/**
28			* Update status tracks record by queue id and status type
29			*
30			* @param integer $id The queue id to track queue record
31			* @param enum $status The status tracks type
32			* @return boolean\|mixed The update result
33			*/
34			protected function update($id, $job, $status)
35			{
36			return Tracks::where('queue_id', $id)->update(['attempts' => $job->attempts(), "{$status}_at" => Carbon::now()]);
37			}
38
39			/**
40			* Prepare record before create new record
41			*
42			* @param mixed $job The queue job object
43			* @return array The array for input to database
44			*/
45			protected function prepareRecord($id, $job)
46			{
47			return [
48			'driver' => config('qwatcher.driver'),
49			'queue_id' => $id,
50			'payload' => $this->createPayload($job),
51			'attempts' => 0,
52			'queue_at' => Carbon::now()
53			];
54			}
55			}
56

maqe / laravel-qwatcher

Pull Request — master (#21)

TracksAbstract A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like