Mapado\RestClientSdk\EntityRepository::__call()

Complexity

Conditions	10
Paths	35

Size

Total Lines	74
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	39
CRAP Score	10.0363

Importance

Changes

0

<?php
    public function __call($method, $arguments)
    {
        switch (true) {
            case 0 === strpos($method, 'findBy'):
                $fieldName = strtolower(substr($method, 6));
                $methodName = 'findBy';
                break;

            case 0 === strpos($method, 'findOneBy'):
                $fieldName = strtolower(substr($method, 9));
                $methodName = 'findOneBy';
                break;

            default:
                throw new \BadMethodCallException(
                    'Undefined method \'' . $method . '\'. The method name must start with
                    either findBy or findOneBy!'
                );
        }

        if (empty($arguments)) {
            throw new SdkException('You need to pass a parameter to ' . $method);
        }

        $mapping = $this->sdk->getMapping();
        $key = $mapping->getKeyFromModel($this->entityName);
        $prefix = $mapping->getIdPrefix();
        $path = empty($prefix) ? '/' . $key : $prefix . '/' . $key;

        if (!empty($fieldName)) {
            $queryParams = [$fieldName => current($arguments)];
        } else {
            $queryParams = current($arguments);
        }
        $path .= '?' . http_build_query($this->convertQueryParameters($queryParams));

        // if entityList is found in cache, return it
        $entityListFromCache = $this->fetchFromCache($path);
        if (false !== $entityListFromCache) {
            return $entityListFromCache;
        }

        $data = $this->restClient->get($path);

        $hydrator = $this->sdk->getModelHydrator();

        if ('findOneBy' == $methodName) {
            // If more results are found but one is requested return the first hit.
            $collectionKey = $mapping->getConfig()['collectionKey'];
            $entityList = ArrayHelper::arrayGet($data, $collectionKey);

It seems like $data can also be of type Psr\Http\Message\ResponseInterface; however, parameter $array of Mapado\RestClientSdk\Helper\ArrayHelper::arrayGet() does only seem to accept array, maybe add an additional type check?

            if (!empty($entityList)) {
                $data = current($entityList);

It seems like $entityList can also be of type Psr\Http\Message\ResponseInterface; however, parameter $array of current() does only seem to accept array, maybe add an additional type check?

                $hydratedData = $hydrator->hydrate($data, $this->entityName);

                $identifier = $hydratedData->{$this->getClassMetadata()->getIdGetter()}();
                $this->unitOfWork->registerClean($identifier, $hydratedData);
                $this->saveToCache($identifier, $hydratedData);
            } else {
                $hydratedData = null;
            }
        } else {
            $hydratedData = $hydrator->hydrateList($data, $this->entityName);

It seems like $data can also be of type Psr\Http\Message\ResponseInterface; however, parameter $data of Mapado\RestClientSdk\Model\ModelHydrator::hydrateList() does only seem to accept array, maybe add an additional type check?

            // then cache each entity from list
            foreach ($hydratedData as $entity) {
                $identifier = $entity->{$this->getClassMetadata()->getIdGetter()}();
                $this->saveToCache($identifier, $entity);
                $this->unitOfWork->registerClean($identifier, $entity);
            }
        }

        $this->saveToCache($path, $hydratedData);

        return $hydratedData;

The expression return $hydratedData also could return the type Mapado\RestClientSdk\Collection\Collection which is incompatible with the documented return type object|array.

    }