UnitOfWork::getDirtyFields() - Code Metrics - Inspection of "unit of work for put requests" - mapado/rest-client-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#58)

unknown

created 2017-06-23 06:20 UTC

UnitOfWork::getDirtyFields() C

↳ Parent: UnitOfWork

Complexity

Conditions	12
Paths	16

Size

Total Lines	37
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	37
rs	5.1612
cc	12
eloc	23
nc	16
nop	3

How to fix Complexity

<?php

namespace Mapado\RestClientSdk;

use Mapado\RestClientSdk\Mapping\ClassMetadata;
use Mapado\RestClientSdk\Mapping;

/**
 * UnitOfWork
 */
class UnitOfWork
{
    /**
     * mapping
     *
     * @var Mapping
     * @access private
     */
    private $mapping;

    /**
     * storage for every entity retrieved
     *
     * @var array
     */
    private $storage;

    /**
     * Constructor.
     */
    public function __construct(Mapping $mapping)
    {
        $this->mapping = $mapping;
        $this->storage = [];
    }

    /**
     * getDirtyData
     *
     * @param array $newSerializedModel
     * @param array $oldSerializedModel
     * @access public
     * @return array
     */
    public function getDirtyData(array $newSerializedModel, array $oldSerializedModel, ClassMetadata $classMetadata)
    {
        return $this->getDirtyFields($newSerializedModel, $oldSerializedModel, $classMetadata);
    }

    /**
     * registerClean
     *
     * @param string $id
     * @param object $entity
     * @access public
     * @return UnitOfWork
     */
    public function registerClean($id, $entity)
    {
        if (is_object($entity)) {
            $entityStored = clone $entity;
            $this->storage[$id] = $entityStored;
        }

        return $this;
    }

    /**
     * getDirtyEntity
     *
     * @param string $id
     * @access public
     * @return mixed
     */
    public function getDirtyEntity($id)
    {
        if (isset($this->storage[$id])) {
            return $this->storage[$id];
        }
        return null;
    }

    /**
     * clear
     *
     * @param string $id
     * @access public
     * @return UnitOfWork
     */
    public function clear($id)
    {
        unset($this->storage[$id]);
        return $this;
    }

    /**
     * getDirtyFields
     *
     * @param array $newArrayModel
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array $oldSerializedModel
     * @access private
     * @return array
     */
    private function getDirtyFields(array $newSerializedModel, array $oldSerializedModel, ClassMetadata $classMetadata = null)
    {
        $dirtyFields = [];

        foreach ($newSerializedModel as $key => $value) {
            if (array_key_exists($key, $oldSerializedModel)) {
                if (is_array($value)) {
                    $currentClassMetadata = $classMetadata->getRelation($key) ? $this->mapping->getClassMetadata($classMetadata->getRelation($key)->getTargetEntity()) : null;
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
                    $idSerializedKey = $currentClassMetadata ? $currentClassMetadata->getIdSerializeKey() : null;
                    $recursiveDiff = $this->getDirtyFields($value, $oldSerializedModel[$key], $currentClassMetadata);
                    if (count($recursiveDiff)) {
                        $dirtyFields[$key] = $recursiveDiff;
                        $dirtyFields[$key] = $this->addIdentifiers($value, $dirtyFields[$key], $idSerializedKey);

                        //if theres only ids not objects, keep them
                        foreach ($value as $valueKey => $valueId) {
                            if (is_string($valueId) && is_int($valueKey)) {
                                $dirtyFields[$key][$valueKey] = $valueId;
                            }
                        }
                    } elseif (count($value) != count($oldSerializedModel[$key])) {
                        //get all objects ids of new array
                        $dirtyFields[$key] = [];
                        $dirtyFields[$key] = $this->addIdentifiers($value, $dirtyFields[$key], $idSerializedKey);
                    }
                } else {
                    if ($value != $oldSerializedModel[$key]) {
                        $dirtyFields[$key] = $value;
                    }
                }
            } else {
                $dirtyFields[$key] = $value;
            }
        }

        return $dirtyFields;
    }

    /**
     * addIdentifiers
     *
     * @param array $newSerializedModel
     * @param array $dirtyFields
     * @access private
     * @return array
     */
    private function addIdentifiers($newSerializedModel, $dirtyFields, $idSerializedKey = null)
    {
        foreach ($newSerializedModel as $key => $value) {
            if ($idSerializedKey && isset($value[$idSerializedKey])) {
                $dirtyFields[$key][$idSerializedKey] = $value[$idSerializedKey];
            } elseif (is_string($value) && is_int($key)) {
                $dirtyFields[$key] = $value;
            }
        }

        return $dirtyFields;
    }
}


1			<?php
2
3			namespace Mapado\RestClientSdk;
4
5			use Mapado\RestClientSdk\Mapping\ClassMetadata;
6			use Mapado\RestClientSdk\Mapping;
7
8			/**
9			* UnitOfWork
10			*/
11			class UnitOfWork
12			{
13			/**
14			* mapping
15			*
16			* @var Mapping
17			* @access private
18			*/
19			private $mapping;
20
21			/**
22			* storage for every entity retrieved
23			*
24			* @var array
25			*/
26			private $storage;
27
28			/**
29			* Constructor.
30			*/
31			public function __construct(Mapping $mapping)
32			{
33			$this->mapping = $mapping;
34			$this->storage = [];
35			}
36
37			/**
38			* getDirtyData
39			*
40			* @param array $newSerializedModel
41			* @param array $oldSerializedModel
42			* @access public
43			* @return array
44			*/
45			public function getDirtyData(array $newSerializedModel, array $oldSerializedModel, ClassMetadata $classMetadata)
46			{
47			return $this->getDirtyFields($newSerializedModel, $oldSerializedModel, $classMetadata);
48			}
49
50			/**
51			* registerClean
52			*
53			* @param string $id
54			* @param object $entity
55			* @access public
56			* @return UnitOfWork
57			*/
58			public function registerClean($id, $entity)
59			{
60			if (is_object($entity)) {
61			$entityStored = clone $entity;
62			$this->storage[$id] = $entityStored;
63			}
64
65			return $this;
66			}
67
68			/**
69			* getDirtyEntity
70			*
71			* @param string $id
72			* @access public
73			* @return mixed
74			*/
75			public function getDirtyEntity($id)
76			{
77			if (isset($this->storage[$id])) {
78			return $this->storage[$id];
79			}
80			return null;
81			}
82
83			/**
84			* clear
85			*
86			* @param string $id
87			* @access public
88			* @return UnitOfWork
89			*/
90			public function clear($id)
91			{
92			unset($this->storage[$id]);
93			return $this;
94			}
95
96			/**
97			* getDirtyFields
98			*
99			* @param array $newArrayModel
			0 ignored issues – show Bug introduced 2017-06-23 06:27 UTC by Report Bug Copy Issue Report There is no parameter named `$newArrayModel`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
100			* @param array $oldSerializedModel
101			* @access private
102			* @return array
103			*/
104			private function getDirtyFields(array $newSerializedModel, array $oldSerializedModel, ClassMetadata $classMetadata = null)
105			{
106			$dirtyFields = [];
107
108			foreach ($newSerializedModel as $key => $value) {
109			if (array_key_exists($key, $oldSerializedModel)) {
110			if (is_array($value)) {
111			$currentClassMetadata = $classMetadata->getRelation($key) ? $this->mapping->getClassMetadata($classMetadata->getRelation($key)->getTargetEntity()) : null;
			0 ignored issues – show Bug introduced 2017-06-23 06:27 UTC by Report Bug Copy Issue Report It seems like `$classMetadata` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
112			$idSerializedKey = $currentClassMetadata ? $currentClassMetadata->getIdSerializeKey() : null;
113			$recursiveDiff = $this->getDirtyFields($value, $oldSerializedModel[$key], $currentClassMetadata);
114			if (count($recursiveDiff)) {
115			$dirtyFields[$key] = $recursiveDiff;
116			$dirtyFields[$key] = $this->addIdentifiers($value, $dirtyFields[$key], $idSerializedKey);
117
118			//if theres only ids not objects, keep them
119			foreach ($value as $valueKey => $valueId) {
120			if (is_string($valueId) && is_int($valueKey)) {
121			$dirtyFields[$key][$valueKey] = $valueId;
122			}
123			}
124			} elseif (count($value) != count($oldSerializedModel[$key])) {
125			//get all objects ids of new array
126			$dirtyFields[$key] = [];
127			$dirtyFields[$key] = $this->addIdentifiers($value, $dirtyFields[$key], $idSerializedKey);
128			}
129			} else {
130			if ($value != $oldSerializedModel[$key]) {
131			$dirtyFields[$key] = $value;
132			}
133			}
134			} else {
135			$dirtyFields[$key] = $value;
136			}
137			}
138
139			return $dirtyFields;
140			}
141
142			/**
143			* addIdentifiers
144			*
145			* @param array $newSerializedModel
146			* @param array $dirtyFields
147			* @access private
148			* @return array
149			*/
150			private function addIdentifiers($newSerializedModel, $dirtyFields, $idSerializedKey = null)
151			{
152			foreach ($newSerializedModel as $key => $value) {
153			if ($idSerializedKey && isset($value[$idSerializedKey])) {
154			$dirtyFields[$key][$idSerializedKey] = $value[$idSerializedKey];
155			} elseif (is_string($value) && is_int($key)) {
156			$dirtyFields[$key] = $value;
157			}
158			}
159
160			return $dirtyFields;
161			}
162			}
163

mapado / rest-client-sdk

Pull Request — master (#58)

UnitOfWork::getDirtyFields() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like