mapado / rest-client-sdk

src/EntityRepository.php

Doc Comments -2 removed lines

@@ -278,7 +278,6 @@ 
     /**
      * fetchFromCache
      *
-     * @param array $data
      * @access private
      * @return object
      */
@@ -301,7 +300,6 @@ 
     /**
      * saveToCache
      *
-     * @param array $data
      * @access private
      * @return object
      */

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 namespace Mapado\RestClientSdk;
 
 use Mapado\RestClientSdk\Exception\SdkException;
-use Symfony\Component\Cache\CacheItem;
 
 class EntityRepository
 {

Spacing +1 added lines, -1 removed lines

@@ -264,7 +264,7 @@
         $sdk = $this->sdk;
 
         return array_map(
-            function ($item) use ($sdk) {
+            function($item) use ($sdk) {
                 if (is_object($item) && method_exists($item, 'getId')) {
                     return $item->getId();
                 }

Tests/Units/EntityRepository.php

Doc Comments -1 removed lines

@@ -125,7 +125,6 @@
     /**
      * testFindWithCache
      *
-     * @param mixed $method
      * @access public
      * @return void
      */

Spacing +6 added lines, -6 removed lines

@@ -114,7 +114,7 @@ 
         $this->calling($this->mockedRestClient)->get = [];
 
         $this
-            ->if($this->repository->find('1', [ 'foo' => 'bar', 'bar'  => 'baz' ]))
+            ->if($this->repository->find('1', ['foo' => 'bar', 'bar'  => 'baz']))
             ->then
                 ->mock($this->mockedRestClient)
                     ->call('get')
@@ -177,8 +177,8 @@ 
             ->given($this->resetMock($this->mockedRestClient))
                 ->and($this->mockedSdk->getCacheItemPool()->clear())
 
-            ->if($this->repository->findBy([ 'foo' => 'bar', 'bar'  => 'baz' ]))
-            ->and($this->repository->findBy([ 'foo' => 'bar', 'bar'  => 'baz' ]))
+            ->if($this->repository->findBy(['foo' => 'bar', 'bar'  => 'baz']))
+            ->and($this->repository->findBy(['foo' => 'bar', 'bar'  => 'baz']))
             ->if($this->repository->find(1))
             ->then
                 ->mock($this->mockedRestClient)
@@ -203,8 +203,8 @@ 
             // find one by
             ->given($this->resetMock($this->mockedRestClient))
 
-            ->if($this->repository->findOneBy([ 'foo' => 'baz', 'bar'  => 'bar' ]))
-            ->and($this->repository->findOneBy([ 'foo' => 'baz', 'bar'  => 'bar' ]))
+            ->if($this->repository->findOneBy(['foo' => 'baz', 'bar'  => 'bar']))
+            ->and($this->repository->findOneBy(['foo' => 'baz', 'bar'  => 'bar']))
             ->then
                 ->mock($this->mockedRestClient)
                     ->call('get')
@@ -222,7 +222,7 @@ 
 
             // find one by with data already in cache
             ->given($this->resetMock($this->mockedRestClient))
-            ->if($this->repository->findOneBy([ 'foo' => 'bar', 'bar'  => 'baz' ]))
+            ->if($this->repository->findOneBy(['foo' => 'bar', 'bar'  => 'baz']))
             ->then
                 ->mock($this->mockedRestClient)
                     ->call('get')

src/Model/Serializer.php

Spacing +1 added lines, -1 removed lines

@@ -195,7 +195,7 @@
                                 $item,
                                 $relation->getTargetEntity(),
                                 $level + 1,
-                                [ 'serializeRelation' => $serializeRelation ]
+                                ['serializeRelation' => $serializeRelation]
                             );
                         } else {
                             $newData[$key] = $item;

Tests/Units/Model/Serializer.php

Doc Comments +10 added lines, -6 removed lines

@@ -670,7 +670,7 @@ 
      * createNewCart
      *
      * @access private
-     * @return AbstractModel
+     * @return \Mapado\RestClientSdk\Tests\Model\Cart
      */
     private function createNewCart()
     {
@@ -689,7 +689,7 @@ 
      * createCart
      *
      * @access private
-     * @return void
+     * @return \Mapado\RestClientSdk\Tests\Model\Cart
      */
     private function createCart()
     {
@@ -703,7 +703,7 @@ 
      * createKnownCartItem
      *
      * @access private
-     * @return AbstractModel
+     * @return \Mapado\RestClientSdk\Tests\Model\CartItem
      */
     private function createKnownCartItem()
     {
@@ -724,7 +724,7 @@ 
      * createNewCartItem
      *
      * @access private
-     * @return AbstractModel
+     * @return \Mapado\RestClientSdk\Tests\Model\CartItem
      */
     private function createNewCartItem($addKnownedProduct = true)
     {
@@ -747,7 +747,7 @@ 
      * createNewProduct
      *
      * @access private
-     * @return AbstractModel
+     * @return \Mapado\RestClientSdk\Tests\Model\Product
      */
     private function createNewProduct()
     {
@@ -764,7 +764,7 @@ 
      * createKnownedProduct
      *
      * @access private
-     * @return AbstractModel
+     * @return \Mapado\RestClientSdk\Tests\Model\Product
      */
     private function createKnownedProduct()
     {
@@ -787,6 +787,7 @@ 
      * createNewInstance
      *
      * @access private
+     * @param Mapping $mapping
      * @return void
      */
     private function createNewInstance($mapping = null)
@@ -815,6 +816,9 @@ 
         $this->testedInstance->setSdk($sdk);
     }
 
+    /**
+     * @param string $modelName
+     */
     private function getCartRepositoryMock($sdk, $restClient, $modelName)
     {
         $repository = new \mock\Mapado\RestClientSdk\EntityRepository(

Spacing +10 added lines, -10 removed lines

@@ -75,7 +75,7 @@ 
                 ->array($data = $this->testedInstance->serialize(
                     $cart,
                     'Mapado\RestClientSdk\Tests\Model\Cart',
-                    [ 'serializeRelations' => ['cart_items'] ]
+                    ['serializeRelations' => ['cart_items']]
                 ))
                     ->isIdenticalTo([
                         '@id' => '/v1/carts/8',
@@ -103,7 +103,7 @@ 
                 ->array($data = $this->testedInstance->serialize(
                     $cart,
                     'Mapado\RestClientSdk\Tests\Model\Cart',
-                    [ 'serializeRelations' => ['cart_items'] ]
+                    ['serializeRelations' => ['cart_items']]
                 ))
                     ->isIdenticalTo([
                         '@id' => '/v1/carts/8',
@@ -245,8 +245,8 @@ 
                                     'who' => 'John',
                                 ],
                                 'cartItemDetailList' => [
-                                    [ 'name' => 'Bill' ],
-                                    [ 'name' => 'Bill', ],
+                                    ['name' => 'Bill'],
+                                    ['name' => 'Bill', ],
                                 ],
                             ],
                         ],
@@ -275,7 +275,7 @@ 
                 ->array($data = $this->testedInstance->serialize(
                     $cart,
                     'Mapado\RestClientSdk\Tests\Model\Cart',
-                    [ 'serializeRelations' => ['cart_items'] ]
+                    ['serializeRelations' => ['cart_items']]
                 ))
                     ->isIdenticalTo([
                         '@id' => '/v1/carts/8',
@@ -338,7 +338,7 @@ 
             ->then
                 ->object($cartItemDetail->getCartItem())
                     ->isInstanceOf('Mapado\RestClientSdk\Tests\Model\CartItem')
-                ->exception(function () use ($testedInstance, $cartItemDetail) {
+                ->exception(function() use ($testedInstance, $cartItemDetail) {
                     $testedInstance->serialize($cartItemDetail, 'Mapado\RestClientSdk\Tests\Model\CartItemDetail');
                 })
                     ->isInstanceOf('Mapado\RestClientSdk\Exception\SdkException')
@@ -513,7 +513,7 @@ 
                 ->array($data = $this->testedInstance->serialize(
                     $cart,
                     'Mapado\RestClientSdk\Tests\Model\Cart',
-                    [ 'serializeRelations' => ['cart_items'] ]
+                    ['serializeRelations' => ['cart_items']]
                 ))
                     ->isIdenticalTo([
                         'weirdId' => '/v1/carts/8',
@@ -541,7 +541,7 @@ 
                 ->array($data = $this->testedInstance->serialize(
                     $cart,
                     'Mapado\RestClientSdk\Tests\Model\Cart',
-                    [ 'serializeRelations' => ['cart_items'] ]
+                    ['serializeRelations' => ['cart_items']]
                 ))
                     ->isIdenticalTo([
                         'weirdId' => '/v1/carts/8',
@@ -803,7 +803,7 @@ 
 
         $cartRepositoryMock = $this->getCartRepositoryMock($sdk, $restClient, 'Mapado\RestClientSdk\Tests\Model\Cart');
 
-        $this->calling($sdk)->getRepository = function ($modelName) use ($cartRepositoryMock) {
+        $this->calling($sdk)->getRepository = function($modelName) use ($cartRepositoryMock) {
             switch ($modelName) {
                 case 'Mapado\RestClientSdk\Tests\Model\Cart':
                     return $cartRepositoryMock;
@@ -825,7 +825,7 @@ 
 
         $_this = $this;
 
-        $this->calling($repository)->find = function ($id) use ($_this) {
+        $this->calling($repository)->find = function($id) use ($_this) {
             return $_this->createCart();
         };