Issues in Serve.php (master) - Issues in master - maou/simple-asset-manager - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Serve.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Simple\Asset;

use MatthiasMullie\Minify;

/**
 * wrapper for MatthiasMullie\Minify
 */
class Serve
{
    public $path;
    public $opts = array(
                        'etag' => true,
                        'timeout' => 604800,
                        'maxAge' => 315360000,
                        'gzip' => false
                        );


    public function __construct($path = null, $opts = array())
    {
        if (!empty($path)) {
            $dir = dirname($path);
            if (!file_exists($dir)) {
                @mkdir($dir, 0755, true);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            }
        }

        $this->path = $path;

        $this->opts = array_merge($this->opts, $opts);
    }

    /**
     * css loader
     *
     * @param array $files
     * @return string
     */
    public function css(array $files)
    {
        $minify = new Minify\CSS();
        $minify->setMaxImportSize(2048);

        $minify->setImportExtensions(
            array(
                'gif' => 'data:image/gif',
                'png' => 'data:image/png',
                'jpe' => 'data:image/jpeg',
                'jpg' => 'data:image/jpeg',
                'jpeg' => 'data:image/jpeg',
                'svg' => 'data:image/svg+xml',
                'woff' => 'data:application/x-font-woff',
                'ttf' => 'data:application/x-font-ttf',
                'ttc' => 'data:application/x-font-ttf',
                'otf' => 'data:application/x-font-otf',
                'eot' => 'data:application/vnd.ms-fontobject',
                'woff2' => 'data:application/font-woff2',
                'tif' => 'image/tiff',
                'tiff' => 'image/tiff',
                'xbm' => 'image/x-xbitmap',
            )
        );

        $minify->add($files);

        return $this->offer(
            $minify,
            $files,
            array(
                'Content-type' => 'text/css'
            )
        );
    }

    /**
     * js loader
     *
     * @param array $files
     * @return string
     */
    public function js(array $files)
    {
        $minify = new Minify\JS();

        return $this->offer(
            $minify,
            $files,
            array(
                'Content-type' => 'text/javascript'
            )
        );
    }
    
    /**
     * offer
     *
     * @param Minify\Minify $minify
     * @param array $files
     * @param array $header
     * @return string
     */
    private function offer($minify, $files, $header = array())
    {
        header("Expires: ".gmdate('D, d M Y H:i:s', time() + $this->opts['timeout'])." GMT", true);
        header("Last-Modified: ".gmdate('D, d M Y H:i:s', time())." GMT", true);
        header("Cache-Control: max-age=".$this->opts['maxAge'], true);
        header("Pragma: cache", true);

        $minify->add($files);

        $buffer = $this->opts['gzip']
            ? $minify->gzip(
                $this->path,
                (int) $this->opts['gzip']
            )
            : $minify->minify(
                $this->path
            );

        foreach ($header as $key => $value) {
            header("$key: $value", true);
        }

        if ($this->opts['etag']) {
            header("Etag: " . md5($buffer), true);
        }
        session_cache_limiter('public');

        return $buffer;
    }
}


1			<?php
2
3			namespace Simple\Asset;
4
5			use MatthiasMullie\Minify;
6
7			/**
8			* wrapper for MatthiasMullie\Minify
9			*/
10			class Serve
11			{
12			public $path;
13			public $opts = array(
14			'etag' => true,
15			'timeout' => 604800,
16			'maxAge' => 315360000,
17			'gzip' => false
18			);
19
20
21			public function __construct($path = null, $opts = array())
22			{
23			if (!empty($path)) {
24			$dir = dirname($path);
25			if (!file_exists($dir)) {
26			@mkdir($dir, 0755, true);
			0 ignored issues – show Security Best Practice introduced 2019-08-13 09:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
27			}
28			}
29
30			$this->path = $path;
31
32			$this->opts = array_merge($this->opts, $opts);
33			}
34
35			/**
36			* css loader
37			*
38			* @param array $files
39			* @return string
40			*/
41			public function css(array $files)
42			{
43			$minify = new Minify\CSS();
44			$minify->setMaxImportSize(2048);
45
46			$minify->setImportExtensions(
47			array(
48			'gif' => 'data:image/gif',
49			'png' => 'data:image/png',
50			'jpe' => 'data:image/jpeg',
51			'jpg' => 'data:image/jpeg',
52			'jpeg' => 'data:image/jpeg',
53			'svg' => 'data:image/svg+xml',
54			'woff' => 'data:application/x-font-woff',
55			'ttf' => 'data:application/x-font-ttf',
56			'ttc' => 'data:application/x-font-ttf',
57			'otf' => 'data:application/x-font-otf',
58			'eot' => 'data:application/vnd.ms-fontobject',
59			'woff2' => 'data:application/font-woff2',
60			'tif' => 'image/tiff',
61			'tiff' => 'image/tiff',
62			'xbm' => 'image/x-xbitmap',
63			)
64			);
65
66			$minify->add($files);
67
68			return $this->offer(
69			$minify,
70			$files,
71			array(
72			'Content-type' => 'text/css'
73			)
74			);
75			}
76
77			/**
78			* js loader
79			*
80			* @param array $files
81			* @return string
82			*/
83			public function js(array $files)
84			{
85			$minify = new Minify\JS();
86
87			return $this->offer(
88			$minify,
89			$files,
90			array(
91			'Content-type' => 'text/javascript'
92			)
93			);
94			}
95
96			/**
97			* offer
98			*
99			* @param Minify\Minify $minify
100			* @param array $files
101			* @param array $header
102			* @return string
103			*/
104			private function offer($minify, $files, $header = array())
105			{
106			header("Expires: ".gmdate('D, d M Y H:i:s', time() + $this->opts['timeout'])." GMT", true);
107			header("Last-Modified: ".gmdate('D, d M Y H:i:s', time())." GMT", true);
108			header("Cache-Control: max-age=".$this->opts['maxAge'], true);
109			header("Pragma: cache", true);
110
111			$minify->add($files);
112
113			$buffer = $this->opts['gzip']
114			? $minify->gzip(
115			$this->path,
116			(int) $this->opts['gzip']
117			)
118			: $minify->minify(
119			$this->path
120			);
121
122			foreach ($header as $key => $value) {
123			header("$key: $value", true);
124			}
125
126			if ($this->opts['etag']) {
127			header("Etag: " . md5($buffer), true);
128			}
129			session_cache_limiter('public');
130
131			return $buffer;
132			}
133			}
134

maou / simple-asset-manager

Issues (1)

Security Analysis no request data

src/Serve.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like