AVCIterator::prepareJson() - Code Metrics - Inspection of "fixed bugs" - manuwhat/AVC - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2)

by Akpé Aurelle Emmanuel Moïse

created 2019-05-15 11:37 UTC

AVCIterator::prepareJson() B

↳ Parent: Project

Complexity

Conditions	7
Paths	7

Size

Total Lines	26
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	20
nc	7
nop	1
dl	0
loc	26
rs	8.6666
c	0
b	0
f	0

<?php
namespace EZAMA{


    class AVCIterator implements \ArrayAccess, \Iterator, \Countable, \JsonSerializable
    {
        protected $container=array();
        protected $keys=array();
        protected $simple;
        public function __construct($keys, $container)
        {
            $this->container=$container;
            $this->keys=$keys;
            $this->simple=!is_array($container);
        }
        
        public function offsetSet($key, $value)
        {
            if ($this->isSimple()) {
                $this->keys[$key]=is_int($value)?$value:0;
            } else {
                $this->container[array_search($key, $this->keys, true)]=is_int($value)?$value:0;
            }
        }
        
        public function offsetGet($key)
        {
            if ($this->isSimple()) {
                return $this->keys[$key];
            } else {
                return $this->container[array_search($key, $this->keys, true)];
            }
        }
        
        public function offsetExists($key)
        {
            if ($this->isSimple()) {
                return isset($this->keys[$key]);
            } else {
                return false!==array_search($key, $this->keys, true);
            }
        }
        
        public function offsetUnset($key)
        {
            if ($this->isSimple()) {
                unset($this->keys[$key]);
            } else {
                unset($this->container[$k=array_search($key, $this->keys, true)], $this->keys[$k]);
            }
        }
        
        
        public function count()
        {
            return count($this->keys);
        }
        
        public function key()
        {
            if ($this->isSimple()) {
                return key($this->keys);
            } else {
                return $this->keys[key($this->keys)];
            }
        }
        
        public function current()
        {
            if ($this->isSimple()) {
                return current($this->keys);
            } else {
                return current($this->container);
            }
        }
        
        public function rewind()
        {
            if ($this->isSimple()) {
                reset($this->keys);
            } else {
                reset($this->keys);
                reset($this->container);
            }
        }
        
        public function next()
        {
            if ($this->isSimple()) {
                next($this->keys);
            } else {
                next($this->keys)&&next($this->container);
            }
        }
        
        public function valid()
        {
            $key=key($this->keys);
            return null!==$key&&false!==$key;
        }
        
        public function jsonSerialize()
        {
            if ($this->isSimple()) {
                return $this->keys;
            } else {
                $callback=function ($value, $count) {
                    return array($value, $count);
                };
                return array_map($callback, $this->keys, $this->container);
            }
        }
        
        public function isSimple()
        {
            return $this->simple;
        }
        
        private static function prepareJson($value)

        {
            switch (gettype($value)) {
                case "resource":
                case "resource(closed)":
                    throw new \InvalidArgumentError("Resource type detected while trying to prepare JsonSerialize ");
filter:
    dependency_paths: ["lib/*"]
                    break;
                case "object":
                    if (is_object($value)) {
                        if (in_array('Serializable', class_implements(get_class($value)))) {
                            try {
                                $serialize=serialize($value);
                                return $serialize;
                            } catch (Exception $e) {

                                throw new \InvalidArgumentError($e->getMessage());
                            }
                        }
                        return serialize($value);
                        break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
                    }
                    throw new \InvalidArgumentError("Invalid object type detected while trying to prepare JsonSerialize ");
                    break;
                    
                default:
                    return $value;
                    break;
                
            }
        }
    }
}


1			<?php
2			namespace EZAMA{
3
4
5			class AVCIterator implements \ArrayAccess, \Iterator, \Countable, \JsonSerializable
6			{
7			protected $container=array();
8			protected $keys=array();
9			protected $simple;
10			public function __construct($keys, $container)
11			{
12			$this->container=$container;
13			$this->keys=$keys;
14			$this->simple=!is_array($container);
15			}
16
17			public function offsetSet($key, $value)
18			{
19			if ($this->isSimple()) {
20			$this->keys[$key]=is_int($value)?$value:0;
21			} else {
22			$this->container[array_search($key, $this->keys, true)]=is_int($value)?$value:0;
23			}
24			}
25
26			public function offsetGet($key)
27			{
28			if ($this->isSimple()) {
29			return $this->keys[$key];
30			} else {
31			return $this->container[array_search($key, $this->keys, true)];
32			}
33			}
34
35			public function offsetExists($key)
36			{
37			if ($this->isSimple()) {
38			return isset($this->keys[$key]);
39			} else {
40			return false!==array_search($key, $this->keys, true);
41			}
42			}
43
44			public function offsetUnset($key)
45			{
46			if ($this->isSimple()) {
47			unset($this->keys[$key]);
48			} else {
49			unset($this->container[$k=array_search($key, $this->keys, true)], $this->keys[$k]);
50			}
51			}
52
53
54			public function count()
55			{
56			return count($this->keys);
57			}
58
59			public function key()
60			{
61			if ($this->isSimple()) {
62			return key($this->keys);
63			} else {
64			return $this->keys[key($this->keys)];
65			}
66			}
67
68			public function current()
69			{
70			if ($this->isSimple()) {
71			return current($this->keys);
72			} else {
73			return current($this->container);
74			}
75			}
76
77			public function rewind()
78			{
79			if ($this->isSimple()) {
80			reset($this->keys);
81			} else {
82			reset($this->keys);
83			reset($this->container);
84			}
85			}
86
87			public function next()
88			{
89			if ($this->isSimple()) {
90			next($this->keys);
91			} else {
92			next($this->keys)&&next($this->container);
93			}
94			}
95
96			public function valid()
97			{
98			$key=key($this->keys);
99			return null!==$key&&false!==$key;
100			}
101
102			public function jsonSerialize()
103			{
104			if ($this->isSimple()) {
105			return $this->keys;
106			} else {
107			$callback=function ($value, $count) {
108			return array($value, $count);
109			};
110			return array_map($callback, $this->keys, $this->container);
111			}
112			}
113
114			public function isSimple()
115			{
116			return $this->simple;
117			}
118
119			private static function prepareJson($value)
			0 ignored issues – show Unused Code introduced 2019-05-15 11:39 UTC by Report Bug Copy Issue Report The method `prepareJson()` is not used, and could be removed. This check looks for private methods that have been defined, but are not used inside the class. Loading history...
120			{
121			switch (gettype($value)) {
122			case "resource":
123			case "resource(closed)":
124			throw new \InvalidArgumentError("Resource type detected while trying to prepare JsonSerialize ");
			0 ignored issues – show Bug introduced 2019-05-15 11:39 UTC by Report Bug Copy Issue Report The type `InvalidArgumentError` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
125			break;
126			case "object":
127			if (is_object($value)) {
128			if (in_array('Serializable', class_implements(get_class($value)))) {
129			try {
130			$serialize=serialize($value);
131			return $serialize;
132			} catch (Exception $e) {
			0 ignored issues – show Bug introduced 2019-05-15 11:39 UTC by Report Bug Copy Issue Report The type `EZAMA\Exception` was not found. Did you mean `Exception`? If so, make sure to prefix the type with `\`. Loading history...
133			throw new \InvalidArgumentError($e->getMessage());
134			}
135			}
136			return serialize($value);
137			break;
			0 ignored issues – show Unused Code introduced 2019-05-15 11:39 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
138			}
139			throw new \InvalidArgumentError("Invalid object type detected while trying to prepare JsonSerialize ");
140			break;
141
142			default:
143			return $value;
144			break;
145
146			}
147			}
148			}
149			}
150

manuwhat / AVC

Pull Request — master (#2)

AVCIterator::prepareJson() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like