Issues in ProvidersController.php (master) - Issues in master - manuelblanch/inventory - Measure and Improve Code Quality continuously with Scrutinizer

Issues (147)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Models/ProvidersController.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Http\Controllers;

use App\Http\Requests\ProviderCreateRequest;
use App\Http\Requests\ProviderUpdateRequest;
use App\Repositories\ProviderRepository;
use App\Validators\ProviderValidator;
use Illuminate\Http\Request;

class ProvidersController extends Controller
{
    /**
     * @var ProviderRepository
     */
    protected $repository;

    /**
     * @var ProviderValidator
     */
    protected $validator;

    public function __construct(ProviderRepository $repository, ProviderValidator $validator)
    {
        $this->repository = $repository;
        $this->validator = $validator;
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $this->repository->pushCriteria(app('Prettus\Repository\Criteria\RequestCriteria'));
        $providers = $this->repository->all();

        if (request()->wantsJson()) {
            return response()->json([
                'data' => $providers,
            ]);
        }

        $providers = Country::paginate(5);

        return view('manteniments/providers/index', ['providers' => $providers]);

        //return view('providers.index', compact('providers'));

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param ProviderCreateRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(ProviderCreateRequest $request)
    {
        return view('manteniments/providers/create');
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $this->validateInput($request);

        Country::create([
        'name'          => $request['name'],
        'shortName'     => $request['shortName'],
        'description'   => $request['description'],
        'date_entrance' => $request['date_entrance'],
        'last_update'   => $request['last_update'],
          ]);

        return redirect()->intended('manteniments/providers');
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $providers = Providers::find($id);
      // Redirect to country list if updating country wasn't existed
      if ($providers == null || count($providers) == 0) {
          return redirect()->intended('/manteniments/providers');
      }

        return view('manteniments/providers/edit', ['providers' => $providers]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param ProviderUpdateRequest $request
     * @param string                $id
     *
     * @return Response
     */
    public function update(ProviderUpdateRequest $request, $id)
    {
        $providers = Providers::findOrFail($id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $input = [
        'name'          => $request['name'],
        'shortName'     => $request['shortName'],
        'description'   => $request['description'],
        'date_entrance' => $request['date_entrance'],
        'last_update'   => $request['last_update'],
      ];
        $this->validate($request, [
      'name' => 'required|max:60',
      ]);
        Providers::where('id', $id)
          ->update($input);

        return redirect()->intended('manteniments/providers');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        Providers::where('id', $id)->delete();

        return redirect()->intended('manteniments/providers');
    }

    public function search(Request $request)
    {
        $constraints = [
            'name'      => $request['name'],
            'shortName' => $request['shortName'],
            ];
        $providers = $this->doSearchingQuery($constraints);

        return view('manteniments/providers/index', ['providers' => $providers, 'searchingVals' => $constraints]);
    }

    private function doSearchingQuery($constraints)
    {
        $query = providers::query();
        $fields = array_keys($constraints);
        $index = 0;
        foreach ($constraints as $constraint) {
            if ($constraint != null) {
                $query = $query->where($fields[$index], 'like', '%'.$constraint.'%');
            }
            $index++;
        }

        return $query->paginate(5);
    }

    private function validateInput($request)
    {
        $this->validate($request, [
        'name'      => 'required|max:60|unique:providers',
        'shortName' => 'required|max:6|unique:providers',
    ]);
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Http\Requests\ProviderCreateRequest;
6			use App\Http\Requests\ProviderUpdateRequest;
7			use App\Repositories\ProviderRepository;
8			use App\Validators\ProviderValidator;
9			use Illuminate\Http\Request;
10
11			class ProvidersController extends Controller
12			{
13			/**
14			* @var ProviderRepository
15			*/
16			protected $repository;
17
18			/**
19			* @var ProviderValidator
20			*/
21			protected $validator;
22
23			public function __construct(ProviderRepository $repository, ProviderValidator $validator)
24			{
25			$this->repository = $repository;
26			$this->validator = $validator;
27			}
28
29			/**
30			* Display a listing of the resource.
31			*
32			* @return \Illuminate\Http\Response
33			*/
34			public function index()
35			{
36			$this->repository->pushCriteria(app('Prettus\Repository\Criteria\RequestCriteria'));
37			$providers = $this->repository->all();
38
39			if (request()->wantsJson()) {
40			return response()->json([
41			'data' => $providers,
42			]);
43			}
44
45			$providers = Country::paginate(5);
46
47			return view('manteniments/providers/index', ['providers' => $providers]);
48
49			//return view('providers.index', compact('providers'));
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-06-12 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50			}
51
52			/**
53			* Store a newly created resource in storage.
54			*
55			* @param ProviderCreateRequest $request
56			*
57			* @return \Illuminate\Http\Response
58			*/
59			public function store(ProviderCreateRequest $request)
60			{
61			return view('manteniments/providers/create');
62			}
63
64			/**
65			* Display the specified resource.
66			*
67			* @param int $id
68			*
69			* @return \Illuminate\Http\Response
70			*/
71			public function show($id)
72			{
73			$this->validateInput($request);
			0 ignored issues – show Bug introduced 2017-06-12 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$request` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
74			Country::create([
75			'name' => $request['name'],
76			'shortName' => $request['shortName'],
77			'description' => $request['description'],
78			'date_entrance' => $request['date_entrance'],
79			'last_update' => $request['last_update'],
80			]);
81
82			return redirect()->intended('manteniments/providers');
83			}
84
85			/**
86			* Show the form for editing the specified resource.
87			*
88			* @param int $id
89			*
90			* @return \Illuminate\Http\Response
91			*/
92			public function edit($id)
93			{
94			$providers = Providers::find($id);
95			// Redirect to country list if updating country wasn't existed
96			if ($providers == null \|\| count($providers) == 0) {
97			return redirect()->intended('/manteniments/providers');
98			}
99
100			return view('manteniments/providers/edit', ['providers' => $providers]);
101			}
102
103			/**
104			* Update the specified resource in storage.
105			*
106			* @param ProviderUpdateRequest $request
107			* @param string $id
108			*
109			* @return Response
110			*/
111			public function update(ProviderUpdateRequest $request, $id)
112			{
113			$providers = Providers::findOrFail($id);
			0 ignored issues – show Unused Code introduced 2017-06-12 15:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$providers` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
114			$input = [
115			'name' => $request['name'],
116			'shortName' => $request['shortName'],
117			'description' => $request['description'],
118			'date_entrance' => $request['date_entrance'],
119			'last_update' => $request['last_update'],
120			];
121			$this->validate($request, [
122			'name' => 'required\|max:60',
123			]);
124			Providers::where('id', $id)
125			->update($input);
126
127			return redirect()->intended('manteniments/providers');
128			}
129
130			/**
131			* Remove the specified resource from storage.
132			*
133			* @param int $id
134			*
135			* @return \Illuminate\Http\Response
136			*/
137			public function destroy($id)
138			{
139			Providers::where('id', $id)->delete();
140
141			return redirect()->intended('manteniments/providers');
142			}
143
144			public function search(Request $request)
145			{
146			$constraints = [
147			'name' => $request['name'],
148			'shortName' => $request['shortName'],
149			];
150			$providers = $this->doSearchingQuery($constraints);
151
152			return view('manteniments/providers/index', ['providers' => $providers, 'searchingVals' => $constraints]);
153			}
154
155			private function doSearchingQuery($constraints)
156			{
157			$query = providers::query();
158			$fields = array_keys($constraints);
159			$index = 0;
160			foreach ($constraints as $constraint) {
161			if ($constraint != null) {
162			$query = $query->where($fields[$index], 'like', '%'.$constraint.'%');
163			}
164			$index++;
165			}
166
167			return $query->paginate(5);
168			}
169
170			private function validateInput($request)
171			{
172			$this->validate($request, [
173			'name' => 'required\|max:60\|unique:providers',
174			'shortName' => 'required\|max:6\|unique:providers',
175			]);
176			}
177			}
178

manuelblanch / inventory

Issues (147)

Security Analysis no request data

src/Models/ProvidersController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like