MoneySourceController::doSearchingQuery() - Code Metrics - manuelblanch/inventory - Measure and Improve Code Quality continuously with Scrutinizer

MoneySourceController::doSearchingQuery() A
last analyzed 2017-12-05 12:31 UTC

↳ Parent: MoneySourceController

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	9

Duplication

Lines	14
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	14
loc	14
ccs	0
cts	13
cp	0
rs	9.4285
cc	3
eloc	9
nc	3
nop	1
crap	12

<?php

namespace App\Http\Controllers;

use App\MoneySource;
use Illuminate\Http\Request;

class MoneySourceController extends Controller

{
    /**
      * Display a listing of the resource.
      *
      * @return \Illuminate\Http\Response

      */
     public function __construct()
     {
         $this->middleware('auth');
     }

    public function index()
    {
        $moneySources = MoneySource::paginate(5);

        return view('manteniments/moneySource/index', ['moneySources' => $moneySources]);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('manteniments/moneySource/create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $this->validateInput($request);
        MoneySource::create([
         'name'          => $request['name'],
         'shortName'     => $request['shortName'],
         'description'   => $request['description'],
         'date_entrance' => $request['date_entrance'],
         'last_update'   => $request['last_update'],
           ]);

        return redirect()->intended('mnt/moneySource');
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $moneySource = MoneySource::find($id);
      // Redirect to country list if updating country wasn't existed
      if ($moneySource == null || count($moneySource) == 0) {
          return redirect()->intended('/mnt/moneySource');
      }

        return view('manteniments/moneySource/edit', ['moneySource' => $moneySource]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param int                      $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $moneySource = MoneySource::findOrFail($id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $input = [
        'name'          => $request['name'],
        'shortName'     => $request['shortName'],
        'description'   => $request['description'],
        'date_entrance' => $request['date_entrance'],
        'last_update'   => $request['last_update'],
      ];
        $this->validate($request, [
      'name' => 'required|max:60',
      ]);
        MoneySource::where('id', $id)
          ->update($input);

        return redirect()->intended('mnt/moneySource');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        MoneySource::where('id', $id)->delete();

        return redirect()->intended('mnt/moneySource');
    }

    public function search(Request $request)
    {
        $constraints = [
            'name'      => $request['name'],
            'shortName' => $request['shortName'],
            ];
        $moneySources = $this->doSearchingQuery($constraints);

        return view('manteniments/moneySource/index', ['moneySources' => $moneySources, 'searchingVals' => $constraints]);
    }

    private function doSearchingQuery($constraints)
    {
        $query = MoneySource::query();
        $fields = array_keys($constraints);
        $index = 0;
        foreach ($constraints as $constraint) {
            if ($constraint != null) {
                $query = $query->where($fields[$index], 'like', '%'.$constraint.'%');
            }
            $index++;
        }

        return $query->paginate(5);
    }

    private function validateInput($request)
    {
        $this->validate($request, [
        'name'      => 'required|max:60|unique:provider',
        'shortName' => 'required|max:6|unique:provider',
    ]);
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\MoneySource;
6		use Illuminate\Http\Request;
7
8	View Code Duplication	class MoneySourceController extends Controller
		0 ignored issues – show Duplication introduced 2017-06-07 16:35 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		/**
11		* Display a listing of the resource.
12		*
13		* @return \Illuminate\Http\Response
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-06-07 16:35 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
14		*/
15		public function __construct()
16		{
17		$this->middleware('auth');
18		}
19
20		public function index()
21		{
22		$moneySources = MoneySource::paginate(5);
23
24		return view('manteniments/moneySource/index', ['moneySources' => $moneySources]);
25		}
26
27		/**
28		* Show the form for creating a new resource.
29		*
30		* @return \Illuminate\Http\Response
31		*/
32		public function create()
33		{
34		return view('manteniments/moneySource/create');
35		}
36
37		/**
38		* Store a newly created resource in storage.
39		*
40		* @param \Illuminate\Http\Request $request
41		*
42		* @return \Illuminate\Http\Response
43		*/
44		public function store(Request $request)
45		{
46		$this->validateInput($request);
47		MoneySource::create([
48		'name' => $request['name'],
49		'shortName' => $request['shortName'],
50		'description' => $request['description'],
51		'date_entrance' => $request['date_entrance'],
52		'last_update' => $request['last_update'],
53		]);
54
55		return redirect()->intended('mnt/moneySource');
56		}
57
58		/**
59		* Display the specified resource.
60		*
61		* @param int $id
62		*
63		* @return \Illuminate\Http\Response
64		*/
65		public function show($id)
66		{
67		//
68		}
69
70		/**
71		* Show the form for editing the specified resource.
72		*
73		* @param int $id
74		*
75		* @return \Illuminate\Http\Response
76		*/
77		public function edit($id)
78		{
79		$moneySource = MoneySource::find($id);
80		// Redirect to country list if updating country wasn't existed
81		if ($moneySource == null \|\| count($moneySource) == 0) {
82		return redirect()->intended('/mnt/moneySource');
83		}
84
85		return view('manteniments/moneySource/edit', ['moneySource' => $moneySource]);
86		}
87
88		/**
89		* Update the specified resource in storage.
90		*
91		* @param \Illuminate\Http\Request $request
92		* @param int $id
93		*
94		* @return \Illuminate\Http\Response
95		*/
96		public function update(Request $request, $id)
97		{
98		$moneySource = MoneySource::findOrFail($id);
		0 ignored issues – show Unused Code introduced 2017-06-07 16:35 UTC by Report Bug Copy Issue Report `$moneySource` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
99		$input = [
100		'name' => $request['name'],
101		'shortName' => $request['shortName'],
102		'description' => $request['description'],
103		'date_entrance' => $request['date_entrance'],
104		'last_update' => $request['last_update'],
105		];
106		$this->validate($request, [
107		'name' => 'required\|max:60',
108		]);
109		MoneySource::where('id', $id)
110		->update($input);
111
112		return redirect()->intended('mnt/moneySource');
113		}
114
115		/**
116		* Remove the specified resource from storage.
117		*
118		* @param int $id
119		*
120		* @return \Illuminate\Http\Response
121		*/
122		public function destroy($id)
123		{
124		MoneySource::where('id', $id)->delete();
125
126		return redirect()->intended('mnt/moneySource');
127		}
128
129		public function search(Request $request)
130		{
131		$constraints = [
132		'name' => $request['name'],
133		'shortName' => $request['shortName'],
134		];
135		$moneySources = $this->doSearchingQuery($constraints);
136
137		return view('manteniments/moneySource/index', ['moneySources' => $moneySources, 'searchingVals' => $constraints]);
138		}
139
140		private function doSearchingQuery($constraints)
141		{
142		$query = MoneySource::query();
143		$fields = array_keys($constraints);
144		$index = 0;
145		foreach ($constraints as $constraint) {
146		if ($constraint != null) {
147		$query = $query->where($fields[$index], 'like', '%'.$constraint.'%');
148		}
149		$index++;
150		}
151
152		return $query->paginate(5);
153		}
154
155		private function validateInput($request)
156		{
157		$this->validate($request, [
158		'name' => 'required\|max:60\|unique:provider',
159		'shortName' => 'required\|max:6\|unique:provider',
160		]);
161		}
162		}
163

manuelblanch / inventory

MoneySourceController::doSearchingQuery() A last analyzed 2017-12-05 12:31 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

MoneySourceController::doSearchingQuery() A
last analyzed 2017-12-05 12:31 UTC