App\Http\Controllers\LocationController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	155
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	6	6	1
A	create()	4	4	1
A	store()	13	13	1
A	show()	4	4	1
A	edit()	10	10	3
A	update()	18	18	1
A	destroy()	6	6	1
A	doSearchingQuery()	14	14	3
A	validateInput()	7	7	1

<?php

namespace App\Http\Controllers;

use App\Location;
use Illuminate\Http\Request;

class LocationController extends Controller

This class seems to be duplicated in your project.

{
    /**
      * Display a listing of the resource.
      *
      * @return \Illuminate\Http\Response

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

      */
     public function __construct()
     {
         $this->middleware('auth');
     }

    public function index()
    {
        $locations = Location::paginate(5);

        return view('manteniments/location/index', ['locations' => $locations]);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('manteniments/location/create');
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(Request $request)
    {
        $this->validateInput($request);
        Location::create([
         'name'          => $request['name'],
         'shortName'     => $request['shortName'],
         'description'   => $request['description'],
         'date_entrance' => $request['date_entrance'],
         'last_update'   => $request['last_update'],
           ]);

        return redirect()->intended('mnt/location');
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        //
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $location = Location::find($id);
      // Redirect to country list if updating country wasn't existed
      if ($location == null || count($location) == 0) {
          return redirect()->intended('/mnt/location');
      }

        return view('manteniments/location/edit', ['location' => $location]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param int                      $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $id)
    {
        $location = Location::findOrFail($id);

$location is not used, you could remove the assignment.

        $input = [
        'name'          => $request['name'],
        'shortName'     => $request['shortName'],
        'description'   => $request['description'],
        'date_entrance' => $request['date_entrance'],
        'last_update'   => $request['last_update'],
      ];
        $this->validate($request, [
      'name' => 'required|max:60',
      ]);
        Location::where('id', $id)
          ->update($input);

        return redirect()->intended('mnt/location');
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        Location::where('id', $id)->delete();

        return redirect()->intended('mnt/location');
    }

    public function search(Request $request)
    {
        $constraints = [
            'name'      => $request['name'],
            'shortName' => $request['shortName'],
            ];
        $locations = $this->doSearchingQuery($constraints);

        return view('manteniments/location/index', ['locations' => $locations, 'searchingVals' => $constraints]);
    }

    private function doSearchingQuery($constraints)
    {
        $query = location::query();
        $fields = array_keys($constraints);
        $index = 0;
        foreach ($constraints as $constraint) {
            if ($constraint != null) {
                $query = $query->where($fields[$index], 'like', '%'.$constraint.'%');
            }
            $index++;
        }

        return $query->paginate(5);
    }

    private function validateInput($request)
    {
        $this->validate($request, [
        'name'      => 'required|max:60|unique:provider',
        'shortName' => 'required|max:6|unique:provider',
    ]);
    }
}