Manticoresearch\Transport\Http

Complexity

Total Complexity

15

Size/Duplication

Total Lines	130
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
D	execute()	0	100	12
A	getCurlConnection()	0	6	3

<?php
namespace Manticoresearch\Transport;

use Manticoresearch\Exceptions\ConnectionException;
use Manticoresearch\Exceptions\ResponseException;
use Manticoresearch\Request;
use Manticoresearch\Response;

/**
 * Class Http
 * @package Manticoresearch\Transport
 */
class Http extends \Manticoresearch\Transport implements TransportInterface
{

    /**
     * @var string
     */
    protected $scheme = 'http';

    /**
     * @var resource
     */
    protected static $curl;

    /**
     * @param Request $request
     * @param array $params
     * @return Response
     */
    public function execute(Request $request, $params = [])
    {
        $connection = $this->getConnection();
        $conn = $this->getCurlConnection($connection->getConfig('persistent'));

It seems like $connection->getConfig('persistent') can also be of type null; however, parameter $persistent of Manticoresearch\Transport\Http::getCurlConnection() does only seem to accept boolean, maybe add an additional type check?

        $url = $this->scheme.'://'.$connection->getHost().':'.$connection->getPort();
        $endpoint = $request->getPath();
        $url .= $endpoint;
        $url = $this->setupURI($url, $request->getQuery());

$request->getQuery() of type string is incompatible with the type array expected by parameter $query of Manticoresearch\Transport::setupURI().

        curl_setopt($conn, CURLOPT_URL, $url);
        curl_setopt($conn, CURLOPT_TIMEOUT, $connection->getTimeout());
        curl_setopt($conn, CURLOPT_ENCODING, '');
        curl_setopt($conn, CURLOPT_FORBID_REUSE, 0);
        $data = $request->getBody();
        $method = $request->getMethod();
        $headers = $connection->getHeaders();
        $headers[] = sprintf('Content-Type: %s', $request->getContentType());
        if (!empty($data)) {
            if (is_array($data)) {
                $content = json_encode($data, JSON_UNESCAPED_UNICODE | JSON_UNESCAPED_SLASHES);
            } else {
                $content = $data;
            }
            curl_setopt($conn, CURLOPT_POSTFIELDS, $content);
        } else {
            curl_setopt($conn, CURLOPT_POSTFIELDS, '');
        }
        curl_setopt($conn, CURLOPT_CUSTOMREQUEST, $method);
        curl_setopt($conn, CURLOPT_HTTPHEADER, $headers);

        if ($connection->getConnectTimeout()>0) {
            curl_setopt($conn, CURLOPT_CONNECTTIMEOUT, $connection->getConnectTimeout());
        }

        if ($connection->getConfig('username') !== null && $connection->getConfig('password') !== null) {
            curl_setopt($conn, CURLOPT_HTTPAUTH, CURLAUTH_ANY);
            curl_setopt(
                $conn,
                CURLOPT_USERPWD,
                $connection->getConfig('username').":".$connection->getConfig('password')
            );
        }
        if ($connection->getConfig('proxy') !== null) {
            curl_setopt($conn, CURLOPT_PROXY, $connection->getConfig('proxy'));
        }
        if (!empty($connection->getConfig('curl'))) {
            foreach ($connection->getConfig('curl') as $k => $v) {
                curl_setopt($conn, $k, $v);
            }
        }
        $start = microtime(true);
        ob_start();
        curl_exec($conn);
        $responseString = \ob_get_clean();
        $end = microtime(true);
        $errorno = curl_errno($conn);
        $status = curl_getinfo($conn, CURLINFO_HTTP_CODE);
        if (isset($params['responseClass'])) {
            $responseClass = $params['responseClass'];
            $response = new $responseClass($responseString, $status);
        } else {
            $response = new Response($responseString, $status);
        }

        $time = $end-$start;
        $response->setTime($time);
        $response->setTransportInfo([
                'url' => $url,
                'headers' => $headers,
                'body' => $request->getBody()
            ]);
        //hard error
        if ($errorno>0) {
            $error = curl_error($conn);

            /* @phpstan-ignore-next-line */
            self::$curl = false;

It seems like false of type false is incompatible with the declared type resource of property $curl.

            throw new ConnectionException($error, $request);
        }


        $this->logger->debug('Request body:', [
                'connection' => $connection->getConfig(),
                'payload'=> $request->getBody()
            ]);
        $this->logger->info(
            'Request:',
            [
                    'url' => $url,
                    'status' => $status,
                    'time' => $time
                ]
        );
        $this->logger->debug('Response body:', [json_decode($responseString, true)]);
        //soft error
        if ($response->hasError()) {
            $this->logger->error('Response error:', [$response->getError()]);
            throw new ResponseException($request, $response);
        }
        return $response;
    }

    /**
     * @param bool $persistent
     * @return false|resource
     */
    protected function getCurlConnection(bool $persistent = true)
    {
        if (!$persistent || !self::$curl) {
            self::$curl = curl_init();

It seems like curl_init() can also be of type false. However, the property $curl is declared as type resource. Maybe add an additional type check?

        }
        return self::$curl;
    }
}