EnrollmentCreateRequest::authorize() - Code Metrics - Inspection of "Permissions seeders" - manelgavalda/enrollment_mobile - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9dc7e5...d49645 )

by Manel

created 2017-01-19 20:05 UTC

EnrollmentCreateRequest::authorize() A

↳ Parent: EnrollmentCreateRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	11
ccs	0
cts	4
cp	0
rs	9.4285
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

namespace Scool\EnrollmentMobile\Http\Requests;

use GuzzleHttp\Psr7\Response;
use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Support\Facades\Auth;

/**
 * Class EnrollmentCreateRequest
 * @package Scool\EnrollmentMobile\Http\Requests
 */
class EnrollmentCreateRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return Auth::user()->can('create enrollments');
        //return false; //Per defecte

        //De moment true

//if (auth:user()->can('update enrollments')) {
        //}
        //return false;
        //TODO: crear requests de show, delete... crear permissos amb un seed. (create writter(BREAD(Browse,Read...)). Crear rol manage per donar-li tots els anteriors.
    }

    public function forbiddenResponse()
    {

        return Response::make('Permission denied on create enrollment', 403);
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [
            'name' => 'required|min:5|max:30'
        ];
    }
}


1			<?php
2
3			namespace Scool\EnrollmentMobile\Http\Requests;
4
5			use GuzzleHttp\Psr7\Response;
6			use Illuminate\Foundation\Http\FormRequest;
7			use Illuminate\Support\Facades\Auth;
8
9			/**
10			* Class EnrollmentCreateRequest
11			* @package Scool\EnrollmentMobile\Http\Requests
12			*/
13			class EnrollmentCreateRequest extends FormRequest
14			{
15			/**
16			* Determine if the user is authorized to make this request.
17			*
18			* @return bool
19			*/
20			public function authorize()
21			{
22			return Auth::user()->can('create enrollments');
23			//return false; //Per defecte
24
25			//De moment true
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-12 20:47 UTC by Report Bug Copy Issue Report `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26			//if (auth:user()->can('update enrollments')) {
27			//}
28			//return false;
29			//TODO: crear requests de show, delete... crear permissos amb un seed. (create writter(BREAD(Browse,Read...)). Crear rol manage per donar-li tots els anteriors.
30			}
31
32			public function forbiddenResponse()
33			{
34
35			return Response::make('Permission denied on create enrollment', 403);
36			}
37
38			/**
39			* Get the validation rules that apply to the request.
40			*
41			* @return array
42			*/
43			public function rules()
44			{
45			return [
46			'name' => 'required\|min:5\|max:30'
47			];
48			}
49			}
50

manelgavalda / enrollment_mobile

Push — master ( 9dc7e5...d49645 )

EnrollmentCreateRequest::authorize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like