EnrollmentsController::update() - Code Metrics - Inspection of "Changing interfaces" - manelgavalda/enrollment_mobile - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7ec402...2e144b )

by Manel

created 2016-12-13 15:02 UTC

EnrollmentsController::update() B

↳ Parent: EnrollmentsController

Complexity

Conditions	4
Paths	14

Size

Total Lines	28
Code Lines	16

Duplication

Lines	28
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	28
loc	28
ccs	0
cts	23
cp	0
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	16
nc	14
nop	2
crap	20

<?php

namespace Scool\EnrollmentMobile\Http\Controllers;

use Illuminate\Http\Request;

use App\Http\Requests;
use Prettus\Validator\Contracts\ValidatorInterface;
use Prettus\Validator\Exceptions\ValidatorException;
use Scool\EnrollmentMobile\Http\Requests\EnrollmentCreateRequest;
use Scool\EnrollmentMobile\Http\Requests\EnrollmentUpdateRequest;
use Scool\EnrollmentMobile\Repositories\EnrollmentRepository;
use Scool\EnrollmentMobile\Validators\EnrollmentValidator;

/**
 * Class EnrollmentsController
 * @package App\Http\Controllers
 */
class EnrollmentsController extends Controller
{

    /**
     * @var EnrollmentRepository
     */
    protected $repository;

    /**
     * @var EnrollmentValidator
     */
    protected $validator;

    /**
     * EnrollmentsController constructor.
     * @param EnrollmentRepository $repository
     * @param EnrollmentValidator $validator
     */
    public function __construct(EnrollmentRepository $repository, EnrollmentValidator $validator)
    {
        $this->repository = $repository;
        $this->validator  = $validator;
    }


    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()

    {
        $this->repository->pushCriteria(app('Prettus\Repository\Criteria\RequestCriteria'));
        $enrollments = $this->repository->all();

        if (request()->wantsJson()) {
            return response()->json([
                'data' => $enrollments,
            ]);
        }

        return view('enrollments.index', compact('enrollments'));
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  EnrollmentCreateRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(EnrollmentCreateRequest $request)

    {
        try {
            $this->validator->with($request->all())->passesOrFail(ValidatorInterface::RULE_CREATE);

            $enrollment = $this->repository->create($request->all());

            $response = [
                'message' => 'Enrollment created.',
                'data'    => $enrollment->toArray(),
            ];

            if ($request->wantsJson()) {
                return response()->json($response);
            }

            return redirect()->back()->with('message', $response['message']);
        } catch (ValidatorException $e) {
            if ($request->wantsJson()) {
                return response()->json([
                    'error'   => true,
                    'message' => $e->getMessageBag()
                ]);
            }

            return redirect()->back()->withErrors($e->getMessageBag())->withInput();
        }
    }


    /**
     * Display the specified resource.
     *
     * @param  int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($id)

    {
        $enrollment = $this->repository->find($id);

        if (request()->wantsJson()) {
            return response()->json([
                'data' => $enrollment,
            ]);
        }

        return view('enrollments.show', compact('enrollment'));
    }


    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $enrollment = $this->repository->find($id);

        return view('enrollments.edit', compact('enrollment'));
    }


    /**
     * Update the specified resource in storage.
     *
     * @param  EnrollmentUpdateRequest $request
     * @param  string            $id
     *
     * @return Response
     */
    public function update(EnrollmentUpdateRequest $request, $id)

    {
        try {
            $this->validator->with($request->all())->passesOrFail(ValidatorInterface::RULE_UPDATE);

            $enrollment = $this->repository->update($id, $request->all());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            $response = [
                'message' => 'Enrollment updated.',
                'data'    => $enrollment->toArray(),
            ];

            if ($request->wantsJson()) {
                return response()->json($response);
            }

            return redirect()->back()->with('message', $response['message']);
        } catch (ValidatorException $e) {
            if ($request->wantsJson()) {
                return response()->json([
                    'error'   => true,
                    'message' => $e->getMessageBag()
                ]);
            }

            return redirect()->back()->withErrors($e->getMessageBag())->withInput();
        }
    }


    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $deleted = $this->repository->delete($id);

        if (request()->wantsJson()) {
            return response()->json([
                'message' => 'Enrollment deleted.',
                'deleted' => $deleted,
            ]);
        }

        return redirect()->back()->with('message', 'Enrollment deleted.');
    }
}


1		<?php
2
3		namespace Scool\EnrollmentMobile\Http\Controllers;
4
5		use Illuminate\Http\Request;
6
7		use App\Http\Requests;
8		use Prettus\Validator\Contracts\ValidatorInterface;
9		use Prettus\Validator\Exceptions\ValidatorException;
10		use Scool\EnrollmentMobile\Http\Requests\EnrollmentCreateRequest;
11		use Scool\EnrollmentMobile\Http\Requests\EnrollmentUpdateRequest;
12		use Scool\EnrollmentMobile\Repositories\EnrollmentRepository;
13		use Scool\EnrollmentMobile\Validators\EnrollmentValidator;
14
15		/**
16		* Class EnrollmentsController
17		* @package App\Http\Controllers
18		*/
19		class EnrollmentsController extends Controller
20		{
21
22		/**
23		* @var EnrollmentRepository
24		*/
25		protected $repository;
26
27		/**
28		* @var EnrollmentValidator
29		*/
30		protected $validator;
31
32		/**
33		* EnrollmentsController constructor.
34		* @param EnrollmentRepository $repository
35		* @param EnrollmentValidator $validator
36		*/
37		public function __construct(EnrollmentRepository $repository, EnrollmentValidator $validator)
38		{
39		$this->repository = $repository;
40		$this->validator = $validator;
41		}
42
43
44		/**
45		* Display a listing of the resource.
46		*
47		* @return \Illuminate\Http\Response
48		*/
49	View Code Duplication	public function index()
		0 ignored issues – show Duplication introduced 2016-12-09 23:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		{
51		$this->repository->pushCriteria(app('Prettus\Repository\Criteria\RequestCriteria'));
52		$enrollments = $this->repository->all();
53
54		if (request()->wantsJson()) {
55		return response()->json([
56		'data' => $enrollments,
57		]);
58		}
59
60		return view('enrollments.index', compact('enrollments'));
61		}
62
63		/**
64		* Store a newly created resource in storage.
65		*
66		* @param EnrollmentCreateRequest $request
67		*
68		* @return \Illuminate\Http\Response
69		*/
70	View Code Duplication	public function store(EnrollmentCreateRequest $request)
		0 ignored issues – show Duplication introduced 2016-12-09 23:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		try {
73		$this->validator->with($request->all())->passesOrFail(ValidatorInterface::RULE_CREATE);
74
75		$enrollment = $this->repository->create($request->all());
76
77		$response = [
78		'message' => 'Enrollment created.',
79		'data' => $enrollment->toArray(),
80		];
81
82		if ($request->wantsJson()) {
83		return response()->json($response);
84		}
85
86		return redirect()->back()->with('message', $response['message']);
87		} catch (ValidatorException $e) {
88		if ($request->wantsJson()) {
89		return response()->json([
90		'error' => true,
91		'message' => $e->getMessageBag()
92		]);
93		}
94
95		return redirect()->back()->withErrors($e->getMessageBag())->withInput();
96		}
97		}
98
99
100		/**
101		* Display the specified resource.
102		*
103		* @param int $id
104		*
105		* @return \Illuminate\Http\Response
106		*/
107	View Code Duplication	public function show($id)
		0 ignored issues – show Duplication introduced 2016-12-09 23:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
108		{
109		$enrollment = $this->repository->find($id);
110
111		if (request()->wantsJson()) {
112		return response()->json([
113		'data' => $enrollment,
114		]);
115		}
116
117		return view('enrollments.show', compact('enrollment'));
118		}
119
120
121		/**
122		* Show the form for editing the specified resource.
123		*
124		* @param int $id
125		*
126		* @return \Illuminate\Http\Response
127		*/
128		public function edit($id)
129		{
130		$enrollment = $this->repository->find($id);
131
132		return view('enrollments.edit', compact('enrollment'));
133		}
134
135
136		/**
137		* Update the specified resource in storage.
138		*
139		* @param EnrollmentUpdateRequest $request
140		* @param string $id
141		*
142		* @return Response
143		*/
144	View Code Duplication	public function update(EnrollmentUpdateRequest $request, $id)
		0 ignored issues – show Duplication introduced 2016-12-09 23:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
145		{
146		try {
147		$this->validator->with($request->all())->passesOrFail(ValidatorInterface::RULE_UPDATE);
148
149		$enrollment = $this->repository->update($id, $request->all());
		0 ignored issues – show Documentation introduced 2016-12-09 23:47 UTC by Report Bug Copy Issue Report `$id` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
150
151		$response = [
152		'message' => 'Enrollment updated.',
153		'data' => $enrollment->toArray(),
154		];
155
156		if ($request->wantsJson()) {
157		return response()->json($response);
158		}
159
160		return redirect()->back()->with('message', $response['message']);
161		} catch (ValidatorException $e) {
162		if ($request->wantsJson()) {
163		return response()->json([
164		'error' => true,
165		'message' => $e->getMessageBag()
166		]);
167		}
168
169		return redirect()->back()->withErrors($e->getMessageBag())->withInput();
170		}
171		}
172
173
174		/**
175		* Remove the specified resource from storage.
176		*
177		* @param int $id
178		*
179		* @return \Illuminate\Http\Response
180		*/
181		public function destroy($id)
182		{
183		$deleted = $this->repository->delete($id);
184
185		if (request()->wantsJson()) {
186		return response()->json([
187		'message' => 'Enrollment deleted.',
188		'deleted' => $deleted,
189		]);
190		}
191
192		return redirect()->back()->with('message', 'Enrollment deleted.');
193		}
194		}
195

manelgavalda / enrollment_mobile

Push — master ( 7ec402...2e144b )

EnrollmentsController::update() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like