CreateDepartmentsTable::down() - Code Metrics - Inspection of "return factories" - manelgavalda/enrollment_mobile - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 98b092...abc55c )

by Manel

created 2016-12-16 22:49 UTC

CreateDepartmentsTable::down() A

↳ Parent: CreateDepartmentsTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

use Illuminate\Support\Facades\Schema;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;

/**
 * Class CreateDepartmentsTable.
 */
class CreateDepartmentsTable extends Migration
namespace YourVendor;

class YourClass { }
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::create('departments', function (Blueprint $table) {

            $table->increments('id');
            $table->string('name');
            $table->integer('parent')->unsigned()->nullable();
            $table->integer('location_id')->unsigned();
            $table->timestamps();
        });
        Schema::create('department_family', function (Blueprint $table) {

            $table->integer('department_id')->unsigned();
            $table->integer('family_id')->unsigned();
            $table->timestamps();
            $table->unique(['department_id', 'family_id']);
        });
        Schema::create('department_head', function (Blueprint $table) {

            $table->integer('department_id')->unsigned();
            $table->integer('user_id')->unsigned();
            $table->boolean('main')->default(false);
            $table->timestamps();
            $table->unique(['department_id', 'user_id']);
        });
        Schema::create('department_study', function (Blueprint $table) {

            $table->integer('department_id')->unsigned();
            $table->integer('study_id')->unsigned();
            $table->timestamps();
            $table->unique(['department_id', 'study_id']);
        });
    }
    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        Schema::dropIfExists('departments');
        Schema::dropIfExists('department_family');
        Schema::dropIfExists('department_head');
        Schema::dropIfExists('department_study');
    }
}


1		<?php
2
3		use Illuminate\Support\Facades\Schema;
4		use Illuminate\Database\Schema\Blueprint;
5		use Illuminate\Database\Migrations\Migration;
6
7		/**
8		* Class CreateDepartmentsTable.
9		*/
10		class CreateDepartmentsTable extends Migration
		0 ignored issues – show Coding Style Compatibility introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11		{
12		/**
13		* Run the migrations.
14		*
15		* @return void
16		*/
17		public function up()
18		{
19	View Code Duplication	Schema::create('departments', function (Blueprint $table) {
		0 ignored issues – show Bug introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `Illuminate\Support\Facades\Schema`. Did you maybe mean `createFreshMockInstance()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history... Duplication introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		$table->increments('id');
21		$table->string('name');
22		$table->integer('parent')->unsigned()->nullable();
23		$table->integer('location_id')->unsigned();
24		$table->timestamps();
25		});
26		Schema::create('department_family', function (Blueprint $table) {
		0 ignored issues – show Bug introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `Illuminate\Support\Facades\Schema`. Did you maybe mean `createFreshMockInstance()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
27		$table->integer('department_id')->unsigned();
28		$table->integer('family_id')->unsigned();
29		$table->timestamps();
30		$table->unique(['department_id', 'family_id']);
31		});
32		Schema::create('department_head', function (Blueprint $table) {
		0 ignored issues – show Bug introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `Illuminate\Support\Facades\Schema`. Did you maybe mean `createFreshMockInstance()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
33		$table->integer('department_id')->unsigned();
34		$table->integer('user_id')->unsigned();
35		$table->boolean('main')->default(false);
36		$table->timestamps();
37		$table->unique(['department_id', 'user_id']);
38		});
39		Schema::create('department_study', function (Blueprint $table) {
		0 ignored issues – show Bug introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `Illuminate\Support\Facades\Schema`. Did you maybe mean `createFreshMockInstance()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
40		$table->integer('department_id')->unsigned();
41		$table->integer('study_id')->unsigned();
42		$table->timestamps();
43		$table->unique(['department_id', 'study_id']);
44		});
45		}
46		/**
47		* Reverse the migrations.
48		*
49		* @return void
50		*/
51		public function down()
52		{
53		Schema::dropIfExists('departments');
54		Schema::dropIfExists('department_family');
55		Schema::dropIfExists('department_head');
56		Schema::dropIfExists('department_study');
57		}
58		}
59

manelgavalda / enrollment_mobile

Push — master ( 98b092...abc55c )

CreateDepartmentsTable::down() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like