CreateCoursesTable::up() - Code Metrics - Inspection of "return factories" - manelgavalda/enrollment_mobile - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 98b092...abc55c )

by Manel

created 2016-12-16 22:49 UTC

CreateCoursesTable::up() A

↳ Parent: CreateCoursesTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	10

Duplication

Lines	14
Ratio	100 %

Importance

Changes

Metric	Value
dl	14
loc	14
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	0



<?php

use Illuminate\Support\Facades\Schema;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Database\Migrations\Migration;

/**
 * Class CreateCoursesTable
 */
class CreateCoursesTable extends Migration
namespace YourVendor;

class YourClass { }
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::create('courses', function (Blueprint $table) {

            $table->increments('id');
            $table->string('name');
            $table->timestamps();
        });
        Schema::create('course_study', function (Blueprint $table) {

            $table->integer('course_id')->unsigned();
            $table->integer('study_id')->unsigned();
            $table->timestamps();
            $table->unique(['course_id', 'study_id']);
        });
    }
    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        Schema::dropIfExists('courses');
        Schema::dropIfExists('course_study');
    }
}

1
		0 ignored issues – show Security Bug introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report It is not recommended to output anything before PHP's opening tag in non-template files. Loading history... Coding Style Compatibility introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 11 and the first side effect is on line 1. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		<?php
3
4		use Illuminate\Support\Facades\Schema;
5		use Illuminate\Database\Schema\Blueprint;
6		use Illuminate\Database\Migrations\Migration;
7
8		/**
9		* Class CreateCoursesTable
10		*/
11	View Code Duplication	class CreateCoursesTable extends Migration
		0 ignored issues – show Duplication introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Compatibility introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12		{
13		/**
14		* Run the migrations.
15		*
16		* @return void
17		*/
18		public function up()
19		{
20		Schema::create('courses', function (Blueprint $table) {
		0 ignored issues – show Bug introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `Illuminate\Support\Facades\Schema`. Did you maybe mean `createFreshMockInstance()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
21		$table->increments('id');
22		$table->string('name');
23		$table->timestamps();
24		});
25		Schema::create('course_study', function (Blueprint $table) {
		0 ignored issues – show Bug introduced 2016-12-16 22:54 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `Illuminate\Support\Facades\Schema`. Did you maybe mean `createFreshMockInstance()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
26		$table->integer('course_id')->unsigned();
27		$table->integer('study_id')->unsigned();
28		$table->timestamps();
29		$table->unique(['course_id', 'study_id']);
30		});
31		}
32		/**
33		* Reverse the migrations.
34		*
35		* @return void
36		*/
37		public function down()
38		{
39		Schema::dropIfExists('courses');
40		Schema::dropIfExists('course_study');
41		}
42		}

manelgavalda / enrollment_mobile

Push — master ( 98b092...abc55c )

CreateCoursesTable::up() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like