RecordsActivity::bootRecordsActivity() - Code Metrics - manelgavalda/enrollment_mobile - Measure and Improve Code Quality continuously with Scrutinizer

RecordsActivity::bootRecordsActivity() A
last analyzed 2017-06-18 20:42 UTC

↳ Parent: RecordsActivity

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	11
cp	0
cc	3
eloc	6
nc	3
nop	0
crap	12

<?php

namespace Scool\EnrollmentMobile\Traits;

/**
 * Trait RecordsActivity
 * @package Scool\EnrollmentMobile\Traits
 */
trait RecordsActivity
{
    /**
     * Boot the trait.
     */
    protected static function bootRecordsActivity()
    {
        // Comprovar si no hi ha usuari logat.
        if (auth()->guest()) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            return;
        }

        foreach (static::getActivitiesToRecord() as $event) {
            static::$event(function ($model) use ($event) {
                $model->recordActivity($event);
            });
        }
    }

    /**
     * Fetch all model events that require activity recording.
     *
     * @return array
     */
    protected static function getActivitiesToRecord()
    {
        return ['created', 'updated', 'deleted'];
    }

    /**
     * Record new activity for the model.
     *
     * @param string $event
     */
    protected function recordActivity($event)
    {
        $this->activity()->create([
            'user_id' => auth()->id(),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'type' => $this->getActivityType($event)
        ]);
    }

    /**
     * Fetch the activity relationship.
     *
     * @return \Illuminate\Database\Eloquent\Relations\MorphMany
     */
    public function activity()
    {
        return $this->morphMany('Scool\EnrollmentMobile\Models\Activity', 'subject');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Determine the activity type.
     *
     * @param  string $event
     * @return string
     */
    protected function getActivityType($event)
    {
        $type = strtolower((new \ReflectionClass($this))->getShortName());

        return "{$event}_{$type}";
    }
}


1			<?php
2
3			namespace Scool\EnrollmentMobile\Traits;
4
5			/**
6			* Trait RecordsActivity
7			* @package Scool\EnrollmentMobile\Traits
8			*/
9			trait RecordsActivity
10			{
11			/**
12			* Boot the trait.
13			*/
14			protected static function bootRecordsActivity()
15			{
16			// Comprovar si no hi ha usuari logat.
17			if (auth()->guest()) {
			0 ignored issues – show Bug introduced 2017-06-06 14:26 UTC by Report Bug Copy Issue Report The method `guest` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
18			return;
19			}
20
21			foreach (static::getActivitiesToRecord() as $event) {
22			static::$event(function ($model) use ($event) {
23			$model->recordActivity($event);
24			});
25			}
26			}
27
28			/**
29			* Fetch all model events that require activity recording.
30			*
31			* @return array
32			*/
33			protected static function getActivitiesToRecord()
34			{
35			return ['created', 'updated', 'deleted'];
36			}
37
38			/**
39			* Record new activity for the model.
40			*
41			* @param string $event
42			*/
43			protected function recordActivity($event)
44			{
45			$this->activity()->create([
46			'user_id' => auth()->id(),
			0 ignored issues – show Bug introduced 2017-05-09 16:05 UTC by Report Bug Copy Issue Report The method `id` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
47			'type' => $this->getActivityType($event)
48			]);
49			}
50
51			/**
52			* Fetch the activity relationship.
53			*
54			* @return \Illuminate\Database\Eloquent\Relations\MorphMany
55			*/
56			public function activity()
57			{
58			return $this->morphMany('Scool\EnrollmentMobile\Models\Activity', 'subject');
			0 ignored issues – show Bug introduced 2017-05-09 17:13 UTC by Report Bug Copy Issue Report It seems like `morphMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
59			}
60
61			/**
62			* Determine the activity type.
63			*
64			* @param string $event
65			* @return string
66			*/
67			protected function getActivityType($event)
68			{
69			$type = strtolower((new \ReflectionClass($this))->getShortName());
70
71			return "{$event}_{$type}";
72			}
73			}
74

manelgavalda / enrollment_mobile

RecordsActivity::bootRecordsActivity() A last analyzed 2017-06-18 20:42 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

RecordsActivity::bootRecordsActivity() A
last analyzed 2017-06-18 20:42 UTC