EnrollmentDeleteRequest - Code Metrics - manelgavalda/enrollment_mobile - Measure and Improve Code Quality continuously with Scrutinizer

EnrollmentDeleteRequest A
last analyzed 2017-06-18 20:42 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	3
c	3
b	0
f	0
lcom	0
cbo	2
dl	0
loc	29
ccs	0
cts	13
cp	0
rs	10

3 Methods

Rating	Name	Size	Complexity
A	forbiddenResponse()	4	1
A	authorize()	4	1
A	rules()	6	1

<?php
namespace Scool\EnrollmentMobile\Http\Requests;

use Illuminate\Foundation\Http\FormRequest;
use Illuminate\Http\Response;
use Illuminate\Support\Facades\Auth;

/**
 * Class EnrollmentDeleteRequest
 * @package Scool\EnrollmentMobile\Http\Requests
 */
class EnrollmentDeleteRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return Auth::user()->can('delete enrollments');
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules()
    {
        return [

        ];
    }

    public function forbiddenResponse()
    {
        return Response::make('Permission denied on deleting enrollment', 403);

    }
}


1			<?php
2			namespace Scool\EnrollmentMobile\Http\Requests;
3
4			use Illuminate\Foundation\Http\FormRequest;
5			use Illuminate\Http\Response;
6			use Illuminate\Support\Facades\Auth;
7
8			/**
9			* Class EnrollmentDeleteRequest
10			* @package Scool\EnrollmentMobile\Http\Requests
11			*/
12			class EnrollmentDeleteRequest extends FormRequest
13			{
14			/**
15			* Determine if the user is authorized to make this request.
16			*
17			* @return bool
18			*/
19			public function authorize()
20			{
21			return Auth::user()->can('delete enrollments');
			0 ignored issues – show Bug introduced 2017-02-02 20:28 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `can()` does only exist in the following implementations of said interface: `Illuminate\Foundation\Auth\User`, `Scool\Foundation\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
22			}
23
24			/**
25			* Get the validation rules that apply to the request.
26			*
27			* @return array
28			*/
29			public function rules()
30			{
31			return [
32
33			];
34			}
35
36			public function forbiddenResponse()
37			{
38			return Response::make('Permission denied on deleting enrollment', 403);
			0 ignored issues – show Bug introduced 2017-02-02 20:28 UTC by Report Bug Copy Issue Report The method `make()` does not seem to exist on `object<Illuminate\Http\Response>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
39			}
40			}
41

manelgavalda / enrollment_mobile

EnrollmentDeleteRequest A last analyzed 2017-06-18 20:42 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

EnrollmentDeleteRequest A
last analyzed 2017-06-18 20:42 UTC