Scool\EnrollmentMobile\Http\Controllers\EnrollmentsController

Complexity

Total Complexity

16

Size/Duplication

Total Lines	176
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	store()	0	28	4
A	__construct()	0	5	1
A	index()	0	12	2
A	show()	0	13	2
A	edit()	0	6	1
B	update()	0	28	4
A	destroy()	0	13	2

<?php

namespace Scool\EnrollmentMobile\Http\Controllers;

use Prettus\Validator\Contracts\ValidatorInterface;
use Prettus\Validator\Exceptions\ValidatorException;
use Scool\EnrollmentMobile\Http\Requests\EnrollmentBrowseRequest;
use Scool\EnrollmentMobile\Http\Requests\EnrollmentCreateRequest;
use Scool\EnrollmentMobile\Http\Requests\EnrollmentDeleteRequest;
use Scool\EnrollmentMobile\Http\Requests\EnrollmentUpdateRequest;
use Scool\EnrollmentMobile\Repositories\EnrollmentRepository;
use Scool\EnrollmentMobile\Validators\EnrollmentValidator;

/**
 * Class EnrollmentsController
 * @package App\Http\Controllers
 */
class EnrollmentsController extends Controller
{

    /**
     * @var EnrollmentRepository
     */
    protected $repository;

    /**
     * @var EnrollmentValidator
     */
    protected $validator;

    /**
     * EnrollmentsController constructor.
     * @param EnrollmentRepository $repository
     * @param EnrollmentValidator $validator
     */
    public function __construct(EnrollmentRepository $repository, EnrollmentValidator $validator)
    {
        $this->repository = $repository;
        $this->validator  = $validator;
    }


    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(EnrollmentBrowseRequest $request)

The parameter $request is not used and could be removed.

    {
        $this->repository->pushCriteria(app('Prettus\Repository\Criteria\RequestCriteria'));
        $enrollments = $this->repository->with(['classroom', 'course', 'study'])->all();
        if (request()->wantsJson()) {
            return response()->json([
                'data' => $enrollments,
            ]);
        }

        return view('enrollment_mobile::enrollments.index', compact('enrollments'));
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  EnrollmentCreateRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(EnrollmentCreateRequest $request)
    {
        try {
            $this->validator->with($request->all())->passesOrFail(ValidatorInterface::RULE_CREATE);

            $enrollment = $this->repository->create($request->all());

            $response = [
                'message' => 'Enrollment created.',
                'data'    => $enrollment->toArray(),
            ];

            if ($request->wantsJson()) {
                return response()->json($response);
            }

            return redirect()->back()->with('message', $response['message']);
        } catch (ValidatorException $e) {
            if ($request->wantsJson()) {
                return response()->json([
                    'error'   => true,
                    'message' => $e->getMessageBag()
                ]);
            }

            return redirect()->back()->withErrors($e->getMessageBag())->withInput();
        }
    }


    /**
     * Display the specified resource.
     *
     * @param  int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        //return Auth::user()->can('view enrollment');

70% of this comment could be valid code. Did you maybe forget this after debugging?

        $enrollment = $this->repository->find($id);

        if (request()->wantsJson()) {
            return response()->json([
                'data' => $enrollment,
            ]);
        }

        return view('enrollment_mobile::enrollments.show', compact('enrollment'));
    }


    /**
     * Show the form for editing the specified resource.
     *
     * @param  int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit($id)
    {
        $enrollment = $this->repository->find($id);

        return view('enrollment_mobile::enrollments.edit', compact('enrollment'));
    }


    /**
     * Update the specified resource in storage.
     *
     * @param  EnrollmentUpdateRequest $request
     * @param  $id string
     *
     * @return Response
     */
    public function update(EnrollmentUpdateRequest $request, $id)
    {
        try {
            $this->validator->with($request->all())->passesOrFail(ValidatorInterface::RULE_UPDATE);

            $enrollment = $this->repository->update($request->all(), $id);

            $response = [
                'message' => 'Enrollment updated.',
                'data'    => $enrollment->toArray(),
            ];

            if ($request->wantsJson()) {
                return response()->json($response);
            }

            return redirect()->back()->with('message', $response['message']);
        } catch (ValidatorException $e) {
            if ($request->wantsJson()) {
                return response()->json([
                    'error'   => true,
                    'message' => $e->getMessageBag()
                ]);
            }

            return redirect()->back()->withErrors($e->getMessageBag())->withInput();
        }
    }


    /**
     * Remove the specified resource from storage.
     *
     * @param  int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy(EnrollmentDeleteRequest $request, $id)

The parameter $request is not used and could be removed.

    {
        $deleted = $this->repository->delete($id);

        if (request()->wantsJson()) {
            return response()->json([
                'message' => 'Enrollment deleted.',
                'deleted' => $deleted,
            ]);
        }

        return redirect()->back()->with('message', 'Enrollment deleted.');
    }
}
//TODO: Fer testos de validació enrollment_mobile i todos_Backend. mock del repository del create(crear nosalters lenrollment per fer el test).