mambax7 / xoositemap

sitemap.xml.php

<?php
/**
 * Xoositemap module
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @package         Xoositemap
 * @since           2.6.0
 * @author          Laurent JEN (Aka DuGris)

 */
if (file_exists('mainfile.php')) {
    include __DIR__ . '/mainfile.php';
} else {
    require  dirname(dirname(__DIR__)) . '/mainfile.php';
}
$xoops = \Xoops::getInstance();
$xoops->disableErrorReporting();

if (function_exists('mb_http_output')) {
    mb_http_output('pass');
}
header('Content-Type:text/xml; charset=utf-8');

$dirname = $xoops->isModule() ? $xoops->module->getVar('dirname') : 'system';

The method getVar() does not exist on null.

$tpl = new \XoopsTpl();
//$tpl->caching = 2;
//$tpl->cache_lifetime = 3600;
//if (!$tpl->is_cached('module:xoositemap/xoositemap_xml.html')) {

if ($xoops->isModule()) {
    $plugin = \Xoops\Module\Plugin::getPlugin($dirname, 'xoositemap');

It seems like $dirname can also be of type string[]; however, parameter $dirname of Xoops\Module\Plugin::getPlugin() does only seem to accept string, maybe add an additional type check?

    $res    = $plugin->Xoositemap_xml(true);
    if (is_array($res)) {
        $time       = isset($res['time']) ? $res['time'] : time();
        $mod_time[] = ['time' => $time];
        $modules[] = [
            'time'    => $time,
            'dirname' => $res['dirname'],
            'date' => gmdate('Y-m-d\TH:i:s\Z', $time),
        ];
        if (count($res['items']) > 0) {
            foreach ($res['items'] as $item) {
                $times[] = ['time' => $item['time']];
                $items[] = [
                    'time' => $item['time'],
                    'date' => gmdate('Y-m-d\TH:i:s\Z', $item['time']),
                    'link' => $item['url'],
                ];
            }
        }
    }
} else {
    $plugins = \Xoops\Module\Plugin::getPlugins('xoositemap');
    foreach ($plugins as $plugin) {
        $res = $plugin->Xoositemap_xml(true);
        if (is_array($res)) {
            $time       = isset($res['time']) ? $res['time'] : time();
            $mod_time[] = ['time' => $time];
            $modules[] = [
                'time'    => $time,
                'dirname' => $res['dirname'],
                'date' => gmdate('Y-m-d\TH:i:s\Z', $time),
            ];
            if (count($res['items']) > 0) {
                foreach ($res['items'] as $item) {
                    $times[] = ['time' => $item['time']];
                    $items[] = [
                        'time' => $item['time'],
                        'date' => gmdate('Y-m-d\TH:i:s\Z', $item['time']),
                        'link' => $item['url'],
                    ];
                }
            }
        }
    }
}

array_multisort($times, SORT_DESC, $items);
array_multisort($mod_time, SORT_DESC, $modules);
$tpl->assign('items', $items);
$tpl->assign('modules', $modules);
$tpl->assign('modification', gmdate('Y-m-d\TH:i:s\Z'));
//}
$tpl->display('module:xoositemap/xoositemap_xml.tpl');