mambax7 / xoopsmembers

blocks/membersonline_block.php

<?php declare(strict_types=1);
//  Author: SMD & Trabis
//  URL: https://www.xoopsmalaysia.org  & https://www.xoops.org
//  E-Mail: webmaster@xoopsmalaysia.org  & lusopoemas@gmail.com

if (!defined('XOOPS_ROOT_PATH')) {
    exit;
}

function show_membersonline_block($options)
{
    global $xoopsConfig, $xoopsUser, $xoopsModule, $xoopsDB, $_SERVER;

    /** @var XoopsOnlineHandler $onlineHandler */
    $onlineHandler = xoops_getHandler('online');
    // set gc probabillity to 10% for now..
    if (mt_rand(1, 100) < 11) {
        $onlineHandler->gc(300);
    }
    if (is_object($xoopsUser)) {
        $uid  = $xoopsUser->getVar('uid');
        $name = $xoopsUser->getVar('name');
        if ($options[4] == '1' && $name != '') {
            $uname = $xoopsUser->getVar('name');
        } else {
            $uname = $xoopsUser->getVar('uname');
        }
    } else {
        $uid   = 0;
        $uname = '';
        $name  = '';

The assignment to $name is dead and can be removed.

    }
    $requestIp = \Xmf\IPAddress::fromRequest()->asReadable();
    $requestIp = (false === $requestIp) ? '0.0.0.0' : $requestIp;

The condition false === $requestIp is always false.

    if (is_object($xoopsModule)) {
        $onlineHandler->write($uid, $uname, time(), $xoopsModule->getVar('mid'), $requestIp);
    } else {
        $onlineHandler->write($uid, $uname, time(), 0, $requestIp);
    }
    $onlines = $onlineHandler->getAll();
    if (!empty($onlines)) {
        $total         = count($onlines);
        $block         = [];
        $guests        = 0;
        $membersname   = '';
        $membersavatar = '';

The assignment to $membersavatar is dead and can be removed.

        $avatar        = '';

The assignment to $avatar is dead and can be removed.

        $uid           = '';

The assignment to $uid is dead and can be removed.

        $name          = '';
        $onlineUsers   = [];
        for ($i = 0; $i < $total; ++$i) {
            if ($onlines[$i]['online_uid'] == 0) {
                $onlineUsers[$i]['user'] = '';
            } else {
                $onlineUsers[$i]['user'] = new XoopsUser($onlines[$i]['online_uid']);
            }
            if (is_object($onlineUsers[$i]['user'])) {
                $block['avatar'] = $onlineUsers[$i]['user']->getVar('user_avatar');
                $block['uid']    = $onlineUsers[$i]['user']->getVar('uid');

                $realname = $onlineUsers[$i]['user']->getVar('name');
                if ('1' == $options[5] && '' != $realname) {
                    $block['name'] = $onlineUsers[$i]['user']->getVar('name');
                } else {
                    $block['name'] = $onlineUsers[$i]['user']->getVar('uname');
                }
            }

            if ($onlines[$i]['online_uid'] > 0) {
                $membersname .= '<a href="' . XOOPS_URL . '/userinfo.php?uid=' . $onlines[$i]['online_uid'] . '" title="' . $onlines[$i]['online_uname'] . '">' . $onlines[$i]['online_uname'] . '</a>, ';
            } else {
                ++$guests;
            }
        }
        $block['online_total'] = sprintf(_ONLINEPHRASE, $total);
        if (is_object($xoopsModule)) {
            $mytotal               = $onlineHandler->getCount(new Criteria('online_module', $xoopsModule->getVar('mid')));
            $block['online_total'] .= ' (' . sprintf(_ONLINEPHRASEX, $mytotal, $xoopsModule->getVar('name')) . ')';
        }
        // Membership Statistic
        /** @var \XoopsMemberHandler $memberHandler */
        $memberHandler      = xoops_getHandler('member');
        $today              = formatTimestamp(time());

The assignment to $today is dead and can be removed.

        $level_criteria     = new Criteria('level', 0, '>');
        $criteria           = new CriteriaCompo($level_criteria);
        $criteria24         = new CriteriaCompo($level_criteria);
        $criteria48         = new CriteriaCompo($level_criteria);
        $total_active_users = $memberHandler->getUserCount($level_criteria);
        //Fixing stats for last 24 and 48 hours
        $users_reg_24 = $memberHandler->getUserCount($criteria24->add(new Criteria('user_regdate', (mktime(0, 0, 0) - (24 * 3600)), '>=')), 'AND');

The call to XoopsMemberHandler::getUserCount() has too many arguments starting with 'AND'.

        $users_reg_48 = $memberHandler->getUserCount($criteria48->add(new Criteria('user_regdate', (mktime(0, 0, 0) - (48 * 3600)), '>=')), 'AND');
        $limit        = 1;
        $criteria->setOrder('DESC');
        $criteria->setSort('user_regdate');
        $criteria->setLimit($limit);

        // data
        $block['activeusers']    = $total_active_users;
        $block['todayreg']       = $users_reg_24;
        $block['yesterdayreg']   = $users_reg_48 - $users_reg_24;
        $block['total_online']   = sprintf(_MB_XOOPSMEMBERS_TOTALONLINE, $total);
        $block['online_members'] = $total - $guests . ' ' . _MB_XOOPSMEMBERS_MEMBERS . ' ' . _MB_XOOPSMEMBERS_CURRENTONLINE;
        $block['online_guests']  = $guests . ' ' . _MB_XOOPSMEMBERS_GUESTS . ' ' . _MB_XOOPSMEMBERS_AND;

        $block['showonlinemember'] = $options[0];
        $block['showonlinename']   = $options[1];
        $block['showonlineavatar'] = $options[2];
        $block['showonlinepopup']  = $options[3];
        $block['showtotalonline']  = $options[4];
        $block['userealname']      = $options[5];
        $block['memberdisplay']    = $options[6];

        return $block;
    }

    return false;
}

function membersonline_edit($options)
{
    $chk  = '';
    $form = _MB_XOOPSMEMBERS_SHOWONLINEMEMBER . ' ';
    if ($options[0] == 1) {
        $chk = ' checked';
    }
    $form .= "<input type='radio' name='options[0]' value='1'" . $chk . '>&nbsp;' . _YES . '';
    if ($options[0] == 0) {
        $chk = ' checked';
    }
    $form .= "&nbsp;<input type='radio' name='options[0]' value='0'" . $chk . '>' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_SHOWONLINENAME . '&nbsp;';
    if ($options[1] == 1) {
        $chk = ' checked';
    }
    $form .= "<input type='radio' name='options[1]' value='1'" . $chk . '>&nbsp;' . _YES . '';
    $chk  = '';
    if ($options[1] == 0) {
        $chk = ' checked';
    }
    $form .= "&nbsp;<input type='radio' name='options[1]' value='0'" . $chk . '>' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_SHOWONLINEAVATAR . '&nbsp;';
    if ($options[2] == 1) {
        $chk = ' checked';
    }
    $form .= "<input type='radio' name='options[2]' value='1'" . $chk . '>&nbsp;' . _YES . '';
    $chk  = '';
    if ($options[2] == 0) {
        $chk = ' checked';
    }
    $form .= "&nbsp;<input type='radio' name='options[2]' value='0'" . $chk . '>' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_SHOWONLINEPOPUP . '&nbsp;';
    if ($options[3] == 1) {
        $chk = ' checked';
    }
    $form .= "<input type='radio' name='options[3]' value='1'" . $chk . '>&nbsp;' . _YES . '';
    $chk  = '';
    if ($options[3] == 0) {
        $chk = ' checked';
    }
    $form .= "&nbsp;<input type='radio' name='options[3]' value='0'" . $chk . '>' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_SHOWTOTALONLINE . '&nbsp;';
    if ($options[4] == 1) {
        $chk = ' checked';
    }
    $form .= "<input type='radio' name='options[4]' value='1'" . $chk . '>&nbsp;' . _YES . '';
    $chk  = '';
    if ($options[4] == 0) {
        $chk = ' checked';
    }
    $form .= "&nbsp;<input type='radio' name='options[4]' value='0'" . $chk . '>' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_USEREALNAME . '&nbsp;';
    if ($options[5] == 1) {
        $chk = ' checked';
    }
    $form .= "<input type='radio' name='options[5]' value='1'" . $chk . '>&nbsp;' . _YES . '';
    $chk  = '';
    if ($options[5] == 0) {
        $chk = ' checked';
    }
    $form .= "&nbsp;<input type='radio' name='options[5]' value='0'" . $chk . '>' . _NO . '<br>';

    $form .= _MB_XOOPSMEMBERS_MEMBERDISPLAY . '&nbsp;';
    $form .= "<input type='text' name='options[6]' value='" . $options[6] . "'>";

    return $form;
}