mambax7 / xoopsmembers

index.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 338 and the first side effect is on line 20.

/**
 * Xoops Members Module
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright The XOOPS Project http://sourceforge.net/projects/xoops/
 * @license http://www.fsf.org/copyleft/gpl.html GNU public license
 * @package Xoops Members
 * @since 2.3.0
 * @author onokazu
 * @author John Neill
 * @version $Id: index.php catzwolf$
 */
include dirname( dirname( dirname( __FILE__ ) ) ) . DIRECTORY_SEPARATOR . 'mainfile.php';
//include_once 'header.php';

67% of this comment could be valid code. Did you maybe forget this after debugging?

//global $pathIcon16;

global $xoopsModule;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

$pathIcon16 = $xoopsModule->getInfo('icons16');

$op = ( isset( $_POST['op'] ) && $_POST['op'] == 'submit' ) ? 'submit' : 'form';

if ( $op == 'form' ) {
    $xoopsOption['template_main'] = 'xoopsmembers_searchform.html';
    include XOOPS_ROOT_PATH . '/header.php';

    $member_handler = &xoops_gethandler( 'member' );
    $total = $member_handler->getUserCount( new Criteria( 'level', 0, '>' ) );

    include_once XOOPS_ROOT_PATH . "/class/xoopsformloader.php";

    $form = new XoopsThemeForm( '', 'searchform', 'index.php' );
    $uname_text = new XoopsFormText( '', 'user_uname', 30, 60 );
    $uname_match = new XoopsFormSelectMatchOption( '', 'user_uname_match' );
    $uname_tray = new XoopsFormElementTray( _XO_LA_UNAME, ' ' );
    $uname_tray->addElement( $uname_match );
    $uname_tray->addElement( $uname_text );
    $form->addElement( $uname_tray );

    $name_text = new XoopsFormText( '', 'user_name', 30, 60 );
    $name_match = new XoopsFormSelectMatchOption( '', 'user_name_match' );
    $name_tray = new XoopsFormElementTray( _XO_LA_REALNAME, ' ' );
    $name_tray->addElement( $name_match );
    $name_tray->addElement( $name_text );
    $form->addElement( $name_tray );

    $email_text = new XoopsFormText( '', 'user_email', 30, 60 );
    $email_match = new XoopsFormSelectMatchOption( '', 'user_email_match' );
    $email_tray = new XoopsFormElementTray( _XO_LA_EMAIL, ' ' );
    $email_tray->addElement( $email_match );
    $email_tray->addElement( $email_text );
    $form->addElement( $email_tray );

    $form->addElement( new XoopsFormText( _XO_LA_URLC, 'user_url', 30, 100 ) );

    $icq_text = new XoopsFormText( '', 'user_icq', 30, 100 );
    $icq_match = new XoopsFormSelectMatchOption( '', 'user_icq_match' );
    $icq_tray = new XoopsFormElementTray( _XO_LA_ICQ, ' ' );
    $icq_tray->addElement( $icq_match );
    $icq_tray->addElement( $icq_text );
    $form->addElement( $icq_tray );

    $aim_text = new XoopsFormText( '', 'user_aim', 30, 100 );
    $aim_match = new XoopsFormSelectMatchOption( '', 'user_aim_match' );
    $aim_tray = new XoopsFormElementTray( _XO_LA_AIM, ' ' );
    $aim_tray->addElement( $aim_match );
    $aim_tray->addElement( $aim_text );
    $form->addElement( $aim_tray );

    $yim_text = new XoopsFormText( '', 'user_yim', 30, 100 );
    $yim_match = new XoopsFormSelectMatchOption( '', 'user_yim_match' );
    $yim_tray = new XoopsFormElementTray( _XO_LA_YIM, ' ' );
    $yim_tray->addElement( $yim_match );
    $yim_tray->addElement( $yim_text );
    $form->addElement( $yim_tray );

    $msnm_text = new XoopsFormText( '', 'user_msnm', 30, 100 );
    $msnm_match = new XoopsFormSelectMatchOption( '', 'user_msnm_match' );
    $msnm_tray = new XoopsFormElementTray( _XO_LA_MSNM, ' ' );
    $msnm_tray->addElement( $msnm_match );
    $msnm_tray->addElement( $msnm_text );
    $form->addElement( $msnm_tray );

    $form->addElement( new XoopsFormText( _XO_LA_LOCATION, 'user_from', 30, 100 ) );
    $form->addElement( new XoopsFormText( _XO_LA_OCCUPATION, 'user_occ', 30, 100 ) );
    $form->addElement( new XoopsFormText( _XO_LA_INTEREST, 'user_intrest', 30, 100 ) );
    $form->addElement( new XoopsFormText( _XO_LA_LASTLOGMORE, 'user_lastlog_more', 10, 5 ) );
    $form->addElement( new XoopsFormText( _XO_LA_LASTLOGLESS, 'user_lastlog_less', 10, 5 ) );
    $form->addElement( new XoopsFormText( _XO_LA_REGMORE, 'user_reg_more', 10, 5 ) );
    $form->addElement( new XoopsFormText( _XO_LA_REGLESS, 'user_reg_less', 10, 5 ) );
    $form->addElement( new XoopsFormText( _XO_LA_POSTSMORE, 'user_posts_more', 10, 5 ) );
    $form->addElement( new XoopsFormText( _XO_LA_POSTSLESS, 'user_posts_less', 10, 5 ) );

    $sort_select = new XoopsFormSelect( _XO_LA_SORT, 'user_sort' );
    $sort_select->addOptionArray( array( 'uname' => _XO_LA_UNAME, 'email' => _XO_LA_EMAIL, 'last_login' => _XO_LA_LASTLOGIN, 'user_regdate' => _XO_LA_REGDATE, 'posts' => _XO_LA_POSTS ) );
    $form->addElement( $sort_select );

    $order_select = new XoopsFormSelect( _XO_LA_ORDER, 'user_order' );
    $order_select->addOptionArray( array( 'ASC' => _XO_LA_ASC, 'DESC' => _XO_LA_DESC ) );
    $form->addElement( $order_select );

    $form->addElement( new XoopsFormText( _XO_LA_LIMIT, 'limit', 6, 2 ) );
    $form->addElement( new XoopsFormHidden( 'op', 'submit' ) );
    $form->addElement( new XoopsFormButton( '', 'user_submit', _SUBMIT, 'submit' ) );
    $form->assign( $xoopsTpl );
    $xoopsTpl->assign( 'totalmember', $total );
}

if ( $op == 'submit' ) {
    $xoopsOption['template_main'] = 'xoopsmembers_searchresults.html';
    include XOOPS_ROOT_PATH . '/header.php';

    $iamadmin = $xoopsUserIsAdmin;
    $myts = &MyTextSanitizer::getInstance();
    $criteria = new CriteriaCompo();

    if ( !empty( $_POST['user_uname'] ) ) {

This code seems to be duplicated across your project.

        $match = ( !empty( $_POST['user_uname_match'] ) ) ? intval( $_POST['user_uname_match'] ) : XOOPS_MATCH_START;
        $ret = $myts->addSlashes( trim( $_POST['user_uname'] ) );
        xoops_Criteria( $criteria, 'uname', $ret, $match );
    }

    if ( !empty( $_POST['user_name'] ) ) {

This code seems to be duplicated across your project.

        $match = ( !empty( $_POST['user_name_match'] ) ) ? intval( $_POST['user_name_match'] ) : XOOPS_MATCH_START;
        $ret = $myts->addSlashes( trim( $_POST['user_uname'] ) );
        xoops_Criteria( $criteria, 'name', $ret, $match );
    }

    if ( !empty( $_POST['user_email'] ) ) {
        $match = ( !empty( $_POST['user_email_match'] ) ) ? intval( $_POST['user_email_match'] ) : XOOPS_MATCH_START;
        $ret = $myts->addSlashes( trim( $_POST['user_email'] ) );
        xoops_Criteria( $criteria, 'name', $ret, $match );
        if ( !$iamadmin ) {
            $criteria->add( new Criteria( 'user_viewemail', 1 ) );
        }
    }

    if ( !empty( $_POST['user_url'] ) ) {

This code seems to be duplicated across your project.

        $url = formatURL( trim( $_POST['user_url'] ) );
        $criteria->add( new Criteria( 'url', $myts->addSlashes( $url ) . '%', 'LIKE' ) );
    }

    if ( !empty( $_POST['user_icq'] ) ) {

This code seems to be duplicated across your project.

        $match = ( !empty( $_POST['user_icq_match'] ) ) ? intval( $_POST['user_icq_match'] ) : XOOPS_MATCH_START;
        $ret = $myts->addSlashes( trim( $_POST['user_icq'] ) );
        xoops_Criteria( $criteria, 'user_icq', $ret, $match );
    }

    if ( !empty( $_POST['user_aim'] ) ) {

This code seems to be duplicated across your project.

        $match = ( !empty( $_POST['user_aim_match'] ) ) ? intval( $_POST['user_aim_match'] ) : XOOPS_MATCH_START;
        $ret = $myts->addSlashes( trim( $_POST['user_aim'] ) );
        xoops_Criteria( $criteria, 'user_aim', $ret, $match );
    }

    if ( !empty( $_POST['user_yim'] ) ) {

This code seems to be duplicated across your project.

        $match = ( !empty( $_POST['user_yim_match'] ) ) ? intval( $_POST['user_yim_match'] ) : XOOPS_MATCH_START;
        $ret = $myts->addSlashes( trim( $_POST['user_yim'] ) );
        xoops_Criteria( $criteria, 'user_yim', $ret, $match );
    }

    if ( !empty( $_POST['user_msnm'] ) ) {

This code seems to be duplicated across your project.

        $match = ( !empty( $_POST['user_msnm_match'] ) ) ? intval( $_POST['user_msnm_match'] ) : XOOPS_MATCH_START;
        $ret = $myts->addSlashes( trim( $_POST['user_msnm'] ) );
        xoops_Criteria( $criteria, 'user_msnm', $ret, $match );
    }

    if ( !empty( $_POST['user_from'] ) ) {

This code seems to be duplicated across your project.

        $criteria->add( new Criteria( 'user_from', '%' . $myts->addSlashes( trim( $_POST['user_from'] ) ) . '%', 'LIKE' ) );
    }

    if ( !empty( $_POST['user_intrest'] ) ) {

This code seems to be duplicated across your project.

        $criteria->add( new Criteria( 'user_intrest', '%' . $myts->addSlashes( trim( $_POST['user_intrest'] ) ) . '%', 'LIKE' ) );
    }

    if ( !empty( $_POST['user_occ'] ) ) {

This code seems to be duplicated across your project.

        $criteria->add( new Criteria( 'user_occ', '%' . $myts->addSlashes( trim( $_POST['user_occ'] ) ) . '%', 'LIKE' ) );
    }

    if ( !empty( $_POST['user_lastlog_more'] ) && is_numeric( $_POST['user_lastlog_more'] ) ) {

This code seems to be duplicated across your project.

        $f_user_lastlog_more = intval( trim( $_POST['user_lastlog_more'] ) );
        $time = time() - ( 60 * 60 * 24 * $f_user_lastlog_more );
        if ( $time > 0 ) {
            $criteria->add( new Criteria( 'last_login', $time, '<' ) );
        }
    }

    if ( !empty( $_POST['user_lastlog_less'] ) && is_numeric( $_POST['user_lastlog_less'] ) ) {

This code seems to be duplicated across your project.

        $f_user_lastlog_less = intval( trim( $_POST['user_lastlog_less'] ) );
        $time = time() - ( 60 * 60 * 24 * $f_user_lastlog_less );
        if ( $time > 0 ) {
            $criteria->add( new Criteria( 'last_login', $time, '>' ) );
        }
    }

    if ( !empty( $_POST['user_reg_more'] ) && is_numeric( $_POST['user_reg_more'] ) ) {

This code seems to be duplicated across your project.

        $f_user_reg_more = intval( trim( $_POST['user_reg_more'] ) );
        $time = time() - ( 60 * 60 * 24 * $f_user_reg_more );
        if ( $time > 0 ) {
            $criteria->add( new Criteria( 'user_regdate', $time, '<' ) );
        }
    }

    if ( !empty( $_POST['user_reg_less'] ) && is_numeric( $_POST['user_reg_less'] ) ) {

This code seems to be duplicated across your project.

        $f_user_reg_less = intval( $_POST['user_reg_less'] );
        $time = time() - ( 60 * 60 * 24 * $f_user_reg_less );
        if ( $time > 0 ) {
            $criteria->add( new Criteria( 'user_regdate', $time, '>' ) );
        }
    }

    if ( isset( $_POST['user_posts_more'] ) && is_numeric( $_POST['user_posts_more'] ) ) {

This code seems to be duplicated across your project.

        $criteria->add( new Criteria( 'posts', intval( $_POST['user_posts_more'] ), '>' ) );
    }

    if ( !empty( $_POST['user_posts_less'] ) && is_numeric( $_POST['user_posts_less'] ) ) {

This code seems to be duplicated across your project.

        $criteria->add( new Criteria( 'posts', intval( $_POST['user_posts_less'] ), '<' ) );
    }

    $criteria->add( new Criteria( 'level', 0, '>' ) );
    $validsort = array( 'uname', 'email', 'last_login', 'user_regdate', 'posts' );
    $sort = ( !in_array( $_POST['user_sort'], $validsort ) ) ? 'uname' : $_POST['user_sort'];
    $order = 'ASC';
    if ( isset( $_POST['user_order'] ) && $_POST['user_order'] == 'DESC' ) {
        $order = 'DESC';
    }
    $limit = ( !empty( $_POST['limit'] ) ) ? intval( $_POST['limit'] ) : 20;
    if ( $limit == 0 || $limit > 50 ) {
        $limit = 50;
    }

    $start = ( !empty( $_POST['start'] ) ) ? intval( $_POST['start'] ) : 0;
    $member_handler = &xoops_gethandler( 'member' );
    $total = $member_handler->getUserCount( $criteria );
    $xoopsTpl->assign( 'total_found', $total );

    if ( $total == 0 ) {

This if statement is empty and can be removed.

    } elseif ( $start < $total ) {
        if ( $iamadmin ) {
            $xoopsTpl->assign( 'is_admin', true );
        }
        $criteria->setSort( $sort );
        $criteria->setOrder( $order );
        $criteria->setStart( $start );
        $criteria->setLimit( $limit );
        $foundusers = &$member_handler->getUsers( $criteria, true );
        foreach ( array_keys( $foundusers ) as $j ) {
            $userdata["avatar"] = $foundusers[$j]->getVar( 'user_avatar' ) ? '<img src="' . XOOPS_UPLOAD_URL . '/' . $foundusers[$j]->getVar( 'user_avatar' ) . '" alt="" />' : '&nbsp;';
            $userdata["realname"] = $foundusers[$j]->getVar( 'name' ) ? $foundusers[$j]->getVar( 'name' ) : '&nbsp;';
            $userdata["name"] = $foundusers[$j]->getVar( 'uname' );
            $userdata["id"] = $foundusers[$j]->getVar( 'uid' );
            if ( $foundusers[$j]->getVar( 'user_viewemail' ) == 1 || $iamadmin ) {
                $userdata["email"] = '<a href="mailto:' . $foundusers[$j]->getVar( 'email' ) . '"><img src="' . XOOPS_URL . '/images/icons/email.gif" border="0" alt="' . sprintf( _SENDEMAILTO, $foundusers[$j]->getVar( 'uname', "e" ) ) . '" /></a>';
            } else {
                $userdata["email"] = '&nbsp;';
            }
            if ( $xoopsUser ) {
                $userdata["pmlink"] = '<a href="javascript:openWithSelfMain(\'' . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . $foundusers[$j]->getVar( 'uid' ) . '\',\'pmlite\',450,370);"><img src="' . XOOPS_URL . '/images/icons/pm.gif" border="0" alt="' . sprintf( _SENDPMTO, $foundusers[$j]->getVar( 'uname', "e" ) ) . '" /></a>';
            } else {
                $userdata["pmlink"] = '&nbsp;';
            }
            if ( $foundusers[$j]->getVar( 'url', "e" ) != '' ) {
                $userdata["website"] = '<a href="' . $foundusers[$j]->getVar( 'url', "e" ) . '" target="_blank"><img src="' . XOOPS_URL . '/images/icons/www.gif" border="0" alt="' . _VISITWEBSITE . '" /></a>';
            } else {
                $userdata["website"] = '&nbsp;';
            }
            $userdata["registerdate"] = formatTimeStamp( $foundusers[$j]->getVar( 'user_regdate' ), 's' );
            if ( $foundusers[$j]->getVar( 'last_login' ) != 0 ) {
                $userdata["lastlogin"] = formatTimeStamp( $foundusers[$j]->getVar( 'last_login' ), "m" );
            } else {
                $userdata["lastlogin"] = '&nbsp;';
            }
            $userdata["posts"] = $foundusers[$j]->getVar( 'posts' );
            if ( $iamadmin ) {
                $userdata["adminlink"] = '<a href="' . XOOPS_URL . '/modules/system/admin.php?fct=users&amp;uid=' . $foundusers[$j]->getVar( 'uid' ) . '&amp;op=users_edit">' . '<img src='. $pathIcon16 .'/edit.png'." alt='" . _EDIT . "' title='" . _EDIT . "' />"

                . '</a> | <a href="' . XOOPS_URL . '/modules/system/admin.php?fct=users&amp;op=users_delete&amp;uid=' . $foundusers[$j]->getVar( 'uid' ) . '">' . '<img src='. $pathIcon16 .'/delete.png'." alt='" . _DELETE . "' title='" . _DELETE . "' />" . '</a>';
            }
            $xoopsTpl->append( "users", $userdata );
        }

        $totalpages = ceil( $total / $limit );
        if ( $totalpages > 1 ) {
            $hiddenform = '<form name="findnext" action="index.php" method="post">';
            foreach ( $_POST as $k => $v ) {
                $hiddenform .= '<input type="hidden" name="' . $myts->htmlSpecialChars( $k ) . '" value="' . $myts->previewTarea( $v ) . '" />';
            }
            if ( !isset( $_POST['limit'] ) ) {
                $hiddenform .= '<input type="hidden" name="limit" value="' . $limit . '" />';
            }
            if ( !isset( $_POST['start'] ) ) {
                $hiddenform .= '<input type="hidden" name="start" value="' . $start . '" />';
            }
            $prev = $start - $limit;
            if ( $start - $limit >= 0 ) {
                $hiddenform .= '<a href="#0" onclick="javascript:document.findnext.start.value=' . $prev . ';document.findnext.submit();">' . _XO_LA_PREVIOUS . '</a>&nbsp;';
            }
            $counter = 1;
            $currentpage = ( $start + $limit ) / $limit;
            while ( $counter <= $totalpages ) {
                if ( $counter == $currentpage ) {
                    $hiddenform .= '<b>' . $counter . '</b> ';
                } elseif ( ( $counter > $currentpage-4 && $counter < $currentpage + 4 ) || $counter == 1 || $counter == $totalpages ) {
                    if ( $counter == $totalpages && $currentpage < $totalpages-4 ) {
                        $hiddenform .= '... ';
                    }
                    $hiddenform .= '<a href="#' . $counter . '" onclick="javascript:document.findnext.start.value=' . ( $counter-1 ) * $limit . ';document.findnext.submit();">' . $counter . '</a> ';
                    if ( $counter == 1 && $currentpage > 5 ) {
                        $hiddenform .= '... ';
                    }
                }
                $counter++;
            }
            $next = $start + $limit;
            if ( $total > $next ) {
                $hiddenform .= '&nbsp;<a href="#' . $total . '" onclick="javascript:document.findnext.start.value=' . $next . ';document.findnext.submit();">' . _XO_LA_NEXT . '</a>';
            }
            $hiddenform .= '</form>';
            $xoopsTpl->assign( 'pagenav', $hiddenform );
            $xoopsTpl->assign( 'lang_numfound', sprintf( _XO_LA_USERSFOUND, $total ) );
        }
    }
}

include_once XOOPS_ROOT_PATH . '/footer.php';
exit();

/**
 * xoops_Criteria()
 *
 * @return
 */
function xoops_Criteria( &$criteria, $name = '', $ret = '', $match = '' ) {
    global $criteria;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    switch ( $match ) {
        case XOOPS_MATCH_START:
            $criteria->add( new Criteria( $name, $ret . '%', 'LIKE' ) );
            break;
        case XOOPS_MATCH_END:
            $criteria->add( new Criteria( $name, '%' . $ret . '%', 'LIKE' ) );
            break;
        case XOOPS_MATCH_EQUAL:
            $criteria->add( new Criteria( $name, $ret ) );
            break;
        case XOOPS_MATCH_CONTAIN:
            $criteria->add( new Criteria( $name, '%' . $ret . '%', 'LIKE' ) );
            break;
    }
}