Issues in index.php - All Issues - Inspection of "Help & Language files update" - mambax7/xoopsmembers - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff4558...64abdf )

by Michael

created 2017-08-04 11:11 UTC

index.php (21 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Xoops Members Module
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright XOOPS Project (https://xoops.org)
 * @license   http://www.fsf.org/copyleft/gpl.html GNU public license
 * @package   Xoops Members
 * @since     2.3.0
 * @author    onokazu
 * @author    John Neill
 */
include dirname(dirname(__DIR__)) . DIRECTORY_SEPARATOR . 'mainfile.php';
//require_once __DIR__ . '/header.php';

//global $pathIcon16;

global $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
$pathIcon16 = \Xmf\Module\Admin::iconUrl('', 16);

$op = (isset($_POST['op']) && $_POST['op'] === 'submit') ? 'submit' : 'form';

if ($op === 'form') {
    $GLOBALS['xoopsOption']['template_main'] = 'xoopsmembers_searchform.html';
    include XOOPS_ROOT_PATH . '/header.php';

    $memberHandler = xoops_getHandler('member');
    $total         = $memberHandler->getUserCount(new Criteria('level', 0, '>'));

    require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

    $form        = new XoopsThemeForm('', 'searchform', 'index.php');
    $uname_text  = new XoopsFormText('', 'user_uname', 30, 60);
    $uname_match = new XoopsFormSelectMatchOption('', 'user_uname_match');
    $uname_tray  = new XoopsFormElementTray(_XO_LA_UNAME, '&nbsp;');
    $uname_tray->addElement($uname_match);
    $uname_tray->addElement($uname_text);
    $form->addElement($uname_tray);

    $name_text  = new XoopsFormText('', 'user_name', 30, 60);
    $name_match = new XoopsFormSelectMatchOption('', 'user_name_match');
    $name_tray  = new XoopsFormElementTray(_XO_LA_REALNAME, '&nbsp;');
    $name_tray->addElement($name_match);
    $name_tray->addElement($name_text);
    $form->addElement($name_tray);

    $email_text  = new XoopsFormText('', 'user_email', 30, 60);
    $email_match = new XoopsFormSelectMatchOption('', 'user_email_match');
    $email_tray  = new XoopsFormElementTray(_XO_LA_EMAIL, '&nbsp;');
    $email_tray->addElement($email_match);
    $email_tray->addElement($email_text);
    $form->addElement($email_tray);

    $form->addElement(new XoopsFormText(_XO_LA_URLC, 'user_url', 30, 100));

    $icq_text  = new XoopsFormText('', 'user_icq', 30, 100);
    $icq_match = new XoopsFormSelectMatchOption('', 'user_icq_match');
    $icq_tray  = new XoopsFormElementTray(_XO_LA_ICQ, '&nbsp;');
    $icq_tray->addElement($icq_match);
    $icq_tray->addElement($icq_text);
    $form->addElement($icq_tray);

    $aim_text  = new XoopsFormText('', 'user_aim', 30, 100);
    $aim_match = new XoopsFormSelectMatchOption('', 'user_aim_match');
    $aim_tray  = new XoopsFormElementTray(_XO_LA_AIM, '&nbsp;');
    $aim_tray->addElement($aim_match);
    $aim_tray->addElement($aim_text);
    $form->addElement($aim_tray);

    $yim_text  = new XoopsFormText('', 'user_yim', 30, 100);
    $yim_match = new XoopsFormSelectMatchOption('', 'user_yim_match');
    $yim_tray  = new XoopsFormElementTray(_XO_LA_YIM, '&nbsp;');
    $yim_tray->addElement($yim_match);
    $yim_tray->addElement($yim_text);
    $form->addElement($yim_tray);

    $msnm_text  = new XoopsFormText('', 'user_msnm', 30, 100);
    $msnm_match = new XoopsFormSelectMatchOption('', 'user_msnm_match');
    $msnm_tray  = new XoopsFormElementTray(_XO_LA_MSNM, '&nbsp;');
    $msnm_tray->addElement($msnm_match);
    $msnm_tray->addElement($msnm_text);
    $form->addElement($msnm_tray);

    $form->addElement(new XoopsFormText(_XO_LA_LOCATION, 'user_from', 30, 100));
    $form->addElement(new XoopsFormText(_XO_LA_OCCUPATION, 'user_occ', 30, 100));
    $form->addElement(new XoopsFormText(_XO_LA_INTEREST, 'user_intrest', 30, 100));
    $form->addElement(new XoopsFormText(_XO_LA_LASTLOGMORE, 'user_lastlog_more', 10, 5));
    $form->addElement(new XoopsFormText(_XO_LA_LASTLOGLESS, 'user_lastlog_less', 10, 5));
    $form->addElement(new XoopsFormText(_XO_LA_REGMORE, 'user_reg_more', 10, 5));
    $form->addElement(new XoopsFormText(_XO_LA_REGLESS, 'user_reg_less', 10, 5));
    $form->addElement(new XoopsFormText(_XO_LA_POSTSMORE, 'user_posts_more', 10, 5));
    $form->addElement(new XoopsFormText(_XO_LA_POSTSLESS, 'user_posts_less', 10, 5));

    $sort_select = new XoopsFormSelect(_XO_LA_SORT, 'user_sort');
    $sort_select->addOptionArray(array(
                                     'uname'        => _XO_LA_UNAME,
                                     'email'        => _XO_LA_EMAIL,
                                     'last_login'   => _XO_LA_LASTLOGIN,
                                     'user_regdate' => _XO_LA_REGDATE,
                                     'posts'        => _XO_LA_POSTS
                                 ));
    $form->addElement($sort_select);

    $order_select = new XoopsFormSelect(_XO_LA_ORDER, 'user_order');
    $order_select->addOptionArray(array('ASC' => _XO_LA_ASC, 'DESC' => _XO_LA_DESC));
    $form->addElement($order_select);

    $form->addElement(new XoopsFormText(_XO_LA_LIMIT, 'limit', 6, 2));
    $form->addElement(new XoopsFormHidden('op', 'submit'));
    $form->addElement(new XoopsFormButton('', 'user_submit', _SUBMIT, 'submit'));
    $form->assign($xoopsTpl);
    $xoopsTpl->assign('totalmember', $total);
}

if ($op === 'submit') {
    $GLOBALS['xoopsOption']['template_main'] = 'xoopsmembers_searchresults.html';
    include XOOPS_ROOT_PATH . '/header.php';

    $iamadmin = $xoopsUserIsAdmin;
    $myts     = MyTextSanitizer::getInstance();
    $criteria = new CriteriaCompo();

    if (!empty($_POST['user_uname'])) {

        $match = (!empty($_POST['user_uname_match'])) ? (int)$_POST['user_uname_match'] : XOOPS_MATCH_START;
        $ret   = $myts->addSlashes(trim($_POST['user_uname']));
        xoops_Criteria($criteria, 'uname', $ret, $match);
    }

    if (!empty($_POST['user_name'])) {

        $match = (!empty($_POST['user_name_match'])) ? (int)$_POST['user_name_match'] : XOOPS_MATCH_START;
        $ret   = $myts->addSlashes(trim($_POST['user_uname']));
        xoops_Criteria($criteria, 'name', $ret, $match);
    }

    if (!empty($_POST['user_email'])) {
        $match = (!empty($_POST['user_email_match'])) ? (int)$_POST['user_email_match'] : XOOPS_MATCH_START;
        $ret   = $myts->addSlashes(trim($_POST['user_email']));
        xoops_Criteria($criteria, 'name', $ret, $match);
        if (!$iamadmin) {
            $criteria->add(new Criteria('user_viewemail', 1));
        }
    }

    if (!empty($_POST['user_url'])) {

        $url = formatURL(trim($_POST['user_url']));
        $criteria->add(new Criteria('url', $myts->addSlashes($url) . '%', 'LIKE'));
    }

    if (!empty($_POST['user_icq'])) {

        $match = (!empty($_POST['user_icq_match'])) ? (int)$_POST['user_icq_match'] : XOOPS_MATCH_START;
        $ret   = $myts->addSlashes(trim($_POST['user_icq']));
        xoops_Criteria($criteria, 'user_icq', $ret, $match);
    }

    if (!empty($_POST['user_aim'])) {

        $match = (!empty($_POST['user_aim_match'])) ? (int)$_POST['user_aim_match'] : XOOPS_MATCH_START;
        $ret   = $myts->addSlashes(trim($_POST['user_aim']));
        xoops_Criteria($criteria, 'user_aim', $ret, $match);
    }

    if (!empty($_POST['user_yim'])) {

        $match = (!empty($_POST['user_yim_match'])) ? (int)$_POST['user_yim_match'] : XOOPS_MATCH_START;
        $ret   = $myts->addSlashes(trim($_POST['user_yim']));
        xoops_Criteria($criteria, 'user_yim', $ret, $match);
    }

    if (!empty($_POST['user_msnm'])) {

        $match = (!empty($_POST['user_msnm_match'])) ? (int)$_POST['user_msnm_match'] : XOOPS_MATCH_START;
        $ret   = $myts->addSlashes(trim($_POST['user_msnm']));
        xoops_Criteria($criteria, 'user_msnm', $ret, $match);
    }

    if (!empty($_POST['user_from'])) {

        $criteria->add(new Criteria('user_from', '%' . $myts->addSlashes(trim($_POST['user_from'])) . '%', 'LIKE'));
    }

    if (!empty($_POST['user_intrest'])) {

        $criteria->add(new Criteria('user_intrest', '%' . $myts->addSlashes(trim($_POST['user_intrest'])) . '%', 'LIKE'));
    }

    if (!empty($_POST['user_occ'])) {

        $criteria->add(new Criteria('user_occ', '%' . $myts->addSlashes(trim($_POST['user_occ'])) . '%', 'LIKE'));
    }

    if (!empty($_POST['user_lastlog_more']) && is_numeric($_POST['user_lastlog_more'])) {

        $f_user_lastlog_more = (int)trim($_POST['user_lastlog_more']);
        $time                = time() - (60 * 60 * 24 * $f_user_lastlog_more);
        if ($time > 0) {
            $criteria->add(new Criteria('last_login', $time, '<'));
        }
    }

    if (!empty($_POST['user_lastlog_less']) && is_numeric($_POST['user_lastlog_less'])) {

        $f_user_lastlog_less = (int)trim($_POST['user_lastlog_less']);
        $time                = time() - (60 * 60 * 24 * $f_user_lastlog_less);
        if ($time > 0) {
            $criteria->add(new Criteria('last_login', $time, '>'));
        }
    }

    if (!empty($_POST['user_reg_more']) && is_numeric($_POST['user_reg_more'])) {

        $f_user_reg_more = (int)trim($_POST['user_reg_more']);
        $time            = time() - (60 * 60 * 24 * $f_user_reg_more);
        if ($time > 0) {
            $criteria->add(new Criteria('user_regdate', $time, '<'));
        }
    }

    if (!empty($_POST['user_reg_less']) && is_numeric($_POST['user_reg_less'])) {

        $f_user_reg_less = (int)$_POST['user_reg_less'];
        $time            = time() - (60 * 60 * 24 * $f_user_reg_less);
        if ($time > 0) {
            $criteria->add(new Criteria('user_regdate', $time, '>'));
        }
    }

    if (isset($_POST['user_posts_more']) && is_numeric($_POST['user_posts_more'])) {

        $criteria->add(new Criteria('posts', (int)$_POST['user_posts_more'], '>'));
    }

    if (!empty($_POST['user_posts_less']) && is_numeric($_POST['user_posts_less'])) {

        $criteria->add(new Criteria('posts', (int)$_POST['user_posts_less'], '<'));
    }

    $criteria->add(new Criteria('level', 0, '>'));
    $validsort = array('uname', 'email', 'last_login', 'user_regdate', 'posts');
    $sort      = (!in_array($_POST['user_sort'], $validsort)) ? 'uname' : $_POST['user_sort'];
    $order     = 'ASC';
    if (isset($_POST['user_order']) && $_POST['user_order'] === 'DESC') {
        $order = 'DESC';
    }
    $limit = (!empty($_POST['limit'])) ? (int)$_POST['limit'] : 20;
    if ($limit == 0 || $limit > 50) {
        $limit = 50;
    }

    $start         = (!empty($_POST['start'])) ? (int)$_POST['start'] : 0;
    $memberHandler = xoops_getHandler('member');
    $total         = $memberHandler->getUserCount($criteria);
    $xoopsTpl->assign('total_found', $total);

    if ($total == 0) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
    } elseif ($start < $total) {
        if ($iamadmin) {
            $xoopsTpl->assign('is_admin', true);
        }
        $criteria->setSort($sort);
        $criteria->setOrder($order);
        $criteria->setStart($start);
        $criteria->setLimit($limit);
        $foundusers = $memberHandler->getUsers($criteria, true);
        foreach (array_keys($foundusers) as $j) {
            $userdata['avatar']   = $foundusers[$j]->getVar('user_avatar') ? '<img src="' . XOOPS_UPLOAD_URL . '/' . $foundusers[$j]->getVar('user_avatar') . '" alt="">' : '&nbsp;';
            $userdata['realname'] = $foundusers[$j]->getVar('name') ?: '&nbsp;';
            $userdata['name']     = $foundusers[$j]->getVar('uname');
            $userdata['id']       = $foundusers[$j]->getVar('uid');
            if ($foundusers[$j]->getVar('user_viewemail') == 1 || $iamadmin) {
                $userdata['email'] = '<a href="mailto:' . $foundusers[$j]->getVar('email') . '"><img src="' . XOOPS_URL . '/images/icons/email.gif" border="0" alt="' . sprintf(_SENDEMAILTO, $foundusers[$j]->getVar('uname', 'e')) . '"></a>';
            } else {
                $userdata['email'] = '&nbsp;';
            }
            if ($xoopsUser) {
                $userdata['pmlink'] = '<a href="javascript:openWithSelfMain(\''
                                      . XOOPS_URL
                                      . '/pmlite.php?send2=1&amp;to_userid='
                                      . $foundusers[$j]->getVar('uid')
                                      . '\',\'pmlite\',450,370);"><img src="'
                                      . XOOPS_URL
                                      . '/images/icons/pm.gif" border="0" alt="'
                                      . sprintf(_SENDPMTO, $foundusers[$j]->getVar('uname', 'e'))
                                      . '"></a>';
            } else {
                $userdata['pmlink'] = '&nbsp;';
            }
            if ($foundusers[$j]->getVar('url', 'e') != '') {
                $userdata['website'] = '<a href="' . $foundusers[$j]->getVar('url', 'e') . '" target="_blank"><img src="' . XOOPS_URL . '/images/icons/www.gif" border="0" alt="' . _VISITWEBSITE . '"></a>';
            } else {
                $userdata['website'] = '&nbsp;';
            }
            $userdata['registerdate'] = formatTimestamp($foundusers[$j]->getVar('user_regdate'), 's');
            if ($foundusers[$j]->getVar('last_login') != 0) {
                $userdata['lastlogin'] = formatTimestamp($foundusers[$j]->getVar('last_login'), 'm');
            } else {
                $userdata['lastlogin'] = '&nbsp;';
            }
            $userdata['posts'] = $foundusers[$j]->getVar('posts');
            if ($iamadmin) {
                $userdata['adminlink'] = '<a href="' . XOOPS_URL . '/modules/system/admin.php?fct=users&amp;uid=' . $foundusers[$j]->getVar('uid') . '&amp;op=users_edit">' . '<img src=' . $pathIcon16 . '/edit.png' . " alt='" . _EDIT . "' title='" . _EDIT . "'>"

                                         . '</a> | <a href="' . XOOPS_URL . '/modules/system/admin.php?fct=users&amp;op=users_delete&amp;uid=' . $foundusers[$j]->getVar('uid') . '">' . '<img src=' . $pathIcon16 . '/delete.png' . " alt='" . _DELETE . "' title='" . _DELETE . "'>" . '</a>';
            }
            $xoopsTpl->append('users', $userdata);
        }

        $totalpages = ceil($total / $limit);
        if ($totalpages > 1) {
            $hiddenform = '<form name="findnext" action="index.php" method="post">';
            foreach ($_POST as $k => $v) {
                $hiddenform .= '<input type="hidden" name="' . $myts->htmlSpecialChars($k) . '" value="' . $myts->previewTarea($v) . '">';
            }
            if (!isset($_POST['limit'])) {
                $hiddenform .= '<input type="hidden" name="limit" value="' . $limit . '">';
            }
            if (!isset($_POST['start'])) {
                $hiddenform .= '<input type="hidden" name="start" value="' . $start . '">';
            }
            $prev = $start - $limit;
            if ($start - $limit >= 0) {
                $hiddenform .= '<a href="#0" onclick="javascript:document.findnext.start.value=' . $prev . ';document.findnext.submit();">' . _XO_LA_PREVIOUS . '</a>&nbsp;';
            }
            $counter     = 1;
            $currentpage = ($start + $limit) / $limit;
            while ($counter <= $totalpages) {
                if ($counter == $currentpage) {
                    $hiddenform .= '<b>' . $counter . '</b> ';
                } elseif (($counter > $currentpage - 4 && $counter < $currentpage + 4) || $counter == 1
                          || $counter == $totalpages) {
                    if ($counter == $totalpages && $currentpage < $totalpages - 4) {
                        $hiddenform .= '... ';
                    }
                    $hiddenform .= '<a href="#' . $counter . '" onclick="javascript:document.findnext.start.value=' . ($counter - 1) * $limit . ';document.findnext.submit();">' . $counter . '</a> ';
                    if ($counter == 1 && $currentpage > 5) {
                        $hiddenform .= '... ';
                    }
                }
                $counter++;
            }
            $next = $start + $limit;
            if ($total > $next) {
                $hiddenform .= '&nbsp;<a href="#' . $total . '" onclick="javascript:document.findnext.start.value=' . $next . ';document.findnext.submit();">' . _XO_LA_NEXT . '</a>';
            }
            $hiddenform .= '</form>';
            $xoopsTpl->assign('pagenav', $hiddenform);
            $xoopsTpl->assign('lang_numfound', sprintf(_XO_LA_USERSFOUND, $total));
        }
    }
}

require_once XOOPS_ROOT_PATH . '/footer.php';
exit();

/**
 * xoops_Criteria()
 *
 * @param        $criteria
 * @param string $name
 * @param string $ret
 * @param string $match
 */
function xoops_Criteria(&$criteria, $name = '', $ret = '', $match = '')
{
    global $criteria;
function myFunction($a, $b) {
    // Do something
}

    switch ($match) {
        case XOOPS_MATCH_START:
            $criteria->add(new Criteria($name, $ret . '%', 'LIKE'));
            break;
        case XOOPS_MATCH_END:
            $criteria->add(new Criteria($name, '%' . $ret . '%', 'LIKE'));
            break;
        case XOOPS_MATCH_EQUAL:
            $criteria->add(new Criteria($name, $ret));
            break;
        case XOOPS_MATCH_CONTAIN:
            $criteria->add(new Criteria($name, '%' . $ret . '%', 'LIKE'));
            break;
    }
}


Push — master ( ff4558...64abdf )

index.php (21 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-29 03:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 355 and the first side effect is on line 19. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* Xoops Members Module
4			*
5			* You may not change or alter any portion of this comment or credits
6			* of supporting developers from this source code or any supporting source code
7			* which is considered copyrighted (c) material of the original comment or credit authors.
8			* This program is distributed in the hope that it will be useful,
9			* but WITHOUT ANY WARRANTY; without even the implied warranty of
10			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11			*
12			* @copyright XOOPS Project (https://xoops.org)
13			* @license http://www.fsf.org/copyleft/gpl.html GNU public license
14			* @package Xoops Members
15			* @since 2.3.0
16			* @author onokazu
17			* @author John Neill
18			*/
19			include dirname(dirname(__DIR__)) . DIRECTORY_SEPARATOR . 'mainfile.php';
20			//require_once __DIR__ . '/header.php';
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 11:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
21			//global $pathIcon16;
22
23			global $xoopsModule;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 08:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
24			$pathIcon16 = \Xmf\Module\Admin::iconUrl('', 16);
25
26			$op = (isset($_POST['op']) && $_POST['op'] === 'submit') ? 'submit' : 'form';
27
28			if ($op === 'form') {
29			$GLOBALS['xoopsOption']['template_main'] = 'xoopsmembers_searchform.html';
30			include XOOPS_ROOT_PATH . '/header.php';
31
32			$memberHandler = xoops_getHandler('member');
33			$total = $memberHandler->getUserCount(new Criteria('level', 0, '>'));
34
35			require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
36
37			$form = new XoopsThemeForm('', 'searchform', 'index.php');

mambax7 / xoopsmembers

Push — master ( ff4558...64abdf )

index.php (21 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like