Issues in menu.php - New Issues - Inspection of "Help & Language files update" - mambax7/xoopsmembers - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ff4558...64abdf )

by Michael

created 2017-08-04 11:11 UTC

admin/menu.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Name: menu.php
 * Description: Menu for the Xoops Members Module
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright ::  XOOPS Project (https://xoops.org)
 * @license   ::    {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @package   ::    xoopsmembers
 * @subpackage:: Xoops Members Adminisration
 * @since     ::      1.02
 * @author    ::     John Neill
 */

$moduleDirName = basename(dirname(__DIR__));

if (false !== ($moduleHelper = Xmf\Module\Helper::getHelper($moduleDirName))) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
} else {
    $moduleHelper = Xmf\Module\Helper::getHelper('system');
}
$adminObject = \Xmf\Module\Admin::getInstance();

$pathIcon32 = \Xmf\Module\Admin::menuIconPath('');
//$pathModIcon32 = $moduleHelper->getModule()->getInfo('modicons32');


$moduleHelper->loadLanguage('modinfo');

$adminObject            = array();
$i                      = 1;
$adminmenu[$i]['title'] = _AM_MODULEADMIN_HOME;
$adminmenu[$i]['link']  = 'admin/index.php';
$adminmenu[$i]['icon']  = $pathIcon32 . '/home.png';

$i++;
$adminmenu[$i]['title'] = _AM_MODULEADMIN_ABOUT;
$adminmenu[$i]['link']  = 'admin/about.php';
$adminmenu[$i]['icon']  = $pathIcon32 . '/about.png';


1			<?php
2			/**
3			* Name: menu.php
4			* Description: Menu for the Xoops Members Module
5			*
6			* You may not change or alter any portion of this comment or credits
7			* of supporting developers from this source code or any supporting source code
8			* which is considered copyrighted (c) material of the original comment or credit authors.
9			* This program is distributed in the hope that it will be useful,
10			* but WITHOUT ANY WARRANTY; without even the implied warranty of
11			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
12			*
13			* @copyright :: XOOPS Project (https://xoops.org)
14			* @license :: {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
15			* @package :: xoopsmembers
16			* @subpackage:: Xoops Members Adminisration
17			* @since :: 1.02
18			* @author :: John Neill
19			*/
20
21			$moduleDirName = basename(dirname(__DIR__));
22
23			if (false !== ($moduleHelper = Xmf\Module\Helper::getHelper($moduleDirName))) {
			0 ignored issues – show Unused Code introduced 2017-08-04 11:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
24			} else {
25			$moduleHelper = Xmf\Module\Helper::getHelper('system');
26			}
27			$adminObject = \Xmf\Module\Admin::getInstance();
28
29			$pathIcon32 = \Xmf\Module\Admin::menuIconPath('');
30			//$pathModIcon32 = $moduleHelper->getModule()->getInfo('modicons32');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-04 11:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
31
32			$moduleHelper->loadLanguage('modinfo');
33
34			$adminObject = array();
35			$i = 1;
36			$adminmenu[$i]['title'] = _AM_MODULEADMIN_HOME;
37			$adminmenu[$i]['link'] = 'admin/index.php';
38			$adminmenu[$i]['icon'] = $pathIcon32 . '/home.png';
39
40			$i++;
41			$adminmenu[$i]['title'] = _AM_MODULEADMIN_ABOUT;
42			$adminmenu[$i]['link'] = 'admin/about.php';
43			$adminmenu[$i]['icon'] = $pathIcon32 . '/about.png';
44

mambax7 / xoopsmembers

Push — master ( ff4558...64abdf )

admin/menu.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like