XoopsModules\Xoopsfaq\Contents::renderForm()

Complexity

Conditions	7
Paths	13

Size

Total Lines	114
Code Lines	80

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php declare(strict_types=1);

    public function renderForm()

    {

        /** @var Helper $helper */

        $helper = Helper::getHelper($this->dirname);

        /** @var CategoryHandler $categoryHandler */

        $categoryHandler = $helper->getHandler('Category');

        $catCount        = $categoryHandler->getCount();

        if (empty($catCount)) {

            \xoops_error(\_AM_XOOPSFAQ_ERROR_NO_CATS_EXIST, '');

            \xoops_cp_footer();

            exit();

Using exit here is not recommended.

        }


        require_once \dirname(__DIR__, 3) . '/class/xoopsformloader.php';


        if ($this->isNew()) {

            $caption = \_AM_XOOPSFAQ_CREATE_NEW;

        } else {

            $contentsTitle = $this->getVar('contents_title');

            if (\is_scalar($contentsTitle)) {

                $caption = \sprintf(\_AM_XOOPSFAQ_MODIFY_ITEM, $contentsTitle);

            } else {

                $caption = '';

            }

        }


        $form = new \XoopsThemeForm($caption, 'content', $_SERVER['REQUEST_URI'], 'post', true);

        //        $form->addElement(new \XoopsFormHiddenToken());

        $form->addElement(new \XoopsFormHidden('op', 'save'));

        $form->addElement(new \XoopsFormHidden('contents_id', $this->getVar('contents_id', 'e')));

It seems like $this->getVar('contents_id', 'e') can also be of type array and array; however, parameter $value of XoopsFormHidden::__construct() does only seem to accept string, maybe add an additional type check?

        // Active

        $contents_active = new \XoopsFormRadioYN(\_AM_XOOPSFAQ_E_CONTENTS_ACTIVE, 'contents_active', $this->getVar('contents_active', 'e'), ' ' . \_YES, ' ' . \_NO);

It seems like $this->getVar('contents_active', 'e') can also be of type array and array; however, parameter $value of XoopsFormRadioYN::__construct() does only seem to accept string, maybe add an additional type check?

        $contents_active->setDescription(\_AM_XOOPSFAQ_E_CONTENTS_ACTIVE_DESC);

        $form->addElement($contents_active, false);


        // Title

        $contents_title = new \XoopsFormText(\_AM_XOOPSFAQ_E_CONTENTS_TITLE, 'contents_title', 50, 150, $this->getVar('contents_title', 'e'));

It seems like $this->getVar('contents_title', 'e') can also be of type array and array; however, parameter $value of XoopsFormText::__construct() does only seem to accept string, maybe add an additional type check?

        $contents_title->setDescription(\_AM_XOOPSFAQ_E_CONTENTS_TITLE_DESC);

        $form->addElement($contents_title, true);


        // Category

        $catCriteria        = new \CriteriaCompo();

        $catCriteria->order = 'ASC';

        $catCriteria->setSort('category_order');

        $objects      = $categoryHandler->getList($catCriteria);

        $contents_cid = new \XoopsFormSelect(\_AM_XOOPSFAQ_E_CONTENTS_CATEGORY, 'contents_cid', $this->getVar('contents_cid', 'e'), 1, false);

        $contents_cid->setDescription(\_AM_XOOPSFAQ_E_CONTENTS_CATEGORY_DESC);

        $contents_cid->addOptionArray($objects);

        $form->addElement($contents_cid);


        // Weight

        $contents_weight = new \XoopsFormText(\_AM_XOOPSFAQ_E_CONTENTS_WEIGHT, 'contents_weight', 5, 5, $this->getVar('contents_weight', 'e'));

        $contents_weight->setDescription(\_AM_XOOPSFAQ_E_CONTENTS_WEIGHT_DESC);

        $form->addElement($contents_weight, false);


        // Editor

        $editorConfigs = [];

        $options_tray  = new \XoopsFormElementTray(\_AM_XOOPSFAQ_E_CONTENTS_CONTENT, '<br>');

        if (\class_exists('XoopsFormEditor')) {

            // $editorConfigs = array('editor' => $GLOBALS['xoopsConfig']['general_editor'],

            $editorConfigs     = [

                'editor' => $helper->getConfig('use_wysiwyg', 'dhtmltextarea'),

                'rows'   => 25,

                'cols'   => '100%',

                'width'  => '100%',

                'height' => '600px',

                'name'   => 'contents_contents',

                'value'  => $this->getVar('contents_contents', 'e'),

            ];

            $contents_contents = new \XoopsFormEditor('', 'contents_contents', $editorConfigs);

        } else {

            $contents_contents = new \XoopsFormDhtmlTextArea('', 'contents_contents', $this->getVar('contents_contents', 'e'), '100%', '100%');

'100%' of type string is incompatible with the type integer expected by parameter $rows of XoopsFormDhtmlTextArea::__construct().

It seems like $this->getVar('contents_contents', 'e') can also be of type array and array; however, parameter $value of XoopsFormDhtmlTextArea::__construct() does only seem to accept string, maybe add an additional type check?

'100%' of type string is incompatible with the type integer expected by parameter $cols of XoopsFormDhtmlTextArea::__construct().

        }

        $options_tray->addElement($contents_contents);

        $options_tray->setDescription(\_AM_XOOPSFAQ_E_CONTENTS_CONTENT_DESC);


        \xoops_load('XoopsEditorHandler');

        $editorHandler = \XoopsEditorHandler::getInstance();

        $editorList    = $editorHandler->getList(true);

        if (isset($editorConfigs['editor']) && \in_array($editorConfigs['editor'], \array_flip($editorList), true)) {

            $form->addElement(new \XoopsFormHidden('dohtml', (string)Constants::NOTSET));

            $form->addElement(new \XoopsFormHidden('dobr', (string)Constants::SET));

        } else {

            $html_checkbox = new \XoopsFormCheckBox('', 'dohtml', $this->getVar('dohtml', 'e'));

            $html_checkbox->addOption('1', \_AM_XOOPSFAQ_E_DOHTML);

            $options_tray->addElement($html_checkbox);


            $breaks_checkbox = new \XoopsFormCheckBox('', 'dobr', $this->getVar('dobr', 'e'));

            $breaks_checkbox->addOption('1', \_AM_XOOPSFAQ_E_BREAKS);

            $options_tray->addElement($breaks_checkbox);

        }


        $doimage_checkbox = new \XoopsFormCheckBox('', 'doimage', $this->getVar('doimage', 'e'));

        $doimage_checkbox->addOption('1', \_AM_XOOPSFAQ_E_DOIMAGE);

        $options_tray->addElement($doimage_checkbox);


        $xcodes_checkbox = new \XoopsFormCheckBox('', 'doxcode', $this->getVar('doxcode', 'e'));

        $xcodes_checkbox->addOption('1', \_AM_XOOPSFAQ_E_DOXCODE);

        $options_tray->addElement($xcodes_checkbox);


        $smiley_checkbox = new \XoopsFormCheckBox('', 'dosmiley', $this->getVar('dosmiley', 'e'));

        $smiley_checkbox->addOption('1', \_AM_XOOPSFAQ_E_DOSMILEY);

        $options_tray->addElement($smiley_checkbox);


        $form->addElement($options_tray);


        $contents_publish = new \XoopsFormTextDateSelect(\_AM_XOOPSFAQ_E_CONTENTS_PUBLISH, 'contents_publish', 20, (int)$this->getVar('contents_publish'), $this->isNew());

The call to XoopsFormTextDateSelect::__construct() has too many arguments starting with $this->isNew().

        $contents_publish->setDescription(\_AM_XOOPSFAQ_E_CONTENTS_PUBLISH_DESC);

        $form->addElement($contents_publish);


        $form->addElement(new \XoopsFormButtonTray('contents_form', \_SUBMIT, 'submit'));


        return $form->render();

    }