mambax7 /
xoopseditors
| Conditions | 28 |
| Paths | > 20000 |
| Total Lines | 137 |
| Code Lines | 84 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 6 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 76 | public function init() |
||
| 77 | { |
||
| 78 | // list of configured options |
||
| 79 | $configured = []; |
||
| 80 | $this->setting['selector'] = 'textarea'; |
||
| 81 | $this->setting['theme'] = 'modern'; |
||
| 82 | |||
| 83 | // Load default settings |
||
| 84 | if (!($this->setting = @include($GLOBALS['xoops']->path('var/configs/tinymce.php')))) { |
||
| 85 | $this->setting = include __DIR__ . '/settings.php'; |
||
| 86 | } |
||
| 87 | |||
| 88 | // get editor language (from ...) |
||
| 89 | if (is_readable(XOOPS_ROOT_PATH . $this->rootpath . '/langs/' . $this->config['language'] . '.js')) { |
||
| 90 | $this->setting['language'] = $this->config['language']; |
||
| 91 | $configured[] = 'language'; |
||
| 92 | } |
||
| 93 | |||
| 94 | $this->setting['content_css'] = implode(',', $this->loadCss()); |
||
| 95 | $configured[] = 'content_css'; |
||
| 96 | |||
| 97 | if (!empty($this->config['theme']) && is_dir(XOOPS_ROOT_PATH . $this->rootpath . '/themes/' . $this->config['theme'])) { |
||
| 98 | $this->setting['theme'] = $this->config['theme']; |
||
| 99 | $configured[] = 'theme'; |
||
| 100 | } |
||
| 101 | |||
| 102 | if (!empty($this->config['mode'])) { |
||
| 103 | $this->setting['mode'] = $this->config['mode']; |
||
| 104 | $configured[] = 'mode'; |
||
| 105 | } |
||
| 106 | |||
| 107 | // load all plugins except the plugins in setting["exclude_plugins"] |
||
| 108 | $this->setting['plugins'] = implode(',', $this->loadPlugins()); |
||
| 109 | $configured[] = 'plugins'; |
||
| 110 | |||
| 111 | if ('simple' !== $this->setting['theme']) { |
||
| 112 | if (empty($this->config['buttons'])) { |
||
| 113 | $this->config['buttons'][] = [ |
||
| 114 | 'before' => '', |
||
| 115 | 'add' => '', |
||
| 116 | ]; |
||
| 117 | $this->config['buttons'][] = [ |
||
| 118 | 'before' => '', |
||
| 119 | 'add' => '', |
||
| 120 | ]; |
||
| 121 | $this->config['buttons'][] = [ |
||
| 122 | 'before' => '', |
||
| 123 | 'add' => '', |
||
| 124 | ]; |
||
| 125 | } |
||
| 126 | $i = 0; |
||
| 127 | foreach ($this->config['buttons'] as $button) { |
||
| 128 | ++$i; |
||
| 129 | if (isset($button['before'])) { |
||
| 130 | $this->setting['theme_' . $this->setting['theme'] . "_buttons{$i}_add_before"] = $button['before']; |
||
| 131 | } |
||
| 132 | if (isset($button['add'])) { |
||
| 133 | $this->setting['theme_' . $this->setting['theme'] . "_buttons{$i}_add"] = $button['add']; |
||
| 134 | } |
||
| 135 | if (isset($button[''])) { |
||
| 136 | $this->setting['theme_' . $this->setting['theme'] . "_buttons{$i}"] = $button['']; |
||
| 137 | } |
||
| 138 | } |
||
| 139 | $configured[] = 'buttons'; |
||
| 140 | |||
| 141 | if (isset($this->config['toolbar_location'])) { |
||
| 142 | $this->setting['theme_' . $this->setting['theme'] . '_toolbar_location'] = $this->config['toolbar_location']; |
||
| 143 | $configured[] = 'toolbar_location'; |
||
| 144 | } else { |
||
| 145 | $this->setting['theme_' . $this->setting['theme'] . '_toolbar_location'] = 'top'; |
||
| 146 | } |
||
| 147 | |||
| 148 | if (isset($this->config['toolbar_align'])) { |
||
| 149 | $this->setting['theme_' . $this->setting['theme'] . '_toolbar_align'] = $this->config['toolbar_align']; |
||
| 150 | $configured[] = 'toolbar_align'; |
||
| 151 | } else { |
||
| 152 | $this->setting['theme_' . $this->setting['theme'] . '_toolbar_align'] = 'left'; |
||
| 153 | } |
||
| 154 | |||
| 155 | if (isset($this->config['statusbar_location'])) { |
||
| 156 | $this->setting['theme_' . $this->setting['theme'] . '_statusbar_location'] = $this->config['statusbar_location']; |
||
| 157 | $configured[] = 'statusbar_location'; |
||
| 158 | } |
||
| 159 | |||
| 160 | if (isset($this->config['path_location'])) { |
||
| 161 | $this->setting['theme_' . $this->setting['theme'] . '_path_location'] = $this->config['path_location']; |
||
| 162 | $configured[] = 'path_location'; |
||
| 163 | } |
||
| 164 | |||
| 165 | if (isset($this->config['resize_horizontal'])) { |
||
| 166 | $this->setting['theme_' . $this->setting['theme'] . '_resize_horizontal'] = $this->config['resize_horizontal']; |
||
| 167 | $configured[] = 'resize_horizontal'; |
||
| 168 | } |
||
| 169 | |||
| 170 | if (isset($this->config['resizing'])) { |
||
| 171 | $this->setting['theme_' . $this->setting['theme'] . '_resizing'] = $this->config['resizing']; |
||
| 172 | $configured[] = 'resizing'; |
||
| 173 | } |
||
| 174 | |||
| 175 | if (!empty($this->config['fonts'])) { |
||
| 176 | $this->setting['theme_' . $this->setting['theme'] . '_fonts'] = $this->config['fonts']; |
||
| 177 | $configured[] = 'fonts'; |
||
| 178 | } |
||
| 179 | |||
| 180 | for ($i=1 ; $i <= 4 ; ++$i ) { |
||
| 181 | $buttons = []; |
||
| 182 | if (isset($this->setting['theme_' . $this->setting['theme'] . "_buttons{$i}"])) { |
||
| 183 | $checklist = explode(',', $this->setting['theme_' . $this->setting['theme'] . "_buttons{$i}"]); |
||
| 184 | foreach ( $checklist as $plugin ) { |
||
| 185 | if (false != strpos(strtolower($plugin), 'xoops')) { |
||
|
Bug
Best Practice
introduced
by
|
|||
| 186 | if ( in_array( $plugin, $this->xoopsPlugins ) ) { |
||
| 187 | $buttons[] = $plugin; |
||
| 188 | } |
||
| 189 | } else { |
||
| 190 | $buttons[] = $plugin; |
||
| 191 | } |
||
| 192 | } |
||
| 193 | $this->setting['theme_' . $this->setting['theme'] . "_buttons{$i}"] = implode(',', $buttons); |
||
| 194 | } |
||
| 195 | } |
||
| 196 | } |
||
| 197 | |||
| 198 | $configured = array_unique($configured); |
||
| 199 | foreach ($this->config as $key => $val) { |
||
| 200 | if (isset($this->setting[$key]) || in_array($key, $configured)) { |
||
| 201 | continue; |
||
| 202 | } |
||
| 203 | $this->setting[$key] = $val; |
||
| 204 | } |
||
| 205 | |||
| 206 | if (!is_dir(XOOPS_ROOT_PATH . $this->rootpath . '/themes/' . $this->setting['theme'] . '/docs/' . $this->setting['language'] . '/')) { |
||
| 207 | $this->setting['docs_language'] = 'en'; |
||
| 208 | } |
||
| 209 | |||
| 210 | unset($this->config, $configured); |
||
| 211 | |||
| 212 | return true; |
||
| 213 | } |
||
| 380 |
Loading history...