mambax7 /
xoopseditors
| Conditions | 67 |
| Paths | 187 |
| Total Lines | 272 |
| Code Lines | 156 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 484 | function decode($str) |
||
| 485 | { |
||
| 486 | $str = $this->reduce_string($str); |
||
| 487 | |||
| 488 | switch (strtolower($str)) { |
||
| 489 | case 'true': |
||
| 490 | return true; |
||
| 491 | |||
| 492 | case 'false': |
||
| 493 | return false; |
||
| 494 | |||
| 495 | case 'null': |
||
| 496 | return null; |
||
| 497 | |||
| 498 | default: |
||
| 499 | $m = array(); |
||
| 500 | |||
| 501 | if (is_numeric($str)) { |
||
| 502 | // Lookie-loo, it's a number |
||
| 503 | |||
| 504 | // This would work on its own, but I'm trying to be |
||
| 505 | // good about returning integers where appropriate: |
||
| 506 | // return (float)$str; |
||
| 507 | |||
| 508 | // Return float or int, as appropriate |
||
| 509 | return ((float)$str == (integer)$str) |
||
| 510 | ? (integer)$str |
||
| 511 | : (float)$str; |
||
| 512 | |||
| 513 | } elseif (preg_match('/^("|\').*(\1)$/s', $str, $m) && $m[1] == $m[2]) { |
||
| 514 | // STRINGS RETURNED IN UTF-8 FORMAT |
||
| 515 | $delim = substr($str, 0, 1); |
||
| 516 | $chrs = substr($str, 1, -1); |
||
| 517 | $utf8 = ''; |
||
| 518 | $strlen_chrs = strlen($chrs); |
||
| 519 | |||
| 520 | for ($c = 0; $c < $strlen_chrs; ++$c) { |
||
| 521 | |||
| 522 | $substr_chrs_c_2 = substr($chrs, $c, 2); |
||
| 523 | $ord_chrs_c = ord($chrs{$c}); |
||
| 524 | |||
| 525 | switch (true) { |
||
| 526 | case $substr_chrs_c_2 == '\b': |
||
| 527 | $utf8 .= chr(0x08); |
||
| 528 | ++$c; |
||
| 529 | break; |
||
| 530 | case $substr_chrs_c_2 == '\t': |
||
| 531 | $utf8 .= chr(0x09); |
||
| 532 | ++$c; |
||
| 533 | break; |
||
| 534 | case $substr_chrs_c_2 == '\n': |
||
| 535 | $utf8 .= chr(0x0A); |
||
| 536 | ++$c; |
||
| 537 | break; |
||
| 538 | case $substr_chrs_c_2 == '\f': |
||
| 539 | $utf8 .= chr(0x0C); |
||
| 540 | ++$c; |
||
| 541 | break; |
||
| 542 | case $substr_chrs_c_2 == '\r': |
||
| 543 | $utf8 .= chr(0x0D); |
||
| 544 | ++$c; |
||
| 545 | break; |
||
| 546 | |||
| 547 | case $substr_chrs_c_2 == '\\"': |
||
| 548 | case $substr_chrs_c_2 == '\\\'': |
||
| 549 | case $substr_chrs_c_2 == '\\\\': |
||
| 550 | case $substr_chrs_c_2 == '\\/': |
||
| 551 | if (($delim == '"' && $substr_chrs_c_2 != '\\\'') || |
||
| 552 | ($delim == "'" && $substr_chrs_c_2 != '\\"')) { |
||
| 553 | $utf8 .= $chrs{++$c}; |
||
| 554 | } |
||
| 555 | break; |
||
| 556 | |||
| 557 | case preg_match('/\\\u[0-9A-F]{4}/i', substr($chrs, $c, 6)): |
||
| 558 | // single, escaped unicode character |
||
| 559 | $utf16 = chr(hexdec(substr($chrs, ($c + 2), 2))) |
||
| 560 | . chr(hexdec(substr($chrs, ($c + 4), 2))); |
||
| 561 | $utf8 .= $this->utf162utf8($utf16); |
||
| 562 | $c += 5; |
||
| 563 | break; |
||
| 564 | |||
| 565 | case ($ord_chrs_c >= 0x20) && ($ord_chrs_c <= 0x7F): |
||
| 566 | $utf8 .= $chrs{$c}; |
||
| 567 | break; |
||
| 568 | |||
| 569 | case ($ord_chrs_c & 0xE0) == 0xC0: |
||
| 570 | // characters U-00000080 - U-000007FF, mask 110XXXXX |
||
| 571 | //see http://www.cl.cam.ac.uk/~mgk25/unicode.html#utf-8 |
||
| 572 | $utf8 .= substr($chrs, $c, 2); |
||
| 573 | ++$c; |
||
| 574 | break; |
||
| 575 | |||
| 576 | case ($ord_chrs_c & 0xF0) == 0xE0: |
||
| 577 | // characters U-00000800 - U-0000FFFF, mask 1110XXXX |
||
| 578 | // see http://www.cl.cam.ac.uk/~mgk25/unicode.html#utf-8 |
||
| 579 | $utf8 .= substr($chrs, $c, 3); |
||
| 580 | $c += 2; |
||
| 581 | break; |
||
| 582 | |||
| 583 | case ($ord_chrs_c & 0xF8) == 0xF0: |
||
| 584 | // characters U-00010000 - U-001FFFFF, mask 11110XXX |
||
| 585 | // see http://www.cl.cam.ac.uk/~mgk25/unicode.html#utf-8 |
||
| 586 | $utf8 .= substr($chrs, $c, 4); |
||
| 587 | $c += 3; |
||
| 588 | break; |
||
| 589 | |||
| 590 | case ($ord_chrs_c & 0xFC) == 0xF8: |
||
| 591 | // characters U-00200000 - U-03FFFFFF, mask 111110XX |
||
| 592 | // see http://www.cl.cam.ac.uk/~mgk25/unicode.html#utf-8 |
||
| 593 | $utf8 .= substr($chrs, $c, 5); |
||
| 594 | $c += 4; |
||
| 595 | break; |
||
| 596 | |||
| 597 | case ($ord_chrs_c & 0xFE) == 0xFC: |
||
| 598 | // characters U-04000000 - U-7FFFFFFF, mask 1111110X |
||
| 599 | // see http://www.cl.cam.ac.uk/~mgk25/unicode.html#utf-8 |
||
| 600 | $utf8 .= substr($chrs, $c, 6); |
||
| 601 | $c += 5; |
||
| 602 | break; |
||
| 603 | |||
| 604 | } |
||
| 605 | |||
| 606 | } |
||
| 607 | |||
| 608 | return $utf8; |
||
| 609 | |||
| 610 | } elseif (preg_match('/^\[.*\]$/s', $str) || preg_match('/^\{.*\}$/s', $str)) { |
||
| 611 | // array, or object notation |
||
| 612 | |||
| 613 | if ($str{0} == '[') { |
||
| 614 | $stk = array(SERVICES_JSON_IN_ARR); |
||
| 615 | $arr = array(); |
||
| 616 | } else { |
||
| 617 | if ($this->use & SERVICES_JSON_LOOSE_TYPE) { |
||
| 618 | $stk = array(SERVICES_JSON_IN_OBJ); |
||
| 619 | $obj = array(); |
||
| 620 | } else { |
||
| 621 | $stk = array(SERVICES_JSON_IN_OBJ); |
||
| 622 | $obj = new stdClass(); |
||
| 623 | } |
||
| 624 | } |
||
| 625 | |||
| 626 | array_push($stk, array('what' => SERVICES_JSON_SLICE, |
||
| 627 | 'where' => 0, |
||
| 628 | 'delim' => false)); |
||
| 629 | |||
| 630 | $chrs = substr($str, 1, -1); |
||
| 631 | $chrs = $this->reduce_string($chrs); |
||
| 632 | |||
| 633 | if ($chrs == '') { |
||
| 634 | if (reset($stk) == SERVICES_JSON_IN_ARR) { |
||
| 635 | return $arr; |
||
| 636 | |||
| 637 | } else { |
||
| 638 | return $obj; |
||
| 639 | |||
| 640 | } |
||
| 641 | } |
||
| 642 | |||
| 643 | //print("\nparsing {$chrs}\n"); |
||
| 644 | |||
| 645 | $strlen_chrs = strlen($chrs); |
||
| 646 | |||
| 647 | for ($c = 0; $c <= $strlen_chrs; ++$c) { |
||
| 648 | |||
| 649 | $top = end($stk); |
||
| 650 | $substr_chrs_c_2 = substr($chrs, $c, 2); |
||
| 651 | |||
| 652 | if (($c == $strlen_chrs) || (($chrs{$c} == ',') && ($top['what'] == SERVICES_JSON_SLICE))) { |
||
| 653 | // found a comma that is not inside a string, array, etc., |
||
| 654 | // OR we've reached the end of the character list |
||
| 655 | $slice = substr($chrs, $top['where'], ($c - $top['where'])); |
||
| 656 | array_push($stk, array('what' => SERVICES_JSON_SLICE, 'where' => ($c + 1), 'delim' => false)); |
||
| 657 | //print("Found split at {$c}: ".substr($chrs, $top['where'], (1 + $c - $top['where']))."\n"); |
||
| 658 | |||
| 659 | if (reset($stk) == SERVICES_JSON_IN_ARR) { |
||
| 660 | // we are in an array, so just push an element onto the stack |
||
| 661 | array_push($arr, $this->decode($slice)); |
||
| 662 | |||
| 663 | } elseif (reset($stk) == SERVICES_JSON_IN_OBJ) { |
||
| 664 | // we are in an object, so figure |
||
| 665 | // out the property name and set an |
||
| 666 | // element in an associative array, |
||
| 667 | // for now |
||
| 668 | $parts = array(); |
||
| 669 | |||
| 670 | if (preg_match('/^\s*(["\'].*[^\\\]["\'])\s*:\s*(\S.*),?$/Uis', $slice, $parts)) { |
||
| 671 | // "name":value pair |
||
| 672 | $key = $this->decode($parts[1]); |
||
| 673 | $val = $this->decode($parts[2]); |
||
| 674 | |||
| 675 | if ($this->use & SERVICES_JSON_LOOSE_TYPE) { |
||
| 676 | $obj[$key] = $val; |
||
| 677 | } else { |
||
| 678 | $obj->$key = $val; |
||
| 679 | } |
||
| 680 | } elseif (preg_match('/^\s*(\w+)\s*:\s*(\S.*),?$/Uis', $slice, $parts)) { |
||
| 681 | // name:value pair, where name is unquoted |
||
| 682 | $key = $parts[1]; |
||
| 683 | $val = $this->decode($parts[2]); |
||
| 684 | |||
| 685 | if ($this->use & SERVICES_JSON_LOOSE_TYPE) { |
||
| 686 | $obj[$key] = $val; |
||
| 687 | } else { |
||
| 688 | $obj->$key = $val; |
||
| 689 | } |
||
| 690 | } |
||
| 691 | |||
| 692 | } |
||
| 693 | |||
| 694 | } elseif ((($chrs{$c} == '"') || ($chrs{$c} == "'")) && ($top['what'] != SERVICES_JSON_IN_STR)) { |
||
| 695 | // found a quote, and we are not inside a string |
||
| 696 | array_push($stk, array('what' => SERVICES_JSON_IN_STR, 'where' => $c, 'delim' => $chrs{$c})); |
||
| 697 | //print("Found start of string at {$c}\n"); |
||
| 698 | |||
| 699 | } elseif (($chrs{$c} == $top['delim']) && |
||
| 700 | ($top['what'] == SERVICES_JSON_IN_STR) && |
||
| 701 | ((strlen(substr($chrs, 0, $c)) - strlen(rtrim(substr($chrs, 0, $c), '\\'))) % 2 != 1)) { |
||
| 702 | // found a quote, we're in a string, and it's not escaped |
||
| 703 | // we know that it's not escaped becase there is _not_ an |
||
| 704 | // odd number of backslashes at the end of the string so far |
||
| 705 | array_pop($stk); |
||
| 706 | //print("Found end of string at {$c}: ".substr($chrs, $top['where'], (1 + 1 + $c - $top['where']))."\n"); |
||
| 707 | |||
| 708 | } elseif (($chrs{$c} == '[') && |
||
| 709 | in_array($top['what'], array(SERVICES_JSON_SLICE, SERVICES_JSON_IN_ARR, SERVICES_JSON_IN_OBJ))) { |
||
| 710 | // found a left-bracket, and we are in an array, object, or slice |
||
| 711 | array_push($stk, array('what' => SERVICES_JSON_IN_ARR, 'where' => $c, 'delim' => false)); |
||
| 712 | //print("Found start of array at {$c}\n"); |
||
| 713 | |||
| 714 | } elseif (($chrs{$c} == ']') && ($top['what'] == SERVICES_JSON_IN_ARR)) { |
||
| 715 | // found a right-bracket, and we're in an array |
||
| 716 | array_pop($stk); |
||
| 717 | //print("Found end of array at {$c}: ".substr($chrs, $top['where'], (1 + $c - $top['where']))."\n"); |
||
| 718 | |||
| 719 | } elseif (($chrs{$c} == '{') && |
||
| 720 | in_array($top['what'], array(SERVICES_JSON_SLICE, SERVICES_JSON_IN_ARR, SERVICES_JSON_IN_OBJ))) { |
||
| 721 | // found a left-brace, and we are in an array, object, or slice |
||
| 722 | array_push($stk, array('what' => SERVICES_JSON_IN_OBJ, 'where' => $c, 'delim' => false)); |
||
| 723 | //print("Found start of object at {$c}\n"); |
||
| 724 | |||
| 725 | } elseif (($chrs{$c} == '}') && ($top['what'] == SERVICES_JSON_IN_OBJ)) { |
||
| 726 | // found a right-brace, and we're in an object |
||
| 727 | array_pop($stk); |
||
| 728 | //print("Found end of object at {$c}: ".substr($chrs, $top['where'], (1 + $c - $top['where']))."\n"); |
||
| 729 | |||
| 730 | } elseif (($substr_chrs_c_2 == '/*') && |
||
| 731 | in_array($top['what'], array(SERVICES_JSON_SLICE, SERVICES_JSON_IN_ARR, SERVICES_JSON_IN_OBJ))) { |
||
| 732 | // found a comment start, and we are in an array, object, or slice |
||
| 733 | array_push($stk, array('what' => SERVICES_JSON_IN_CMT, 'where' => $c, 'delim' => false)); |
||
| 734 | $c++; |
||
| 735 | //print("Found start of comment at {$c}\n"); |
||
| 736 | |||
| 737 | } elseif (($substr_chrs_c_2 == '*/') && ($top['what'] == SERVICES_JSON_IN_CMT)) { |
||
| 738 | // found a comment end, and we're in one now |
||
| 739 | array_pop($stk); |
||
| 740 | $c++; |
||
| 741 | |||
| 742 | for ($i = $top['where']; $i <= $c; ++$i) |
||
| 743 | $chrs = substr_replace($chrs, ' ', $i, 1); |
||
| 744 | |||
| 745 | //print("Found end of comment at {$c}: ".substr($chrs, $top['where'], (1 + $c - $top['where']))."\n"); |
||
| 746 | |||
| 747 | } |
||
| 748 | |||
| 749 | } |
||
| 750 | |||
| 751 | if (reset($stk) == SERVICES_JSON_IN_ARR) { |
||
| 752 | return $arr; |
||
| 753 | |||
| 754 | } elseif (reset($stk) == SERVICES_JSON_IN_OBJ) { |
||
| 755 | return $obj; |
||
| 756 | |||
| 806 | ?> |
||
Loading history...
Adding explicit visibility (
private,protected, orpublic) is generally recommend to communicate to other developers how, and from where this method is intended to be used.