JUpload::receive_uploaded_files()

Complexity

Conditions	51
Paths	> 20000

Size

Total Lines	191
Code Lines	130

Duplication

Lines	0
Ratio	0 %

Importance

Changes	5
Bugs	0	Features	0

<?php
    private function receive_uploaded_files()
    {
        $this->logDebug('receive_uploaded_files', 'Entering POST management');

        if ('' == session_id()) {
            session_start();
        }
        // we check for the session *after* handling possible error log
        // because an error could have happened because the session-id is missing.
        if (!isset($_SESSION[$this->classparams['var_prefix'] . 'size'])) {
            $this->abort('Invalid session (in afterupload, POST, check of size)');
        }
        if (!isset($_SESSION[$this->classparams['var_prefix'] . 'files'])) {
            $this->abort('Invalid session (in afterupload, POST, check of files)');
        }
        $this->files = $_SESSION[$this->classparams['var_prefix'] . 'files'];
        if (!is_array($this->files)) {
            $this->abort('Invalid session (in afterupload, POST, is_array(files))');
        }
        if ('true' === $this->appletparams['sendMD5Sum'] && !isset($_POST['md5sum'])) {
            $this->abort('Required POST variable md5sum is missing');
        }
        $cnt = 0;
        foreach ($_FILES as $key => $value) {
            //Let's read the $_FILES data
            if (isset($files_data)) {
                unset($files_data);
            }
            $jupart    = (isset($_POST['jupart'])) ? (int)$_POST['jupart'] : 0;
            $jufinal   = (isset($_POST['jufinal'])) ? (int)$_POST['jufinal'] : 1;
            $relpaths  = (isset($_POST['relpathinfo'])) ? $_POST['relpathinfo'] : null;
            $md5sums   = (isset($_POST['md5sum'])) ? $_POST['md5sum'] : null;
            $mimetypes = (isset($_POST['mimetype'])) ? $_POST['mimetype'] : null;
            //$relpaths = (isset($_POST["relpathinfo$cnt"])) ? $_POST["relpathinfo$cnt"] : null;
            //$md5sums = (isset($_POST["md5sum$cnt"])) ? $_POST["md5sum$cnt"] : null;

            if ('string' === gettype($relpaths)) {
                $relpaths = [$relpaths];
            }
            if ('string' === gettype($md5sums)) {
                $md5sums = [$md5sums];
            }
            if ('true' === $this->appletparams['sendMD5Sum'] && !is_array($md5sums)) {
                $this->abort('Expecting an array of MD5 checksums');
            }
            if (!is_array($relpaths)) {
                $this->abort('Expecting an array of relative paths');
            }
            if (!is_array($mimetypes)) {
                $this->abort('Expecting an array of MIME types');
            }
            // Check the MIME type (note: this is easily forged!)
            if (isset($this->classparams['allowed_mime_types']) && is_array($this->classparams['allowed_mime_types'])) {
                if (!in_array($mimetypes[$cnt], $this->classparams['allowed_mime_types'])) {
                    $this->abort('MIME type ' . $mimetypes[$cnt] . ' not allowed');
                }
            }
            if (isset($this->classparams['allowed_file_extensions']) && is_array($this->classparams['allowed_file_extensions'])) {
                $fileExtension = substr(strrchr($value['name'][$cnt], '.'), 1);
                if (!in_array($fileExtension, $this->classparams['allowed_file_extensions'])) {
                    $this->abort('File extension ' . $fileExtension . ' not allowed');
                }
            }

            $dstdir  = $this->classparams['destdir'];
            $dstname = $dstdir . '/' . $this->classparams['tmp_prefix'] . session_id();
            $tmpname = $dstdir . '/' . $this->classparams['tmp_prefix'] . 'tmp' . session_id();

            // Controls are now done. Let's store the current uploaded files properties in an array, for future use.
            $files_data['name']         = $value['name'][$cnt];
            $files_data['size']         = 'not calculated yet';
            $files_data['tmp_name']     = $value['tmp_name'][$cnt];
            $files_data['error']        = $value['error'][$cnt];
            $files_data['relativePath'] = $relpaths[$cnt];
            $files_data['md5sum']       = $md5sums[$cnt];
            $files_data['mimetype']     = $mimetypes[$cnt];

            if (!move_uploaded_file($files_data['tmp_name'], $tmpname)) {

The variable $files_data seems to be defined later in this foreach loop on line 689. Are you sure it is defined here?

                if ($classparams['verbose_errors']) {

The variable $classparams seems to be never defined.

                    $this->abort("Unable to move uploaded file (from ${files_data['tmp_name']} to $tmpname)");
                } else {
                    trigger_error("Unable to move uploaded file (from ${files_data['tmp_name']} to $tmpname)", E_USER_WARNING);
                    $this->abort('Unable to move uploaded file');
                }
            }

            // In demo mode, no file storing is done. We just delete the newly uploaded file.
            if ($this->classparams['demo_mode']) {
                if ($jufinal || (!$jupart)) {
                    if ($jupart) {
                        $files_data['size'] = ($jupart - 1) * $this->appletparams['maxChunkSize'] + filesize($tmpname);
                    } else {
                        $files_data['size'] = filesize($tmpname);
                    }
                    $files_data['fullName'] = 'Demo mode<BR>No file storing';
                    array_push($this->files, $files_data);
                }
                unlink($tmpname);
                ++$cnt;
                continue;
            }
            //If we get here, the upload is a real one (no demo)
            if ($jupart) {
                // got a chunk of a multi-part upload
                $len                                                 = filesize($tmpname);
                $_SESSION[$this->classparams['var_prefix'] . 'size'] += $len;
                if ($len > 0) {
                    $src = fopen($tmpname, 'rb');
                    $dst = fopen($dstname, (1 == $jupart) ? 'wb' : 'ab');
                    while ($len > 0) {
                        $rlen = ($len > 8192) ? 8192 : $len;
                        $buf  = fread($src, $rlen);

It seems like $src can also be of type false; however, parameter $handle of fread() does only seem to accept resource, maybe add an additional type check?

                        if (!$buf) {
                            fclose($src);

It seems like $src can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

                            fclose($dst);
                            unlink($dstname);
                            $this->abort('read IO error');
                        }
                        if (!fwrite($dst, $buf, $rlen)) {

It seems like $dst can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

                            fclose($src);
                            fclose($dst);
                            unlink($dstname);
                            $this->abort('write IO error');
                        }
                        $len -= $rlen;
                    }
                    fclose($src);
                    fclose($dst);
                    unlink($tmpname);
                }
                if ($jufinal) {
                    // This is the last chunk. Check total lenght and
                    // rename it to it's final name.
                    $dlen = filesize($dstname);
                    if ($dlen != $_SESSION[$this->classparams['var_prefix'] . 'size']) {
                        $this->abort('file size mismatch');
                    }
                    if ('true' === $this->appletparams['sendMD5Sum']) {
                        if ($md5sums[$cnt] != md5_file($dstname)) {
                            $this->abort('MD5 checksum mismatch');
                        }
                    }
                    // remove zero sized files
                    if (($dlen > 0) || $this->classparams['allow_zerosized']) {
                        $dstfinal = $this->dstfinal($files_data['name'], $files_data['relativePath']);
                        if (!rename($dstname, $dstfinal)) {
                            $this->abort('rename IO error');
                        }
                        $_umask = umask(0);    // override the system mask
                        if (!chmod($dstfinal, $this->classparams['fileperm'])) {
                            $this->abort('chmod IO error');
                        }
                        umask($_umask);
                        $files_data['size']     = filesize($dstfinal);
                        $files_data['fullName'] = $dstfinal;
                        $files_data['path']     = fix_dirname($dstfinal);
                        array_push($this->files, $files_data);
                    } else {
                        unlink($dstname);
                    }
                    // reset session var
                    $_SESSION[$this->classparams['var_prefix'] . 'size'] = 0;
                }
            } else {
                // Got a single file upload. Trivial.
                if ('true' === $this->appletparams['sendMD5Sum']) {
                    if ($md5sums[$cnt] != md5_file($tmpname)) {
                        $this->abort('MD5 checksum mismatch');
                    }
                }
                $dstfinal = $this->dstfinal($files_data['name'], $files_data['relativePath']);
                if (!rename($tmpname, $dstfinal)) {
                    $this->abort('rename IO error');
                }
                $_umask = umask(0);    // override the system mask
                if (!chmod($dstfinal, $this->classparams['fileperm'])) {
                    $this->abort('chmod IO error');
                }
                umask($_umask);
                $files_data['size']     = filesize($dstfinal);
                $files_data['fullName'] = $dstfinal;
                $files_data['path']     = fix_dirname($dstfinal);
                array_push($this->files, $files_data);
            }
            ++$cnt;
        }

        echo $this->appletparams['stringUploadSuccess'] . "\n";
        $_SESSION[$this->classparams['var_prefix'] . 'files'] = $this->files;
        session_write_close();
        exit;

Using exit here is not recommended.

    }