Issues in unzip.php (master) - Issues in master - mambax7/xoops-martin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (663)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

zip/unzip.php (4 issues)

Labels

Severity

Informational 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

//验证密码
$password = "pwd";

?>
<html>
<head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
    <title>在线ZIP解压程序</title>
    <style type="text/css">
        <!--
        body, td {
            font-size: 14px;
            color: #000000;
        }

        a {
            color: #000066;
            text-decoration: none;
        }

        a:hover {
            color: #FF6600;
            text-decoration: underline;
        }

        -->
    </style>
</head>

<body>
<form name="myform" method="post" action="<?= $_SERVER[PHP_SELF]; ?>" enctype="multipart/form-data" onSubmit="return check_uploadObject(this);">
    <?
    if (!$_REQUEST["myaction"]):
        ?>

        <script language="javascript">
            function check_uploadObject(form) {
                if (form.password.value == '') {
                    alert('请输入密码.');
                    return false;
                }
                return true;
            }
        </script>

        <table width="100%" border="0" cellspacing="0" cellpadding="4">
            <tr>
                <td height="40" colspan="2" style="color:#FF9900"><p><font color="#FF0000">在线解压ZIP文件程序</font></p>
                    <p>使用方法:把zip文件通过FTP上传到本文件相同的目录下,选择zip文件;或直接点击“浏览...”上传zip文件。</p>
                    <p>解压的结果保留原来的目录结构。</p>
                    <p>&nbsp;</p></td>
            </tr>
            <tr>
                <td width="11%">选择ZIP文件:</td>
                <td width="89%"><select name="zipfile">
                        <option value="" selected>- 请选择 -</option>
                        <?
                        $fdir = opendir('./');
                        while ($file = readdir($fdir)) {
                            if (!is_file($file)) {
                                continue;
                            }
                            if (preg_match('/\.zip$/mis', $file)) {
                                echo "<option value='$file'>$file</option>\r\n";
                            }
                        }
                        ?>
                    </select></td>
            </tr>
            <tr>
                <td width="11%" nowrap>或上传文件:</td>
                <td width="89%"><input name="upfile" type="file" id="upfile" size="20"></td>
            </tr>
            <tr>
                <td>解压到目录:</td>
                <td><input name="todir" type="text" id="todir" value="__unzipfiles__" size="15">
                    (留空为本目录,必须有写入权限)
                </td>
            </tr>
            <tr>
                <td>验证密码:</td>
                <td><input name="password" type="password" id="password" size="15">
                    (源文件中设定的密码)
                </td>
            </tr>
            <tr>
                <td><input name="myaction" type="hidden" id="myaction" value="dounzip"></td>
                <td><input type="submit" name="Submit" value=" 解 压 "></td>
            </tr>
        </table>

    <?

    elseif ($_REQUEST["myaction"] === "dounzip"):

    /**
     * Class zip
     */
    class zip
    {

        var $total_files   = 0;
        var $total_folders = 0;

        /**
         * @param       $zn
         * @param       $to
         * @param array $index
         * @return int
         */
        function Extract($zn, $to, $index = Array(-1))
        {
            $ok  = 0;
            $zip = @fopen($zn, 'rb');
            if (!$zip) {
                return (-1);
            }
            $cdir      = $this->ReadCentralDir($zip, $zn);
            $pos_entry = $cdir['offset'];

            if (!is_array($index)) {
                $index = array($index);
            }
            for ($i = 0; $index[$i]; $i++) {
                if ((int)($index[$i]) != $index[$i] || $index[$i] > $cdir['entries']) {
                    return (-1);
                }
            }
            for ($i = 0; $i < $cdir['entries']; $i++) {
                @fseek($zip, $pos_entry);
                $header          = $this->ReadCentralFileHeaders($zip);
                $header['index'] = $i;
                $pos_entry       = ftell($zip);
                @rewind($zip);
                fseek($zip, $header['offset']);
                if (in_array("-1", $index) || in_array($i, $index)) {
                    $stat[$header['filename']] = $this->ExtractFile($header, $to, $zip);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                }
            }
            fclose($zip);

            return $stat;
        }

        /**
         * @param $zip
         * @return mixed
         */
        function ReadFileHeader($zip)
        {
            $binary_data = fread($zip, 30);
            $data        = unpack('vchk/vid/vversion/vflag/vcompression/vmtime/vmdate/Vcrc/Vcompressed_size/Vsize/vfilename_len/vextra_len', $binary_data);

            $header['filename'] = fread($zip, $data['filename_len']);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            if ($data['extra_len'] != 0) {
                $header['extra'] = fread($zip, $data['extra_len']);
            } else {
                $header['extra'] = '';
            }

            $header['compression']     = $data['compression'];
            $header['size']            = $data['size'];
            $header['compressed_size'] = $data['compressed_size'];
            $header['crc']             = $data['crc'];
            $header['flag']            = $data['flag'];
            $header['mdate']           = $data['mdate'];
            $header['mtime']           = $data['mtime'];

            if ($header['mdate'] && $header['mtime']) {
                $hour            = ($header['mtime'] & 0xF800) >> 11;
                $minute          = ($header['mtime'] & 0x07E0) >> 5;
                $seconde         = ($header['mtime'] & 0x001F) * 2;
                $year            = (($header['mdate'] & 0xFE00) >> 9) + 1980;
                $month           = ($header['mdate'] & 0x01E0) >> 5;
                $day             = $header['mdate'] & 0x001F;
                $header['mtime'] = mktime($hour, $minute, $seconde, $month, $day, $year);
            } else {
                $header['mtime'] = time();
            }

            $header['stored_filename'] = $header['filename'];
            $header['status']          = "ok";

            return $header;
        }

        /**
         * @param $zip
         * @return array
         */
        function ReadCentralFileHeaders($zip)
        {
            $binary_data = fread($zip, 46);
            $header      = unpack('vchkid/vid/vversion/vversion_extracted/vflag/vcompression/vmtime/vmdate/Vcrc/Vcompressed_size/Vsize/vfilename_len/vextra_len/vcomment_len/vdisk/vinternal/Vexternal/Voffset', $binary_data);

            if ($header['filename_len'] != 0) {
                $header['filename'] = fread($zip, $header['filename_len']);
            } else {
                $header['filename'] = '';
            }

            if ($header['extra_len'] != 0) {
                $header['extra'] = fread($zip, $header['extra_len']);
            } else {
                $header['extra'] = '';
            }

            if ($header['comment_len'] != 0) {
                $header['comment'] = fread($zip, $header['comment_len']);
            } else {
                $header['comment'] = '';
            }

            if ($header['mdate'] && $header['mtime']) {
                $hour            = ($header['mtime'] & 0xF800) >> 11;
                $minute          = ($header['mtime'] & 0x07E0) >> 5;
                $seconde         = ($header['mtime'] & 0x001F) * 2;
                $year            = (($header['mdate'] & 0xFE00) >> 9) + 1980;
                $month           = ($header['mdate'] & 0x01E0) >> 5;
                $day             = $header['mdate'] & 0x001F;
                $header['mtime'] = mktime($hour, $minute, $seconde, $month, $day, $year);
            } else {
                $header['mtime'] = time();
            }
            $header['stored_filename'] = $header['filename'];
            $header['status']          = 'ok';
            if (substr($header['filename'], -1) === '/') {
                $header['external'] = 0x41FF0010;
            }

            return $header;
        }

        /**
         * @param $zip
         * @param $zip_name
         * @return mixed
         */
        function ReadCentralDir($zip, $zip_name)
        {
            $size = filesize($zip_name);

            if ($size < 277) {
                $maximum_size = $size;
            } else {
                $maximum_size = 277;
            }

            @fseek($zip, $size - $maximum_size);
            $pos   = ftell($zip);
            $bytes = 0x00000000;

            while ($pos < $size) {
                $byte  = @fread($zip, 1);
                $bytes = ($bytes << 8) | ord($byte);
                if ($bytes == 0x504b0506 or $bytes == 0x2e706870504b0506) {
                    $pos++;
                    break;
                }
                $pos++;
            }

            $fdata = fread($zip, 18);

            $data = @unpack('vdisk/vdisk_start/vdisk_entries/ventries/Vsize/Voffset/vcomment_size', $fdata);

            if ($data['comment_size'] != 0) {
                $centd['comment'] = fread($zip, $data['comment_size']);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            } else {
                $centd['comment'] = '';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
            $centd['entries']      = $data['entries'];
            $centd['disk_entries'] = $data['disk_entries'];
            $centd['offset']       = $data['offset'];
            $centd['disk_start']   = $data['disk_start'];
            $centd['size']         = $data['size'];
            $centd['disk']         = $data['disk'];

            return $centd;
        }

        /**
         * @param $header
         * @param $to
         * @param $zip
         * @return bool|void
         */
        function ExtractFile($header, $to, $zip)
        {
            $header = $this->readfileheader($zip);

            if (substr($to, -1) !== "/") {
                $to .= "/";
            }
            if ($to === './') {
                $to = '';
            }
            $pth   = explode("/", $to . $header['filename']);
            $mydir = '';
            for ($i = 0; $i < count($pth) - 1; $i++) {
                if (!$pth[$i]) {
                    continue;
                }
                $mydir .= $pth[$i] . "/";
                if ((!is_dir($mydir) && @mkdir($mydir, 0777)) || (($mydir == $to . $header['filename'] || ($mydir == $to && $this->total_folders == 0)) && is_dir($mydir))) {
                    @chmod($mydir, 0777);
                    $this->total_folders++;
                    echo "<input name='dfile[]' type='checkbox' value='$mydir' checked> <a href='$mydir' target='_blank'>目录: $mydir</a><br>";
                }
            }

            if (strrchr($header['filename'], '/') === '/') {
                return;
            }

            if (!($header['external'] == 0x41FF0010) && !($header['external'] == 16)) {
                if ($header['compression'] == 0) {
                    $fp = @fopen($to . $header['filename'], 'wb');
                    if (!$fp) {
                        return (-1);
                    }
                    $size = $header['compressed_size'];

                    while ($size != 0) {
                        $read_size   = ($size < 2048 ? $size : 2048);
                        $buffer      = fread($zip, $read_size);
                        $binary_data = pack('a' . $read_size, $buffer);
                        @fwrite($fp, $binary_data, $read_size);
                        $size -= $read_size;
                    }
                    fclose($fp);
                    touch($to . $header['filename'], $header['mtime']);
                } else {
                    $fp = @fopen($to . $header['filename'] . '.gz', 'wb');
                    if (!$fp) {
                        return (-1);
                    }
                    $binary_data = pack('va1a1Va1a1', 0x8b1f, Chr($header['compression']), Chr(0x00), time(), Chr(0x00), Chr(3));

                    fwrite($fp, $binary_data, 10);
                    $size = $header['compressed_size'];

                    while ($size != 0) {
                        $read_size   = ($size < 1024 ? $size : 1024);
                        $buffer      = fread($zip, $read_size);
                        $binary_data = pack('a' . $read_size, $buffer);
                        @fwrite($fp, $binary_data, $read_size);
                        $size -= $read_size;
                    }

                    $binary_data = pack('VV', $header['crc'], $header['size']);
                    fwrite($fp, $binary_data, 8);
                    fclose($fp);

                    $gzp = @gzopen($to . $header['filename'] . '.gz', 'rb') or die("Cette archive est compress閑");
                    if (!$gzp) {
                        return (-2);
                    }
                    $fp = @fopen($to . $header['filename'], 'wb');
                    if (!$fp) {
                        return (-1);
                    }
                    $size = $header['size'];

                    while ($size != 0) {
                        $read_size   = ($size < 2048 ? $size : 2048);
                        $buffer      = gzread($gzp, $read_size);
                        $binary_data = pack('a' . $read_size, $buffer);
                        @fwrite($fp, $binary_data, $read_size);
                        $size -= $read_size;
                    }
                    fclose($fp);
                    gzclose($gzp);

                    touch($to . $header['filename'], $header['mtime']);
                    @unlink($to . $header['filename'] . '.gz');

                }
            }

            $this->total_files++;
            echo "<input name='dfile[]' type='checkbox' value='$to$header[filename]' checked> <a href='$to$header[filename]' target='_blank'>文件: $to$header[filename]</a><br>";

            return true;
        }

        // end class
    }

    set_time_limit(0);

    if ($_POST['password'] != $password) {
        die("输入的密码不正确，请重新输入。");
    }
    if (!$_POST["todir"]) {
        $_POST["todir"] = ".";
    }
    $z             = new Zip;
    $have_zip_file = 0;
    /**
     * @param $tmp_name
     * @param $new_name
     * @param $checked
     */
    function start_unzip($tmp_name, $new_name, $checked)
    {
        global $_POST, $z, $have_zip_file;
        $upfile = array("tmp_name" => $tmp_name, "name" => $new_name);
        if (is_file($upfile[tmp_name])) {
            $have_zip_file = 1;
            echo "<br>正在解压: <input name='dfile[]' type='checkbox' value='$upfile[name]' " . ($checked ? "checked" : "") . "> $upfile[name]<br><br>";
            if (preg_match('/\.zip$/mis', $upfile[name])) {
                $result = $z->Extract($upfile[tmp_name], $_POST["todir"]);
                if ($result == -1) {
                    echo "<br>文件 $upfile[name] 错误.<br>";
                }
                echo "<br>完成,共建立 $z->total_folders 个目录,$z->total_files 个文件.<br><br><br>";
            } else {
                echo "<br>$upfile[name] 不是 zip 文件.<br><br>";
            }
            if (realpath($upfile[name]) != realpath($upfile[tmp_name])) {
                @unlink($upfile[name]);
                rename($upfile[tmp_name], $upfile[name]);
            }
        }
    }

    clearstatcache();

    start_unzip($_POST["zipfile"], $_POST["zipfile"], 0);
    start_unzip($_FILES["upfile"][tmp_name], $_FILES["upfile"][name], 1);

    if (!$have_zip_file) {
        echo "<br>请选择或上传文件.<br>";
    }
    ?>
    <input name="password" type="hidden" id="password" value="<?= $_POST['password']; ?>">
    <input name="myaction" type="hidden" id="myaction" value="dodelete">
    <input name="按钮" type="button" value="返回" onClick="window.location='<?= $_SERVER[PHP_SELF]; ?>';">

    <input type='button' value='反选' onclick='selrev();'> <input type='submit' onclick='return confirm("删除选定文件?");' value='删除选定'>

        <script language='javascript'>
            function selrev() {
                with (document.myform) {
                    for (i = 0; i < elements.length; i++) {
                        thiselm = elements[i];
                        if (thiselm.name.match(/dfile\[]/))    thiselm.checked = !thiselm.checked;
                    }
                }
            }
            alert('完成.');
        </script>
        <?

    elseif ($_REQUEST["myaction"] === "dodelete"):
        set_time_limit(0);
        if ($_POST['password'] != $password) {
            die("输入的密码不正确，请重新输入。");
        }

        $dfile = $_POST["dfile"];
        echo "正在删除文件...<br><br>";
        if (is_array($dfile)) {
            for ($i = count($dfile) - 1; $i >= 0; $i--) {
                if (is_file($dfile[$i])) {
                    if (@unlink($dfile[$i])) {
                        echo "已删除文件: $dfile[$i]<br>";
                    } else {
                        echo "删除文件失败: $dfile[$i]<br>";
                    }
                } else {
                    if (@rmdir($dfile[$i])) {
                        echo "已删除目录: $dfile[$i]<br>";
                    } else {
                        echo "删除目录失败: $dfile[$i]<br>";
                    }
                }

            }
        }
        echo "<br>完成.<br><br><input type='button' value='返回' onclick=\"window.location='$_SERVER[PHP_SELF]';\"><br><br>
		 <script language='javascript'>('完成.');</script>";

    endif;

    ?>
</form>
</body>
</html>


1		<?php
2
3		//验证密码
4		$password = "pwd";
5
6		?>
7		<html>
8		<head>
9		<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
10		<title>在线ZIP解压程序</title>
11		<style type="text/css">
12		<!--
13		body, td {
14		font-size: 14px;
15		color: #000000;
16		}
17
18		a {
19		color: #000066;
20		text-decoration: none;
21		}
22
23		a:hover {
24		color: #FF6600;
25		text-decoration: underline;
26		}
27
28		-->
29		</style>
30		</head>
31
32		<body>
33		<form name="myform" method="post" action="<?= $_SERVER[PHP_SELF]; ?>" enctype="multipart/form-data" onSubmit="return check_uploadObject(this);">
34		<?
35		if (!$_REQUEST["myaction"]):
36		?>
37
38		<script language="javascript">
39		function check_uploadObject(form) {
40		if (form.password.value == '') {
41		alert('请输入密码.');
42		return false;
43		}
44		return true;
45		}
46		</script>
47
48		<table width="100%" border="0" cellspacing="0" cellpadding="4">
49		<tr>
50		<td height="40" colspan="2" style="color:#FF9900"><p><font color="#FF0000">在线解压ZIP文件程序</font></p>
51		<p>使用方法:把zip文件通过FTP上传到本文件相同的目录下,选择zip文件;或直接点击“浏览...”上传zip文件。</p>
52		<p>解压的结果保留原来的目录结构。</p>
53		<p> </p></td>
54		</tr>
55		<tr>
56		<td width="11%">选择ZIP文件:</td>
57		<td width="89%"><select name="zipfile">
58		<option value="" selected>- 请选择 -</option>
59		<?
60		$fdir = opendir('./');
61		while ($file = readdir($fdir)) {
62		if (!is_file($file)) {
63		continue;
64		}
65		if (preg_match('/\.zip$/mis', $file)) {
66		echo "<option value='$file'>$file</option>\r\n";
67		}
68		}
69		?>
70		</select></td>
71		</tr>
72		<tr>
73		<td width="11%" nowrap>或上传文件:</td>
74		<td width="89%"><input name="upfile" type="file" id="upfile" size="20"></td>
75		</tr>
76		<tr>
77		<td>解压到目录:</td>
78		<td><input name="todir" type="text" id="todir" value="__unzipfiles__" size="15">
79		(留空为本目录,必须有写入权限)
80		</td>
81		</tr>
82		<tr>
83		<td>验证密码:</td>
84		<td><input name="password" type="password" id="password" size="15">
85		(源文件中设定的密码)
86		</td>
87		</tr>
88		<tr>
89		<td><input name="myaction" type="hidden" id="myaction" value="dounzip"></td>
90		<td><input type="submit" name="Submit" value=" 解压 "></td>
91		</tr>
92		</table>
93
94		<?
95
96		elseif ($_REQUEST["myaction"] === "dounzip"):
97
98		/**
99		* Class zip
100		*/
101		class zip
102		{
103
104		var $total_files = 0;
105		var $total_folders = 0;
106
107		/**
108		* @param $zn
109		* @param $to
110		* @param array $index
111		* @return int
112		*/
113		function Extract($zn, $to, $index = Array(-1))
114		{
115		$ok = 0;
116		$zip = @fopen($zn, 'rb');
117		if (!$zip) {
118		return (-1);
119		}
120		$cdir = $this->ReadCentralDir($zip, $zn);
121		$pos_entry = $cdir['offset'];
122
123		if (!is_array($index)) {
124		$index = array($index);
125		}
126		for ($i = 0; $index[$i]; $i++) {
127		if ((int)($index[$i]) != $index[$i] \|\| $index[$i] > $cdir['entries']) {
128		return (-1);
129		}
130		}
131		for ($i = 0; $i < $cdir['entries']; $i++) {
132		@fseek($zip, $pos_entry);
133		$header = $this->ReadCentralFileHeaders($zip);
134		$header['index'] = $i;
135		$pos_entry = ftell($zip);
136		@rewind($zip);
137		fseek($zip, $header['offset']);
138		if (in_array("-1", $index) \|\| in_array($i, $index)) {
139		$stat[$header['filename']] = $this->ExtractFile($header, $to, $zip);
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$stat` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$stat = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
140		}
141		}
142		fclose($zip);
143
144		return $stat;
145		}
146
147		/**
148		* @param $zip
149		* @return mixed
150		*/
151		function ReadFileHeader($zip)
152		{
153		$binary_data = fread($zip, 30);
154		$data = unpack('vchk/vid/vversion/vflag/vcompression/vmtime/vmdate/Vcrc/Vcompressed_size/Vsize/vfilename_len/vextra_len', $binary_data);
155
156		$header['filename'] = fread($zip, $data['filename_len']);
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$header` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$header = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
157	View Code Duplication	if ($data['extra_len'] != 0) {
158		$header['extra'] = fread($zip, $data['extra_len']);
159		} else {
160		$header['extra'] = '';
161		}
162
163		$header['compression'] = $data['compression'];
164		$header['size'] = $data['size'];
165		$header['compressed_size'] = $data['compressed_size'];
166		$header['crc'] = $data['crc'];
167		$header['flag'] = $data['flag'];
168		$header['mdate'] = $data['mdate'];
169		$header['mtime'] = $data['mtime'];
170
171	View Code Duplication	if ($header['mdate'] && $header['mtime']) {
172		$hour = ($header['mtime'] & 0xF800) >> 11;
173		$minute = ($header['mtime'] & 0x07E0) >> 5;
174		$seconde = ($header['mtime'] & 0x001F) * 2;
175		$year = (($header['mdate'] & 0xFE00) >> 9) + 1980;
176		$month = ($header['mdate'] & 0x01E0) >> 5;
177		$day = $header['mdate'] & 0x001F;
178		$header['mtime'] = mktime($hour, $minute, $seconde, $month, $day, $year);
179		} else {
180		$header['mtime'] = time();
181		}
182
183		$header['stored_filename'] = $header['filename'];
184		$header['status'] = "ok";
185
186		return $header;
187		}
188
189		/**
190		* @param $zip
191		* @return array
192		*/
193		function ReadCentralFileHeaders($zip)
194		{
195		$binary_data = fread($zip, 46);
196		$header = unpack('vchkid/vid/vversion/vversion_extracted/vflag/vcompression/vmtime/vmdate/Vcrc/Vcompressed_size/Vsize/vfilename_len/vextra_len/vcomment_len/vdisk/vinternal/Vexternal/Voffset', $binary_data);
197
198		if ($header['filename_len'] != 0) {
199		$header['filename'] = fread($zip, $header['filename_len']);
200		} else {
201		$header['filename'] = '';
202		}
203
204	View Code Duplication	if ($header['extra_len'] != 0) {
205		$header['extra'] = fread($zip, $header['extra_len']);
206		} else {
207		$header['extra'] = '';
208		}
209
210		if ($header['comment_len'] != 0) {
211		$header['comment'] = fread($zip, $header['comment_len']);
212		} else {
213		$header['comment'] = '';
214		}
215
216	View Code Duplication	if ($header['mdate'] && $header['mtime']) {
217		$hour = ($header['mtime'] & 0xF800) >> 11;
218		$minute = ($header['mtime'] & 0x07E0) >> 5;
219		$seconde = ($header['mtime'] & 0x001F) * 2;
220		$year = (($header['mdate'] & 0xFE00) >> 9) + 1980;
221		$month = ($header['mdate'] & 0x01E0) >> 5;
222		$day = $header['mdate'] & 0x001F;
223		$header['mtime'] = mktime($hour, $minute, $seconde, $month, $day, $year);
224		} else {
225		$header['mtime'] = time();
226		}
227		$header['stored_filename'] = $header['filename'];
228		$header['status'] = 'ok';
229		if (substr($header['filename'], -1) === '/') {
230		$header['external'] = 0x41FF0010;
231		}
232
233		return $header;
234		}
235
236		/**
237		* @param $zip
238		* @param $zip_name
239		* @return mixed
240		*/
241		function ReadCentralDir($zip, $zip_name)
242		{
243		$size = filesize($zip_name);
244
245		if ($size < 277) {
246		$maximum_size = $size;
247		} else {
248		$maximum_size = 277;
249		}
250
251		@fseek($zip, $size - $maximum_size);
252		$pos = ftell($zip);
253		$bytes = 0x00000000;
254
255		while ($pos < $size) {
256		$byte = @fread($zip, 1);
257		$bytes = ($bytes << 8) \| ord($byte);
258		if ($bytes == 0x504b0506 or $bytes == 0x2e706870504b0506) {
259		$pos++;
260		break;
261		}
262		$pos++;
263		}
264
265		$fdata = fread($zip, 18);
266
267		$data = @unpack('vdisk/vdisk_start/vdisk_entries/ventries/Vsize/Voffset/vcomment_size', $fdata);
268
269		if ($data['comment_size'] != 0) {
270		$centd['comment'] = fread($zip, $data['comment_size']);
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$centd` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$centd = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
271		} else {
272		$centd['comment'] = '';
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$centd` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$centd = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
273		}
274		$centd['entries'] = $data['entries'];
275		$centd['disk_entries'] = $data['disk_entries'];
276		$centd['offset'] = $data['offset'];
277		$centd['disk_start'] = $data['disk_start'];
278		$centd['size'] = $data['size'];
279		$centd['disk'] = $data['disk'];
280
281		return $centd;
282		}
283
284		/**
285		* @param $header
286		* @param $to
287		* @param $zip
288		* @return bool\|void
289		*/
290		function ExtractFile($header, $to, $zip)
291		{
292		$header = $this->readfileheader($zip);
293
294		if (substr($to, -1) !== "/") {
295		$to .= "/";
296		}
297		if ($to === './') {
298		$to = '';
299		}
300		$pth = explode("/", $to . $header['filename']);
301		$mydir = '';
302		for ($i = 0; $i < count($pth) - 1; $i++) {
303		if (!$pth[$i]) {
304		continue;
305		}
306		$mydir .= $pth[$i] . "/";
307		if ((!is_dir($mydir) && @mkdir($mydir, 0777)) \|\| (($mydir == $to . $header['filename'] \|\| ($mydir == $to && $this->total_folders == 0)) && is_dir($mydir))) {
308		@chmod($mydir, 0777);
309		$this->total_folders++;
310		echo "<input name='dfile[]' type='checkbox' value='$mydir' checked> <a href='$mydir' target='_blank'>目录: $mydir</a><br>";
311		}
312		}
313
314		if (strrchr($header['filename'], '/') === '/') {
315		return;
316		}
317
318		if (!($header['external'] == 0x41FF0010) && !($header['external'] == 16)) {
319		if ($header['compression'] == 0) {
320		$fp = @fopen($to . $header['filename'], 'wb');
321		if (!$fp) {
322		return (-1);
323		}
324		$size = $header['compressed_size'];
325
326	View Code Duplication	while ($size != 0) {
327		$read_size = ($size < 2048 ? $size : 2048);
328		$buffer = fread($zip, $read_size);
329		$binary_data = pack('a' . $read_size, $buffer);
330		@fwrite($fp, $binary_data, $read_size);
331		$size -= $read_size;
332		}
333		fclose($fp);
334		touch($to . $header['filename'], $header['mtime']);
335		} else {
336		$fp = @fopen($to . $header['filename'] . '.gz', 'wb');
337		if (!$fp) {
338		return (-1);
339		}
340		$binary_data = pack('va1a1Va1a1', 0x8b1f, Chr($header['compression']), Chr(0x00), time(), Chr(0x00), Chr(3));
341
342		fwrite($fp, $binary_data, 10);
343		$size = $header['compressed_size'];
344
345	View Code Duplication	while ($size != 0) {
346		$read_size = ($size < 1024 ? $size : 1024);
347		$buffer = fread($zip, $read_size);
348		$binary_data = pack('a' . $read_size, $buffer);
349		@fwrite($fp, $binary_data, $read_size);
350		$size -= $read_size;
351		}
352
353		$binary_data = pack('VV', $header['crc'], $header['size']);
354		fwrite($fp, $binary_data, 8);
355		fclose($fp);
356
357		$gzp = @gzopen($to . $header['filename'] . '.gz', 'rb') or die("Cette archive est compress閑");
358		if (!$gzp) {
359		return (-2);
360		}
361		$fp = @fopen($to . $header['filename'], 'wb');
362		if (!$fp) {
363		return (-1);
364		}
365		$size = $header['size'];
366
367	View Code Duplication	while ($size != 0) {
368		$read_size = ($size < 2048 ? $size : 2048);
369		$buffer = gzread($gzp, $read_size);
370		$binary_data = pack('a' . $read_size, $buffer);
371		@fwrite($fp, $binary_data, $read_size);
372		$size -= $read_size;
373		}
374		fclose($fp);
375		gzclose($gzp);
376
377		touch($to . $header['filename'], $header['mtime']);
378		@unlink($to . $header['filename'] . '.gz');
379
380		}
381		}
382
383		$this->total_files++;
384		echo "<input name='dfile[]' type='checkbox' value='$to$header[filename]' checked> <a href='$to$header[filename]' target='_blank'>文件: $to$header[filename]</a><br>";
385
386		return true;
387		}
388
389		// end class
390		}
391
392		set_time_limit(0);
393
394		if ($_POST['password'] != $password) {
395		die("输入的密码不正确，请重新输入。");
396		}
397		if (!$_POST["todir"]) {
398		$_POST["todir"] = ".";
399		}
400		$z = new Zip;
401		$have_zip_file = 0;
402		/**
403		* @param $tmp_name
404		* @param $new_name
405		* @param $checked
406		*/
407		function start_unzip($tmp_name, $new_name, $checked)
408		{
409		global $_POST, $z, $have_zip_file;
410		$upfile = array("tmp_name" => $tmp_name, "name" => $new_name);
411		if (is_file($upfile[tmp_name])) {
412		$have_zip_file = 1;
413		echo "<br>正在解压: <input name='dfile[]' type='checkbox' value='$upfile[name]' " . ($checked ? "checked" : "") . "> $upfile[name]<br><br>";
414		if (preg_match('/\.zip$/mis', $upfile[name])) {
415		$result = $z->Extract($upfile[tmp_name], $_POST["todir"]);
416		if ($result == -1) {
417		echo "<br>文件 $upfile[name] 错误.<br>";
418		}
419		echo "<br>完成,共建立 $z->total_folders 个目录,$z->total_files 个文件.<br><br><br>";
420		} else {
421		echo "<br>$upfile[name] 不是 zip 文件.<br><br>";
422		}
423		if (realpath($upfile[name]) != realpath($upfile[tmp_name])) {
424		@unlink($upfile[name]);
425		rename($upfile[tmp_name], $upfile[name]);
426		}
427		}
428		}
429
430		clearstatcache();
431
432		start_unzip($_POST["zipfile"], $_POST["zipfile"], 0);
433		start_unzip($_FILES["upfile"][tmp_name], $_FILES["upfile"][name], 1);
434
435		if (!$have_zip_file) {
436		echo "<br>请选择或上传文件.<br>";
437		}
438		?>
439		<input name="password" type="hidden" id="password" value="<?= $_POST['password']; ?>">
440		<input name="myaction" type="hidden" id="myaction" value="dodelete">
441		<input name="按钮" type="button" value="返回" onClick="window.location='<?= $_SERVER[PHP_SELF]; ?>';">
442
443		<input type='button' value='反选' onclick='selrev();'> <input type='submit' onclick='return confirm("删除选定文件?");' value='删除选定'>
444
445		<script language='javascript'>
446		function selrev() {
447		with (document.myform) {
448		for (i = 0; i < elements.length; i++) {
449		thiselm = elements[i];
450		if (thiselm.name.match(/dfile\[]/)) thiselm.checked = !thiselm.checked;
451		}
452		}
453		}
454		alert('完成.');
455		</script>
456		<?
457
458		elseif ($_REQUEST["myaction"] === "dodelete"):
459		set_time_limit(0);
460		if ($_POST['password'] != $password) {
461		die("输入的密码不正确，请重新输入。");
462		}
463
464		$dfile = $_POST["dfile"];
465		echo "正在删除文件...<br><br>";
466		if (is_array($dfile)) {
467		for ($i = count($dfile) - 1; $i >= 0; $i--) {
468		if (is_file($dfile[$i])) {
469		if (@unlink($dfile[$i])) {
470		echo "已删除文件: $dfile[$i]<br>";
471		} else {
472		echo "删除文件失败: $dfile[$i]<br>";
473		}
474		} else {
475		if (@rmdir($dfile[$i])) {
476		echo "已删除目录: $dfile[$i]<br>";
477		} else {
478		echo "删除目录失败: $dfile[$i]<br>";
479		}
480		}
481
482		}
483		}
484		echo "<br>完成.<br><br><input type='button' value='返回' onclick=\"window.location='$_SERVER[PHP_SELF]';\"><br><br>
485		<script language='javascript'>('完成.');</script>";
486
487		endif;
488
489		?>
490		</form>
491		</body>
492		</html>
493

mambax7 / xoops-martin

Issues (663)

Security Analysis not enabled

zip/unzip.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like