Issues in hotelpromotion.php (master) - Issues in master - mambax7/xoops-martin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (663)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/hotelpromotion.php (24 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * $Id: promotion.php,v 1.42 2007/02/04 15:01:40 malanciault Exp $
 * Module:martin
 * Licence: GNU
 */

if (!defined("XOOPS_ROOT_PATH")) {
    die("XOOPS root path not defined");
}

include_once XOOPS_ROOT_PATH . '/modules/martin/include/common.php';

/**
 * Class MartinHotelPromotion
 */
class MartinHotelPromotion extends XoopsObject
{
    public function MartinHotelPromotion()
    {
        $this->initVar("promotion_id", XOBJ_DTYPE_INT, null, false);
        $this->initVar("hotel_id", XOBJ_DTYPE_INT, null, false);
        $this->initVar("hotel_name", XOBJ_DTYPE_TXTBOX, null, true, 255);
        $this->initVar("promotion_start_date", XOBJ_DTYPE_INT, null, false);
        $this->initVar("promotion_end_date", XOBJ_DTYPE_INT, null, false);
        $this->initVar("promotion_description", XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar("promotion_add_time", XOBJ_DTYPE_INT, null, false);
    }

    /**
     * @return mixed
     */
    public function promotion_id()
    {
        return $this->getVar("promotion_id");
    }

    /**
     * @return mixed
     */
    public function hotel_id()
    {
        return $this->getVar("hotel_id");
    }

    /**
     * @return mixed
     */
    public function hotel_name()
    {
        return $this->getVar("hotel_name");
    }

    /**
     * @return mixed
     */
    public function promotion_start_date()
    {
        return $this->getVar("promotion_start_date");
    }

    /**
     * @return mixed
     */
    public function promotion_end_date()
    {
        return $this->getVar("promotion_end_date");
    }

    /**
     * @param string $format
     * @return mixed
     */
    public function promotion_description($format = 'edit')
    {
        return $this->getVar("promotion_description", $format);
    }

    /**
     * @return mixed
     */
    public function promotion_add_time()
    {
        return $this->getVar("promotion_add_time");
    }
}

/**
 * @method: MartinHotelPromotionHandler
 * @license   http://www.blags.org/
 * @created   :2010年05月21日 20时40分
 * @copyright 1997-2010 The Martin promotion
 * @author    Martin <[email protected]>
 * */
class MartinHotelPromotionHandler extends XoopsObjectHandler
{
    /**
     * create a new hotel city
     * @param bool $isNew flag the new objects as "new"?
     * @return object promotion
     */
    public function &create($isNew = true)
    {
        $promotion = new MartinHotelPromotion();
        if ($isNew) {
            $promotion->setNew();
        }

        return $promotion;
    }

    /**
     * retrieve a hotel city
     *
     * @param int $id promotionid of the hotel promotion
     * @return mixed reference to the {@link promotion} object, FALSE if failed
     */
    public function &get($id)

    {
        if ((int)($id) <= 0) {
            return false;
        }

        $criteria = new CriteriaCompo(new Criteria('promotion_id', $id));
        $criteria->setLimit(1);
        $obj_array = $this->getObjects($criteria);
        if (count($obj_array) != 1) {
            $obj =& $this->create();

            return $obj;
        }

        return $obj_array[0];
    }

    /**
     * @得到列表
     * @method:
     * @license   http://www.blags.org/
     * @created   :2010年05月23日 14时59分
     * @copyright 1997-2010 The Martin promotion
     * @author    Martin <[email protected]>
     * @param int    $limit
     * @param int    $start
     * @param string $sort
     * @param string $order
     * @param bool   $id_as_key
     * @return array
     */
    public function &getPromotions($limit = 0, $start = 0, $sort = 'promotion_add_time', $order = 'DESC', $id_as_key = true)

    {
        $criteria = new CriteriaCompo();

        $criteria->setSort($sort);
        $criteria->setOrder($order);

        $criteria->setStart($start);
        $criteria->setLimit($limit);

        return $this->getObjects($criteria, $id_as_key);
    }

    /**
     * insert a new promotion in the database
     *
     * @param object $promotion reference to the {@link hotel promotion} object
     * @param bool   $force
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */
    public function insert(&$promotion, $force = false)
    {
        if (strtolower(get_class($promotion)) !== 'martinhotelpromotion') {
            return false;
        }

        if (!$promotion->cleanVars()) {
            return false;
        }

        foreach ($promotion->cleanVars as $k => $v) {
            ${$k} = $v;
        }

        if ($promotion->isNew()) {
            $sql = sprintf("INSERT INTO %s (
                                promotion_id,
                                promotion_description,
                                hotel_id,
                                promotion_start_date,
                                promotion_end_date,
                                promotion_add_time
                            ) VALUES (
                                NULL,
                                %s,%u,%u,%u,%u
                            )", $this->db->prefix('martin_hotel_promotions'), $this->db->quoteString($promotion_description), $hotel_id, $promotion_start_date, $promotion_end_date, $promotion_add_time);

        } else {
            $sql = sprintf("UPDATE %s SET
                                promotion_description = %s,
                                hotel_id = %u,
                                promotion_start_date = %u,
                                promotion_end_date = %u
                            WHERE promotion_id = %u", $this->db->prefix('martin_hotel_promotions'), $this->db->quoteString($promotion_description), $hotel_id, $promotion_start_date, $promotion_end_date, $promotion_id);

        }
        //echo $sql;exit;
        if (false != $force) {

            $result = $this->db->queryF($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
            $result = $this->db->query($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        return $promotion_id > 0 ? $promotion_id : $this->db->getInsertId();

    }

    /**
     * @删除一个城市
     * @method:delete(promotion_id)
     * @license   http://www.blags.org/
     * @created   :2010年05月21日 20时40分
     * @copyright 1997-2010 The Martin promotion
     * @author    Martin <[email protected]>
     * @param object $promotion
     * @param bool   $force
     * @return bool|void
     */
    public function delete(&$promotion, $force = false)

    {
        if (strtolower(get_class($promotion)) !== 'martinhotelpromotion') {
            return false;
        }

        $sql = "DELETE FROM " . $this->db->prefix("martin_hotel_promotions") . " WHERE promotion_id = " . $promotion->promotion_id();

        if (false != $force) {

            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }

        if (!$result) {
            return false;
        }

        return true;
    }

    /**
     * delete hotel cities matching a set of conditions
     *
     * @param object $criteria {@link CriteriaElement}

     * @return bool FALSE if deletion failed
     */
    public function deleteAll($criteria = null)

    {
        $sql = 'DELETE FROM ' . $this->db->prefix('martin_hotel_promotions');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {
            return false;
        }

        return true;
    }

    /**
     * count hotel cities matching a condition
     *
     * @param object $criteria {@link CriteriaElement} to match

     * @return int count of categories
     */
    public function getCount($criteria = null)

    {
        $sql = 'SELECT COUNT(*) FROM ' . $this->db->prefix('martin_hotel_promotions');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

            $sql .= ' ' . $criteria->renderWhere();
        }
        $result = $this->db->query($sql);
        if (!$result) {
            return 0;
        }
        list($count) = $this->db->fetchRow($result);

        return $count;
    }

    /**
     * @得到城市
     * @license   http://www.blags.org/
     * @created   :2010年05月21日 20时40分
     * @copyright 1997-2010 The Martin promotion
     * @author    Martin <[email protected]>
     * @param null $criteria
     * @param bool $id_as_key
     * @return array
     */
    public function &getObjects($criteria = null, $id_as_key = false)
    {
        $ret   = array();
        $limit = $start = 0;
        $sql   = 'SELECT p.*,h.hotel_name FROM ' . $this->db->prefix('martin_hotel_promotions') . ' p ';
        $sql .= ' left join ' . $this->db->prefix('martin_hotel') . ' h on ( h.hotel_id = p.hotel_id ) ';
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
            $limit = $criteria->getLimit();
            $start = $criteria->getStart();
        }
        $sql .= " order by p.promotion_id DESC ";
        //echo "<br />" . $sql . "<br />";
        $result = $this->db->query($sql, $limit, $start);

        if (!$result) {
            return $ret;
        }

        $theObjects = array();

        while ($myrow = $this->db->fetchArray($result)) {
            $promotion = new MartinHotelPromotion();
            $promotion->assignVars($myrow);
            $theObjects[$myrow['promotion_id']] =& $promotion;
            //var_dump($promotion);
            unset($promotion);
        }
        //var_dump($theObjects);

        foreach ($theObjects as $theObject) {
            if (!$id_as_key) {
                $ret[] =& $theObject;
            } else {
                $ret[$theObject->promotion_id()] =& $theObject;
            }
            unset($theObject);
        }

        return $ret;
    }

    /**
     * @get       hotel promotion
     * @license   http://www.blags.org/
     * @created   :2010年06月14日 20时47分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <[email protected]>
     * @param $hotel_id
     * @return string
     */
    public function getHotelPromotion($hotel_id)
    {
        global $xoopsDB;
        if (!$hotel_id > 0) {
            return '';
        }
        $sql = 'SELECT * FROM ' . $xoopsDB->prefix('martin_hotel_promotions') . ' WHERE
            ' . time() . ' BETWEEN  promotion_start_date AND promotion_end_date  AND hotel_id = ' . $hotel_id . '  limit 1 ';

        return $xoopsDB->fetchArray($xoopsDB->query($sql));
    }
}


1		<?php
2		/**
3		* $Id: promotion.php,v 1.42 2007/02/04 15:01:40 malanciault Exp $
4		* Module:martin
5		* Licence: GNU
6		*/
7
8		if (!defined("XOOPS_ROOT_PATH")) {
9		die("XOOPS root path not defined");
10		}
11
12		include_once XOOPS_ROOT_PATH . '/modules/martin/include/common.php';
13
14		/**
15		* Class MartinHotelPromotion
16		*/
17		class MartinHotelPromotion extends XoopsObject
18		{
19		public function MartinHotelPromotion()
20		{
21		$this->initVar("promotion_id", XOBJ_DTYPE_INT, null, false);
22		$this->initVar("hotel_id", XOBJ_DTYPE_INT, null, false);
23		$this->initVar("hotel_name", XOBJ_DTYPE_TXTBOX, null, true, 255);
24		$this->initVar("promotion_start_date", XOBJ_DTYPE_INT, null, false);
25		$this->initVar("promotion_end_date", XOBJ_DTYPE_INT, null, false);
26		$this->initVar("promotion_description", XOBJ_DTYPE_TXTAREA, null, false);
27		$this->initVar("promotion_add_time", XOBJ_DTYPE_INT, null, false);
28		}
29
30		/**
31		* @return mixed
32		*/
33		public function promotion_id()
34		{
35		return $this->getVar("promotion_id");
36		}
37
38		/**
39		* @return mixed
40		*/
41		public function hotel_id()
42		{
43		return $this->getVar("hotel_id");
44		}
45
46		/**
47		* @return mixed
48		*/
49		public function hotel_name()
50		{
51		return $this->getVar("hotel_name");
52		}
53
54		/**
55		* @return mixed
56		*/
57		public function promotion_start_date()
58		{
59		return $this->getVar("promotion_start_date");
60		}
61
62		/**
63		* @return mixed
64		*/
65		public function promotion_end_date()
66		{
67		return $this->getVar("promotion_end_date");
68		}
69
70		/**
71		* @param string $format
72		* @return mixed
73		*/
74		public function promotion_description($format = 'edit')
75		{
76		return $this->getVar("promotion_description", $format);
77		}
78
79		/**
80		* @return mixed
81		*/
82		public function promotion_add_time()
83		{
84		return $this->getVar("promotion_add_time");
85		}
86		}
87
88		/**
89		* @method: MartinHotelPromotionHandler
90		* @license http://www.blags.org/
91		* @created :2010年05月21日 20时40分
92		* @copyright 1997-2010 The Martin promotion
93		* @author Martin <[email protected]>
94		* */
95		class MartinHotelPromotionHandler extends XoopsObjectHandler
96		{
97		/**
98		* create a new hotel city
99		* @param bool $isNew flag the new objects as "new"?
100		* @return object promotion
101		*/
102		public function &create($isNew = true)
103		{
104		$promotion = new MartinHotelPromotion();
105		if ($isNew) {
106		$promotion->setNew();
107		}
108
109		return $promotion;
110		}
111
112		/**
113		* retrieve a hotel city
114		*
115		* @param int $id promotionid of the hotel promotion
116		* @return mixed reference to the {@link promotion} object, FALSE if failed
117		*/
118	View Code Duplication	public function &get($id)
		0 ignored issues – show Duplication introduced 2019-01-19 05:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		{
120		if ((int)($id) <= 0) {
121		return false;
122		}
123
124		$criteria = new CriteriaCompo(new Criteria('promotion_id', $id));
125		$criteria->setLimit(1);
126		$obj_array = $this->getObjects($criteria);
127		if (count($obj_array) != 1) {
128		$obj =& $this->create();
129
130		return $obj;
131		}
132
133		return $obj_array[0];
134		}
135
136		/**
137		* @得到列表
138		* @method:
139		* @license http://www.blags.org/
140		* @created :2010年05月23日 14时59分
141		* @copyright 1997-2010 The Martin promotion
142		* @author Martin <[email protected]>
143		* @param int $limit
144		* @param int $start
145		* @param string $sort
146		* @param string $order
147		* @param bool $id_as_key
148		* @return array
149		*/
150	View Code Duplication	public function &getPromotions($limit = 0, $start = 0, $sort = 'promotion_add_time', $order = 'DESC', $id_as_key = true)
		0 ignored issues – show Duplication introduced 2019-01-19 05:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		{
152		$criteria = new CriteriaCompo();
153
154		$criteria->setSort($sort);
155		$criteria->setOrder($order);
156
157		$criteria->setStart($start);
158		$criteria->setLimit($limit);
159
160		return $this->getObjects($criteria, $id_as_key);
161		}
162
163		/**
164		* insert a new promotion in the database
165		*
166		* @param object $promotion reference to the {@link hotel promotion} object
167		* @param bool $force
168		* @return bool FALSE if failed, TRUE if already present and unchanged or successful
169		*/
170		public function insert(&$promotion, $force = false)
171		{
172		if (strtolower(get_class($promotion)) !== 'martinhotelpromotion') {
173		return false;
174		}
175
176		if (!$promotion->cleanVars()) {
177		return false;
178		}
179
180		foreach ($promotion->cleanVars as $k => $v) {
181		${$k} = $v;
182		}
183
184		if ($promotion->isNew()) {
185		$sql = sprintf("INSERT INTO %s (
186		promotion_id,
187		promotion_description,
188		hotel_id,
189		promotion_start_date,
190		promotion_end_date,
191		promotion_add_time
192		) VALUES (
193		NULL,
194		%s,%u,%u,%u,%u
195		)", $this->db->prefix('martin_hotel_promotions'), $this->db->quoteString($promotion_description), $hotel_id, $promotion_start_date, $promotion_end_date, $promotion_add_time);
		0 ignored issues – show Bug introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$promotion_description` does not exist. Did you mean `$promotion`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history... Bug introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$hotel_id` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$promotion_start_date` does not exist. Did you mean `$promotion`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history... Bug introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$promotion_end_date` does not exist. Did you mean `$promotion`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history... Bug introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$promotion_add_time` does not exist. Did you mean `$promotion`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
196		} else {
197		$sql = sprintf("UPDATE %s SET
198		promotion_description = %s,
199		hotel_id = %u,
200		promotion_start_date = %u,
201		promotion_end_date = %u
202		WHERE promotion_id = %u", $this->db->prefix('martin_hotel_promotions'), $this->db->quoteString($promotion_description), $hotel_id, $promotion_start_date, $promotion_end_date, $promotion_id);
		0 ignored issues – show Bug introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$promotion_description` does not exist. Did you mean `$promotion`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history... Bug introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$promotion_start_date` does not exist. Did you mean `$promotion`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history... Bug introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$promotion_end_date` does not exist. Did you mean `$promotion`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history... Bug introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$promotion_id` does not exist. Did you mean `$promotion`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
203		}
204		//echo $sql;exit;
205		if (false != $force) {
		0 ignored issues – show Coding Style Best Practice introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing two booleans. Considering using the strict comparison `!==` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
206		$result = $this->db->queryF($sql);
		0 ignored issues – show Unused Code introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
207		} else {
208		$result = $this->db->query($sql);
		0 ignored issues – show Unused Code introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$result` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
209		}
210
211		return $promotion_id > 0 ? $promotion_id : $this->db->getInsertId();
		0 ignored issues – show Bug introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$promotion_id` does not exist. Did you mean `$promotion`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history...
212		}
213
214		/**
215		* @删除一个城市
216		* @method:delete(promotion_id)
217		* @license http://www.blags.org/
218		* @created :2010年05月21日 20时40分
219		* @copyright 1997-2010 The Martin promotion
220		* @author Martin <[email protected]>
221		* @param object $promotion
222		* @param bool $force
223		* @return bool\|void
224		*/
225	View Code Duplication	public function delete(&$promotion, $force = false)
		0 ignored issues – show Duplication introduced 2019-01-19 05:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
226		{
227		if (strtolower(get_class($promotion)) !== 'martinhotelpromotion') {
228		return false;
229		}
230
231		$sql = "DELETE FROM " . $this->db->prefix("martin_hotel_promotions") . " WHERE promotion_id = " . $promotion->promotion_id();
232
233		if (false != $force) {
		0 ignored issues – show Coding Style Best Practice introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing two booleans. Considering using the strict comparison `!==` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
234		$result = $this->db->queryF($sql);
235		} else {
236		$result = $this->db->query($sql);
237		}
238
239		if (!$result) {
240		return false;
241		}
242
243		return true;
244		}
245
246		/**
247		* delete hotel cities matching a set of conditions
248		*
249		* @param object $criteria {@link CriteriaElement}
		0 ignored issues – show Documentation introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$criteria` not be `object\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
250		* @return bool FALSE if deletion failed
251		*/
252	View Code Duplication	public function deleteAll($criteria = null)
		0 ignored issues – show Duplication introduced 2019-01-19 05:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
253		{
254		$sql = 'DELETE FROM ' . $this->db->prefix('martin_hotel_promotions');
255		if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
		0 ignored issues – show Bug introduced 2016-01-18 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Due to PHP Bug #53727, `is_subclass_of` returns inconsistent results on some PHP versions for interfaces; you could instead use `ReflectionClass::implementsInterface`. Loading history...
256		$sql .= ' ' . $criteria->renderWhere();
257		}
258		if (!$result = $this->db->query($sql)) {
259		return false;
260		}
261
262		return true;
263		}
264
265		/**
266		* count hotel cities matching a condition
267		*
268		* @param object $criteria {@link CriteriaElement} to match
		0 ignored issues – show Documentation introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$criteria` not be `object\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
269		* @return int count of categories
270		*/
271	View Code Duplication	public function getCount($criteria = null)
		0 ignored issues – show Duplication introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
272		{
273		$sql = 'SELECT COUNT(*) FROM ' . $this->db->prefix('martin_hotel_promotions');
274		if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
		0 ignored issues – show Bug introduced 2016-01-18 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Due to PHP Bug #53727, `is_subclass_of` returns inconsistent results on some PHP versions for interfaces; you could instead use `ReflectionClass::implementsInterface`. Loading history...
275		$sql .= ' ' . $criteria->renderWhere();
276		}
277		$result = $this->db->query($sql);
278		if (!$result) {
279		return 0;
280		}
281		list($count) = $this->db->fetchRow($result);
282
283		return $count;
284		}
285
286		/**
287		* @得到城市
288		* @license http://www.blags.org/
289		* @created :2010年05月21日 20时40分
290		* @copyright 1997-2010 The Martin promotion
291		* @author Martin <[email protected]>
292		* @param null $criteria
293		* @param bool $id_as_key
294		* @return array
295		*/
296		public function &getObjects($criteria = null, $id_as_key = false)
297		{
298		$ret = array();
299		$limit = $start = 0;
300		$sql = 'SELECT p.*,h.hotel_name FROM ' . $this->db->prefix('martin_hotel_promotions') . ' p ';
301		$sql .= ' left join ' . $this->db->prefix('martin_hotel') . ' h on ( h.hotel_id = p.hotel_id ) ';
302		if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {
		0 ignored issues – show Bug introduced 2016-01-18 08:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Due to PHP Bug #53727, `is_subclass_of` returns inconsistent results on some PHP versions for interfaces; you could instead use `ReflectionClass::implementsInterface`. Loading history...
303		$sql .= ' ' . $criteria->renderWhere();
304		if ($criteria->getSort() != '') {
305		$sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
306		}
307		$limit = $criteria->getLimit();
308		$start = $criteria->getStart();
309		}
310		$sql .= " order by p.promotion_id DESC ";
311		//echo "<br />" . $sql . "<br />";
312		$result = $this->db->query($sql, $limit, $start);
313
314		if (!$result) {
315		return $ret;
316		}
317
318		$theObjects = array();
319
320		while ($myrow = $this->db->fetchArray($result)) {
321		$promotion = new MartinHotelPromotion();
322		$promotion->assignVars($myrow);
323		$theObjects[$myrow['promotion_id']] =& $promotion;
324		//var_dump($promotion);
325		unset($promotion);
326		}
327		//var_dump($theObjects);
328
329		foreach ($theObjects as $theObject) {
330		if (!$id_as_key) {
331		$ret[] =& $theObject;
332		} else {
333		$ret[$theObject->promotion_id()] =& $theObject;
334		}
335		unset($theObject);
336		}
337
338		return $ret;
339		}
340
341		/**
342		* @get hotel promotion
343		* @license http://www.blags.org/
344		* @created :2010年06月14日 20时47分
345		* @copyright 1997-2010 The Martin Group
346		* @author Martin <[email protected]>
347		* @param $hotel_id
348		* @return string
349		*/
350		public function getHotelPromotion($hotel_id)
351		{
352		global $xoopsDB;
353		if (!$hotel_id > 0) {
354		return '';
355		}
356		$sql = 'SELECT * FROM ' . $xoopsDB->prefix('martin_hotel_promotions') . ' WHERE
357		' . time() . ' BETWEEN promotion_start_date AND promotion_end_date AND hotel_id = ' . $hotel_id . ' limit 1 ';
358
359		return $xoopsDB->fetchArray($xoopsDB->query($sql));
360		}
361		}
362

mambax7 / xoops-martin

Issues (663)

Security Analysis not enabled

class/hotelpromotion.php (24 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like