form_order::__construct() - Code Metrics - Inspection of "Few more language conversions, plus few files from..." - mambax7/xoops-martin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5be1c3...395766 )

by Michael

created 2015-12-30 17:50 UTC

form_order::__construct() A

↳ Parent: form_order

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	18
rs	9.4286
cc	1
eloc	11
nc	1
nop	1

<?php

/**
 * @酒店表单
 * @license   http://www.blags.org/
 * @created   :2010年05月20日 23时52分
 * @copyright 1997-2010 The Martin Group
 * @author    Martin <[email protected]>
 * */
if (!defined('XOOPS_ROOT_PATH')) {
    return;
}

include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

/**
 * Class form_order
 */
class form_order extends XoopsThemeForm
namespace YourVendor;

class YourClass { }
{
    /**
     * form_order constructor.
     * @param $OrderObj
     */
    public function __construct(&$OrderObj)
    {
        //array
        $this->OrderType         = getModuleArray('order_type', 'order_type', true);
        $this->OrderMode         = getModuleArray('order_mode', 'order_mode', true);
        $this->OrderPayMethod    = getModuleArray('order_pay_method', 'order_pay_method', true);
        $this->OrderStatus       = getModuleArray('order_status', 'order_status', true);
        $this->OrderDocumentType = getModuleArray('order_document_type', 'order_document_type', true);

        //print_r($this->OrderStatus);exit;


        $this->Obj = &$OrderObj;
        parent::__construct(_AM_MARTIN_ORDER_INFORMATION, "op", xoops_getenv('PHP_SELF') . "?action=save");
        $this->setExtra('enctype="multipart/form-data"');

        $this->createElements();
        $this->createButtons();
    }

    /**
     * created elements
     * @license   http://www.blags.org/
     * @created   :2010年05月21日 20时40分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <[email protected]>
     * */
    public function createElements()
    {
        //var_dump($this->Obj);exit;

        //编辑器
        include_once XOOPS_ROOT_PATH . "/modules/martin/class/xoopsformloader.php";
        include_once MARTIN_ROOT_PATH . '/include/formdatetime.php';

        $Order = new XoopsFormElementTray(_AM_MARTIN_ORDER_ID);
        $Order->addElement(new XoopsFormElementTray($this->Obj->order_id()));
        $this->addElement($Order, false);

        $order_type   = new XoopsFormElementTray(_AM_MARTIN_PREDETERMINED_MANNER);
        $orderIniType = $this->Obj->order_type();
        $order_type->addElement(new XoopsFormElementTray($this->OrderType[$orderIniType]));
        $this->addElement($order_type, false);

        $order_status  = new XoopsFormElementTray(_AM_MARTIN_ORDER_STATUS);
        $StatusElement = new XoopsFormSelect(_AM_MARTIN_CURRENT_CONDITION . ':' . $this->OrderStatus[$this->Obj->order_status()] . '<br>', 'order_status', $this->Obj->order_status(), 1);
        $StatusElement->addOptionArray($this->OrderStatus);
        $order_status->addElement($StatusElement, false);

        if ($qrooms = $this->Obj->qrooms) {
            $orderqrooms = '<br><br>';
            foreach ($qrooms as $room) {
                $orderqrooms .= $orderqroomsPrefix . _AM_MARTIN_HOTEL_NAME . ': <a href="martin.hotel.php?action=add&id=' . $room['hotel_id'] . '">' . $room['hotel_name'] . '</a> &nbsp;';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $orderqrooms .= _AM_MARTIN_ROOM_COUNT . ': <a href="martin.room.php?action=add&id=' . $room['room_id'] . '">' . $room['room_name'] . '</a> &nbsp;';
                $orderqrooms .= _AM_MARTIN_THE_NUMBER_OF_ROOMS . ': <b>' . $room['room_count'] . '</b>&nbsp;';
                $orderqrooms .= _AM_MARTIN_RESERVATION_TIME . ': <b>' . date('Y-m-d', $room['room_date']) . '</b>&nbsp;';
                $orderqrooms .= _AM_MARTIN_PRICE_SETTING . ' : <input type="text" name="room_price[' . $room['room_id'] . '-' . $room['room_date'] . ']" value= ' . $room['room_price'] . '>&nbsp;';
                $orderqroomsPrefix = '<br><br>';
            }
        }

        //$orderqrooms .= '<br><br><input type="button" value="'._AM_MARTIN_SAVE_PRICE.'">';


        $order_status->addElement(new XoopsFormElementTray($orderqrooms));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        $this->addElement($order_status, false);

        $order_pay_method = new XoopsFormElementTray(_AM_MARTIN_PAYMENT_ORDER);
        $order_pay_method->addElement(new XoopsFormElementTray($this->OrderPayMethod[$this->Obj->order_pay_method()]));
        $this->addElement($order_pay_method, false);

        $order_total_price = new XoopsFormElementTray(_AM_MARTIN_THE_TOTAL_AMOUNT_OF_ORDERS);
        $order_total_price->addElement(new XoopsFormElementTray($this->Obj->order_total_price()));
        $this->addElement($order_total_price, false);

        $order_pay_money = new XoopsFormElementTray(_AM_MARTIN_THE_ACTUAL_PAYMENT_AMOUNT);
        $order_pay_money->addElement(new XoopsFormElementTray($this->Obj->order_pay_money()));
        $this->addElement($order_pay_money, false);

        $order_coupon = new XoopsFormElementTray(_AM_MARTIN_CASH_VOLUME_PAYMENT_AMOUNT);
        $order_coupon->addElement(new XoopsFormElementTray($this->Obj->order_coupon()));
        $this->addElement($order_coupon, false);

        $order_sented_coupon = new XoopsFormElementTray(_AM_MARTIN_GET_MONEY);
        $order_sented_coupon->addElement(new XoopsFormElementTray($this->Obj->order_sented_coupon()));
        $this->addElement($order_sented_coupon, false);

        $order_mode = new XoopsFormElementTray(_AM_MARTIN_ORDER_MODE);
        $order_mode->addElement(new XoopsFormElementTray('<a href=' . XOOPS_URL . '/userinfo.php?uid=' . $this->Obj->order_uid() . '>' . $this->Obj->uname() . '</a>'));
        $this->addElement($order_mode, false);

        $order_real_name = new XoopsFormElementTray(_AM_MARTIN_ACTUAL_NAME);
        $order_real_name->addElement(new XoopsFormElementTray($this->Obj->order_real_name()));
        $this->addElement($order_real_name, false);

        $order_document_type = new XoopsFormElementTray(_AM_MARTIN_CERTIFICATION_TYPE);
        $order_document_type->addElement(new XoopsFormElementTray($this->OrderDocumentType[$this->Obj->order_document_type()]));
        $this->addElement($order_document_type, false);

        $order_document = new XoopsFormElementTray(_AM_MARTIN_CREDENTIALS);
        $order_document->addElement(new XoopsFormElementTray($this->Obj->order_document()));
        $this->addElement($order_document, false);

        $order_phone = new XoopsFormElementTray(_AM_MARTIN_PHONE);
        $order_phone->addElement(new XoopsFormElementTray($this->Obj->order_phone()));
        $this->addElement($order_phone, false);

        $order_telephone = new XoopsFormElementTray(_AM_MARTIN_PHONE);
        $order_telephone->addElement(new XoopsFormElementTray($this->Obj->order_telephone()));
        $this->addElement($order_telephone, false);

        $extraPersons = $this->Obj->order_extra_persons();
        if (is_array($extraPersons)) {
            var_dump($extraPersons);

        }
        $order_extra_persons = new XoopsFormElementTray(_AM_MARTIN_INCIDENTAL_PERSONNEL_INFORMATION);
        $order_extra_persons->addElement(new XoopsFormElementTray($$extraPersons));
        $this->addElement($order_extra_persons, false);

        $order_note = new XoopsFormElementTray(_AM_MARTIN_ORDER_NOTES);
        $order_note->addElement(new XoopsFormElementTray($this->Obj->order_note()));
        $this->addElement($order_note, false);

        $order_status_time = new XoopsFormElementTray(_AM_MARTIN_ORDERS_LAST_MODIFIED);
        $order_status_time->addElement(new XoopsFormElementTray(date('Y-m-d H:i:s', $this->Obj->order_status_time())));
        $this->addElement($order_status_time, false);

        $order_submit_time = new XoopsFormElementTray(_AM_MARTIN_ORDER_SUBMISSION_TIME);
        $order_submit_time->addElement(new XoopsFormElementTray(date('Y-m-d H:i;s', $this->Obj->order_submit_time())));
        $this->addElement($order_submit_time, false);

        $orderrooms = '';
        if ($rooms = $this->Obj->rooms) {
            foreach ($rooms as $room) {
                $orderrooms .= $orderroomsPrefix . _AM_MARTIN_HOTEL_NAME . ': <a href="martin.hotel.php?action=add&id=' . $room['hotel_id'] . '">' . $room['hotel_name'] . '</a> &nbsp;';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $orderrooms .= _AM_MARTIN_ROOM_COUNT . ': <a href="martin.room.php?action=add&id=' . $room['room_id'] . '">' . $room['room_name'] . '</a> &nbsp;';
                $orderrooms .= _AM_MARTIN_THE_NUMBER_OF_ROOMS . ': <b>' . $room['room_count'] . '</b>&nbsp;';
                $orderrooms .= _AM_MARTIN_RESERVATION_TIME . ': <b>' . date('Y-m-d', $room['room_date']) . '</b>&nbsp;';
                $orderrooms .= _AM_MARTIN_PRICE . ': <b>' . $room['room_price'] . '</b>&nbsp;';
                $orderroomsPrefix = '<br>';
            }
        }
        $order_rooms = new XoopsFormElementTray(_AM_MARTIN_ORDER_ROOM_INFORMATION);
        $order_rooms->addElement(new XoopsFormElementTray($orderrooms));
        $this->addElement($order_rooms, false);

        /*$this->addElement( new XoopsFormText('酒店排序', 'hotel_rank', 11, 11, $this->Obj->hotel_rank()), true);


        $this->addElement( new XoopsFormText(_AM_MARTIN_HOTEL_NAME, 'hotel_name', 50, 255, $this->Obj->hotel_name()), true);

        $this->addElement( new XoopsFormText('酒店英文名称', 'hotel_enname', 50, 255, $this->Obj->hotel_enname()), true);

        $this->addElement( new XoopsFormText('酒店别名', 'hotel_alias', 50, 255, $this->Obj->hotel_alias()), true);

        $this->addElement( new XoopsFormText(_AM_MARTIN_HOTEL_KEYWORDS_SEO, 'hotel_keywords', 50, 255, $this->Obj->hotel_keywords()), true);
        
        $this->addElement( new XoopsFormTextArea(_AM_MARTIN_HOTEL_DESC_SEO, 'hotel_description', $this->Obj->hotel_description()) , true);
        
        //hotel star
        $rankElement = new XoopsFormSelect(_AM_MARTIN_HOTEL_STARS, 'hotel_star', $this->Obj->hotel_star() , 1 );
        $rankElement->addOptionArray($this->Ranks);
        $this->addElement($rankElement , true);

        $this->addElement( new XoopsFormText('酒店地址', 'hotel_address', 50, 255, $this->Obj->hotel_address()), true);
        
        $this->addElement( new XoopsFormText('酒店电话', 'hotel_telephone', 50, 255, $this->Obj->hotel_telephone()), true);
        
        $this->addElement( new XoopsFormText('酒店 FAX', 'hotel_fax', 50, 255, $this->Obj->hotel_fax()), true);
        
        $this->addElement( new XoopsFormText('酒店特色', 'hotel_characteristic', 50, 255, $this->Obj->hotel_characteristic()), true);
        
        $this->addElement( new XoopsFormText('酒店房间数', 'hotel_room_count', 11, 11, $this->Obj->hotel_room_count()), true);
        
        //$this->addElement( new XoopsFormText(_AM_MARTIN_HOTEL_ROOM_PHOTOS, 'hotel_image', 50, 255, $this->Obj->hotel_image()), true);
        
        //特殊处理
        //酒店地图
        $Coordinate = $this->Obj->hotel_google();
        $google = new XoopsFormElementTray('google 地图'); 
        $google->addElement(new XoopsFormText('纬度', 'GmapLatitude', 25, 25, $Coordinate[0]), true);
        $google->addElement(new XoopsFormText('经度', 'GmapLongitude', 25, 25, $Coordinate[1]), true);
        $google->addElement(new XoopsFormLabel("<br><br><font style='background-color:#2F5376;color:#FFFFFF;padding:2px;vertical-align:middle;'>google map:</font><br>", $this->googleMap($Coordinate) ));
        
        //酒店图片
        $Img = new XoopsFormElementTray('酒店图片'); 
        $Img->addElement(new XoopsFormLabel("", $this->Swfupload() ));

        $this->addElement($Img);
        $this->addElement($google , true);
        //特殊处理
        
        //编辑器 酒店详细信息
        $this->addElement( new XoopsFormTextArea('酒店特别提醒', 'hotel_reminded', $this->Obj->hotel_reminded()) , true);
        $editor = 'tinymce';
        $hotel_info = $this->Obj->hotel_info();
        $editor_configs = array();
        $editor_configs["name"] ="hotel_info";
        $editor_configs["value"] = $hotel_info;
        $editor_configs["rows"] = empty($xoopsModuleConfig["editor_rows"])? 35 : $xoopsModuleConfig["editor_rows"];
        $editor_configs["cols"] = empty($xoopsModuleConfig["editor_cols"])? 60 : $xoopsModuleConfig["editor_cols"];
        $editor_configs["width"] = empty($xoopsModuleConfig["editor_width"])? "100%" : $xoopsModuleConfig["editor_width"];
        $editor_configs["height"] = empty($xoopsModuleConfig["editor_height"])? "400px" : $xoopsModuleConfig["editor_height"];

        $this->addElement(new XoopsFormEditor("酒店详细信息", $editor, $editor_configs, false, $onfailure = null) , false);
        //$this->addElement(new XoopsFormHidden("hotel_info", $hotel_info) , true );
        
        $this->addElement( new XoopsFormRadioYN("酒店编辑状态", 'hotel_status', $this->Obj->hotel_status(), _AM_MARTIN_PUBLISHED, _AM_MARTIN_DRAFT) , true);
        $this->addElement( new MartinFormDateTime("酒店发布时间", 'hotel_open_time', $size = 15, $this->Obj->hotel_open_time() ) ,true);*/

        $this->addElement(new XoopsFormHidden('id', $this->Obj->order_id()));
    }

    /**
     * @创建按钮
     * @license   http://www.blags.org/
     * @created   :2010年05月20日 23时52分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <[email protected]>
     * */
    public function createButtons()

    {
        $button_tray = new XoopsFormElementTray('', '');
        // No ID for category -- then it's new category, button says 'Create'
        if (!$this->Obj->order_id()) {
            $butt_create = new XoopsFormButton('', '', _SUBMIT, 'submit');
            $butt_create->setExtra('onclick="this.form.elements.op.value=\'addcategory\'"');
            $button_tray->addElement($butt_create);

            $butt_clear = new XoopsFormButton('', '', _RESET, 'reset');
            $button_tray->addElement($butt_clear);

            $butt_cancel = new XoopsFormButton('', '', _CANCEL, 'button');
            $butt_cancel->setExtra('onclick="history.go(-1)"');
            $button_tray->addElement($butt_cancel);

            $this->addElement($button_tray);
        } else {
            // button says 'Update'
            $butt_create = new XoopsFormButton('', '', _EDIT, 'submit');
            $butt_create->setExtra('onclick="this.form.elements.op.value=\'addcategory\'"');
            $button_tray->addElement($butt_create);

            $butt_clear = new XoopsFormButton('', '', _RESET, 'reset');
            $button_tray->addElement($butt_clear);

            $butt_cancel = new XoopsFormButton('', '', _CANCEL, 'button');
            $butt_cancel->setExtra('onclick="history.go(-1)"');
            $button_tray->addElement($butt_cancel);

            $this->addElement($button_tray);
        }
    }

    /**
     * @google    地图
     * @license   http://www.blags.org/
     * @created   :2010年05月24日 19时55分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <[email protected]>
     * @param $Coordinate
     */
    public function googleMap($Coordinate)
    {
    }

    /**
     * swf 多图片上传
     * @license   http://www.blags.org/
     * @created   :2010年05月24日 19时55分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <[email protected]>
     * */
    public function Swfupload()
    {
    }
}


Push — master ( 5be1c3...395766 )

form_order::__construct() A

Complexity

Size

Duplication

Available Fixes

Available Fixes

Available Fixes

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 18 and the first side effect is on line 10. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* @酒店表单
4			* @license http://www.blags.org/
5			* @created :2010年05月20日 23时52分
6			* @copyright 1997-2010 The Martin Group
7			* @author Martin <[email protected]>
8			* */
9			if (!defined('XOOPS_ROOT_PATH')) {
10			return;
11			}
12
13			include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
14
15			/**
16			* Class form_order
17			*/
18			class form_order extends XoopsThemeForm
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
19			{
20			/**
21			* form_order constructor.
22			* @param $OrderObj
23			*/
24			public function __construct(&$OrderObj)
25			{
26			//array
27			$this->OrderType = getModuleArray('order_type', 'order_type', true);
28			$this->OrderMode = getModuleArray('order_mode', 'order_mode', true);
29			$this->OrderPayMethod = getModuleArray('order_pay_method', 'order_pay_method', true);
30			$this->OrderStatus = getModuleArray('order_status', 'order_status', true);
31			$this->OrderDocumentType = getModuleArray('order_document_type', 'order_document_type', true);
32
33			//print_r($this->OrderStatus);exit;
			0 ignored issues – show Unused Code Comprehensibility introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report `78%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
34
35			$this->Obj = &$OrderObj;
36			parent::__construct(_AM_MARTIN_ORDER_INFORMATION, "op", xoops_getenv('PHP_SELF') . "?action=save");
37			$this->setExtra('enctype="multipart/form-data"');

mambax7 / xoops-martin

Push — master ( 5be1c3...395766 )

form_order::__construct() A

Complexity

Size

Duplication

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like