MartinHotelPromotionHandler::insert() - Code Metrics - Inspection of "Few more language conversions, plus few files from..." - mambax7/xoops-martin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5be1c3...395766 )

by Michael

created 2015-12-30 17:50 UTC

MartinHotelPromotionHandler::insert() C

↳ Parent: MartinHotelPromotionHandler

Complexity

Conditions	7
Paths	18

Size

Total Lines	43
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	43
rs	6.7273
cc	7
eloc	18
nc	18
nop	2

<?php

/**
 * $Id: promotion.php,v 1.42 2007/02/04 15:01:40 malanciault Exp $
 * Module:martin
 * Licence: GNU
 */

if (!defined("XOOPS_ROOT_PATH")) {
    die("XOOPS root path not defined");
}

include_once XOOPS_ROOT_PATH . '/modules/martin/include/common.php';

/**
 * Class MartinHotelPromotion
 */
class MartinHotelPromotion extends XoopsObject
namespace YourVendor;

class YourClass { }
{
    public function MartinHotelPromotion()

    {
        $this->initVar("promotion_id", XOBJ_DTYPE_INT, null, false);
        $this->initVar("hotel_id", XOBJ_DTYPE_INT, null, false);
        $this->initVar("hotel_name", XOBJ_DTYPE_TXTBOX, null, true, 255);
        $this->initVar("promotion_start_date", XOBJ_DTYPE_INT, null, false);
        $this->initVar("promotion_end_date", XOBJ_DTYPE_INT, null, false);
        $this->initVar("promotion_description", XOBJ_DTYPE_TXTAREA, null, false);
        $this->initVar("promotion_add_time", XOBJ_DTYPE_INT, null, false);
    }

    /**
     * @return mixed
     */
    public function promotion_id()
    {
        return $this->getVar("promotion_id");
    }

    /**
     * @return mixed
     */
    public function hotel_id()
    {
        return $this->getVar("hotel_id");
    }

    /**
     * @return mixed
     */
    public function hotel_name()
    {
        return $this->getVar("hotel_name");
    }

    /**
     * @return mixed
     */
    public function promotion_start_date()
    {
        return $this->getVar("promotion_start_date");
    }

    /**
     * @return mixed
     */
    public function promotion_end_date()
    {
        return $this->getVar("promotion_end_date");
    }

    /**
     * @param string $format
     * @return mixed
     */
    public function promotion_description($format = 'edit')
    {
        return $this->getVar("promotion_description", $format);
    }

    /**
     * @return mixed
     */
    public function promotion_add_time()
    {
        return $this->getVar("promotion_add_time");
    }
}

/**
 * @method: MartinHotelPromotionHandler
 * @license   http://www.blags.org/
 * @created   :2010年05月21日 20时40分
 * @copyright 1997-2010 The Martin promotion
 * @author    Martin <[email protected]>
 * */
class MartinHotelPromotionHandler extends XoopsObjectHandler
namespace YourVendor;

class YourClass { }
{
    /**
     * create a new hotel city
     * @param bool $isNew flag the new objects as "new"?
     * @return object promotion
     */
    public function &create($isNew = true)
    {
        $promotion = new MartinHotelPromotion();
        if ($isNew) {
            $promotion->setNew();
        }

        return $promotion;
    }

    /**
     * retrieve a hotel city
     *
     * @param int $id promotionid of the hotel promotion
     * @return mixed reference to the {@link promotion} object, FALSE if failed
     */
    public function &get($id)

    {
        if ((int)($id) <= 0) {
            return false;
        }

        $criteria = new CriteriaCompo(new Criteria('promotion_id', $id));
        $criteria->setLimit(1);
        $obj_array =& $this->getObjects($criteria);
        if (count($obj_array) != 1) {
            $obj =& $this->create();

            return $obj;
        }

        return $obj_array[0];
    }

    /**
     * @得到列表
     * @method:
     * @license   http://www.blags.org/
     * @created   :2010年05月23日 14时59分
     * @copyright 1997-2010 The Martin promotion
     * @author    Martin <[email protected]>
     * @param int    $limit
     * @param int    $start
     * @param string $sort
     * @param string $order
     * @param bool   $id_as_key
     * @return array
     */
    public function &getPromotions($limit = 0, $start = 0, $sort = 'promotion_add_time', $order = 'DESC', $id_as_key = true)

    {
        $criteria = new CriteriaCompo();

        $criteria->setSort($sort);
        $criteria->setOrder($order);

        $criteria->setStart($start);
        $criteria->setLimit($limit);

        return $this->getObjects($criteria, $id_as_key);
    }

    /**
     * insert a new promotion in the database
     *
     * @param object $promotion reference to the {@link hotel promotion} object
     * @param bool   $force
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */
    public function insert(&$promotion, $force = false)
    {
        if (strtolower(get_class($promotion)) !== 'martinhotelpromotion') {
            return false;
        }

        if (!$promotion->cleanVars()) {
            return false;
        }

        foreach ($promotion->cleanVars as $k => $v) {
            ${$k} = $v;
        }

        if ($promotion->isNew()) {
            $sql = sprintf("INSERT INTO %s (
                                promotion_id,
                                promotion_description,
                                hotel_id,
                                promotion_start_date,
                                promotion_end_date,
                                promotion_add_time
                            ) VALUES (
                                NULL,
                                %s,%u,%u,%u,%u
                            )", $this->db->prefix('martin_hotel_promotions'), $this->db->quoteString($promotion_description), $hotel_id, $promotion_start_date, $promotion_end_date, $promotion_add_time);

        } else {
            $sql = sprintf("UPDATE %s SET
                                promotion_description = %s,
                                hotel_id = %u,
                                promotion_start_date = %u,
                                promotion_end_date = %u
                            WHERE promotion_id = %u", $this->db->prefix('martin_hotel_promotions'), $this->db->quoteString($promotion_description), $hotel_id, $promotion_start_date, $promotion_end_date, $promotion_id);

        }
        //echo $sql;exit;

        if (false != $force) {

            $result = $this->db->queryF($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
            $result = $this->db->query($sql);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        return $promotion_id > 0 ? $promotion_id : $this->db->getInsertId();

    }

    /**
     * @删除一个城市
     * @method:delete(promotion_id)
     * @license   http://www.blags.org/
     * @created   :2010年05月21日 20时40分
     * @copyright 1997-2010 The Martin promotion
     * @author    Martin <[email protected]>
     * @param object $promotion
     * @param bool   $force
     * @return bool|void
     */
    public function delete(&$promotion, $force = false)

    {
        if (strtolower(get_class($promotion)) !== 'martinhotelpromotion') {
            return false;
        }

        $sql = "DELETE FROM " . $this->db->prefix("martin_hotel_promotions") . " WHERE promotion_id = " . $promotion->promotion_id();

        if (false != $force) {

            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }

        if (!$result) {
            return false;
        }

        return true;
    }

    /**
     * delete hotel cities matching a set of conditions
     *
     * @param object $criteria {@link CriteriaElement}

     * @return bool FALSE if deletion failed
     */
    public function deleteAll($criteria = null)

    {
        $sql = 'DELETE FROM ' . $this->db->prefix('martin_hotel_promotions');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {
            return false;
        }

        return true;
    }

    /**
     * count hotel cities matching a condition
     *
     * @param object $criteria {@link CriteriaElement} to match

     * @return int count of categories
     */
    public function getCount($criteria = null)

    {
        $sql = 'SELECT COUNT(*) FROM ' . $this->db->prefix('martin_hotel_promotions');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

            $sql .= ' ' . $criteria->renderWhere();
        }
        $result = $this->db->query($sql);
        if (!$result) {
            return 0;
        }
        list($count) = $this->db->fetchRow($result);

        return $count;
    }

    /**
     * @得到城市
     * @license   http://www.blags.org/
     * @created   :2010年05月21日 20时40分
     * @copyright 1997-2010 The Martin promotion
     * @author    Martin <[email protected]>
     * @param null $criteria
     * @param bool $id_as_key
     * @return array
     */
    public function &getObjects($criteria = null, $id_as_key = false)
    {
        $ret   = array();
        $limit = $start = 0;
        $sql   = 'SELECT p.*,h.hotel_name FROM ' . $this->db->prefix('martin_hotel_promotions') . ' p ';
        $sql .= ' left join ' . $this->db->prefix('martin_hotel') . ' h on ( h.hotel_id = p.hotel_id ) ';
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
            $limit = $criteria->getLimit();
            $start = $criteria->getStart();
        }
        $sql .= " order by p.promotion_id DESC ";
        //echo "<br />" . $sql . "<br />";

        $result = $this->db->query($sql, $limit, $start);

        if (!$result) {
            return $ret;
        }

        $theObjects = array();

        while ($myrow = $this->db->fetchArray($result)) {
            $promotion = new MartinHotelPromotion();
            $promotion->assignVars($myrow);
            $theObjects[$myrow['promotion_id']] =& $promotion;
            //var_dump($promotion);
            unset($promotion);
        }
        //var_dump($theObjects);

        foreach ($theObjects as $theObject) {
            if (!$id_as_key) {
                $ret[] =& $theObject;
            } else {
                $ret[$theObject->promotion_id()] =& $theObject;
            }
            unset($theObject);
        }

        return $ret;
    }

    /**
     * @get       hotel promotion
     * @license   http://www.blags.org/
     * @created   :2010年06月14日 20时47分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <[email protected]>
     * @param $hotel_id
     * @return string
     */
    public function getHotelPromotion($hotel_id)
    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        if (!$hotel_id > 0) {
            return '';
        }
        $sql = 'SELECT * FROM ' . $xoopsDB->prefix('martin_hotel_promotions') . ' WHERE
            ' . time() . ' BETWEEN  promotion_start_date AND promotion_end_date  AND hotel_id = ' . $hotel_id . '  limit 1 ';

        return $xoopsDB->fetchArray($xoopsDB->query($sql));
    }
}


Push — master ( 5be1c3...395766 )

MartinHotelPromotionHandler::insert() C

Complexity

Size

Duplication

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-30 17:55 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 17 and the first side effect is on line 9. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* $Id: promotion.php,v 1.42 2007/02/04 15:01:40 malanciault Exp $
4			* Module:martin
5			* Licence: GNU
6			*/
7
8			if (!defined("XOOPS_ROOT_PATH")) {
9			die("XOOPS root path not defined");
10			}
11
12			include_once XOOPS_ROOT_PATH . '/modules/martin/include/common.php';
13
14			/**
15			* Class MartinHotelPromotion
16			*/
17			class MartinHotelPromotion extends XoopsObject
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
18			{
19			public function MartinHotelPromotion()
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Please use `__construct()` instead of a PHP4-style constructor that is named after the class. Loading history...
20			{
21			$this->initVar("promotion_id", XOBJ_DTYPE_INT, null, false);
22			$this->initVar("hotel_id", XOBJ_DTYPE_INT, null, false);
23			$this->initVar("hotel_name", XOBJ_DTYPE_TXTBOX, null, true, 255);
24			$this->initVar("promotion_start_date", XOBJ_DTYPE_INT, null, false);
25			$this->initVar("promotion_end_date", XOBJ_DTYPE_INT, null, false);
26			$this->initVar("promotion_description", XOBJ_DTYPE_TXTAREA, null, false);
27			$this->initVar("promotion_add_time", XOBJ_DTYPE_INT, null, false);
28			}
29
30			/**
31			* @return mixed
32			*/
33			public function promotion_id()
34			{
35			return $this->getVar("promotion_id");
36			}
37

mambax7 / xoops-martin

Push — master ( 5be1c3...395766 )

MartinHotelPromotionHandler::insert() C

Complexity

Size

Duplication

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like