MartinReviewHandler - Code Metrics - Inspection of "some more changes from 7mogjl" - mambax7/xoops-martin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 395766...48e7d6 )

by Michael

created 2015-12-30 17:54 UTC

MartinReviewHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	103
Duplicated Lines	6.8 %

Coupling/Cohesion

Components	0
Dependencies	1

Metric	Value
wmc	10
lcom	0
cbo	1
dl	7
loc	103
rs	10

5 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	6	1
B	SaveReview()	0	22	6
A	CheckReviewExist()	7	7	1
A	GetReview()	0	8	1
A	GetHotelReview()	0	12	1

How to fix Duplicated Code

<?php

/**
 *
 * @access    public
 * @return void
 * @copyright 1997-2010 The Lap Group
 * @author    Martin <[email protected]>
 * @created   time :2010-07-22 16:27:07
 * */
class MartinReview extends XoopsObject
namespace YourVendor;

class YourClass { }
{
}

/**
 *
 * @access    public
 * @return void
 * @copyright 1997-2010 The Lap Group
 * @author    Martin <[email protected]>
 * @created   time :2010-07-22 16:27:25
 * */
class MartinReviewHandler extends XoopsObjectHandler
namespace YourVendor;

class YourClass { }
{
    /**
     * @create    cart object
     * @license   http://www.blags.org/
     * @created   :2010年07月04日 12时59分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <[email protected]>
     * */
    public function &create()
    {
        $obj =& new MartinReview;

        return $obj;
    }

    /**
     * insert review for hotel
     * @access    public
     * @param $Data
     * @copyright 1997-2010 The Lap Group
     * @author    Martin <[email protected]>
     * @created   time :2010-07-22 16:28:18
     */
    public function SaveReview($Data)

    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        if (!$Data) {
            return $Data;
        }
        $table = $xoopsDB->prefix('martin_user_review');
        $exist = $this->CheckReviewExist($Data['hotel_id'], $Data['uid']);
        if (is_array($Data)) {
            foreach ($Data as $key => $value) {
                $v .= $prefix . $value;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $k .= $prefix . $key;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $updateStr .= $prefix . "$key = $value";
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                $prefix = ',';
            }
        }
        $sql = $exist ? "UPDATE $table SET %s WHERE hotel_id = {$Data['hotel_id']} AND uid = {$Data['uid']}" : "INSERT INTO $table (%s) VALUES (%s)";
        $sql = $exist ? sprintf($sql, $updateStr) : sprintf($sql, $k, $v);

        //echo $sql;
        return $xoopsDB->query($sql);
    }

    /**
     *
     * @access    public
     * @param $hotel_id
     * @param $uid
     * @return bool
     * @copyright 1997-2010 The Lap Group
     * @author    Martin <[email protected]>
     * @created   time :2010-07-22 16:43:23
     */
    public function CheckReviewExist($hotel_id, $uid)

    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        $sql = "SELECT * FROM {$xoopsDB->prefix('martin_user_review')} WHERE hotel_id = $hotel_id AND uid = $uid ";

        return is_array($xoopsDB->fetchArray($xoopsDB->query($sql)));
    }

    /**
     *
     * @access    public
     * @param $hotel_id
     * @copyright 1997-2010 The Lap Group
     * @author    Martin <[email protected]>
     * @created   time :2010-07-22 16:49:41
     */
    public function GetReview($hotel_id)

    {
        global $xoopsDB, $xoopsUser;
function myFunction($a, $b) {
    // Do something
}
        $uid = $xoopsUser->uid();
        $sql = "SELECT * FROM {$xoopsDB->prefix('martin_user_review')} WHERE hotel_id = $hotel_id AND uid = $uid ";

        return $xoopsDB->fetchArray($xoopsDB->query($sql));
    }

    /**
     * get hotel review
     * @access    public
     * @param $hotel_id
     * @copyright 1997-2010 The Lap Group
     * @author    Martin <[email protected]>
     * @created   time :2010-07-22 17:03:32
     */
    public function GetHotelReview($hotel_id)
    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
        $table                  = $xoopsDB->prefix('martin_user_review');
        $sql                    = "SELECT avg(review_type_avg) as review_type_avg , count(uid) as count FROM $table WHERE hotel_id = $hotel_id GROUP BY hotel_id ";
        $row                    = ($xoopsDB->fetchArray($xoopsDB->query($sql)));
        $row['review_type_avg'] = round($row['review_type_avg'], 2);
        $row['score']           = (int)(($row['review_type_avg'] / 5) * 100);

        //var_dump($row);
        return $row;
    }
}


Push — master ( 395766...48e7d6 )

MartinReviewHandler A

Complexity

Size/Duplication

Coupling/Cohesion

5 Methods

How to fix Duplicated Code

Duplicated Code

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2
3		/**
4		*
5		* @access public
6		* @return void
7		* @copyright 1997-2010 The Lap Group
8		* @author Martin <[email protected]>
9		* @created time :2010-07-22 16:27:07
10		* */
11		class MartinReview extends XoopsObject
		0 ignored issues – show Coding Style Compatibility introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12		{
13		}
14
15		/**
16		*
17		* @access public
18		* @return void
19		* @copyright 1997-2010 The Lap Group
20		* @author Martin <[email protected]>
21		* @created time :2010-07-22 16:27:25
22		* */
23		class MartinReviewHandler extends XoopsObjectHandler
		0 ignored issues – show Coding Style Compatibility introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
24		{
25		/**
26		* @create cart object
27		* @license http://www.blags.org/
28		* @created :2010年07月04日 12时59分
29		* @copyright 1997-2010 The Martin Group
30		* @author Martin <[email protected]>
31		* */
32		public function &create()
33		{
34		$obj =& new MartinReview;
35
36		return $obj;
37		}
38
39		/**
40		* insert review for hotel
41		* @access public
42		* @param $Data
43		* @copyright 1997-2010 The Lap Group
44		* @author Martin <[email protected]>
45		* @created time :2010-07-22 16:28:18
46		*/
47		public function SaveReview($Data)
		0 ignored issues – show Documentation introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
48		{
49		global $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
50		if (!$Data) {
51		return $Data;
52		}
53		$table = $xoopsDB->prefix('martin_user_review');
54		$exist = $this->CheckReviewExist($Data['hotel_id'], $Data['uid']);
55		if (is_array($Data)) {
56		foreach ($Data as $key => $value) {
57		$v .= $prefix . $value;
		0 ignored issues – show Bug introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report The variable `$v` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report The variable `$prefix` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
58		$k .= $prefix . $key;
		0 ignored issues – show Bug introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report The variable `$k` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
59		$updateStr .= $prefix . "$key = $value";
		0 ignored issues – show Bug introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report The variable `$updateStr` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
60		$prefix = ',';
61		}
62		}
63		$sql = $exist ? "UPDATE $table SET %s WHERE hotel_id = {$Data['hotel_id']} AND uid = {$Data['uid']}" : "INSERT INTO $table (%s) VALUES (%s)";
64		$sql = $exist ? sprintf($sql, $updateStr) : sprintf($sql, $k, $v);
65
66		//echo $sql;
67		return $xoopsDB->query($sql);
68		}
69
70		/**
71		*
72		* @access public
73		* @param $hotel_id
74		* @param $uid
75		* @return bool
76		* @copyright 1997-2010 The Lap Group
77		* @author Martin <[email protected]>
78		* @created time :2010-07-22 16:43:23
79		*/
80	View Code Duplication	public function CheckReviewExist($hotel_id, $uid)
		0 ignored issues – show Duplication introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81		{
82		global $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
83		$sql = "SELECT * FROM {$xoopsDB->prefix('martin_user_review')} WHERE hotel_id = $hotel_id AND uid = $uid ";
84
85		return is_array($xoopsDB->fetchArray($xoopsDB->query($sql)));
86		}
87
88		/**
89		*
90		* @access public
91		* @param $hotel_id
92		* @copyright 1997-2010 The Lap Group
93		* @author Martin <[email protected]>
94		* @created time :2010-07-22 16:49:41
95		*/
96		public function GetReview($hotel_id)
		0 ignored issues – show Documentation introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
97		{
98		global $xoopsDB, $xoopsUser;
		0 ignored issues – show Compatibility Best Practice introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
99		$uid = $xoopsUser->uid();
100		$sql = "SELECT * FROM {$xoopsDB->prefix('martin_user_review')} WHERE hotel_id = $hotel_id AND uid = $uid ";
101
102		return $xoopsDB->fetchArray($xoopsDB->query($sql));
103		}
104
105		/**
106		* get hotel review
107		* @access public
108		* @param $hotel_id
109		* @copyright 1997-2010 The Lap Group
110		* @author Martin <[email protected]>
111		* @created time :2010-07-22 17:03:32
112		*/
113		public function GetHotelReview($hotel_id)
114		{
115		global $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2015-12-30 18:20 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
116		$table = $xoopsDB->prefix('martin_user_review');
117		$sql = "SELECT avg(review_type_avg) as review_type_avg , count(uid) as count FROM $table WHERE hotel_id = $hotel_id GROUP BY hotel_id ";
118		$row = ($xoopsDB->fetchArray($xoopsDB->query($sql)));
119		$row['review_type_avg'] = round($row['review_type_avg'], 2);
120		$row['score'] = (int)(($row['review_type_avg'] / 5) * 100);
121
122		//var_dump($row);
123		return $row;
124		}
125		}
126

mambax7 / xoops-martin

Push — master ( 395766...48e7d6 )

MartinReviewHandler A

Complexity

Size/Duplication

Coupling/Cohesion

5 Methods

How to fix Duplicated Code

Duplicated Code

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like