martin.hotel.city.php ➔ display() - Code Metrics - Inspection of "Remove pass-by-reference instances" - mambax7/xoops-martin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c40551...5ee518 )

by Michael

created 2017-05-24 05:37 UTC

martin.hotel.city.php ➔ display() B

↳ Parent: Project

Complexity

Conditions	4
Paths	4

Size

Total Lines	23
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	17
nc	4
nop	2
dl	0
loc	23
rs	8.7972
c	0
b	0
f	0

<?php

include_once __DIR__ . '/admin_header.php';
/*
 * 处理
 **/

//头部
include "martin.header.php";
$currentFile   = basename(__FILE__);
$myModuleAdmin = new ModuleAdmin();
echo $myModuleAdmin->addNavigation($currentFile);

//parameter 参数
$action        = isset($_POST['action']) ? $_POST['action'] : @$_GET['action'];
$action        = empty($action) ? 'list' : $action;
$action        = trim(strtolower($action));
$id            = !empty($_POST['id']) ? $_POST['id'] : @$_GET['id'];
$id            = (int)($id);
$start         = isset($_GET['start']) ? (int)($_GET['start']) : 0;
$city_parentid = isset($_GET['city_parentid']) ? (int)($_GET['city_parentid']) : 0;
//确认删除
$confirm = (isset($_POST['confirm'])) ? $_POST['confirm'] : 0;
//parameter 参数

// martin_adminMenu(5, "订房后台 > 城市管理");


$hotelcity_handler =& xoops_getmodulehandler('hotelcity', MARTIN_DIRNAME, true);

if ($id) {
    $HotelCityObj = $hotelcity_handler->get($id);
} else {
    $HotelCityObj = $hotelcity_handler->create();
}
//var_dump($HotelCityObj);

//var_dump($hotelcity_handler);
//var_dump($hotelcity_handler->city_name());

switch ($action) {
    case "add":

        include MARTIN_ROOT_PATH . 'include/form.hotel.city.php';
        martin_collapsableBar('createtable', 'createtableicon', _AM_MARTIN_ADD_HOTEL_CITY, _AM_MARTIN_ADD_HOTEL_CITY);
        //Create_button(array('addcity'=>array('url'=>'mconfirmartin.hotel.city.php?action=add','value'=>_AM_MARTIN_CITY_NAME)));

        $form = new form_hotel_city($HotelCityObj);

        $form->display();
        martin_close_collapsable('createtable', 'createtableicon');

        break;

    case "save":
        $city_alias    = isset($_POST['city_alias']) ? addslashes($_POST['city_alias']) : '';
        $city_parentid = isset($_POST['city_parentid']) ? (int)($_POST['city_parentid']) : 0;
        $city_alias    = $city_parentid ? '' : $city_alias;
        $HotelCityObj->setVar('city_id', $id);
        $HotelCityObj->setVar('city_parentid', $city_parentid);
        $HotelCityObj->setVar('city_name', (isset($_POST['city_name'])) ? addslashes($_POST['city_name']) : '');
        $HotelCityObj->setVar('city_alias', $city_alias);
        $HotelCityObj->setVar('city_level', 0);

        if (!$id) {
            $HotelCityObj->setNew();
        }

        if ($HotelCityObj->isNew()) {
            $redirect_msg = _AM_MARTIN_ADDED_SUCCESSFULLY;
            $redirect_to  = 'martin.hotel.city.php';
        } else {
            $redirect_msg = _AM_MARTIN_MODIFIED_SUCCESSFULLY;
            $redirect_to  = 'martin.hotel.city.php';
        }
        if (!$hotelcity_handler->insert($HotelCityObj)) {
            redirect_header('javascript:history.go(-1);', 2, _AM_MARTIN_OPERATION_FAILED);
            exit();
        }
        redirect_header($redirect_to, 2, $redirect_msg);
        break;
    case "del":

        if (!$confirm) {
            xoops_confirm(array('op' => 'del', 'id' => $HotelCityObj->city_id(), 'confirm' => 1, 'name' => $HotelCityObj->city_name()), '?action=del', _DELETE . " '" . $HotelCityObj->city_name() . "'. <br /> <br />"._AM_MARTIN_OK_TO_DELETE_THE_DISTRICTS, _DELETE);
        } else {
            if ($hotelcity_handler->delete($HotelCityObj)) {
                $redirect_msg = _AM_MARTIN_OK_TO_DELETE_THE_ORDER;
                $redirect_to  = "martin.hotel.city.php";
            } else {
                $redirect_msg = _AM_MARTIN_DELETE_FAILED;
                $redirect_to  = "javascript:history.go(-1);";
            }
            redirect_header($redirect_to, 2, $redirect_msg);
        }
        break;
    case "list":
        martin_collapsableBar('createtable', 'createtableicon', _AM_MARTIN_ADD_CITY, _AM_MARTIN_ADD_CITY);
        Create_button(array('addcity' => array('url' => 'martin.hotel.city.php?action=add', 'value' => _AM_MARTIN_CITY_NAME)));

        $HoteCityObjs = $hotelcity_handler->getHotelCitys($xoopsModuleConfig['perpage'], $start, 0);

        // Creating the objects for top categories
        echo "<br />\n<table width='100%' cellspacing=1 cellpadding=2 border=0 class = outer>";
        echo "<tr>";
        echo "<td class='bg3' align='left'><b>" . _AM_MARTIN_CITY_NAME . "</b></td>";
        echo "<td width='60' class='bg3' align='center'><b>" . _AM_MARTIN_ACTIONS . "</b></td>";
        echo "</tr>";
        $CityCout = $hotelcity_handler->getCount();
        if (count($HoteCityObjs) > 0) {
            foreach ($HoteCityObjs as $key => $thiscat) {
                display($thiscat);
            }
        } else {
            echo "<tr>";
            echo "<td class='head' align='center' colspan= '7'>" . MARTIN_IS_NUll . "</td>";
            echo "</tr>";
            $categoryid = '0';
        }
        echo "</table>\n";
        include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
        $pagenav = new XoopsPageNav($CityCout, $xoopsModuleConfig['perpage'], 0, 'start');
        echo '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>';
        echo "<br />";
        martin_close_collapsable('createtable', 'createtableicon');

        echo "<br>";

        break;
    default:
        redirect_header(XOOPS_URL, 2, _AM_MARTIN_UNAUTHORIZED_ACCESS);
        break;
}

/**
 * @param     $HotelCityObj
 * @param int $level
 */
function display($HotelCityObj, $level = 0)
{
    global $xoopsModule, $hotelcity_handler;
function myFunction($a, $b) {
    // Do something
}
    $modify = "<a href='?action=add&id=" . $HotelCityObj->city_id() . "&city_parentid=" . $HotelCityObj->city_parentid() . "'><img src='" . XOOPS_URL . "/modules/" . $xoopsModule->dirname() . "/images/icon/edit.gif'/></a>";
    $delete = "<a href='?action=del&id=" . $HotelCityObj->city_id() . "&city_parentid=" . $HotelCityObj->city_parentid() . "'><img src='" . XOOPS_URL . "/modules/" . $xoopsModule->dirname() . "/images/icon/delete.gif'/></a>";

    $spaces = '';
    for ($j = 0; $j < $level; $j++) {
        $spaces .= '&nbsp;&nbsp;&nbsp;';
    }
    echo "<tr>";
    echo "<td class='even' align='lefet'>" . $spaces . "<a href='" . XOOPS_URL . '/hotel/' . $HotelCityObj->city_alias() . "'><img src='" . XOOPS_URL . "/modules/martin/images/icon/subcat.gif' alt='' />&nbsp;" . $HotelCityObj->city_name() . "</a></td>";
    echo "<td class='even' align='center'> $modify $delete </td>";
    echo "</tr>";
    $subObj = $hotelcity_handler->getHotelCitys(0, 0, $HotelCityObj->city_id());
    if (count($subObj) > 0) {
        $level++;
        foreach ($subObj as $key => $thiscat) {
            display($thiscat, $level);
        }
    }
    unset($HotelCityObj);
}

//底部
include_once __DIR__ . '/admin_footer.php';


1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2017-05-24 05:40 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 131 and the first side effect is on line 2. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		include_once __DIR__ . '/admin_header.php';
3		/*
4		* 处理
5		**/
6
7		//头部
8		include "martin.header.php";
9		$currentFile = basename(__FILE__);
10		$myModuleAdmin = new ModuleAdmin();
11		echo $myModuleAdmin->addNavigation($currentFile);
12
13		//parameter 参数
14		$action = isset($_POST['action']) ? $_POST['action'] : @$_GET['action'];
15		$action = empty($action) ? 'list' : $action;
16		$action = trim(strtolower($action));
17		$id = !empty($_POST['id']) ? $_POST['id'] : @$_GET['id'];
18		$id = (int)($id);
19		$start = isset($_GET['start']) ? (int)($_GET['start']) : 0;
20		$city_parentid = isset($_GET['city_parentid']) ? (int)($_GET['city_parentid']) : 0;
21		//确认删除
22		$confirm = (isset($_POST['confirm'])) ? $_POST['confirm'] : 0;
23		//parameter 参数
24
25		// martin_adminMenu(5, "订房后台 > 城市管理");
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 05:40 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26
27		$hotelcity_handler =& xoops_getmodulehandler('hotelcity', MARTIN_DIRNAME, true);
28
29		if ($id) {
30		$HotelCityObj = $hotelcity_handler->get($id);
31		} else {
32		$HotelCityObj = $hotelcity_handler->create();
33		}
34		//var_dump($HotelCityObj);
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 05:40 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
35		//var_dump($hotelcity_handler);
36		//var_dump($hotelcity_handler->city_name());
37
38		switch ($action) {
39	View Code Duplication	case "add":
		0 ignored issues – show Duplication introduced 2016-01-18 08:08 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		include MARTIN_ROOT_PATH . 'include/form.hotel.city.php';
41		martin_collapsableBar('createtable', 'createtableicon', _AM_MARTIN_ADD_HOTEL_CITY, _AM_MARTIN_ADD_HOTEL_CITY);
42		//Create_button(array('addcity'=>array('url'=>'mconfirmartin.hotel.city.php?action=add','value'=>_AM_MARTIN_CITY_NAME)));
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 05:40 UTC by Report Bug Copy Issue Report `85%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
43		$form = new form_hotel_city($HotelCityObj);
44
45		$form->display();
46		martin_close_collapsable('createtable', 'createtableicon');
		0 ignored issues – show Unused Code introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report The call to the function `martin_close_collapsable()` seems unnecessary as the function has no side-effects. Loading history...
47		break;
48
49		case "save":
50		$city_alias = isset($_POST['city_alias']) ? addslashes($_POST['city_alias']) : '';
51		$city_parentid = isset($_POST['city_parentid']) ? (int)($_POST['city_parentid']) : 0;
52		$city_alias = $city_parentid ? '' : $city_alias;
53		$HotelCityObj->setVar('city_id', $id);
54		$HotelCityObj->setVar('city_parentid', $city_parentid);
55		$HotelCityObj->setVar('city_name', (isset($_POST['city_name'])) ? addslashes($_POST['city_name']) : '');
56		$HotelCityObj->setVar('city_alias', $city_alias);
57		$HotelCityObj->setVar('city_level', 0);
58
59		if (!$id) {
60		$HotelCityObj->setNew();
61		}
62
63		if ($HotelCityObj->isNew()) {
64		$redirect_msg = _AM_MARTIN_ADDED_SUCCESSFULLY;
65		$redirect_to = 'martin.hotel.city.php';
66		} else {
67		$redirect_msg = _AM_MARTIN_MODIFIED_SUCCESSFULLY;
68		$redirect_to = 'martin.hotel.city.php';
69		}
70		if (!$hotelcity_handler->insert($HotelCityObj)) {
71		redirect_header('javascript:history.go(-1);', 2, _AM_MARTIN_OPERATION_FAILED);
72		exit();
73		}
74		redirect_header($redirect_to, 2, $redirect_msg);
75		break;
76	View Code Duplication	case "del":
		0 ignored issues – show Duplication introduced 2016-01-18 08:08 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		if (!$confirm) {
78		xoops_confirm(array('op' => 'del', 'id' => $HotelCityObj->city_id(), 'confirm' => 1, 'name' => $HotelCityObj->city_name()), '?action=del', _DELETE . " '" . $HotelCityObj->city_name() . "'. <br /> <br />"._AM_MARTIN_OK_TO_DELETE_THE_DISTRICTS, _DELETE);
79		} else {
80		if ($hotelcity_handler->delete($HotelCityObj)) {
81		$redirect_msg = _AM_MARTIN_OK_TO_DELETE_THE_ORDER;
82		$redirect_to = "martin.hotel.city.php";
83		} else {
84		$redirect_msg = _AM_MARTIN_DELETE_FAILED;
85		$redirect_to = "javascript:history.go(-1);";
86		}
87		redirect_header($redirect_to, 2, $redirect_msg);
88		}
89		break;
90		case "list":
91		martin_collapsableBar('createtable', 'createtableicon', _AM_MARTIN_ADD_CITY, _AM_MARTIN_ADD_CITY);
92		Create_button(array('addcity' => array('url' => 'martin.hotel.city.php?action=add', 'value' => _AM_MARTIN_CITY_NAME)));
93
94		$HoteCityObjs = $hotelcity_handler->getHotelCitys($xoopsModuleConfig['perpage'], $start, 0);
95
96		// Creating the objects for top categories
97		echo "<br />\n<table width='100%' cellspacing=1 cellpadding=2 border=0 class = outer>";
98		echo "<tr>";
99		echo "<td class='bg3' align='left'><b>" . _AM_MARTIN_CITY_NAME . "</b></td>";
100		echo "<td width='60' class='bg3' align='center'><b>" . _AM_MARTIN_ACTIONS . "</b></td>";
101		echo "</tr>";
102		$CityCout = $hotelcity_handler->getCount();
103		if (count($HoteCityObjs) > 0) {
104		foreach ($HoteCityObjs as $key => $thiscat) {
105		display($thiscat);
106		}
107		} else {
108		echo "<tr>";
109		echo "<td class='head' align='center' colspan= '7'>" . MARTIN_IS_NUll . "</td>";
110		echo "</tr>";
111		$categoryid = '0';
112		}
113		echo "</table>\n";
114		include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
115		$pagenav = new XoopsPageNav($CityCout, $xoopsModuleConfig['perpage'], 0, 'start');
116		echo '<div style="text-align:right;">' . $pagenav->renderNav() . '</div>';
117		echo "<br />";
118		martin_close_collapsable('createtable', 'createtableicon');
		0 ignored issues – show Unused Code introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report The call to the function `martin_close_collapsable()` seems unnecessary as the function has no side-effects. Loading history...
119		echo "<br>";
120
121		break;
122		default:
123		redirect_header(XOOPS_URL, 2, _AM_MARTIN_UNAUTHORIZED_ACCESS);
124		break;
125		}
126
127		/**
128		* @param $HotelCityObj
129		* @param int $level
130		*/
131		function display($HotelCityObj, $level = 0)
132		{
133		global $xoopsModule, $hotelcity_handler;
		0 ignored issues – show Compatibility Best Practice introduced 2015-12-30 10:53 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
134		$modify = "<a href='?action=add&id=" . $HotelCityObj->city_id() . "&city_parentid=" . $HotelCityObj->city_parentid() . "'><img src='" . XOOPS_URL . "/modules/" . $xoopsModule->dirname() . "/images/icon/edit.gif'/></a>";
135		$delete = "<a href='?action=del&id=" . $HotelCityObj->city_id() . "&city_parentid=" . $HotelCityObj->city_parentid() . "'><img src='" . XOOPS_URL . "/modules/" . $xoopsModule->dirname() . "/images/icon/delete.gif'/></a>";
136
137		$spaces = '';
138		for ($j = 0; $j < $level; $j++) {
139		$spaces .= '   ';
140		}
141		echo "<tr>";
142		echo "<td class='even' align='lefet'>" . $spaces . "<a href='" . XOOPS_URL . '/hotel/' . $HotelCityObj->city_alias() . "'><img src='" . XOOPS_URL . "/modules/martin/images/icon/subcat.gif' alt='' /> " . $HotelCityObj->city_name() . "</a></td>";
143		echo "<td class='even' align='center'> $modify $delete </td>";
144		echo "</tr>";
145		$subObj = $hotelcity_handler->getHotelCitys(0, 0, $HotelCityObj->city_id());
146		if (count($subObj) > 0) {
147		$level++;
148		foreach ($subObj as $key => $thiscat) {
149		display($thiscat, $level);
150		}
151		}
152		unset($HotelCityObj);
153		}
154
155		//底部
156		include_once __DIR__ . '/admin_footer.php';
157

mambax7 / xoops-martin

Push — master ( c40551...5ee518 )

martin.hotel.city.php ➔ display() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like