form_hotel_promotion

Complexity

Total Complexity

8

Size/Duplication

Total Lines	95
Duplicated Lines	45.26 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	10	10	1
A	createElements()	0	28	5
A	createButtons()	33	33	2

<?php
/**
 * @城市表单
 * @license   http://www.blags.org/
 * @created   :2010年05月20日 23时52分
 * @copyright 1997-2010 The Martin Group
 * @author    Martin <china.codehome@gmail.com>
 * */
if (!defined('XOOPS_ROOT_PATH')) {
    return;
}

include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

/**
 * Class form_hotel_promotion
 */
class form_hotel_promotion extends XoopsThemeForm
{
    /**
     * form_hotel_promotion constructor.
     * @param $HotelPromotionObj
     * @param $HotelList
     */
    public function __construct(&$HotelPromotionObj, &$HotelList)

This method seems to be duplicated in your project.

    {
        $this->Obj       = &$HotelPromotionObj;
        $this->HotelList = &$HotelList;
        parent::__construct(_AM_MARTIN_HOTEL_CITY_LIST, "op", xoops_getenv('PHP_SELF') . "?action=save");
        $this->setExtra('enctype="multipart/form-data"');

        $this->createElements();
        $this->createButtons();
    }

    /**
     * created elements
     * @license   http://www.blags.org/
     * @created   :2010年05月21日 20时40分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * */
    public function createElements()
    {
        //include_once MARTIN_ROOT_PATH . '/include/formdatetime.php';
        include_once XOOPS_ROOT_PATH . "/modules/martin/class/xoopsformloader.php";

        $js          = '<script type=\'text/javascript\'>
            jQuery.noConflict();
            </script>';
        $RoomElement = new XoopsFormSelect($js . _AM_MARTIN_PROMO_HOTELS, 'hotel_id', $this->HotelList, 0, false);
        $RoomElement->addOptionArray($this->HotelList);
        $this->addElement($RoomElement, false);

        $this->addElement(new XoopsFormTextDateSelect(_AM_MARTIN_PROMO_START, 'promotion_start_date', $size = 15, $this->Obj->promotion_start_date(), false), true);

        $this->addElement(new XoopsFormTextDateSelect(_AM_MARTIN_PROMO_END, 'promotion_end_date', $size = 15, $this->Obj->promotion_end_date(), false), true);

        $editor                   = 'tinymce';
        $editor_configs           = array();
        $editor_configs["name"]   = "promotion_description";
        $editor_configs["value"]  = $this->Obj->promotion_description();
        $editor_configs["rows"]   = empty($xoopsModuleConfig["editor_rows"]) ? 35 : $xoopsModuleConfig["editor_rows"];

The variable $xoopsModuleConfig seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

        $editor_configs["cols"]   = empty($xoopsModuleConfig["editor_cols"]) ? 60 : $xoopsModuleConfig["editor_cols"];
        $editor_configs["width"]  = empty($xoopsModuleConfig["editor_width"]) ? "100%" : $xoopsModuleConfig["editor_width"];
        $editor_configs["height"] = empty($xoopsModuleConfig["editor_height"]) ? "400px" : $xoopsModuleConfig["editor_height"];
        $this->addElement(new XoopsFormEditor(_AM_MARTIN_PROMOTION_DETAILS, $editor, $editor_configs, false, $onfailure = null), false);

        $this->addElement(new XoopsFormHidden('id', $this->Obj->promotion_id()));
    }

    /**
     * @创建按钮
     * @license   http://www.blags.org/
     * @created   :2010年05月20日 23时52分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * */
    public function createButtons()

This method seems to be duplicated in your project.

    {
        $button_tray = new XoopsFormElementTray('', '');
        // No ID for category -- then it's new category, button says 'Create'
        if (!$this->Obj->promotion_id()) {
            $butt_create = new XoopsFormButton('', '', _SUBMIT, 'submit');
            $butt_create->setExtra('onclick="this.form.elements.op.value=\'addcategory\'"');
            $button_tray->addElement($butt_create);

            $butt_clear = new XoopsFormButton('', '', _RESET, 'reset');
            $button_tray->addElement($butt_clear);

            $butt_cancel = new XoopsFormButton('', '', _CANCEL, 'button');
            $butt_cancel->setExtra('onclick="history.go(-1)"');
            $button_tray->addElement($butt_cancel);

            $this->addElement($button_tray);
        } else {
            // button says 'Update'
            $butt_create = new XoopsFormButton('', '', _EDIT, 'submit');
            $butt_create->setExtra('onclick="this.form.elements.op.value=\'addcategory\'"');
            $button_tray->addElement($butt_create);

            $butt_clear = new XoopsFormButton('', '', _RESET, 'reset');
            $button_tray->addElement($butt_clear);

            $butt_cancel = new XoopsFormButton('', '', _CANCEL, 'button');
            $butt_cancel->setExtra('onclick="history.go(-1)"');
            $button_tray->addElement($butt_cancel);

            $this->addElement($button_tray);
        }
    }
}