MartinHotelServiceTypeHandler

Complexity

Total Complexity

36

Size/Duplication

Total Lines	266
Duplicated Lines	53.01 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	9	2
A	get()	17	17	3
A	getHotelServiceTypes()	12	12	1
B	insert()	13	46	8
A	delete()	20	20	4
A	deleteAll()	12	12	4
A	getCount()	14	14	4
B	getObjects()	42	42	8
A	GetList()	11	11	2

<?php
/**
 * $Id: hotelservicetype.php,v 1.42 2007/02/04 15:01:40 malanciault Exp $
 * Module:martin
 * Licence: GNU
 */

if (!defined("XOOPS_ROOT_PATH")) {
    die("XOOPS root path not defined");
}

include_once XOOPS_ROOT_PATH . '/modules/martin/include/common.php';

/**
 * Class MartinHotelServiceType
 */
class MartinHotelServiceType extends XoopsObject
{
    public function MartinHotelServiceType()
    {
        $this->initVar("service_type_id", XOBJ_DTYPE_INT, null, false);
        $this->initVar("service_type_name", XOBJ_DTYPE_TXTBOX, null, true, 255);
    }

    /**
     * @return mixed
     */
    public function service_type_id()
    {
        return $this->getVar("service_type_id");
    }

    /**
     * @param string $format
     * @return mixed
     */
    public function service_type_name($format = 'S')
    {
        return $this->getVar("service_type_name", $format);
    }
}

/**
 * @method: hotelservicetypeHandler
 * @license   http://www.blags.org/
 * @created   :2010年05月21日 20时40分
 * @copyright 1997-2010 The Martin Group
 * @author    Martin <china.codehome@gmail.com>
 * */
class MartinHotelServiceTypeHandler extends XoopsObjectHandler
{
    /**
     * create a new hotel city
     * @param bool $isNew flag the new objects as "new"?
     * @return object hotelservicetype
     */
    public function &create($isNew = true)
    {
        $hotelservicetype = new MartinHotelServiceType();
        if ($isNew) {
            $hotelservicetype->setNew();
        }

        return $hotelservicetype;
    }

    /**
     * retrieve a hotel city
     *
     * @param int $id hotelservicetypeid of the hotelservicetype
     * @return mixed reference to the {@link hotelservicetype} object, FALSE if failed
     */
    public function &get($id)

This method seems to be duplicated in your project.

    {
        if ((int)($id) <= 0) {
            return false;
        }

        $criteria = new CriteriaCompo(new Criteria('service_type_id', $id));
        $criteria->setLimit(1);
        $obj_array = $this->getObjects($criteria);
        if (count($obj_array) != 1) {
            $obj =& $this->create();

            return $obj;
        }

        return $obj_array[0];
    }

    /**
     * @得到列表
     * @method:
     * @license   http://www.blags.org/
     * @created   :2010年05月23日 14时59分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * @param int    $limit
     * @param int    $start
     * @param string $sort
     * @param string $order
     * @param bool   $id_as_key
     * @return array
     */
    public function &getHotelServiceTypes($limit = 0, $start = 0, $sort = 'service_type_id', $order = 'ASC', $id_as_key = true)

This method seems to be duplicated in your project.

    {
        $criteria = new CriteriaCompo();

        $criteria->setSort($sort);
        $criteria->setOrder($order);

        $criteria->setStart($start);
        $criteria->setLimit($limit);

        return $this->getObjects($criteria, $id_as_key);
    }

    /**
     * insert a new hotelservicetype in the database
     *
     * @param object $hotelservicetype reference to the {@link hotelservicetype} object
     * @param bool   $force
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */
    public function insert(&$hotelservicetype, $force = false)
    {
        if (strtolower(get_class($hotelservicetype)) !== 'martinhotelservicetype') {
            return false;
        }

        if (!$hotelservicetype->cleanVars()) {
            return false;
        }

        foreach ($hotelservicetype->cleanVars as $k => $v) {
            ${$k} = $v;
        }

        if ($hotelservicetype->isNew()) {

This code seems to be duplicated across your project.

            $sql = sprintf("INSERT INTO %s (
                                service_type_id,
                                service_type_name
                            ) VALUES (
                                NULL,
                                %s
                            )", $this->db->prefix('martin_hotel_service_type'), $this->db->quoteString($service_type_name));

The variable $service_type_name does not exist. Did you forget to declare it?

        } else {
            $sql = sprintf("UPDATE %s SET
                                service_type_name = %s
                            WHERE service_type_id = %u", $this->db->prefix('martin_hotel_service_type'), $this->db->quoteString($service_type_name), $service_type_id);

The variable $service_type_id does not exist. Did you forget to declare it?

        }
        //echo $sql;exit;
        if (false != $force) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }
        if (!$result) {
            $hotelservicetype->setErrors('The query returned an error. ' . $this->db->error());

            return false;
        }
        if ($hotelservicetype->isNew()) {
            $hotelservicetype->assignVar('service_type_id', $this->db->getInsertId());
        }

        $hotelservicetype->assignVar('service_type_id', $service_id);

The variable $service_id does not exist. Did you forget to declare it?

        return true;
    }

    /**
     * @删除一个城市
     * @method:delete(service_id)
     * @license   http://www.blags.org/
     * @created   :2010年05月21日 20时40分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * @param object $hotelservicetype
     * @param bool   $force
     * @return bool|void
     */
    public function delete(&$hotelservicetype, $force = false)

This method seems to be duplicated in your project.

    {
        if (strtolower(get_class($hotelservicetype)) !== 'martinhotelservicetype') {
            return false;
        }

        $sql = "DELETE FROM " . $this->db->prefix("martin_hotel_service_type") . " WHERE service_type_id = " . $hotelservicetype->service_type_id();

        if (false != $force) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }

        if (!$result) {
            return false;
        }

        return true;
    }

    /**
     * delete hotel cities matching a set of conditions
     *
     * @param object $criteria {@link CriteriaElement}

Should the type for parameter $criteria not be object|null?

     * @return bool FALSE if deletion failed
     */
    public function deleteAll($criteria = null)

This method seems to be duplicated in your project.

    {
        $sql = 'DELETE FROM ' . $this->db->prefix('martin_hotel_service_type');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

Due to PHP Bug #53727, is_subclass_of returns inconsistent results on some PHP versions for interfaces; you could instead use ReflectionClass::implementsInterface.

            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {
            return false;
        }

        return true;
    }

    /**
     * count hotel cities matching a condition
     *
     * @param object $criteria {@link CriteriaElement} to match

Should the type for parameter $criteria not be object|null?

     * @return int count of categories
     */
    public function getCount($criteria = null)

This method seems to be duplicated in your project.

    {
        $sql = 'SELECT COUNT(*) FROM ' . $this->db->prefix('martin_hotel_service_type');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

Due to PHP Bug #53727, is_subclass_of returns inconsistent results on some PHP versions for interfaces; you could instead use ReflectionClass::implementsInterface.

            $sql .= ' ' . $criteria->renderWhere();
        }
        $result = $this->db->query($sql);
        if (!$result) {
            return 0;
        }
        list($count) = $this->db->fetchRow($result);

        return $count;
    }

    /**
     * @得到城市
     * @license   http://www.blags.org/
     * @created   :2010年05月21日 20时40分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * @param null $criteria
     * @param bool $id_as_key
     * @return array
     */
    public function &getObjects($criteria = null, $id_as_key = false)

This method seems to be duplicated in your project.

    {
        $ret   = array();
        $limit = $start = 0;
        $sql   = 'SELECT * FROM ' . $this->db->prefix('martin_hotel_service_type');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

Due to PHP Bug #53727, is_subclass_of returns inconsistent results on some PHP versions for interfaces; you could instead use ReflectionClass::implementsInterface.

            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
            $limit = $criteria->getLimit();
            $start = $criteria->getStart();
        }
        //echo "<br />" . $sql . "<br />";
        $result = $this->db->query($sql, $limit, $start);

        if (!$result) {
            return $ret;
        }

        $theObjects = array();

        while ($myrow = $this->db->fetchArray($result)) {
            $hotelservicetype = new MartinHotelServiceType();
            $hotelservicetype->assignVars($myrow);
            $theObjects[$myrow['service_type_id']] =& $hotelservicetype;
            //var_dump($hotelservicetype);
            unset($hotelservicetype);
        }
        //var_dump($theObjects);

        foreach ($theObjects as $theObject) {
            if (!$id_as_key) {
                $ret[] =& $theObject;
            } else {
                $ret[$theObject->service_type_id()] =& $theObject;
            }
            unset($theObject);
        }

        return $ret;
    }

    /**
     * @得到类别列表
     * @license   http://www.blags.org/
     * @created   :2010年05月30日 20时48分
     * @copyright 1997-2010 The Martin Group
     * @author    Martin <china.codehome@gmail.com>
     * */
    public function GetList()

This method seems to be duplicated in your project.

    {
        $sql    = "SELECT * FROM " . $this->db->prefix("martin_hotel_service_type");
        $result = $this->db->query($sql);
        $rows   = array();
        while ($row = $this->db->fetchArray($result)) {
            $rows[$row['service_type_id']] = $row['service_type_name'];
        }

        return $rows;
    }
}