admin/donations.php ➔ updateConfig()

Complexity

Conditions	6
Paths	10

Size

Total Lines	40
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function updateConfig()

updateConfig uses the super-global variable $_POST which is generally not recommended.

{
    global $tr_config, $modversion, $xoopsDB;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    echo '<br />' . _AD_DON_ERR_SQL_FAILURE . "<br /><br />\n";

    $error = 1;
    $ilog  = "<br />\n";

$ilog is not used, you could remove the assignment.

    foreach ($_POST as $option => $value) {
        /// Look for form variables
        if (preg_match('/var_/', $option)) {
            $varnm = preg_replace('/var_/', '', $option);
            // Check for subtype field

            if (preg_match('/-(.*)/', $varnm, $subtype)) {
                echo "<br />subtype = $subtype[1] <br />\n";
                $temp  = $varnm;
                $varnm = preg_replace('/-.*/', '', $temp);
                // Is this is a text field?
                if (preg_match('/([^-]*)-txt/', $subtype[1], $subtype2)) {
                    $textarea = addslashes($value);
                    echo "$varnm $subtype2[1] text=> " . nl2br(htmlspecialchars($textarea)) . "<br />\n";
                    $error &= updateDb($varnm, $subtype2[1], '0', $textarea);
                } else {
                    echo "$varnm $subtype[1] => $value<br />\n";
                    $error &= updateDbShort($varnm, $subtype[1], $value);
                }
            } else {
                echo "$varnm => $value<br />\n";
                $error &= updateDbShort($varnm, '', $value);
            }
        }
    }

    // If there were no errors
    if (0 == $error) {
        header('Location: donations.php?op=Config#AdminTop');
    }
}