Issues in ThumbsNails.php (master) - Issues in master - mambax7/wflinks - Measure and Improve Code Quality continuously with Scrutinizer

Issues (273)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/ThumbsNails.php (1 issue)

Labels

Unused Code 1

Severity

<?php

namespace XoopsModules\Wflinks;

/**
 * this is the image that will be return apon error
 */

use XoopsModules\Wflinks;

if (!\defined('_PATH')) {
    \define('_PATH', XOOPS_ROOT_PATH);
}

if (!\defined('DEFAULT_PATH')) {
    \define('DEFAULT_PATH', XOOPS_UPLOAD_URL . '/blank.gif');
}

/**
 * ThumbsNails
 *
 * @package
 * @author    John N
 * @copyright WF-Projects Copyright (c) 2005
 * @copyright Using this class without our permission or removing this notice voids the license agreement.
 * @access    public
 */
class ThumbsNails
{
    public $_img_name        = 'blank.gif';
    public $_img_path        = 'uploads';
    public $_img_savepath    = 'thumbs';
    public $_source_path     = '';
    public $_save_path       = '';
    public $_source_url      = '';
    public $_source_image    = '';
    public $_save_image      = '';
    public $_usethumbs       = 0;
    public $_image_type      = 'gd2';
    public $_return_fullpath = 0;
    public $img_width        = 100;
    public $img_height       = 100;
    public $img_quality      = 100;
    public $img_update       = 1;
    public $img_aspect       = 1;
    /**
     * @access private
     */
    public $_img_info = [];

    /**
     * Constructor
     *
     * @param null $img_name
     * @param null $img_path
     * @param null $img_savepath
     *
     * @internal param string $_img_name
     * @internal param string $_img_path
     * @internal param string $_img_savepath
     */
    public function __construct($img_name = null, $img_path = null, $img_savepath = null)
    {
        if (!\preg_match("/\.(jpg|gif|png|jpeg)$/i", $img_name)) {
            //            return false;
        }

        /*
        * The actual image we will be processing
        */
        if (null !== $img_name) {
            $this->_img_name = \trim($img_name);
        }

        /*
        * The image path
        */
        if (null !== $img_path) {
            $this->_img_path = \trim($img_path);
        }

        /*
        * The image save path
        */
        if (null !== $img_savepath) {
            $this->_img_savepath = \trim($img_savepath);
        }

        $path_to_check = XOOPS_ROOT_PATH . "/$img_path/$img_savepath";

        if (!\is_dir($path_to_check)) {
            if (!mkdir($path_to_check, 0777) && !is_dir($path_to_check)) {
                //                return false;
            }
        }
        //        return null;
    }

    /**
     * WfThumbsNails::setUseThumbs()
     *
     * @param int $value
     */
    public function setUseThumbs($value = 1)
    {
        $this->_usethumbs = $value;
    }

    /**
     * WfThumbsNails::setImageType()
     *
     * @param string $value
     */
    public function setImageType($value = 'gd2')
    {
        $this->_image_type = $value;
    }

    /**
     * ThumbsNails::createThumb()
     *
     * @param int|null $img_width
     * @param int|null $img_height
     * @param int|null $img_quality
     * @param int|null $img_update
     * @param int|null $img_aspect
     *
     * @return bool|string
     */
    public function createThumb(
        $img_width = null,
        $img_height = null,
        $img_quality = null,
        $img_update = null,
        $img_aspect = null
    ) {
        $this->_source_path  = XOOPS_ROOT_PATH . "/{$this->_img_path}";
        $this->_save_path    = XOOPS_ROOT_PATH . "/{$this->_img_path}/{$this->_img_savepath}";
        $this->_source_url   = XOOPS_URL . "/{$this->_img_path}";
        $this->_source_image = "{$this->_source_path}/{$this->_img_name}";

        if (null !== $img_width) {
            $this->img_width = (int)$img_width;
        }

        if (null !== $img_height) {
            $this->img_height = (int)$img_height;
        }

        if (null !== $img_quality) {
            $this->img_quality = (int)$img_quality;
        }

        if (null !== $img_update) {
            $this->img_update = (int)$img_update;
        }

        if (null !== $img_aspect) {
            $this->img_aspect = (int)$img_aspect;
        }

        /**
         * Return false if we are not using thumb nails
         */
        if (!$this->isUsingThumbs()) {
            return $this->_source_url . '/' . $this->_img_name;
        }
        /**
         * Return false if the server does not have gd lib installed or activated
         */
        if (!$this->checkGdLibrary()) {
            return $this->_source_url . '/' . $this->_img_name;
        }

        /**
         * Return false if the paths to the file are wrong
         */
        if (!$this->checkPaths()) {
            return DEFAULT_PATH;
        }

        if (!$this->checkImage()) {
            return DEFAULT_PATH;
        }

        $image = $this->resizeImage();
        if (false === $image) {
            return DEFAULT_PATH;
        }

        return $image;
    }

    /**
     * @param $value
     */
    public function setImgName($value)
    {
        $this->_img_name = \trim($value);
    }

    /**
     * @param $value
     */
    public function setImgPath($value)
    {
        $this->_img_path = \trim($value);
    }

    /**
     * @param $value
     */
    public function setImgSavePath($value)
    {
        $this->_img_savepath = \trim($value);
    }

    /**
     * ThumbsNails::resizeImage()
     *
     * @return bool|string
     */
    public function resizeImage()
    {
        /** @var Wflinks\Helper $helper */
        $helper = Wflinks\Helper::getInstance();

        // $this->_img_info = info array to the image being resized
        // $this->_img_info[0] == width
        // $this->_img_info[1] == height
        // $this->_img_info[2] == is a flag indicating the type of the image: 1 = GIF, 2 = JPG, 3 = PNG, 4 = SWF, 5 = PSD, 6 = BMP, 7 = TIFF(intel byte order), 8 = TIFF(motorola byte order)
        // $this->_img_info[3] == is a text string with the correct height="yyy" width="xxx" string that can be used directly in an IMG tag
        /**
         * Get image size and scale ratio
         */
        $scale = \min($this->img_width / $this->_img_info[0], $this->img_height / $this->_img_info[1]);
        /**
         * If the image is larger than the max shrink it
         */
        $newWidth  = $this->img_width;
        $newHeight = $this->img_height;
        if ($scale < 1 && 1 == $this->img_aspect) {
            $newWidth  = \floor($scale * $this->_img_info[0]);
            $newHeight = \floor($scale * $this->_img_info[1]);
        }
        $newWidth  = ($newWidth > $this->_img_info[0]) ? $this->_img_info[0] : $newWidth;
        $newHeight = ($newHeight > $this->_img_info[0]) ? $this->_img_info[0] : $newHeight;

        $savefile          = "{$newWidth}x{$newHeight}_{$this->_img_name}";
        $this->_save_image = "{$this->_save_path}/{$savefile}";

        if (0 == $this->img_update && \file_exists($this->_save_image)) {
            if (1 == $this->_return_fullpath) {
                return $this->_source_url . "/{$this->_img_savepath}/{$savefile}";
            }

            return "{$this->_img_savepath}/{$savefile}";
        }

        switch ($this->_image_type) {
            case 'im':
                if (!empty($helper->getConfig('path_magick')) && \is_dir($helper->getConfig('path_magick'))) {
                    if (\preg_match('#[A-Z]:|\\\\#Ai', __FILE__)) {
                        $cur_dir     = __DIR__;
                        $src_file_im = '"' . $cur_dir . '\\' . \str_replace('/', '\\', $this->_source_image) . '"';
                        $new_file_im = '"' . $cur_dir . '\\' . \str_replace('/', '\\', $this->_save_image) . '"';
                    } else {
                        $src_file_im = \escapeshellarg($this->_source_image);
                        $new_file_im = \escapeshellarg($this->_save_image);
                    }
                    $magick_command = $helper->getConfig('path_magick') . '/convert -quality {$helper->getConfig("imagequality")} -antialias -sample {$newWidth}x{$newHeight} {$src_file_im} +profile "*" ' . \str_replace('\\', '/', $new_file_im) . '';
                    \passthru($magick_command);

                    return $this->_source_url . "/{$this->_img_savepath}/{$savefile}";
                }

                return false;
                break;
            case 'gd1':
            case 'gd2':
            default:

                $imageCreateFunction = (\function_exists('imagecreatetruecolor')
                                        && 'gd2' === $this->_image_type) ? 'imagecreatetruecolor' : 'imagecreate';
                $imageCopyfunction   = (\function_exists('imagecopyresampled')
                                        && 'gd2' === $this->_image_type) ? 'imagecopyresampled' : 'imagecopyresized';

                switch ($this->_img_info[2]) {
                    case 1:
                        // GIF image
                        $img     = \function_exists('imagecreatefromgif') ? \imagecreatefromgif($this->_source_image) : \imagecreatefrompng($this->_source_image);
                        $tmp_img = $imageCreateFunction($newWidth, $newHeight);
                        $imageCopyfunction($tmp_img, $img, 0, 0, 0, 0, $newWidth, $newHeight, $this->_img_info[0], $this->_img_info[1]);
                        if (\function_exists('imagegif')) {
                            \imagegif($tmp_img, $this->_save_image);
                        } else {
                            \imagepng($tmp_img, $this->_save_image);
                        }
                        \imagedestroy($tmp_img);
                        break;
                    case 2:
                        // echo $this->_save_image;
                        $img     = \function_exists('imagecreatefromjpeg') ? \imagecreatefromjpeg($this->_source_image) : \imagecreatefrompng($this->_source_image);
                        $tmp_img = $imageCreateFunction($newWidth, $newHeight);
                        $imageCopyfunction($tmp_img, $img, 0, 0, 0, 0, $newWidth, $newHeight, $this->_img_info[0], $this->_img_info[1]);
                        if (\function_exists('imagejpeg')) {
                            \imagejpeg($tmp_img, $this->_save_image, $this->img_quality);
                        } else {
                            \imagepng($tmp_img, $this->_save_image);
                        }
                        \imagedestroy($tmp_img);
                        break;
                    case 3:
                        // PNG image
                        $img     = \imagecreatefrompng($this->_source_image);
                        $tmp_img = $imageCreateFunction($newWidth, $newHeight);
                        $imageCopyfunction($tmp_img, $img, 0, 0, 0, 0, $newWidth, $newHeight, $this->_img_info[0], $this->_img_info[1]);
                        \imagepng($tmp_img, $this->_save_image);
                        \imagedestroy($tmp_img);
                        break;
                    default:
                        return false;
                }
                if (1 == $this->_return_fullpath) {
                    return $this->_source_url . "/{$this->_img_savepath}/{$savefile}";
                }

                return "{$this->_img_savepath}/{$savefile}";
                break;
        }

        return false;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    /**
     * ThumbsNails::checkPaths()
     *
     * @return bool
     */
    public function checkPaths()
    {
        if (\file_exists($this->_source_image) || \is_readable($this->_source_image)) {
            return true;
        }
        if (\is_dir($this->_save_image) || \is_writable($this->_save_image)) {
            return true;
        }

        return false;
    }

    /**
     * @return bool
     */
    public function checkImage()
    {
        $this->_img_info = \getimagesize($this->_source_image, $imageinfo);
        // if ( $this->_img_info[0] < $this->img_width && $this->_img_info[1] < $this->img_height )
        // return false;
        return !(null === $this->_img_info);
    }

    /**
     * wfsThumbs::checkGdLibrary()
     *
     * Private function
     *
     * @return array|false if gd lib not found on the system
     */
    public function checkGdLibrary()
    {
        if (!\extension_loaded('gd')) {
            return false;
        }
        $gdlib = \function_exists('gd_info');
        if (false === $gdlib = gd_info()) {
            return false;
        }

        return $gdlib;
    }

    /**
     * ThumbsNails::isUsingThumbs()
     *
     * @return bool
     */
    public function isUsingThumbs()
    {
        if ($this->_usethumbs) {
            return true;
        }

        return false;
    }
}


1			<?php
2
3			namespace XoopsModules\Wflinks;
4
5			/**
6			* this is the image that will be return apon error
7			*/
8
9			use XoopsModules\Wflinks;
10
11			if (!\defined('_PATH')) {
12			\define('_PATH', XOOPS_ROOT_PATH);
13			}
14
15			if (!\defined('DEFAULT_PATH')) {
16			\define('DEFAULT_PATH', XOOPS_UPLOAD_URL . '/blank.gif');
17			}
18
19			/**
20			* ThumbsNails
21			*
22			* @package
23			* @author John N
24			* @copyright WF-Projects Copyright (c) 2005
25			* @copyright Using this class without our permission or removing this notice voids the license agreement.
26			* @access public
27			*/
28			class ThumbsNails
29			{
30			public $_img_name = 'blank.gif';
31			public $_img_path = 'uploads';
32			public $_img_savepath = 'thumbs';
33			public $_source_path = '';
34			public $_save_path = '';
35			public $_source_url = '';
36			public $_source_image = '';
37			public $_save_image = '';
38			public $_usethumbs = 0;
39			public $_image_type = 'gd2';
40			public $_return_fullpath = 0;
41			public $img_width = 100;
42			public $img_height = 100;
43			public $img_quality = 100;
44			public $img_update = 1;
45			public $img_aspect = 1;
46			/**
47			* @access private
48			*/
49			public $_img_info = [];
50
51			/**
52			* Constructor
53			*
54			* @param null $img_name
55			* @param null $img_path
56			* @param null $img_savepath
57			*
58			* @internal param string $_img_name
59			* @internal param string $_img_path
60			* @internal param string $_img_savepath
61			*/
62			public function __construct($img_name = null, $img_path = null, $img_savepath = null)
63			{
64			if (!\preg_match("/\.(jpg\|gif\|png\|jpeg)$/i", $img_name)) {
65			// return false;
66			}
67
68			/*
69			* The actual image we will be processing
70			*/
71			if (null !== $img_name) {
72			$this->_img_name = \trim($img_name);
73			}
74
75			/*
76			* The image path
77			*/
78			if (null !== $img_path) {
79			$this->_img_path = \trim($img_path);
80			}
81
82			/*
83			* The image save path
84			*/
85			if (null !== $img_savepath) {
86			$this->_img_savepath = \trim($img_savepath);
87			}
88
89			$path_to_check = XOOPS_ROOT_PATH . "/$img_path/$img_savepath";
90
91			if (!\is_dir($path_to_check)) {
92			if (!mkdir($path_to_check, 0777) && !is_dir($path_to_check)) {
93			// return false;
94			}
95			}
96			// return null;
97			}
98
99			/**
100			* WfThumbsNails::setUseThumbs()
101			*
102			* @param int $value
103			*/
104			public function setUseThumbs($value = 1)
105			{
106			$this->_usethumbs = $value;
107			}
108
109			/**
110			* WfThumbsNails::setImageType()
111			*
112			* @param string $value
113			*/
114			public function setImageType($value = 'gd2')
115			{
116			$this->_image_type = $value;
117			}
118
119			/**
120			* ThumbsNails::createThumb()
121			*
122			* @param int\|null $img_width
123			* @param int\|null $img_height
124			* @param int\|null $img_quality
125			* @param int\|null $img_update
126			* @param int\|null $img_aspect
127			*
128			* @return bool\|string
129			*/
130			public function createThumb(
131			$img_width = null,
132			$img_height = null,
133			$img_quality = null,
134			$img_update = null,
135			$img_aspect = null
136			) {
137			$this->_source_path = XOOPS_ROOT_PATH . "/{$this->_img_path}";
138			$this->_save_path = XOOPS_ROOT_PATH . "/{$this->_img_path}/{$this->_img_savepath}";
139			$this->_source_url = XOOPS_URL . "/{$this->_img_path}";
140			$this->_source_image = "{$this->_source_path}/{$this->_img_name}";
141
142			if (null !== $img_width) {
143			$this->img_width = (int)$img_width;
144			}
145
146			if (null !== $img_height) {
147			$this->img_height = (int)$img_height;
148			}
149
150			if (null !== $img_quality) {
151			$this->img_quality = (int)$img_quality;
152			}
153
154			if (null !== $img_update) {
155			$this->img_update = (int)$img_update;
156			}
157
158			if (null !== $img_aspect) {
159			$this->img_aspect = (int)$img_aspect;
160			}
161
162			/**
163			* Return false if we are not using thumb nails
164			*/
165			if (!$this->isUsingThumbs()) {
166			return $this->_source_url . '/' . $this->_img_name;
167			}
168			/**
169			* Return false if the server does not have gd lib installed or activated
170			*/
171			if (!$this->checkGdLibrary()) {
172			return $this->_source_url . '/' . $this->_img_name;
173			}
174
175			/**
176			* Return false if the paths to the file are wrong
177			*/
178			if (!$this->checkPaths()) {
179			return DEFAULT_PATH;
180			}
181
182			if (!$this->checkImage()) {
183			return DEFAULT_PATH;
184			}
185
186			$image = $this->resizeImage();
187			if (false === $image) {
188			return DEFAULT_PATH;
189			}
190
191			return $image;
192			}
193
194			/**
195			* @param $value
196			*/
197			public function setImgName($value)
198			{
199			$this->_img_name = \trim($value);
200			}
201
202			/**
203			* @param $value
204			*/
205			public function setImgPath($value)
206			{
207			$this->_img_path = \trim($value);
208			}
209
210			/**
211			* @param $value
212			*/
213			public function setImgSavePath($value)
214			{
215			$this->_img_savepath = \trim($value);
216			}
217
218			/**
219			* ThumbsNails::resizeImage()
220			*
221			* @return bool\|string
222			*/
223			public function resizeImage()
224			{
225			/** @var Wflinks\Helper $helper */
226			$helper = Wflinks\Helper::getInstance();
227
228			// $this->_img_info = info array to the image being resized
229			// $this->_img_info[0] == width
230			// $this->_img_info[1] == height
231			// $this->_img_info[2] == is a flag indicating the type of the image: 1 = GIF, 2 = JPG, 3 = PNG, 4 = SWF, 5 = PSD, 6 = BMP, 7 = TIFF(intel byte order), 8 = TIFF(motorola byte order)
232			// $this->_img_info[3] == is a text string with the correct height="yyy" width="xxx" string that can be used directly in an IMG tag
233			/**
234			* Get image size and scale ratio
235			*/
236			$scale = \min($this->img_width / $this->_img_info[0], $this->img_height / $this->_img_info[1]);
237			/**
238			* If the image is larger than the max shrink it
239			*/
240			$newWidth = $this->img_width;
241			$newHeight = $this->img_height;
242			if ($scale < 1 && 1 == $this->img_aspect) {
243			$newWidth = \floor($scale * $this->_img_info[0]);
244			$newHeight = \floor($scale * $this->_img_info[1]);
245			}
246			$newWidth = ($newWidth > $this->_img_info[0]) ? $this->_img_info[0] : $newWidth;
247			$newHeight = ($newHeight > $this->_img_info[0]) ? $this->_img_info[0] : $newHeight;
248
249			$savefile = "{$newWidth}x{$newHeight}_{$this->_img_name}";
250			$this->_save_image = "{$this->_save_path}/{$savefile}";
251
252			if (0 == $this->img_update && \file_exists($this->_save_image)) {
253			if (1 == $this->_return_fullpath) {
254			return $this->_source_url . "/{$this->_img_savepath}/{$savefile}";
255			}
256
257			return "{$this->_img_savepath}/{$savefile}";
258			}
259
260			switch ($this->_image_type) {
261			case 'im':
262			if (!empty($helper->getConfig('path_magick')) && \is_dir($helper->getConfig('path_magick'))) {
263			if (\preg_match('#[A-Z]:\|\\\\#Ai', __FILE__)) {
264			$cur_dir = __DIR__;
265			$src_file_im = '"' . $cur_dir . '\\' . \str_replace('/', '\\', $this->_source_image) . '"';
266			$new_file_im = '"' . $cur_dir . '\\' . \str_replace('/', '\\', $this->_save_image) . '"';
267			} else {
268			$src_file_im = \escapeshellarg($this->_source_image);
269			$new_file_im = \escapeshellarg($this->_save_image);
270			}
271			$magick_command = $helper->getConfig('path_magick') . '/convert -quality {$helper->getConfig("imagequality")} -antialias -sample {$newWidth}x{$newHeight} {$src_file_im} +profile "*" ' . \str_replace('\\', '/', $new_file_im) . '';
272			\passthru($magick_command);
273
274			return $this->_source_url . "/{$this->_img_savepath}/{$savefile}";
275			}
276
277			return false;
278			break;
279			case 'gd1':
280			case 'gd2':
281			default:
282
283			$imageCreateFunction = (\function_exists('imagecreatetruecolor')
284			&& 'gd2' === $this->_image_type) ? 'imagecreatetruecolor' : 'imagecreate';
285			$imageCopyfunction = (\function_exists('imagecopyresampled')
286			&& 'gd2' === $this->_image_type) ? 'imagecopyresampled' : 'imagecopyresized';
287
288			switch ($this->_img_info[2]) {
289			case 1:
290			// GIF image
291			$img = \function_exists('imagecreatefromgif') ? \imagecreatefromgif($this->_source_image) : \imagecreatefrompng($this->_source_image);
292			$tmp_img = $imageCreateFunction($newWidth, $newHeight);
293			$imageCopyfunction($tmp_img, $img, 0, 0, 0, 0, $newWidth, $newHeight, $this->_img_info[0], $this->_img_info[1]);
294			if (\function_exists('imagegif')) {
295			\imagegif($tmp_img, $this->_save_image);
296			} else {
297			\imagepng($tmp_img, $this->_save_image);
298			}
299			\imagedestroy($tmp_img);
300			break;
301			case 2:
302			// echo $this->_save_image;
303			$img = \function_exists('imagecreatefromjpeg') ? \imagecreatefromjpeg($this->_source_image) : \imagecreatefrompng($this->_source_image);
304			$tmp_img = $imageCreateFunction($newWidth, $newHeight);
305			$imageCopyfunction($tmp_img, $img, 0, 0, 0, 0, $newWidth, $newHeight, $this->_img_info[0], $this->_img_info[1]);
306			if (\function_exists('imagejpeg')) {
307			\imagejpeg($tmp_img, $this->_save_image, $this->img_quality);
308			} else {
309			\imagepng($tmp_img, $this->_save_image);
310			}
311			\imagedestroy($tmp_img);
312			break;
313			case 3:
314			// PNG image
315			$img = \imagecreatefrompng($this->_source_image);
316			$tmp_img = $imageCreateFunction($newWidth, $newHeight);
317			$imageCopyfunction($tmp_img, $img, 0, 0, 0, 0, $newWidth, $newHeight, $this->_img_info[0], $this->_img_info[1]);
318			\imagepng($tmp_img, $this->_save_image);
319			\imagedestroy($tmp_img);
320			break;
321			default:
322			return false;
323			}
324			if (1 == $this->_return_fullpath) {
325			return $this->_source_url . "/{$this->_img_savepath}/{$savefile}";
326			}
327
328			return "{$this->_img_savepath}/{$savefile}";
329			break;
330			}
331
332			return false;
			0 ignored issues – show Unused Code introduced 2020-08-13 17:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this `return false` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
333			}
334
335			/**
336			* ThumbsNails::checkPaths()
337			*
338			* @return bool
339			*/
340			public function checkPaths()
341			{
342			if (\file_exists($this->_source_image) \|\| \is_readable($this->_source_image)) {
343			return true;
344			}
345			if (\is_dir($this->_save_image) \|\| \is_writable($this->_save_image)) {
346			return true;
347			}
348
349			return false;
350			}
351
352			/**
353			* @return bool
354			*/
355			public function checkImage()
356			{
357			$this->_img_info = \getimagesize($this->_source_image, $imageinfo);
358			// if ( $this->_img_info[0] < $this->img_width && $this->_img_info[1] < $this->img_height )
359			// return false;
360			return !(null === $this->_img_info);
361			}
362
363			/**
364			* wfsThumbs::checkGdLibrary()
365			*
366			* Private function
367			*
368			* @return array\|false if gd lib not found on the system
369			*/
370			public function checkGdLibrary()
371			{
372			if (!\extension_loaded('gd')) {
373			return false;
374			}
375			$gdlib = \function_exists('gd_info');
376			if (false === $gdlib = gd_info()) {
377			return false;
378			}
379
380			return $gdlib;
381			}
382
383			/**
384			* ThumbsNails::isUsingThumbs()
385			*
386			* @return bool
387			*/
388			public function isUsingThumbs()
389			{
390			if ($this->_usethumbs) {
391			return true;
392			}
393
394			return false;
395			}
396			}
397

mambax7 / wflinks

Issues (273)

Security Analysis not enabled

class/ThumbsNails.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like