mambax7 / wflinks

blocks/wflinks_top.php

<?php
/**
 * Module: WF-links
 * Version: v1.0.3
 * Release Date: 21 June 2005
 * Developer: John N
 * Team: WF-Projects
 * Licence: GNU
 * @param mixed $cid
 * @param mixed $permType
 * @param mixed $redirect
 */

// checkBlockgroups()
//
// @param integer $cid
// @param string $permType
// @param boolean $redirect
// @return
/**
 * @param int    $cid
 * @param string $permType
 * @param bool   $redirect
 *
 * @return bool
 */
function checkBlockgroups($cid = 0, $permType = 'WFLinkCatPerm', $redirect = false)
{
    $moduleDirName = basename(dirname(__DIR__));
    global $xoopsUser;

    $groups = is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
    /** @var \XoopsGroupPermHandler $grouppermHandler */
    $grouppermHandler = xoops_getHandler('groupperm');

    /** @var \XoopsModuleHandler $moduleHandler */
    $moduleHandler = xoops_getHandler('module');
    $module        = $moduleHandler->getByDirname($moduleDirName);

    if (!$grouppermHandler->checkRight($permType, $cid, $groups, $module->getVar('mid'))) {
        if (false === $redirect) {
            return false;
        }

        redirect_header('index.php', 3, _NOPERM);
    }
    unset($module);

    return true;
}

// Function: b_mylinks_top_show
// Input   : $options[0] = date for the most recent links
//                 hits for the most popular links
//           $options[1] = How many links are displayes
//           $options[2] = Length of title
//           $options[3] = Date format
//           $block['content'] = The optional above content
// Output  : Returns the most recent or most popular links
/**
 * @param $options
 *
 * @return array
 */
function b_wflinks_top_show($options)
{
    $moduleDirName = basename(dirname(__DIR__));
    global $xoopsDB;

    $block = [];
    $time  = time();
    /** @var \XoopsModuleHandler $moduleHandler */
    $moduleHandler = xoops_getHandler('module');
    $wflModule     = $moduleHandler->getByDirname($moduleDirName);
    /* @var \XoopsConfigHandler $configHandler */
    /** @var \XoopsConfigHandler $configHandler */
    $configHandler   = xoops_getHandler('config');
    $wflModuleConfig = $configHandler->getConfigsByCat(0, $wflModule->getVar('mid'));

The assignment to $wflModuleConfig is dead and can be removed.

    $myts            = MyTextSanitizer:: getInstance();

The assignment to $myts is dead and can be removed.

    $result = $xoopsDB->query('SELECT lid, cid, title, published, hits FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE published > 0 AND published <= ' . $time . ' AND (expired = 0 OR expired > ' . $time . ') AND offline = 0 ORDER BY ' . $options[0] . ' DESC', $options[1], 0);
    while (false !== ($myrow = $xoopsDB->fetchArray($result))) {
        if (0 == $myrow['cid'] || false === checkBlockgroups($myrow['cid'])) {
            continue;
        }
        $linkload = [];
        $title    = htmlspecialchars($myrow['title'], ENT_QUOTES | ENT_HTML5);
        if (!XOOPS_USE_MULTIBYTES) {
            if (mb_strlen($myrow['title']) >= $options[2]) {
                $title = mb_substr($myrow['title'], 0, $options[2] - 1) . '...';
            }
        }
        $linkload['id']    = (int)$myrow['lid'];
        $linkload['cid']   = (int)$myrow['cid'];
        $linkload['title'] = $title;
        if ('published' === $options[0]) {
            $linkload['date'] = formatTimestamp($myrow['published'], $options[3]);
        } elseif ('hits' === $options[0]) {
            $linkload['hits'] = $myrow['hits'];
        }
        $linkload['dirname'] = $wflModule->getVar('dirname');
        $block['links'][]    = $linkload;
    }
    unset($_block_check_array);

The variable $_block_check_array seems to be never defined.

    return $block;
}

// b_wflinks_top_edit()
//
// @param $options
// @return
/**
 * @param $options
 *
 * @return string
 */
function b_wflinks_top_edit($options)
{
    $form = '' . _MB_WFL_DISP . ' ';
    $form .= "<input type='hidden' name='options[]' value='";
    if ('published' === $options[0]) {
        $form .= "published'";
    } else {
        $form .= "hits'";
    }
    $form .= '>';
    $form .= "<input type='text' name='options[]' value='" . $options[1] . "'>&nbsp;" . _MB_WFL_FILES . '';
    $form .= '&nbsp;<br>' . _MB_WFL_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "'>&nbsp;" . _MB_WFL_LENGTH . '';
    $form .= '&nbsp;<br>' . _MB_WFL_DATEFORMAT . "&nbsp;<input type='text' name='options[]' value='" . $options[3] . "'>&nbsp;" . _MB_WFL_DATEFORMATMANUAL;

    return $form;
}