Issues in ratelink.php - All Issues - Inspection of "Merge pull request #6 from aerograf/master" - mambax7/wflinks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dc7924...1aa479 )

by Michael

created 2017-09-17 13:09 UTC

ratelink.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *
 * Module: WF-Links
 * Version: v1.0.3
 * Release Date: 21 June 2005
 * Developer: John N
 * Team: WF-Projects
 * Licence: GNU
 */

require_once __DIR__ . '/header.php';

global $wfmyts, $xoTheme;
function myFunction($a, $b) {
    // Do something
}

// Check if linkload POSTER is voting (UNLESS Anonymous users allowed to post)
$lid = WflinksUtility::cleanRequestVars($_REQUEST, 'lid', 0);
$lid = (int)$lid;

$ip         = getenv('REMOTE_ADDR');
$ratinguser = (!is_object($xoopsUser)) ? 0 : $xoopsUser->getVar('uid');

if ($ratinguser != 0) {
    $result = $xoopsDB->query('SELECT cid, submitter FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $lid);
    while (list($cid, $ratinguserDB) = $xoopsDB->fetchRow($result)) {
        if ($ratinguserDB == $ratinguser) {
            $ratemessage = _MD_WFL_CANTVOTEOWN;
            redirect_header('singlelink.php?cid=' . (int)$cid . '&amp;lid=' . $lid, 4, $ratemessage);
        }
    }
    // Check if REG user is trying to vote twice.
    $result = $xoopsDB->query('SELECT cid, ratinguser FROM ' . $xoopsDB->prefix('wflinks_votedata') . ' WHERE lid=' . $lid);
    while (list($cid, $ratinguserDB) = $xoopsDB->fetchRow($result)) {
        if ($ratinguserDB == $ratinguser) {
            $ratemessage = _MD_WFL_VOTEONCE;
            redirect_header('singlelink.php?cid=' . (int)$cid . '&amp;lid=' . $lid, 4, $ratemessage);
        }
    }
} else {
    // Check if ANONYMOUS user is trying to vote more than once per day.
    $yesterday = (time() - (86400 * $anonwaitdays));
    $result    = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('wflinks_votedata') . ' WHERE lid=' . $lid . ' AND ratinguser=0 AND ratinghostname=' . $ip . '  AND ratingtimestamp > ' . $yesterday);
    list($anonvotecount) = $xoopsDB->fetchRow($result);
    if ($anonvotecount >= 1) {
        redirect_header('singlelink.php?cid=' . (int)$cid . '&amp;lid=' . $lid, 4, _MD_WFL_VOTEONCE);
    }
}

if (!empty($_POST['submit'])) {
    $ratinguser = (!is_object($xoopsUser)) ? 0 : $xoopsUser->getVar('uid');
    // Make sure only 1 anonymous from an IP in a single day.
    $anonwaitdays = 1;
    $ip           = getenv('REMOTE_ADDR');
    $lid          = WflinksUtility::cleanRequestVars($_REQUEST, 'lid', 0);
    $cid          = WflinksUtility::cleanRequestVars($_REQUEST, 'cid', 0);
    $rating       = WflinksUtility::cleanRequestVars($_REQUEST, 'rating', 0);
    $title        = $wfmyts->addSlashes(trim($_POST['title']));
    $lid          = (int)$lid;
    $cid          = (int)$cid;
    $rating       = (int)$rating;
    // Check if Rating is Null
    if ($rating == '--') {
        redirect_header('ratelink.php?cid=' . $cid . '&amp;lid=' . $lid, 4, _MD_WFL_NORATING);
    }
    // All is well.  Add to Line Item Rate to DB.
    $newid    = $xoopsDB->genId($xoopsDB->prefix('wflinks_votedata') . '_ratingid_seq');
    $datetime = time();
    $sql      = sprintf('INSERT INTO %s (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp, title) VALUES (%u, %u, %u, %u, %s, %u, %s)', $xoopsDB->prefix('wflinks_votedata'), $newid, $lid, $ratinguser, $rating, $xoopsDB->quoteString($ip), $datetime, $xoopsDB->quoteString($title));
    if (!$result = $xoopsDB->query($sql)) {
        $ratemessage = _MD_WFL_ERROR;
    } else {
        // All is well.  Calculate Score & Add to Summary (for quick retrieval & sorting) to DB.
        WflinksUtility::updateRating($lid);
        $ratemessage = _MD_WFL_VOTEAPPRE . '<br>' . sprintf(_MD_WFL_THANKYOU, $xoopsConfig['sitename']);
    }
    redirect_header('singlelink.php?cid=' . $cid . '&amp;lid=' . $lid, 4, $ratemessage);
} else {
    $GLOBALS['xoopsOption']['template_main'] = 'wflinks_ratelink.tpl';
    include XOOPS_ROOT_PATH . '/header.php';

    $catarray['imageheader'] = WflinksUtility::getImageHeader();
    $cid                     = WflinksUtility::cleanRequestVars($_REQUEST, 'cid', 0);
    $cid                     = (int)$cid;

    $catarray['imageheader'] = WflinksUtility::getImageHeader();
    $catarray['letters']     = WflinksUtility::getLetters();
    $catarray['toolbar']     = WflinksUtility::getToolbar();
    $xoopsTpl->assign('catarray', $catarray);

    $result = $xoopsDB->query('SELECT title FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $lid);
    list($title) = $xoopsDB->fetchRow($result);
    $xoopsTpl->assign('link', array('id' => $lid, 'cid' => $cid, 'title' => $wfmyts->htmlSpecialCharsStrip($title)));

    if (is_object($xoTheme)) {
        $xoTheme->addMeta('meta', 'robots', 'noindex,nofollow');
    } else {
        $xoopsTpl->assign('xoops_meta_robots', 'noindex,nofollow');
    }

    $xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
    include XOOPS_ROOT_PATH . '/footer.php';
}

if (is_object($xoTheme)) {
    $xoTheme->addMeta('meta', 'robots', 'noindex,nofollow');
} else {
    $xoopsTpl->assign('xoops_meta_robots', 'noindex,nofollow');
}

$xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
include XOOPS_ROOT_PATH . '/footer.php';


1			<?php
2			/**
3			*
4			* Module: WF-Links
5			* Version: v1.0.3
6			* Release Date: 21 June 2005
7			* Developer: John N
8			* Team: WF-Projects
9			* Licence: GNU
10			*/
11
12			require_once __DIR__ . '/header.php';
13
14			global $wfmyts, $xoTheme;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 09:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
15
16			// Check if linkload POSTER is voting (UNLESS Anonymous users allowed to post)
17			$lid = WflinksUtility::cleanRequestVars($_REQUEST, 'lid', 0);
18			$lid = (int)$lid;
19
20			$ip = getenv('REMOTE_ADDR');
21			$ratinguser = (!is_object($xoopsUser)) ? 0 : $xoopsUser->getVar('uid');
22
23			if ($ratinguser != 0) {
24			$result = $xoopsDB->query('SELECT cid, submitter FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $lid);
25			while (list($cid, $ratinguserDB) = $xoopsDB->fetchRow($result)) {
26			if ($ratinguserDB == $ratinguser) {
27			$ratemessage = _MD_WFL_CANTVOTEOWN;
28			redirect_header('singlelink.php?cid=' . (int)$cid . '&lid=' . $lid, 4, $ratemessage);
29			}
30			}
31			// Check if REG user is trying to vote twice.
32			$result = $xoopsDB->query('SELECT cid, ratinguser FROM ' . $xoopsDB->prefix('wflinks_votedata') . ' WHERE lid=' . $lid);
33			while (list($cid, $ratinguserDB) = $xoopsDB->fetchRow($result)) {
34			if ($ratinguserDB == $ratinguser) {
35			$ratemessage = _MD_WFL_VOTEONCE;
36			redirect_header('singlelink.php?cid=' . (int)$cid . '&lid=' . $lid, 4, $ratemessage);
37			}
38			}
39			} else {
40			// Check if ANONYMOUS user is trying to vote more than once per day.
41			$yesterday = (time() - (86400 * $anonwaitdays));
42			$result = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('wflinks_votedata') . ' WHERE lid=' . $lid . ' AND ratinguser=0 AND ratinghostname=' . $ip . ' AND ratingtimestamp > ' . $yesterday);
43			list($anonvotecount) = $xoopsDB->fetchRow($result);
44			if ($anonvotecount >= 1) {
45			redirect_header('singlelink.php?cid=' . (int)$cid . '&lid=' . $lid, 4, _MD_WFL_VOTEONCE);
46			}
47			}
48
49			if (!empty($_POST['submit'])) {
50			$ratinguser = (!is_object($xoopsUser)) ? 0 : $xoopsUser->getVar('uid');
51			// Make sure only 1 anonymous from an IP in a single day.
52			$anonwaitdays = 1;
53			$ip = getenv('REMOTE_ADDR');
54			$lid = WflinksUtility::cleanRequestVars($_REQUEST, 'lid', 0);
55			$cid = WflinksUtility::cleanRequestVars($_REQUEST, 'cid', 0);
56			$rating = WflinksUtility::cleanRequestVars($_REQUEST, 'rating', 0);
57			$title = $wfmyts->addSlashes(trim($_POST['title']));
58			$lid = (int)$lid;
59			$cid = (int)$cid;
60			$rating = (int)$rating;
61			// Check if Rating is Null
62			if ($rating == '--') {
63			redirect_header('ratelink.php?cid=' . $cid . '&lid=' . $lid, 4, _MD_WFL_NORATING);
64			}
65			// All is well. Add to Line Item Rate to DB.
66			$newid = $xoopsDB->genId($xoopsDB->prefix('wflinks_votedata') . '_ratingid_seq');
67			$datetime = time();
68			$sql = sprintf('INSERT INTO %s (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp, title) VALUES (%u, %u, %u, %u, %s, %u, %s)', $xoopsDB->prefix('wflinks_votedata'), $newid, $lid, $ratinguser, $rating, $xoopsDB->quoteString($ip), $datetime, $xoopsDB->quoteString($title));
69			if (!$result = $xoopsDB->query($sql)) {
70			$ratemessage = _MD_WFL_ERROR;
71			} else {
72			// All is well. Calculate Score & Add to Summary (for quick retrieval & sorting) to DB.
73			WflinksUtility::updateRating($lid);
74			$ratemessage = _MD_WFL_VOTEAPPRE . '<br>' . sprintf(_MD_WFL_THANKYOU, $xoopsConfig['sitename']);
75			}
76			redirect_header('singlelink.php?cid=' . $cid . '&lid=' . $lid, 4, $ratemessage);
77			} else {
78			$GLOBALS['xoopsOption']['template_main'] = 'wflinks_ratelink.tpl';
79			include XOOPS_ROOT_PATH . '/header.php';
80
81			$catarray['imageheader'] = WflinksUtility::getImageHeader();
82			$cid = WflinksUtility::cleanRequestVars($_REQUEST, 'cid', 0);
83			$cid = (int)$cid;
84
85			$catarray['imageheader'] = WflinksUtility::getImageHeader();
86			$catarray['letters'] = WflinksUtility::getLetters();
87			$catarray['toolbar'] = WflinksUtility::getToolbar();
88			$xoopsTpl->assign('catarray', $catarray);
89
90			$result = $xoopsDB->query('SELECT title FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $lid);
91			list($title) = $xoopsDB->fetchRow($result);
92			$xoopsTpl->assign('link', array('id' => $lid, 'cid' => $cid, 'title' => $wfmyts->htmlSpecialCharsStrip($title)));
93
94			if (is_object($xoTheme)) {
95			$xoTheme->addMeta('meta', 'robots', 'noindex,nofollow');
96			} else {
97			$xoopsTpl->assign('xoops_meta_robots', 'noindex,nofollow');
98			}
99
100			$xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
101			include XOOPS_ROOT_PATH . '/footer.php';
102			}
103
104			if (is_object($xoTheme)) {
105			$xoTheme->addMeta('meta', 'robots', 'noindex,nofollow');
106			} else {
107			$xoopsTpl->assign('xoops_meta_robots', 'noindex,nofollow');
108			}
109
110			$xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
111			include XOOPS_ROOT_PATH . '/footer.php';
112

mambax7 / wflinks

Push — master ( dc7924...1aa479 )

ratelink.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like