Issues in brokenlink.php - All Issues - Inspection of "Merge pull request #6 from aerograf/master" - mambax7/wflinks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dc7924...1aa479 )

by Michael

created 2017-09-17 13:09 UTC

brokenlink.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *
 * Module: WF-Links
 * Version: v1.0.3
 * Release Date: 21 June 2005
 * Developer: John N
 * Team: WF-Projects
 * Licence: GNU
 */

require_once __DIR__ . '/header.php';

$op      = WflinksUtility::cleanRequestVars($_REQUEST, 'op', '');
$lid     = WflinksUtility::cleanRequestVars($_REQUEST, 'lid', 0);
$lid     = (int)$lid;
$buttonn = _MD_WFL_SUBMITBROKEN;
$buttonn = strtolower($buttonn);

switch (strtolower($op)) {
    case $buttonn:
        global $xoopsUser;
function myFunction($a, $b) {
    // Do something
}

        $sender = (is_object($xoopsUser) && !empty($xoopsUser)) ? $xoopsUser->getVar('uid') : 0;
        $ip     = getenv('REMOTE_ADDR');
        $title  = WflinksUtility::cleanRequestVars($_REQUEST, 'title', '');
        $title  = $wfmyts->addSlashes($title);
        $time   = time();

        // Check if REG user is trying to report twice.
        $result = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('wflinks_broken') . ' WHERE lid=' . $lid);
        list($count) = $xoopsDB->fetchRow($result);
        if ($count > 0) {
            redirect_header('index.php', 2, _MD_WFL_ALREADYREPORTED);
        } else {
            $reportid = 0;
            $sql      = sprintf('INSERT INTO %s (reportid, lid, sender, ip, DATE, confirmed, acknowledged, title ) VALUES ( %u, %u, %u, %s, %u, %u, %u, %s)', $xoopsDB->prefix('wflinks_broken'), $reportid, $lid, $sender, $xoopsDB->quoteString($ip), $time, 0, 0, $xoopsDB->quoteString($title));
            if (!$result = $xoopsDB->query($sql)) {
                $error[] = _MD_WFL_ERROR;
            }
            $newid = $xoopsDB->getInsertId();

            // Send notifications
            $tags                      = array();
            $tags['BROKENREPORTS_URL'] = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/main.php?op=listBrokenlinks';
            $notificationHandler       = xoops_getHandler('notification');
            $notificationHandler->triggerEvent('global', 0, 'link_broken', $tags);

            // Send email to the owner of the linkload stating that it is broken
            $sql      = 'SELECT * FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $lid . ' AND published > 0 AND published <= ' . time() . ' AND (expired = 0 OR expired > ' . time() . ')';
            $link_arr = $xoopsDB->fetchArray($xoopsDB->query($sql));
            unset($sql);

            $memberHandler = xoops_getHandler('member');
            $submit_user   = $memberHandler->getUser($link_arr['submitter']);
            if (is_object($submit_user) && !empty($submit_user)) {
                $subdate = formatTimestamp($link_arr['date'], $xoopsModuleConfig['dateformat']);
                $cid     = $link_arr['cid'];
                $title   = $wfmyts->htmlSpecialCharsStrip($link_arr['title']);
                $subject = _MD_WFL_BROKENREPORTED;

                $xoopsMailer = xoops_getMailer();
                $xoopsMailer->useMail();
                $template_dir = XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/language/' . $xoopsConfig['language'] . '/mail_template';

                $xoopsMailer->setTemplateDir($template_dir);
                $xoopsMailer->setTemplate('linkbroken_notify.tpl');
                $xoopsMailer->setToEmails($submit_user->getVar('email'));
                $xoopsMailer->setFromEmail($xoopsConfig['adminmail']);
                $xoopsMailer->setFromName($xoopsConfig['sitename']);
                $xoopsMailer->assign('X_UNAME', $submit_user->getVar('uname'));
                $xoopsMailer->assign('SITENAME', $xoopsConfig['sitename']);
                $xoopsMailer->assign('X_ADMINMAIL', $xoopsConfig['adminmail']);
                $xoopsMailer->assign('X_SITEURL', XOOPS_URL . '/');
                $xoopsMailer->assign('X_TITLE', $title);
                $xoopsMailer->assign('X_SUB_DATE', $subdate);
                $xoopsMailer->assign('X_LINKLOAD', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/singlelink.php?cid=' . (int)$cid . '&amp;lid=' . $lid);
                $xoopsMailer->setSubject($subject);
                $message = $xoopsMailer->send() ? _MD_WFL_BROKENREPORTED : _MD_WFL_ERRORSENDEMAIL;
            } else {
                $message = _MD_WFL_ERRORSENDEMAIL;
            }
            redirect_header('index.php', 2, $message);
        }
        break;

    default:
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}

        $GLOBALS['xoopsOption']['template_main'] = 'wflinks_brokenlink.tpl';
        include XOOPS_ROOT_PATH . '/header.php';
        xoops_load('XoopsUserUtility');

        $catarray['imageheader'] = WflinksUtility::getImageHeader();
        $catarray['letters']     = WflinksUtility::getLetters();
        $catarray['toolbar']     = WflinksUtility::getToolbar();
        $xoopsTpl->assign('catarray', $catarray);

        $sql      = 'SELECT * FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $lid;
        $link_arr = $xoopsDB->fetchArray($xoopsDB->query($sql));
        unset($sql);

        $sql       = 'SELECT * FROM ' . $xoopsDB->prefix('wflinks_broken') . ' WHERE lid=' . $lid;
        $broke_arr = $xoopsDB->fetchArray($xoopsDB->query($sql));

        if (is_array($broke_arr)) {
            $broken['title']        = $wfmyts->htmlSpecialCharsStrip($link_arr['title']);
            $broken['id']           = $broke_arr['reportid'];
            $broken['reporter']     = XoopsUserUtility::getUnameFromId($broke_arr['sender']);
            $broken['date']         = formatTimestamp($broke_arr['date'], $xoopsModuleConfig['dateformat']);
            $broken['acknowledged'] = ($broke_arr['acknowledged'] == 1) ? _YES : _NO;
            $broken['confirmed']    = ($broke_arr['confirmed'] == 1) ? _YES : _NO;
            $xoopsTpl->assign('broken', $broken);
            $xoopsTpl->assign('brokenreport', true);
        } else {
            if (!is_array($link_arr) || empty($link_arr)) {
                redirect_header('index.php', 0, _MD_WFL_THISFILEDOESNOTEXIST);
            }

            // file info
            $link['title']     = $wfmyts->htmlSpecialCharsStrip($link_arr['title']);
            $time              = ($link_arr['published'] > 0) ? $link_arr['published'] : $link_arr['updated'];
            $link['updated']   = formatTimestamp($time, $xoopsModuleConfig['dateformat']);
            $is_updated        = ($link_arr['updated'] != 0) ? _MD_WFL_UPDATEDON : _MD_WFL_SUBMITDATE;
            $link['publisher'] = XoopsUserUtility::getUnameFromId($link_arr['submitter']);

            $xoopsTpl->assign('link_id', $lid);
            $xoopsTpl->assign('lang_subdate', $is_updated);
            $xoopsTpl->assign('link', $link);
        }

        if (is_object($xoTheme)) {
            $xoTheme->addMeta('meta', 'robots', 'noindex,nofollow');
        } else {
            $xoopsTpl->assign('xoops_meta_robots', 'noindex,nofollow');
        }

        $xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
        include XOOPS_ROOT_PATH . '/footer.php';
        break;
} // switch


1			<?php
2			/**
3			*
4			* Module: WF-Links
5			* Version: v1.0.3
6			* Release Date: 21 June 2005
7			* Developer: John N
8			* Team: WF-Projects
9			* Licence: GNU
10			*/
11
12			require_once __DIR__ . '/header.php';
13
14			$op = WflinksUtility::cleanRequestVars($_REQUEST, 'op', '');
15			$lid = WflinksUtility::cleanRequestVars($_REQUEST, 'lid', 0);
16			$lid = (int)$lid;
17			$buttonn = _MD_WFL_SUBMITBROKEN;
18			$buttonn = strtolower($buttonn);
19
20			switch (strtolower($op)) {
21			case $buttonn:
22			global $xoopsUser;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 09:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
23
24			$sender = (is_object($xoopsUser) && !empty($xoopsUser)) ? $xoopsUser->getVar('uid') : 0;
25			$ip = getenv('REMOTE_ADDR');
26			$title = WflinksUtility::cleanRequestVars($_REQUEST, 'title', '');
27			$title = $wfmyts->addSlashes($title);
28			$time = time();
29
30			// Check if REG user is trying to report twice.
31			$result = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('wflinks_broken') . ' WHERE lid=' . $lid);
32			list($count) = $xoopsDB->fetchRow($result);
33			if ($count > 0) {
34			redirect_header('index.php', 2, _MD_WFL_ALREADYREPORTED);
35			} else {
36			$reportid = 0;
37			$sql = sprintf('INSERT INTO %s (reportid, lid, sender, ip, DATE, confirmed, acknowledged, title ) VALUES ( %u, %u, %u, %s, %u, %u, %u, %s)', $xoopsDB->prefix('wflinks_broken'), $reportid, $lid, $sender, $xoopsDB->quoteString($ip), $time, 0, 0, $xoopsDB->quoteString($title));
38			if (!$result = $xoopsDB->query($sql)) {
39			$error[] = _MD_WFL_ERROR;
40			}
41			$newid = $xoopsDB->getInsertId();
42
43			// Send notifications
44			$tags = array();
45			$tags['BROKENREPORTS_URL'] = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/main.php?op=listBrokenlinks';
46			$notificationHandler = xoops_getHandler('notification');
47			$notificationHandler->triggerEvent('global', 0, 'link_broken', $tags);
48
49			// Send email to the owner of the linkload stating that it is broken
50			$sql = 'SELECT * FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $lid . ' AND published > 0 AND published <= ' . time() . ' AND (expired = 0 OR expired > ' . time() . ')';
51			$link_arr = $xoopsDB->fetchArray($xoopsDB->query($sql));
52			unset($sql);
53
54			$memberHandler = xoops_getHandler('member');
55			$submit_user = $memberHandler->getUser($link_arr['submitter']);
56			if (is_object($submit_user) && !empty($submit_user)) {
57			$subdate = formatTimestamp($link_arr['date'], $xoopsModuleConfig['dateformat']);
58			$cid = $link_arr['cid'];
59			$title = $wfmyts->htmlSpecialCharsStrip($link_arr['title']);
60			$subject = _MD_WFL_BROKENREPORTED;
61
62			$xoopsMailer = xoops_getMailer();
63			$xoopsMailer->useMail();
64			$template_dir = XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname') . '/language/' . $xoopsConfig['language'] . '/mail_template';
65
66			$xoopsMailer->setTemplateDir($template_dir);
67			$xoopsMailer->setTemplate('linkbroken_notify.tpl');
68			$xoopsMailer->setToEmails($submit_user->getVar('email'));
69			$xoopsMailer->setFromEmail($xoopsConfig['adminmail']);
70			$xoopsMailer->setFromName($xoopsConfig['sitename']);
71			$xoopsMailer->assign('X_UNAME', $submit_user->getVar('uname'));
72			$xoopsMailer->assign('SITENAME', $xoopsConfig['sitename']);
73			$xoopsMailer->assign('X_ADMINMAIL', $xoopsConfig['adminmail']);
74			$xoopsMailer->assign('X_SITEURL', XOOPS_URL . '/');
75			$xoopsMailer->assign('X_TITLE', $title);
76			$xoopsMailer->assign('X_SUB_DATE', $subdate);
77			$xoopsMailer->assign('X_LINKLOAD', XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/singlelink.php?cid=' . (int)$cid . '&lid=' . $lid);
78			$xoopsMailer->setSubject($subject);
79			$message = $xoopsMailer->send() ? _MD_WFL_BROKENREPORTED : _MD_WFL_ERRORSENDEMAIL;
80			} else {
81			$message = _MD_WFL_ERRORSENDEMAIL;
82			}
83			redirect_header('index.php', 2, $message);
84			}
85			break;
86
87			default:
			0 ignored issues – show Coding Style introduced 2017-09-02 10:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
88
89			$GLOBALS['xoopsOption']['template_main'] = 'wflinks_brokenlink.tpl';
90			include XOOPS_ROOT_PATH . '/header.php';
91			xoops_load('XoopsUserUtility');
92
93			$catarray['imageheader'] = WflinksUtility::getImageHeader();
94			$catarray['letters'] = WflinksUtility::getLetters();
95			$catarray['toolbar'] = WflinksUtility::getToolbar();
96			$xoopsTpl->assign('catarray', $catarray);
97
98			$sql = 'SELECT * FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $lid;
99			$link_arr = $xoopsDB->fetchArray($xoopsDB->query($sql));
100			unset($sql);
101
102			$sql = 'SELECT * FROM ' . $xoopsDB->prefix('wflinks_broken') . ' WHERE lid=' . $lid;
103			$broke_arr = $xoopsDB->fetchArray($xoopsDB->query($sql));
104
105			if (is_array($broke_arr)) {
106			$broken['title'] = $wfmyts->htmlSpecialCharsStrip($link_arr['title']);
107			$broken['id'] = $broke_arr['reportid'];
108			$broken['reporter'] = XoopsUserUtility::getUnameFromId($broke_arr['sender']);
109			$broken['date'] = formatTimestamp($broke_arr['date'], $xoopsModuleConfig['dateformat']);
110			$broken['acknowledged'] = ($broke_arr['acknowledged'] == 1) ? _YES : _NO;
111			$broken['confirmed'] = ($broke_arr['confirmed'] == 1) ? _YES : _NO;
112			$xoopsTpl->assign('broken', $broken);
113			$xoopsTpl->assign('brokenreport', true);
114			} else {
115			if (!is_array($link_arr) \|\| empty($link_arr)) {
116			redirect_header('index.php', 0, _MD_WFL_THISFILEDOESNOTEXIST);
117			}
118
119			// file info
120			$link['title'] = $wfmyts->htmlSpecialCharsStrip($link_arr['title']);
121			$time = ($link_arr['published'] > 0) ? $link_arr['published'] : $link_arr['updated'];
122			$link['updated'] = formatTimestamp($time, $xoopsModuleConfig['dateformat']);
123			$is_updated = ($link_arr['updated'] != 0) ? _MD_WFL_UPDATEDON : _MD_WFL_SUBMITDATE;
124			$link['publisher'] = XoopsUserUtility::getUnameFromId($link_arr['submitter']);
125
126			$xoopsTpl->assign('link_id', $lid);
127			$xoopsTpl->assign('lang_subdate', $is_updated);
128			$xoopsTpl->assign('link', $link);
129			}
130
131			if (is_object($xoTheme)) {
132			$xoTheme->addMeta('meta', 'robots', 'noindex,nofollow');
133			} else {
134			$xoopsTpl->assign('xoops_meta_robots', 'noindex,nofollow');
135			}
136
137			$xoopsTpl->assign('module_dir', $xoopsModule->getVar('dirname'));
138			include XOOPS_ROOT_PATH . '/footer.php';
139			break;
140			} // switch
141

mambax7 / wflinks

Push — master ( dc7924...1aa479 )

brokenlink.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like