htdocs/modules/wflinks/include/blocksadmin.inc.php ➔ myblocksadmin_update_block()

Complexity

Conditions	17
Paths	560

Size

Total Lines	71
Code Lines	50

Duplication

Lines	4
Ratio	5.63 %

Importance

Changes

0

<?php
    function myblocksadmin_update_block($bid, $bside, $bweight, $bvisible, $btitle, $bcontent, $bctype, $bcachetime, $bmodule, $options=array())

The return type could not be reliably inferred; please add a @return annotation.

    {
        global $xoopsConfig;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        /* if (empty($bmodule)) {

63% of this comment could be valid code. Did you maybe forget this after debugging?

            xoops_cp_header();
            xoops_error(sprintf(_AM_NOTSELNG, _AM_VISIBLEIN));
            xoops_cp_footer();
            exit();
        } */
        $myblock = new XoopsBlock($bid);
        // $myblock->setVar('side', $bside); GIJ -

54% of this comment could be valid code. Did you maybe forget this after debugging?

        if( $bside >= 0 ) $myblock->setVar('side', $bside); // GIJ +
        $myblock->setVar('weight', $bweight);
        $myblock->setVar('visible', $bvisible);
        $myblock->setVar('title', $btitle);
        if( isset( $bcontent ) ) $myblock->setVar('content', $bcontent);
        if( isset( $bctype ) ) $myblock->setVar('c_type', $bctype);
        $myblock->setVar('bcachetime', $bcachetime);
        if ( isset($options) && (count($options) > 0) ) {

This code seems to be duplicated across your project.

            $options = implode('|', $options);
            $myblock->setVar('options', $options);
        }
        if ( $myblock->getVar('block_type') == 'C') {
            switch ( $myblock->getVar('c_type') ) {
            case 'H':
                $name = _AM_CUSTOMHTML;
                break;
            case 'P':
                $name = _AM_CUSTOMPHP;
                break;
            case 'S':
                $name = _AM_CUSTOMSMILE;
                break;
            default:
                $name = _AM_CUSTOMNOSMILE;
                break;
            }
            $myblock->setVar('name', $name);
        }
        $msg = _AM_DBUPDATED;
        if ($myblock->store() != false) {
            $db =& XoopsDatabaseFactory :: getdatabaseconnection();
            $sql = sprintf("DELETE FROM %s WHERE block_id = %u", $db->prefix('block_module_link'), $bid);
            $db->query($sql);
            foreach ($bmodule as $bmid) {
                $sql = sprintf("INSERT INTO %s (block_id, module_id) VALUES (%u, %d)", $db->prefix('block_module_link'), $bid, intval($bmid));
                $db->query($sql);
            }
            include_once XOOPS_ROOT_PATH.'/class/template.php';
            $xoopsTpl = new XoopsTpl();
            $xoopsTpl->xoops_setCaching(2);
            if ($myblock->getVar('template') != '') {
                if ($xoopsTpl->is_cached('db:'.$myblock->getVar('template'))) {
                    if (!$xoopsTpl->clear_cache('db:'.$myblock->getVar('template'))) {
                        $msg = 'Unable to clear cache for block ID'.$bid;
                    }
                }
            } else {
                if ($xoopsTpl->is_cached('db:system_dummy.html', 'block'.$bid)) {
                    if (!$xoopsTpl->clear_cache('db:system_dummy.html', 'block'.$bid)) {
                        $msg = 'Unable to clear cache for block ID'.$bid;
                    }
                }
            }
        } else {
            $msg = 'Failed update of block. ID:'.$bid;
        }
        // redirect_header('admin.php?fct=blocksadmin&t='.time(),1,$msg);

72% of this comment could be valid code. Did you maybe forget this after debugging?

        // exit(); GIJ -

45% of this comment could be valid code. Did you maybe forget this after debugging?

        return $msg ; // GIJ +
    }