notification.inc.php ➔ wflinks_notify_iteminfo() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/mambax..." - mambax7/wflinks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2bafa4...eb74eb )

by Michael

created 2017-09-25 02:16 UTC

notification.inc.php ➔ wflinks_notify_iteminfo() C

↳ Parent: Project

Complexity

Conditions	8
Paths	12

Size

Total Lines	52
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	33
nc	12
nop	2
dl	0
loc	52
rs	6.8493
c	0
b	0
f	0

How to fix Long Method

<?php
/*
 * Module: WF-Links
 * Version: v1.0.3
 * Release Date: 21 June 2005
 * Developer: John N
 * Team: WF-Projects
 * Licence: GNU
 */

/**
 * @param $category
 * @param $item_id
 *
 * @return null

 */
function wflinks_notify_iteminfo($category, $item_id)
{
    $moduleDirName = basename(dirname(__DIR__));
    global $xoopsModule, $xoopsModuleConfig, $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}

    if (empty($xoopsModule) || $xoopsModule->getVar('dirname') != $moduleDirName) {
        /** @var XoopsModuleHandler $moduleHandler */
        $moduleHandler = xoops_getHandler('module');
        $module        = $moduleHandler->getByDirname($moduleDirName);
        $configHandler = xoops_getHandler('config');
        $config        = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    } else {
        $module = $xoopsModule;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $config = $xoopsModuleConfig;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    if ('global' === $category) {
        $item['name'] = '';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $item['url']  = '';

        return $item;
    }

    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    if ('category' === $category) {
        // Assume we have a valid category id
        $sql = 'SELECT title FROM ' . $xoopsDB->prefix('wflinks_cat') . ' WHERE cid=' . $item_id;
        if (!$result = $xoopsDB->query($sql)) {
            return false;
        }
        $result_array = $xoopsDB->fetchArray($result);
        $item['name'] = $result_array['title'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $item['url']  = XOOPS_URL . '/modules/' . $moduleDirName . '/viewcat.php?cid=' . $item_id;

        return $item;
    }

    if ('link' === $category) {
        // Assume we have a valid file id
        $sql = 'SELECT cid,title FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $item_id;
        if (!$result = $xoopsDB->query($sql)) {
            return false;
        }
        $result_array = $xoopsDB->fetchArray($result);
        $item['name'] = $result_array['title'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $item['url']  = XOOPS_URL . '/modules/' . $moduleDirName . '/singlelink.php?cid=' . $result_array['cid'] . '&amp;lid=' . $item_id;

        return $item;
    }

    return null;
}


1			<?php
2			/*
3			* Module: WF-Links
4			* Version: v1.0.3
5			* Release Date: 21 June 2005
6			* Developer: John N
7			* Team: WF-Projects
8			* Licence: GNU
9			*/
10
11			/**
12			* @param $category
13			* @param $item_id
14			*
15			* @return null
			0 ignored issues – show Documentation introduced 2017-09-02 13:58 UTC by Report Bug Copy Issue Report Should the return type not be `array<string,string>\|false\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
16			*/
17			function wflinks_notify_iteminfo($category, $item_id)
18			{
19			$moduleDirName = basename(dirname(__DIR__));
20			global $xoopsModule, $xoopsModuleConfig, $xoopsConfig;
			0 ignored issues – show Compatibility Best Practice introduced 2017-09-02 10:39 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
21
22			if (empty($xoopsModule) \|\| $xoopsModule->getVar('dirname') != $moduleDirName) {
23			/** @var XoopsModuleHandler $moduleHandler */
24			$moduleHandler = xoops_getHandler('module');
25			$module = $moduleHandler->getByDirname($moduleDirName);
26			$configHandler = xoops_getHandler('config');
27			$config = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
			0 ignored issues – show Unused Code introduced 2017-09-04 04:46 UTC by Report Bug Copy Issue Report `$config` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
28			} else {
29			$module = $xoopsModule;
			0 ignored issues – show Unused Code introduced 2017-09-04 04:46 UTC by Report Bug Copy Issue Report `$module` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
30			$config = $xoopsModuleConfig;
			0 ignored issues – show Unused Code introduced 2017-09-04 04:46 UTC by Report Bug Copy Issue Report `$config` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
31			}
32
33			if ('global' === $category) {
34			$item['name'] = '';
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-09-25 02:18 UTC by Report Bug Copy Issue Report `$item` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$item = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
35			$item['url'] = '';
36
37			return $item;
38			}
39
40			global $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 09:02 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
41			if ('category' === $category) {
42			// Assume we have a valid category id
43			$sql = 'SELECT title FROM ' . $xoopsDB->prefix('wflinks_cat') . ' WHERE cid=' . $item_id;
44			if (!$result = $xoopsDB->query($sql)) {
45			return false;
46			}
47			$result_array = $xoopsDB->fetchArray($result);
48			$item['name'] = $result_array['title'];
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-09-02 10:39 UTC by Report Bug Copy Issue Report `$item` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$item = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
49			$item['url'] = XOOPS_URL . '/modules/' . $moduleDirName . '/viewcat.php?cid=' . $item_id;
50
51			return $item;
52			}
53
54			if ('link' === $category) {
55			// Assume we have a valid file id
56			$sql = 'SELECT cid,title FROM ' . $xoopsDB->prefix('wflinks_links') . ' WHERE lid=' . $item_id;
57			if (!$result = $xoopsDB->query($sql)) {
58			return false;
59			}
60			$result_array = $xoopsDB->fetchArray($result);
61			$item['name'] = $result_array['title'];
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-09-02 10:39 UTC by Report Bug Copy Issue Report `$item` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$item = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
62			$item['url'] = XOOPS_URL . '/modules/' . $moduleDirName . '/singlelink.php?cid=' . $result_array['cid'] . '&lid=' . $item_id;
63
64			return $item;
65			}
66
67			return null;
68			}
69

mambax7 / wflinks

Push — master ( 2bafa4...eb74eb )

notification.inc.php ➔ wflinks_notify_iteminfo() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like