wflLists

Complexity

Total Complexity

44

Size/Duplication

Total Lines	178
Duplicated Lines	13.48 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	getarray()	17	17	4
B	getDirListAsArray()	0	17	7
C	getListTypeAsArray()	0	41	14
D	getForum()	7	35	9
A	value()	0	4	1
A	selected()	0	4	1
A	paths()	0	4	1
A	size()	0	4	1
A	emptyselect()	0	4	1
A	type()	0	4	1
A	prefix()	0	4	1
A	suffix()	0	4	1
A	__construct()	0	9	2

<?php
/**
 * Class: wflLists
 * $Id: wfl_list.php v 1.00 21 June 2005 John N Exp $
 * Module: WF-Links
 * Version: v1.0.3
 * Release Date: 21 June 2005
 * Developer: John N
 * Team: WF-Projects
 * Licence: GNU
 */

class wflLists

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    var $value;

The visibility should be declared for property $value.

    var $selected;

The visibility should be declared for property $selected.

    var $path='uploads';

The visibility should be declared for property $path.

    var $size;

The visibility should be declared for property $size.

    var $emptyselect;

The visibility should be declared for property $emptyselect.

    var $type;

The visibility should be declared for property $type.

    var $prefix;

The visibility should be declared for property $prefix.

    var $suffix;

The visibility should be declared for property $suffix.

    function __construct($path="uploads", $value = null, $selected='', $size = 1, $emptyselect = 0, $type = 0, $prefix='', $suffix='')

The parameter $prefix is not used and could be removed.

The parameter $suffix is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this -> value = $value;
        $this -> selection = $selected;

The property selection does not exist. Did you maybe forget to declare it?

        $this -> path = $path;
        $this -> size = intval($size);
        $this -> emptyselect = ($emptyselect) ? 0 : 1;
        $this -> type = $type;
    }

    function &getarray($this_array) {

This method seems to be duplicated in your project.

        $ret="<select size='" . $this -> size() . "' name='$this->value()'>";
        if ($this -> emptyselect) {
            $ret .= "<option value='" . $this -> value() . "'>----------------------</option>";
        }
        foreach ($this_array as $content) {
            $opt_selected="";

            if ($content[0] == $this -> selected()) {
                $opt_selected="selected='selected'";
            }
            $ret .= "<option value='" . $content . "' $opt_selected>" . $content . "</option>";
        }
        $ret .= "</select>";

        return $ret;
    }

    /**
     * Private to be called by other parts of the class
     */
    function &getDirListAsArray($dirname) {
        $dirlist = array();
        if (is_dir($dirname) && $handle = opendir($dirname)) {
            while (false !== ($file = readdir($handle))) {
                if (!preg_match("/^[.]{1,2}$/", $file)) {
                    if (strtolower($file) != 'cvs' && is_dir($dirname . $file)) {
                        $dirlist[$file] = $file;
                    }
                }
            }
            closedir($handle);

            reset($dirlist);
        }

        return $dirlist;
    }

    function &getListTypeAsArray($dirname, $type='', $prefix="", $noselection = 1) {

        $filelist = array();
        switch (trim($type)) {
            case "images":
                $types="[.gif|.jpg|.png]";
                if ($noselection)
                    $filelist[""]=_AM_WFL_SHOWNOIMAGE;
                break;
            case "html":
                $types="[.htm|.html|.xhtml|.php|.php3|.phtml|.txt]";
                if ($noselection)
                    $filelist[""]="No Selection";
                break;
            default:
                $types="";
                if ($noselection)
                    $filelist[""]="No Selected File";
                break;
        }

        if (substr($dirname, -1) == '/') {
            $dirname = substr($dirname, 0, -1);
        }

        if (is_dir($dirname) && $handle = opendir($dirname)) {
            while (false !== ($file = readdir($handle))) {
                if (!preg_match("/^[.]{1,2}$/", $file) && preg_match("/$types$/i", $file) && is_file($dirname . '/' . $file)) {
                    if (strtolower($file) == "blank.gif")
                        Continue;
                    $file = $prefix . $file;
                    $filelist[$file] = $file;
                }
            }
            closedir($handle);
            asort($filelist);
            reset($filelist);
        }

        return $filelist;
    }

    function &getForum( $type = 1, $selected ) {

The return type could not be reliably inferred; please add a @return annotation.

        global $xoopsDB;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        switch ( xoops_trim( $type ) ) {
            case 2:
                $sql = "SELECT id, name FROM " . $xoopsDB->prefix( "ibf_forums" ) . " ORDER BY id";
                break;
            case 3:
                $sql = "SELECT forum_id, forum_name FROM " . $xoopsDB->prefix( "pbb_forums" ) . " ORDER BY forum_id";
                break;
            case 4:
                $sql = "SELECT forum_id, forum_name FROM " . $xoopsDB -> prefix('bbex_forums') . " ORDER BY forum_id";
                break;
            case 1:
            case 0:
            default:
                $sql = "SELECT forum_id, forum_name FROM " . $xoopsDB->prefix( "bb_forums" ) . " ORDER BY forum_id";
                break;
        }
        $result = $xoopsDB->query( $sql );

        $noforum = ( defined( '_WFL_NO_FORUM' ) ) ? _WFL_NO_FORUM : _AM_WFL_NO_FORUM;

        echo "<select size='1' name='forumid'>";
        echo "<option value='0'>" . $noforum . "</option>";
        while (list($forum_id, $forum_name ) = $xoopsDB -> fetchRow($result)) {

This code seems to be duplicated across your project.

            $opt_selected = "";
            if ($forum_id == $selected) {
                $opt_selected = "selected='selected'";
            }
            echo "<option value='" . $forum_id . "' $opt_selected>" . $forum_name . "</option>";
        }
        echo "</select>";

           return $forum_array;

The variable $forum_array does not exist. Did you forget to declare it?

    }

    function value()

The return type could not be reliably inferred; please add a @return annotation.

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->value;
    }

    function selected()

The return type could not be reliably inferred; please add a @return annotation.

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->selected;
    }

    function paths()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->path;
    }

    function size()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->size;
    }

    function emptyselect()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->emptyselect;
    }

    function type()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->type;
    }

    function prefix()

The return type could not be reliably inferred; please add a @return annotation.

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->prefix;
    }

    function suffix()

The return type could not be reliably inferred; please add a @return annotation.

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->suffix;
    }
}