Code Duplication - mambax7/wflinks - Measure and Improve Code Quality continuously with Scrutinizer

Code Duplication Length = 56-56 lines in 2 locations

include/functions.php 2 locations


 *
 * @return null|string
 */
function wfl_getbanner_from_id_banner($banner_id)
{
    ###### Hack by www.stefanosilvestrini.com ######
    global $xoopsConfig;
    $db      = XoopsDatabaseFactory::getDatabaseConnection();
    $bresult = $db->query('SELECT COUNT(*) FROM ' . $db->prefix('banner') . ' WHERE bid=' . $banner_id);
    list($numrows) = $db->fetchRow($bresult);
    if ($numrows > 1) {
        $numrows = $numrows - 1;
        mt_srand((double)microtime() * 1000000);
        $bannum = mt_rand(0, $numrows);
    } else {
        $bannum = 0;
    }
    if ($numrows > 0) {
        $bresult = $db->query('SELECT * FROM ' . $db->prefix('banner') . ' WHERE bid=' . $banner_id, 1, $bannum);
        list($bid, $cid, $imptotal, $impmade, $clicks, $imageurl, $clickurl, $date, $htmlbanner, $htmlcode) = $db->fetchRow($bresult);
        if ($xoopsConfig['my_ip'] == xoops_getenv('REMOTE_ADDR')) {
            // EMPTY
        } else {
            $db->queryF(sprintf('UPDATE %s SET impmade = impmade+1 WHERE bid = %u', $db->prefix('banner'), $bid));
        }
        /* Check if this impression is the last one and print the banner */
        if ($imptotal == $impmade) {
            $newid = $db->genId($db->prefix('bannerfinish') . '_bid_seq');
            $sql   = sprintf('INSERT INTO %s (bid, cid, impressions, clicks, datestart, dateend) VALUES (%u, %u, %u, %u, %u, %u)', $db->prefix('bannerfinish'), $newid, $cid, $impmade, $clicks, $date, time());
            $db->queryF($sql);
            $db->queryF(sprintf('DELETE FROM %s WHERE bid = %u', $db->prefix('banner'), $bid));
        }
        if ($htmlbanner) {
            $bannerobject = $htmlcode;
        } else {
            $bannerobject = '<div align="center"><a href="' . XOOPS_URL . '/banners.php?op=click&bid=' . $bid . '" target="_blank">';
            if (stristr($imageurl, '.swf')) {
                $bannerobject = $bannerobject
                                . '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" width="468" height="60">'
                                . '<param name="movie" value="'
                                . $imageurl
                                . '"></param>'
                                . '<param name="quality" value="high"></param>'
                                . '<embed src="'
                                . $imageurl
                                . '" quality="high" pluginspage="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash" type="application/x-shockwave-flash" width="468" height="60">'
                                . '</embed>'
                                . '</object>';
            } else {
                $bannerobject = $bannerobject . '<img src="' . $imageurl . '" alt="">';
            }
            $bannerobject = $bannerobject . '</a></div>';
        }

        return $bannerobject;
    }

    return null;
}

/**
 * @param $client_id

 *
 * @return string
 */
function wfl_getbanner_from_id_client($client_id)
{
    ###### Hack by www.stefanosilvestrini.com ######
    global $xoopsConfig;
    $db      = XoopsDatabaseFactory::getDatabaseConnection();
    $bresult = $db->query('SELECT COUNT(*) FROM ' . $db->prefix('banner') . ' WHERE cid=' . $client_id);
    list($numrows) = $db->fetchRow($bresult);
    if ($numrows > 1) {
        $numrows = $numrows - 1;
        mt_srand((double)microtime() * 1000000);
        $bannum = mt_rand(0, $numrows);
    } else {
        $bannum = 0;
    }
    if ($numrows > 0) {
        $bresult = $db->query('SELECT * FROM ' . $db->prefix('banner') . ' WHERE cid=' . $client_id . ' ORDER BY rand()', 1, $bannum);
        list($bid, $cid, $imptotal, $impmade, $clicks, $imageurl, $clickurl, $date, $htmlbanner, $htmlcode) = $db->fetchRow($bresult);
        if ($xoopsConfig['my_ip'] == xoops_getenv('REMOTE_ADDR')) {
            // EMPTY
        } else {
            $db->queryF(sprintf('UPDATE %s SET impmade = impmade+1 WHERE bid = %u', $db->prefix('banner'), $bid));
        }
        /* Check if this impression is the last one and print the banner */
        if ($imptotal == $impmade) {
            $newid = $db->genId($db->prefix('bannerfinish') . '_bid_seq');
            $sql   = sprintf('INSERT INTO %s (bid, cid, impressions, clicks, datestart, dateend) VALUES (%u, %u, %u, %u, %u, %u)', $db->prefix('bannerfinish'), $newid, $cid, $impmade, $clicks, $date, time());
            $db->queryF($sql);
            $db->queryF(sprintf('DELETE FROM %s WHERE bid = %u', $db->prefix('banner'), $bid));
        }
        if ($htmlbanner) {
            $bannerobject = $htmlcode;
        } else {
            $bannerobject = '<div align="center"><a href="' . XOOPS_URL . '/banners.php?op=click&bid=' . $bid . '" target="_blank">';
            if (stristr($imageurl, '.swf')) {
                $bannerobject = $bannerobject
                                . '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" width="468" height="60">'
                                . '<param name="movie" value="'
                                . $imageurl
                                . '"></param>'
                                . '<param name="quality" value="high"></param>'
                                . '<embed src="'
                                . $imageurl
                                . '" quality="high" pluginspage="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash" type="application/x-shockwave-flash" width="468" height="60">'
                                . '</embed>'
                                . '</object>';
            } else {
                $bannerobject = $bannerobject . '<img src="' . $imageurl . '" alt="">';
            }
            $bannerobject = $bannerobject . '</a></div>';
        }

        return $bannerobject;
    }

    return null;
}

/**
 * @param $email

		@@ 1912-1967 (lines=56) @@
1909		*
1910		* @return null\|string
1911		*/
1912		function wfl_getbanner_from_id_banner($banner_id)
1913		{
1914		###### Hack by www.stefanosilvestrini.com ######
1915		global $xoopsConfig;
1916		$db = XoopsDatabaseFactory::getDatabaseConnection();
1917		$bresult = $db->query('SELECT COUNT(*) FROM ' . $db->prefix('banner') . ' WHERE bid=' . $banner_id);
1918		list($numrows) = $db->fetchRow($bresult);
1919		if ($numrows > 1) {
1920		$numrows = $numrows - 1;
1921		mt_srand((double)microtime() * 1000000);
1922		$bannum = mt_rand(0, $numrows);
1923		} else {
1924		$bannum = 0;
1925		}
1926		if ($numrows > 0) {
1927		$bresult = $db->query('SELECT * FROM ' . $db->prefix('banner') . ' WHERE bid=' . $banner_id, 1, $bannum);
1928		list($bid, $cid, $imptotal, $impmade, $clicks, $imageurl, $clickurl, $date, $htmlbanner, $htmlcode) = $db->fetchRow($bresult);
1929		if ($xoopsConfig['my_ip'] == xoops_getenv('REMOTE_ADDR')) {
1930		// EMPTY
1931		} else {
1932		$db->queryF(sprintf('UPDATE %s SET impmade = impmade+1 WHERE bid = %u', $db->prefix('banner'), $bid));
1933		}
1934		/* Check if this impression is the last one and print the banner */
1935		if ($imptotal == $impmade) {
1936		$newid = $db->genId($db->prefix('bannerfinish') . '_bid_seq');
1937		$sql = sprintf('INSERT INTO %s (bid, cid, impressions, clicks, datestart, dateend) VALUES (%u, %u, %u, %u, %u, %u)', $db->prefix('bannerfinish'), $newid, $cid, $impmade, $clicks, $date, time());
1938		$db->queryF($sql);
1939		$db->queryF(sprintf('DELETE FROM %s WHERE bid = %u', $db->prefix('banner'), $bid));
1940		}
1941		if ($htmlbanner) {
1942		$bannerobject = $htmlcode;
1943		} else {
1944		$bannerobject = '<div align="center"><a href="' . XOOPS_URL . '/banners.php?op=click&bid=' . $bid . '" target="_blank">';
1945		if (stristr($imageurl, '.swf')) {
1946		$bannerobject = $bannerobject
1947		. '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" width="468" height="60">'
1948		. '<param name="movie" value="'
1949		. $imageurl
1950		. '"></param>'
1951		. '<param name="quality" value="high"></param>'
1952		. '<embed src="'
1953		. $imageurl
1954		. '" quality="high" pluginspage="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash" type="application/x-shockwave-flash" width="468" height="60">'
1955		. '</embed>'
1956		. '</object>';
1957		} else {
1958		$bannerobject = $bannerobject . '<img src="' . $imageurl . '" alt="">';
1959		}
1960		$bannerobject = $bannerobject . '</a></div>';
1961		}
1962
1963		return $bannerobject;
1964		}
1965
1966		return null;
1967		}
1968
1969		/**
1970		* @param $client_id
		@@ 1974-2029 (lines=56) @@
1971		*
1972		* @return string
1973		*/
1974		function wfl_getbanner_from_id_client($client_id)
1975		{
1976		###### Hack by www.stefanosilvestrini.com ######
1977		global $xoopsConfig;
1978		$db = XoopsDatabaseFactory::getDatabaseConnection();
1979		$bresult = $db->query('SELECT COUNT(*) FROM ' . $db->prefix('banner') . ' WHERE cid=' . $client_id);
1980		list($numrows) = $db->fetchRow($bresult);
1981		if ($numrows > 1) {
1982		$numrows = $numrows - 1;
1983		mt_srand((double)microtime() * 1000000);
1984		$bannum = mt_rand(0, $numrows);
1985		} else {
1986		$bannum = 0;
1987		}
1988		if ($numrows > 0) {
1989		$bresult = $db->query('SELECT * FROM ' . $db->prefix('banner') . ' WHERE cid=' . $client_id . ' ORDER BY rand()', 1, $bannum);
1990		list($bid, $cid, $imptotal, $impmade, $clicks, $imageurl, $clickurl, $date, $htmlbanner, $htmlcode) = $db->fetchRow($bresult);
1991		if ($xoopsConfig['my_ip'] == xoops_getenv('REMOTE_ADDR')) {
1992		// EMPTY
1993		} else {
1994		$db->queryF(sprintf('UPDATE %s SET impmade = impmade+1 WHERE bid = %u', $db->prefix('banner'), $bid));
1995		}
1996		/* Check if this impression is the last one and print the banner */
1997		if ($imptotal == $impmade) {
1998		$newid = $db->genId($db->prefix('bannerfinish') . '_bid_seq');
1999		$sql = sprintf('INSERT INTO %s (bid, cid, impressions, clicks, datestart, dateend) VALUES (%u, %u, %u, %u, %u, %u)', $db->prefix('bannerfinish'), $newid, $cid, $impmade, $clicks, $date, time());
2000		$db->queryF($sql);
2001		$db->queryF(sprintf('DELETE FROM %s WHERE bid = %u', $db->prefix('banner'), $bid));
2002		}
2003		if ($htmlbanner) {
2004		$bannerobject = $htmlcode;
2005		} else {
2006		$bannerobject = '<div align="center"><a href="' . XOOPS_URL . '/banners.php?op=click&bid=' . $bid . '" target="_blank">';
2007		if (stristr($imageurl, '.swf')) {
2008		$bannerobject = $bannerobject
2009		. '<object classid="clsid:D27CDB6E-AE6D-11cf-96B8-444553540000" codebase="http://download.macromedia.com/pub/shockwave/cabs/flash/swflash.cab#version=6,0,40,0" width="468" height="60">'
2010		. '<param name="movie" value="'
2011		. $imageurl
2012		. '"></param>'
2013		. '<param name="quality" value="high"></param>'
2014		. '<embed src="'
2015		. $imageurl
2016		. '" quality="high" pluginspage="http://www.macromedia.com/shockwave/download/index.cgi?P1_Prod_Version=ShockwaveFlash" type="application/x-shockwave-flash" width="468" height="60">'
2017		. '</embed>'
2018		. '</object>';
2019		} else {
2020		$bannerobject = $bannerobject . '<img src="' . $imageurl . '" alt="">';
2021		}
2022		$bannerobject = $bannerobject . '</a></div>';
2023		}
2024
2025		return $bannerobject;
2026		}
2027
2028		return null;
2029		}
2030
2031		/**
2032		* @param $email

mambax7 / wflinks

Code Duplication Length = 56-56 lines in 2 locations

include/functions.php 2 locations