b_waiting_xfsection()

Complexity

Conditions	3
Paths	4

Size

Total Lines	27
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php declare(strict_types=1);
function b_waiting_xfsection()
{
    /** @var \XoopsMySQLDatabase $xoopsDB */
    $xoopsDB = \XoopsDatabaseFactory::getDatabaseConnection();
    $ret     = [];

    // xf-section articles - waiting
    $block  = [];
    $result = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('xfs_article') . ' WHERE published=0');
    if ($result) {
        $block['adminlink'] = XOOPS_URL . '/modules/xfsection/admin/allarticles.php?action=submitted';
        [$block['pendingnum']] = $xoopsDB->fetchRow($result);

It seems like $result can also be of type true; however, parameter $result of XoopsMySQLDatabase::fetchRow() does only seem to accept mysqli_result, maybe add an additional type check?

        $block['lang_linkname'] = _PI_WAITING_WAITINGS;
    }
    $ret[] = $block;

    // xf-section articles - attach broken
    $block  = [];
    $result = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('xfs_broken') . '');
    if ($result) {
        $block['adminlink'] = XOOPS_URL . '/modules/xfsection/admin/brokendown.php?op=listBrokenDownloads';
        [$block['pendingnum']] = $xoopsDB->fetchRow($result);
        $block['lang_linkname'] = _PI_WAITING_FILES . ' ' . _PI_WAITING_BROKENS;
    }
    $ret[] = $block;

    return $ret;
}