b_waiting_newbb()

Complexity

Conditions	3
Paths	3

Size

Total Lines	24
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php declare(strict_types=1);
function b_waiting_newbb()
{
    /** @var \XoopsMySQLDatabase $xoopsDB */
    $xoopsDB = \XoopsDatabaseFactory::getDatabaseConnection();
    $ret     = [];
    $block   = [];

    // judge the version of newbb/
    if (!file_exists(XOOPS_ROOT_PATH . '/modules/newbb/polls.php')) {
        // newbb1
        return [];
    }

    // works with newbb2 or CBB 1.14
    $result = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('newbb_posts') . ' WHERE approved=0');
    if ($result) {
        $block['adminlink'] = XOOPS_URL . '/modules/newbb/admin/index.php';
        [$block['pendingnum']] = $xoopsDB->fetchRow($result);

It seems like $result can also be of type true; however, parameter $result of XoopsMySQLDatabase::fetchRow() does only seem to accept mysqli_result, maybe add an additional type check?

        $block['lang_linkname'] = _PI_WAITING_SUBMITTED;
    }

    $ret[] = $block;

    return $ret;
}