b_waiting_myalbum_0()

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php declare(strict_types=1);
function b_waiting_myalbum_0($mydirnumber = '')
{
    /** @var \XoopsMySQLDatabase $xoopsDB */
    $xoopsDB = \XoopsDatabaseFactory::getDatabaseConnection();
    $ret     = [];
    $block   = [];

    $result = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix("myalbum{$mydirnumber}_photos") . ' WHERE STATUS=0');
    if ($result) {
        $block['adminlink'] = XOOPS_URL . "/modules/myalbum{$mydirnumber}/admin/admission.php";
        [$block['pendingnum']] = $xoopsDB->fetchRow($result);

It seems like $result can also be of type true; however, parameter $result of XoopsMySQLDatabase::fetchRow() does only seem to accept mysqli_result, maybe add an additional type check?

        $block['lang_linkname'] = _PI_WAITING_WAITINGS . ('' === $mydirnumber ? '' : "({$mydirnumber})");
    }

    $ret[] = $block;

    return $ret;
}