mambax7 / tdmcreate-1.91

class/Files/CreateFile.php

<?php namespace XoopsModules\Tdmcreate\Files;

use XoopsModules\Tdmcreate;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */
/**
 * tdmcreate module.
 *
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 *
 * @since           2.5.0
 *
 * @author          Txmod Xoops http://www.txmodxoops.org
 *
 * @version         $Id: CreateFile.php 12258 2014-01-02 09:33:29Z timgno $
 */
xoops_load('XoopsFile');
/**
 * Class CreateFile.
 */
class CreateFile extends CreateTableFields
{
    /**
     * @var string
     */
    private $xf = null;

    /**
     * "fileName" attribute of the files.
     *
     * @var mixed
     */
    private $fileName = null;

    /**
     * "subdir" attribute of the directories.
     *
     * @var string
     */
    private $subdir = null;

    /**
     * "uploadPath" attribute of the files.
     *
     * @var string
     */
    private $uploadPath = null;

    /**
     * @var string
     */
    private $content = null;

    /**
     * @var mixed
     */
    private $created = null;

    /**
     * @var mixed
     */
    private $notCreated = null;

    /**
     * @var string
     */
    private $mode = null;

    /**
     * @var string
     */
    protected $phpcode = null;

    /**
     * @var string
     */
    protected $htmlcode;

    /**
     *  @public function constructor
     *  @param null
     */
    public function __construct()
    {
        parent::__construct();
        $this->xf = \XoopsFile::getHandler();

It seems like XoopsFile::getHandler() can also be of type XoopsFileHandler. However, the property $xf is declared as type string. Maybe add an additional type check?

    }

    /**
     *  @public static function getInstance
     *  @param null
     * @return Tdmcreate\Files\CreateFile
     */
    public static function getInstance()
    {
        static $instance = false;
        if (!$instance) {
            $instance = new self();
        }

        return $instance;
    }

    /**
     * @public function create
     *
     * @param $moduleDirname
     * @param $subdir
     * @param $fileName
     * @param $content
     * @param $created
     * @param $notCreated
     * @param $mode
     */
    public function create($moduleDirname, $subdir = null, $fileName = null, $content = '', $created = null, $notCreated = null, $mode = 'w+')
    {
        $this->setFileName($fileName);
        $this->created = $created;
        $this->notCreated = $notCreated;
        $this->setMode($mode);
        $this->setRepositoryPath($moduleDirname);
        if (!empty($content) && is_string($content)) {
            $this->setContent($content);
        }
        if (isset($subdir) && is_string($subdir)) {
            $this->setSubDir($subdir);
        }
    }

    /**
     *  @public function write
     *  @param string $module
     *  @param string $fileName
     * @param mixed $moduleDirname
     */
    /*public function write($module, $fileName)
    {
        $this->setModule($module);
        $this->setFileName($fileName);
    }*/

    /**
     *  @private function setRepositoryPath
     *  @param string $moduleDirname
     */
    private function setRepositoryPath($moduleDirname)
    {
        $this->uploadPath = TDMC_UPLOAD_REPOSITORY_PATH . '/' . $moduleDirname;
    }

    /**
     *  @private function getRepositoryPath
     *  @param null
     * @return string
     */
    private function getRepositoryPath()
    {
        return $this->uploadPath;
    }

    /**
     * @private function setSubDir
     * @param $subdir
     */
    private function setSubDir($subdir)
    {
        $this->subdir = $subdir;
    }

    /**
     * @private function getSubDir
     * @param null
     * @return string
     */
    private function getSubDir()
    {
        return $this->subdir;
    }

    /**
     * public function setFileName.
     *
     * @param $fileName
     */
    public function setFileName($fileName)
    {
        $this->fileName = $fileName;
    }

    /**
     *  @public function getFileName
     *  @param null
     * @return mixed
     */
    public function getFileName()
    {
        return $this->fileName;
    }

    /**
     * @private function setContent
     * @param $content
     */
    private function setContent($content)
    {
        $this->content = $content;
    }

    /**
     * @private function setContent
     * @param null
     * @return string
     */
    private function getContent()
    {
        return $this->content;
    }

    /**
     *  @private function getFolderName
     *  @param null
     * @return string
     */
    private function getFolderName()
    {
        $path = $this->getUploadPath();
        if (mb_strrpos($path, '\\')) {
            $str = mb_strrpos($path, '\\');
            if (false !== $str) {
                return mb_substr($path, $str + 1, mb_strlen($path));
            }

            return mb_substr($path, $str, mb_strlen($path));
        }
        //return 'root module';
        return false;

The expression return false returns the type false which is incompatible with the documented return type string.

    }

    /**
     *  @public function getUploadPath
     *  @param null
     * @return string
     */
    private function getUploadPath()
    {
        if (null != $this->getSubDir()) {
            $ret = $this->getRepositoryPath() . '/' . $this->getSubDir();
        } else {
            $ret = $this->getRepositoryPath();
        }

        return $ret;
    }

    /**
     *  @private function getCreated
     *  @param null
     * @return bool
     */
    private function getCreated()
    {
        return $this->created;
    }

    /**
     *  @private function getNotCreated
     *  @param null
     * @return bool
     */
    private function getNotCreated()
    {
        return $this->notCreated;
    }

    /**
     * @private function setMode
     * @param $mode
     */
    private function setMode($mode)
    {
        $this->mode = $mode;
    }

    /**
     * @private function getMode
     * @param null
     * @return string
     */
    private function getMode()
    {
        return $this->mode;
    }

    /**
     *  @public function getLanguage
     *  @param string $moduleDirname
     *  @param string $prefix
     *  @param string $suffix
     *
     * @return string
     */
    public function getLanguage($moduleDirname, $prefix = '', $suffix = '')
    {
        $lang = '_' . $prefix . '_' . mb_strtoupper($moduleDirname);
        $ret = $lang;
        if (!empty($suffix) || '_' !== $suffix) {
            $ret = $lang . '_' . $suffix;
        } elseif ('_' === $suffix) {
            $ret = $lang . '_';
        }

        return $ret;
    }

    /**
     *  @public function getLeftString
     *  @param string $string
     *
     * @return string
     */
    public function getLeftString($string)
    {
        return mb_substr($string, 0, mb_strpos($string, '_'));
    }

    /**
     *  @public function getRightString
     *  @param $string
     *
     * @return string
     */
    public function getRightString($string = null)
    {
        if (mb_strpos($string, '_')) {
            $str = mb_strpos($string, '_');
            if (false !== $str) {
                $ret = mb_substr($string, $str + 1, mb_strlen($string));

                return $ret;
            }
        }

        return $string;
    }

    /**
     *  @public function getCamelCase
     *  @param $string
     * @param $ucfirst
     * @param $lcfirst
     *
     * @return string
     */
    public function getCamelCase($string, $ucfirst = false, $lcfirst = false)
    {
        $rightString = $this->getRightString($string);
        $leftString = $this->getLeftString($string);
        if ($ucfirst) {
            return $this->getUcfirst($leftString) . $this->getUcfirst($rightString);
        }
        if ($lcfirst) {
            return $this->getLcfirst($leftString) . $this->getUcfirst($rightString);
        }

        return $string;
    }

    /**
     *  @public function getUcfirst
     *  @param $string
     *
     * @return string
     */
    public function getUcfirst($string)
    {
        return ucfirst($string);
    }

    /**
     * @public function getLcfirst
     *
     * @param $string
     * @return string
     */
    public function getLcfirst($string)
    {
        return lcfirst($string);
    }

    /**
     * @public function getStrToUpper
     *
     * @param $string
     * @return string
     */
    public function getStrToUpper($string)
    {
        return mb_strtoupper($string);
    }

    /**
     *  @public function getStrToLower
     *  @param $string
     *
     * @return string
     */
    public function getStrToLower($string)
    {
        return mb_strtolower($string);
    }

    /**
     *  @public function getInclude
     *  @param $filename
     * @return string
     */
    public function getInclude($filename = 'header')
    {
        return "include __DIR__ . '/{$filename}.php';\n";
    }

    /**
     *  @public function getIncludeOnce
     *  @param $filename
     * @return string
     */
    public function getIncludeOnce($filename = 'header')
    {
        return "include_once __DIR__ . '/{$filename}.php';\n";
    }

    /**
     * @private function getDashComment
     *
     * @param $comment
     *
     * @return string
     */
    public function getDashComment($comment)
    {
        return "// ------------------- {$comment} ------------------- //\n";
    }

    /**
     * @public function getSimpleString
     * @param        $string
     *
     * @param string $t
     * @return string
     */
    public function getSimpleString($string, $t = '')
    {
        return "{$t}{$string}\n";
    }

    /**
     *  @public function getHeaderFilesComments
     *  @param string $module
     *  @param string $fileName
     * @param $noPhpFile
     *
     * @return string
     */
    public function getHeaderFilesComments($module, $fileName, $noPhpFile = null)
    {
        $name = $module->getVar('mod_name');
        $dirname = $module->getVar('mod_dirname');
        $version = $module->getVar('mod_version');
        $since = $module->getVar('mod_since');
        $minXoops = $module->getVar('mod_min_xoops');
        $author = $module->getVar('mod_author');
        $credits = $module->getVar('mod_credits');
        $authorMail = $module->getVar('mod_author_mail');
        $authorWebsiteUrl = $module->getVar('mod_author_website_url');
        $license = $module->getVar('mod_license');
        $subversion = $module->getVar('mod_subversion');
        $date = date('D Y-m-d H:i:s');
        if (null === $noPhpFile) {
            $ret = "<?php\n";
            $ret .= "/*\n";
        } elseif (is_string($noPhpFile)) {
            $ret = $noPhpFile;
            $ret .= "\n/*\n";
        } else {
            $ret .= "\n/*\n";

The variable $ret seems to be never defined.

        }
        $filename = TDMC_CLASS_PATH . '/files/docs/license.txt';
        $handle = fopen($filename, 'rb');
        $data = fread($handle, filesize($filename));

It seems like $handle can also be of type false; however, parameter $handle of fread() does only seem to accept resource, maybe add an additional type check?

        fclose($handle);

It seems like $handle can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        $ret .= $data . "\n";

The variable $ret does not seem to be defined for all execution paths leading up to this point.

        $ret .= "*/\n";
        $copyright = [
            $name => 'module for xoops', '' => '', '@copyright  ' => '   module for xoops', '@license   ' => "    {$license}", '@package   ' => "    {$dirname}",
            '@since    ' => "     {$since}", '@min_xoops   ' => "  {$minXoops}", '@author    ' => "    {$author} - Email:<{$authorMail}> - Website:<{$authorWebsiteUrl}>",
            '@version    ' => "   \$Id: {$version} {$fileName} {$subversion} {$date}Z {$credits} \$",
        ];
        $ret .= Tdmcreate\Files\CreatePhpCode::getInstance()->getPhpCodeCommentMultiLine($copyright);

        return $ret;
    }

    /**
     *  @public function renderFile
     *  @param null
     * @return string
     */
    public function renderFile()
    {
        $fileName = $this->getFileName();
        $path = $this->getUploadPath() . '/' . $fileName;
        $created = $this->getCreated();
        $notCreated = $this->getNotCreated();
        $folderName = $this->getFolderName();
        $mode = $this->getMode();
        $ret = '';
        if (!$this->xf->__construct($path, true)) {
            // Force to create file if not exist
            if ($this->xf->open($mode, true)) {
                if ($this->xf->writable()) {
                    // Integration of the content in the file
                    if (!$this->xf->write($this->getContent(), $mode, true)) {
                        $ret .= sprintf($notCreated, $fileName, $folderName);
                        $GLOBALS['xoopsTpl']->assign('created', false);
                        exit();

Using exit here is not recommended.

                    }
                    // Created
                    $ret .= sprintf($created, $fileName, $folderName);
                    $GLOBALS['xoopsTpl']->assign('created', true);
                    $this->xf->close();
                } else {
                    $ret .= sprintf($notCreated, $fileName, $folderName);
                    $GLOBALS['xoopsTpl']->assign('created', false);
                }
            } else {
                $ret .= sprintf($notCreated, $fileName, $folderName);
                $GLOBALS['xoopsTpl']->assign('created', false);
            }
        }

        return $ret;
    }
}