mambax7 /
tdmcreate-1.91
| Total Complexity | 57 |
| Total Lines | 756 |
| Duplicated Lines | 0 % |
| Changes | 7 | ||
| Bugs | 0 | Features | 0 |
Complex classes like ClassFormElements often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ClassFormElements, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 28 | class ClassFormElements extends TDMCreateAbstract |
||
| 29 | { |
||
| 30 | /** |
||
| 31 | * @static function getInstance |
||
| 32 | * @param null |
||
| 33 | * |
||
| 34 | * @return ClassFormElements |
||
| 35 | */ |
||
| 36 | public static function getInstance() |
||
| 45 | |||
| 46 | /** |
||
| 47 | * @public function initForm |
||
| 48 | * |
||
| 49 | * @param $module |
||
| 50 | * @param $table |
||
| 51 | */ |
||
| 52 | public function initForm($module, $table) |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @private function getXoopsFormText |
||
| 60 | * |
||
| 61 | * @param $language |
||
| 62 | * @param $fieldName |
||
| 63 | * @param $fieldDefault |
||
| 64 | * @param string $required |
||
| 65 | * @return string |
||
| 66 | */ |
||
| 67 | private function getXoopsFormText($language, $fieldName, $fieldDefault, $required = 'false') |
||
| 87 | |||
| 88 | /** |
||
| 89 | * @private function getXoopsFormText |
||
| 90 | * |
||
| 91 | * @param $language |
||
| 92 | * @param $fieldName |
||
| 93 | * @param $required |
||
| 94 | * |
||
| 95 | * @return string |
||
| 96 | */ |
||
| 97 | private function getXoopsFormTextArea($language, $fieldName, $required = 'false') |
||
| 109 | |||
| 110 | /** |
||
| 111 | * @private function getXoopsFormDhtmlTextArea |
||
| 112 | * |
||
| 113 | * @param $language |
||
| 114 | * @param $moduleDirname |
||
| 115 | * @param $fieldName |
||
| 116 | * @param $required |
||
| 117 | * |
||
| 118 | * @return string |
||
| 119 | */ |
||
| 120 | private function getXoopsFormDhtmlTextArea($language, $moduleDirname, $fieldName, $required = 'false') |
||
| 144 | |||
| 145 | /** |
||
| 146 | * @private function getXoopsFormCheckBox |
||
| 147 | * |
||
| 148 | * @param $language |
||
| 149 | * @param $tableSoleName |
||
| 150 | * @param $fieldName |
||
| 151 | * @param $fieldElementId |
||
| 152 | * @param string $required |
||
| 153 | * @return string |
||
| 154 | */ |
||
| 155 | private function getXoopsFormCheckBox($language, $tableSoleName, $fieldName, $fieldElementId, $required = 'false') |
||
| 186 | |||
| 187 | /** |
||
| 188 | * @private function getXoopsFormHidden |
||
| 189 | * |
||
| 190 | * @param $fieldName |
||
| 191 | * |
||
| 192 | * @return string |
||
| 193 | */ |
||
| 194 | private function getXoopsFormHidden($fieldName) |
||
| 206 | |||
| 207 | /** |
||
| 208 | * @private function getXoopsFormImageList |
||
| 209 | * |
||
| 210 | * @param $language |
||
| 211 | * @param $moduleDirname |
||
| 212 | * @param $tableName |
||
| 213 | * @param $tableSoleName |
||
| 214 | * @param $fieldName |
||
| 215 | * @param $required |
||
| 216 | * |
||
| 217 | * @return string |
||
| 218 | */ |
||
| 219 | private function getXoopsFormImageList($language, $moduleDirname, $tableName, $tableSoleName, $fieldName, $required = 'false') |
||
| 259 | |||
| 260 | /** |
||
| 261 | * @private function getXoopsFormSelectFile |
||
| 262 | * |
||
| 263 | * @param $language |
||
| 264 | * @param $moduleDirname |
||
| 265 | * @param $fieldName |
||
| 266 | * @param $required |
||
| 267 | * |
||
| 268 | * @return string |
||
| 269 | */ |
||
| 270 | private function getXoopsFormSelectFile($language, $moduleDirname, $fieldName, $required = 'false') |
||
| 310 | |||
| 311 | /** |
||
| 312 | * @private function getXoopsFormUrlFile |
||
| 313 | * |
||
| 314 | * @param $language |
||
| 315 | * @param $moduleDirname |
||
| 316 | * @param $fieldName |
||
| 317 | * @param $fieldDefault |
||
| 318 | * @param $required |
||
| 319 | * |
||
| 320 | * @return string |
||
| 321 | */ |
||
| 322 | private function getXoopsFormUrlFile($language, $moduleDirname, $fieldName, $fieldDefault, $required = 'false') |
||
| 342 | |||
| 343 | /** |
||
| 344 | * @private function getXoopsFormUploadImage |
||
| 345 | * |
||
| 346 | * @param $language |
||
| 347 | * @param $moduleDirname |
||
| 348 | * @param $tableName |
||
| 349 | * @param $tableSoleName |
||
| 350 | * @param $fieldName |
||
| 351 | * @param string $required |
||
| 352 | * @return string |
||
| 353 | */ |
||
| 354 | private function getXoopsFormUploadImage($language, $moduleDirname, $tableName, $tableSoleName, $fieldName, $required = 'false') |
||
| 393 | |||
| 394 | /** |
||
| 395 | * @private function getXoopsFormUploadFile |
||
| 396 | * |
||
| 397 | * @param $language |
||
| 398 | * @param $moduleDirname |
||
| 399 | * @param $tableName |
||
| 400 | * @param $fieldName |
||
| 401 | * @param $required |
||
| 402 | * |
||
| 403 | * @return string |
||
| 404 | */ |
||
| 405 | private function getXoopsFormUploadFile($language, $moduleDirname, $tableName, $fieldName, $required = 'false') |
||
| 421 | |||
| 422 | /** |
||
| 423 | * @private function getXoopsFormColorPicker |
||
| 424 | * |
||
| 425 | * @param $language |
||
| 426 | * @param $moduleDirname |
||
| 427 | * @param $fieldName |
||
| 428 | * @param $required |
||
| 429 | * |
||
| 430 | * @return string |
||
| 431 | */ |
||
| 432 | private function getXoopsFormColorPicker($language, $moduleDirname, $fieldName, $required = 'false') |
||
| 447 | |||
| 448 | /** |
||
| 449 | * @private function getXoopsFormSelectBox |
||
| 450 | * |
||
| 451 | * @param $language |
||
| 452 | * @param $moduleDirname |
||
| 453 | * @param $tableName |
||
| 454 | * @param $fieldName |
||
| 455 | * @param $required |
||
| 456 | * |
||
| 457 | * @return string |
||
| 458 | */ |
||
| 459 | private function getXoopsFormSelectBox($language, $moduleDirname, $tableName, $fieldName, $required = 'false') |
||
| 478 | |||
| 479 | /** |
||
| 480 | * @private function getXoopsFormSelectUser |
||
| 481 | * |
||
| 482 | * @param $language |
||
| 483 | * @param $moduleDirname |
||
| 484 | * @param $fieldName |
||
| 485 | * @param string $required |
||
| 486 | * @return string |
||
| 487 | */ |
||
| 488 | private function getXoopsFormSelectUser($language, $moduleDirname, $fieldName, $required = 'false') |
||
| 503 | |||
| 504 | /** |
||
| 505 | * @private function getXoopsFormRadioYN |
||
| 506 | * |
||
| 507 | * @param $language |
||
| 508 | * @param $fieldName |
||
| 509 | * @param $required |
||
| 510 | * |
||
| 511 | * @return string |
||
| 512 | */ |
||
| 513 | private function getXoopsFormRadioYN($language, $fieldName, $required = 'false') |
||
| 528 | |||
| 529 | /** |
||
| 530 | * @private function getXoopsFormTextDateSelect |
||
| 531 | * |
||
| 532 | * @param $language |
||
| 533 | * @param $fieldName |
||
| 534 | * @param $required |
||
| 535 | * |
||
| 536 | * @return string |
||
| 537 | */ |
||
| 538 | private function getXoopsFormTextDateSelect($language, $fieldName, $required = 'false') |
||
| 553 | |||
| 554 | /** |
||
| 555 | * @private function getXoopsFormTable |
||
| 556 | * |
||
| 557 | * @param $language |
||
| 558 | * @param $moduleDirname |
||
| 559 | * @param $tableName |
||
| 560 | * @param $fieldName |
||
| 561 | * @param $fieldElement |
||
| 562 | * @param $required |
||
| 563 | * |
||
| 564 | * @return string |
||
| 565 | */ |
||
| 566 | private function getXoopsFormTable($language, $moduleDirname, $tableName, $fieldName, $fieldElement, $required = 'false') |
||
| 588 | |||
| 589 | /** |
||
| 590 | * @private function getXoopsFormTopic |
||
| 591 | * |
||
| 592 | * @param $language |
||
| 593 | * @param $moduleDirname |
||
| 594 | * @param $topicTableName |
||
| 595 | * @param $fieldId |
||
| 596 | * @param $fieldPid |
||
| 597 | * @param $fieldMain |
||
| 598 | * @param string $required |
||
| 599 | * @return string |
||
| 600 | */ |
||
| 601 | private function getXoopsFormTopic($language, $moduleDirname, $topicTableName, $fieldId, $fieldPid, $fieldMain, $required = 'false') |
||
| 626 | |||
| 627 | /** |
||
| 628 | * @private function getXoopsFormTag |
||
| 629 | * |
||
| 630 | * @param $moduleDirname |
||
| 631 | * @param $fieldId |
||
| 632 | * @param $required |
||
| 633 | * |
||
| 634 | * @return string |
||
| 635 | */ |
||
| 636 | private function getXoopsFormTag($moduleDirname, $fieldId, $required = 'false') |
||
| 654 | |||
| 655 | /** |
||
| 656 | * @public function renderElements |
||
| 657 | * @param null |
||
| 658 | * @return string |
||
| 659 | */ |
||
| 660 | public function renderElements() |
||
| 661 | { |
||
| 662 | $tc = TDMCreateHelper::getInstance(); |
||
| 663 | $tf = TDMCreateFile::getInstance(); |
||
| 664 | $ttf = TDMCreateTableFields::getInstance(); |
||
| 665 | $module = $this->getModule(); |
||
| 666 | $table = $this->getTable(); |
||
| 667 | $moduleDirname = $module->getVar('mod_dirname'); |
||
| 668 | $tableName = $table->getVar('table_name'); |
||
| 669 | $tableSoleName = $table->getVar('table_solename'); |
||
| 670 | $languageFunct = $tf->getLanguage($moduleDirname, 'AM'); |
||
| 671 | //$language_table = $languageFunct . strtoupper($tableName); |
||
| 672 | $ret = ''; |
||
| 673 | $fields = $ttf->getTableFields($table->getVar('table_mid'), $table->getVar('table_id'), 'field_order ASC, field_id'); |
||
| 674 | $fieldId = ''; |
||
| 675 | $fieldIdTopic = ''; |
||
| 676 | $fieldPidTopic = ''; |
||
| 677 | $fieldMainTopic = ''; |
||
| 678 | $fieldElementId = []; |
||
| 679 | foreach (array_keys($fields) as $f) { |
||
| 680 | $fieldName = $fields[$f]->getVar('field_name'); |
||
| 681 | $fieldDefault = $fields[$f]->getVar('field_default'); |
||
| 682 | $fieldElement = $fields[$f]->getVar('field_element'); |
||
| 683 | $fieldParent = $fields[$f]->getVar('field_parent'); |
||
| 684 | $fieldInForm = $fields[$f]->getVar('field_inform'); |
||
| 685 | if ((0 == $f) && (1 == $table->getVar('table_autoincrement'))) { |
||
| 686 | $fieldId = $fieldName; |
||
| 687 | } |
||
| 688 | $rpFieldName = $tf->getRightString($fieldName); |
||
| 689 | $language = $languageFunct . mb_strtoupper($tableSoleName) . '_' . mb_strtoupper($rpFieldName); |
||
| 690 | $required = (1 == $fields[$f]->getVar('field_required')) ? ', true' : ''; |
||
| 691 | |||
| 692 | $fieldElements = $tc->getHandler('fieldelements')->get($fieldElement); |
||
| 693 | $fieldElementId[] = $fieldElements->getVar('fieldelement_id'); |
||
| 694 | |||
| 695 | if (1 == $fieldInForm) { |
||
| 696 | // Switch elements |
||
| 697 | switch ($fieldElement) { |
||
| 698 | case 1: |
||
| 699 | break; |
||
| 700 | case 2: |
||
| 701 | $ret .= $this->getXoopsFormText($language, $fieldName, $fieldDefault, $required); |
||
| 702 | break; |
||
| 703 | case 3: |
||
| 704 | $ret .= $this->getXoopsFormTextArea($language, $fieldName, $required); |
||
| 705 | break; |
||
| 706 | case 4: |
||
| 707 | $ret .= $this->getXoopsFormDhtmlTextArea($language, $moduleDirname, $fieldName, $required); |
||
| 708 | break; |
||
| 709 | case 5: |
||
| 710 | $ret .= $this->getXoopsFormCheckBox($language, $tableSoleName, $fieldName, $fieldElementId, $required); |
||
| 711 | break; |
||
| 712 | case 6: |
||
| 713 | $ret .= $this->getXoopsFormRadioYN($language, $fieldName, $required); |
||
| 714 | break; |
||
| 715 | case 7: |
||
| 716 | $ret .= $this->getXoopsFormSelectBox($language, $moduleDirname, $tableName, $fieldName, $required); |
||
| 717 | break; |
||
| 718 | case 8: |
||
| 719 | $ret .= $this->getXoopsFormSelectUser($language, $moduleDirname, $fieldName, $required); |
||
| 720 | break; |
||
| 721 | case 9: |
||
| 722 | $ret .= $this->getXoopsFormColorPicker($language, $moduleDirname, $fieldName, $required); |
||
| 723 | break; |
||
| 724 | case 10: |
||
| 725 | $ret .= $this->getXoopsFormImageList($languageFunct, $moduleDirname, $tableName, $tableSoleName, $fieldName, $required); |
||
| 726 | break; |
||
| 727 | case 11: |
||
| 728 | $ret .= $this->getXoopsFormSelectFile($language, $moduleDirname, $fieldName, $required); |
||
| 729 | break; |
||
| 730 | case 12: |
||
| 731 | $ret .= $this->getXoopsFormUrlFile($language, $moduleDirname, $fieldName, $fieldDefault, $required); |
||
| 732 | break; |
||
| 733 | case 13: |
||
| 734 | $ret .= $this->getXoopsFormUploadImage($languageFunct, $moduleDirname, $tableName, $tableSoleName, $fieldName, $required); |
||
| 735 | break; |
||
| 736 | case 14: |
||
| 737 | $ret .= $this->getXoopsFormUploadFile($language, $moduleDirname, $tableName, $fieldName, $required); |
||
| 738 | break; |
||
| 739 | case 15: |
||
| 740 | $ret .= $this->getXoopsFormTextDateSelect($language, $fieldName, $required); |
||
| 741 | break; |
||
| 742 | default: |
||
| 743 | // If we use tag module |
||
| 744 | if (1 == $table->getVar('table_tag')) { |
||
| 745 | $ret .= $this->getXoopsFormTag($moduleDirname, $fieldId, $required); |
||
| 746 | } |
||
| 747 | // If we want to hide XoopsFormHidden() or field id |
||
| 748 | if ((0 == $f) && (1 == $table->getVar('table_autoincrement'))) { |
||
| 749 | $ret .= $this->getXoopsFormHidden($fieldName); |
||
| 750 | } |
||
| 751 | break; |
||
| 752 | } |
||
| 753 | if ($fieldElement > 15) { |
||
| 754 | if ((1 == $fieldParent) || 1 == $table->getVar('table_category')) { |
||
| 755 | $fieldElements = $tc->getHandler('fieldelements')->get($fieldElement); |
||
| 756 | $fieldElementMid = $fieldElements->getVar('fieldelement_mid'); |
||
| 757 | $fieldElementTid = $fieldElements->getVar('fieldelement_tid'); |
||
| 758 | $fieldElementName = $fieldElements->getVar('fieldelement_name'); |
||
| 759 | $fieldNameDesc = mb_substr($fieldElementName, mb_strrpos($fieldElementName, ':'), mb_strlen($fieldElementName)); |
||
| 760 | $topicTableName = str_replace(': ', '', $fieldNameDesc); |
||
| 761 | $fieldsTopics = $ttf->getTableFields($fieldElementMid, $fieldElementTid); |
||
| 762 | foreach (array_keys($fieldsTopics) as $g) { |
||
| 763 | $fieldNameTopic = $fieldsTopics[$g]->getVar('field_name'); |
||
| 764 | if ((0 == $g) && (1 == $table->getVar('table_autoincrement'))) { |
||
| 765 | $fieldIdTopic = $fieldNameTopic; |
||
| 766 | } |
||
| 767 | if (1 == $fieldsTopics[$g]->getVar('field_parent')) { |
||
| 768 | $fieldPidTopic = $fieldNameTopic; |
||
| 769 | } |
||
| 770 | if (1 == $fieldsTopics[$g]->getVar('field_main')) { |
||
| 771 | $fieldMainTopic = $fieldNameTopic; |
||
| 772 | } |
||
| 773 | } |
||
| 774 | $ret .= $this->getXoopsFormTopic($language, $moduleDirname, $topicTableName, $fieldIdTopic, $fieldPidTopic, $fieldMainTopic, $required); |
||
| 775 | } else { |
||
| 776 | $ret .= $this->getXoopsFormTable($language, $moduleDirname, $tableName, $fieldName, $fieldElement, $required); |
||
| 777 | } |
||
| 778 | } |
||
| 779 | } |
||
| 780 | } |
||
| 781 | unset($fieldElementId); |
||
| 782 | |||
| 783 | return $ret; |
||
| 784 | } |
||
| 786 |
Loading history...
This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.