mambax7 /
tdmcreate-1.91
| Conditions | 9 |
| Paths | 27 |
| Total Lines | 143 |
| Code Lines | 101 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php namespace XoopsModules\Tdmcreate; |
||
| 305 | public function getFormEdit($fieldMid = null, $fieldTid = null, $action = false) |
||
| 306 | { |
||
| 307 | $helper = Tdmcreate\Helper::getInstance(); |
||
| 308 | // Header function class |
||
| 309 | $fieldsForm = self::getInstance(); |
||
| 310 | $form = $fieldsForm->getHeaderForm($action); |
||
| 311 | |||
| 312 | $class = 'even'; |
||
| 313 | // Get the number of fields - goffy |
||
| 314 | $tablesHandler =& $helper->getHandler('Tables'); |
||
| 315 | $tables = $tablesHandler->get($fieldTid); |
||
| 316 | $tableAutoincrement = $tables->getVar('table_autoincrement'); |
||
| 317 | $fieldNumb = $tables->getVar('table_nbfields'); |
||
| 318 | $fName = $tables->getVar('table_fieldname'); |
||
| 319 | |||
| 320 | // Get the list of fields |
||
| 321 | $cr = new \CriteriaCompo(); |
||
| 322 | $cr->add(new \Criteria('field_mid', $fieldMid)); |
||
| 323 | $cr->add(new \Criteria('field_tid', $fieldTid)); |
||
| 324 | $cr->setSort('field_order'); //added by goffy |
||
| 325 | $fields = $helper->getHandler('Fields')->getObjects($cr); |
||
| 326 | unset($cr); |
||
| 327 | $id = 1; |
||
| 328 | foreach ($fields as $field) { |
||
| 329 | $class = ('even' === $class) ? 'odd' : 'even'; |
||
| 330 | $fieldId = (int)$field->getVar('field_id'); |
||
| 331 | if ($id > $fieldNumb) { // delete additional fields, if number of fields is reduced - goffy |
||
| 332 | $fieldsObj =& $helper->getHandler('Fields')->get($fieldId); |
||
| 333 | $helper->getHandler('Fields')->delete($fieldsObj, true); |
||
| 334 | } else { |
||
| 335 | // show field with settings |
||
| 336 | $form->addElement(new \XoopsFormHidden('field_id['.$id.']', $fieldId)); |
||
| 337 | |||
| 338 | $form->addElement(new Tdmcreate\Html\FormLabel('<tr class="'.$class.'">')); |
||
| 339 | // Index ID |
||
| 340 | $form->addElement(new Tdmcreate\Html\FormLabel('<td class="center">'.$id.'</td>')); |
||
| 341 | // Field Name |
||
| 342 | $fieldName = new \XoopsFormText(_AM_TDMCREATE_FIELD_NAME, 'field_name['.$id.']', 15, 255, $field->getVar('field_name')); |
||
| 343 | $form->addElement(new Tdmcreate\Html\FormLabel('<td class="center">'.$fieldName->render().'</td>')); |
||
| 344 | // Field Type |
||
| 345 | $fieldTypeSelect = new \XoopsFormSelect(_AM_TDMCREATE_FIELD_TYPE, 'field_type['.$id.']', $field->getVar('field_type')); |
||
| 346 | $fieldTypeSelect->addOptionArray($helper->getHandler('Fieldtype')->getList()); |
||
| 347 | $form->addElement(new Tdmcreate\Html\FormLabel('<td class="center">'.$fieldTypeSelect->render().'</td>')); |
||
| 348 | // Field Value |
||
| 349 | $fieldValue = new \XoopsFormText(_AM_TDMCREATE_FIELD_VALUE, 'field_value['.$id.']', 10, 200, $field->getVar('field_value')); |
||
| 350 | $form->addElement(new Tdmcreate\Html\FormLabel('<td class="center">'.$fieldValue->render().'</td>')); |
||
| 351 | // Field Attributes |
||
| 352 | $fieldAttributesSelect = new \XoopsFormSelect(_AM_TDMCREATE_FIELD_TYPE, 'field_attribute['.$id.']', $field->getVar('field_attribute')); |
||
| 353 | $fieldAttributesSelect->addOptionArray($helper->getHandler('Fieldattributes')->getList()); |
||
| 354 | $form->addElement(new Tdmcreate\Html\FormLabel('<td class="center">'.$fieldAttributesSelect->render().'</td>')); |
||
| 355 | // Field Null |
||
| 356 | $fieldNullSelect = new \XoopsFormSelect(_AM_TDMCREATE_FIELD_NULL, 'field_null['.$id.']', $field->getVar('field_null')); |
||
| 357 | $fieldNullSelect->addOptionArray($helper->getHandler('Fieldnull')->getList()); |
||
| 358 | $form->addElement(new Tdmcreate\Html\FormLabel('<td class="center">'.$fieldNullSelect->render().'</td>')); |
||
| 359 | // Field Default |
||
| 360 | $fieldDefault = new \XoopsFormText(_AM_TDMCREATE_FIELD_DEFAULT, 'field_default['.$id.']', 15, 25, $field->getVar('field_default')); |
||
| 361 | $form->addElement(new Tdmcreate\Html\FormLabel('<td class="center">'.$fieldDefault->render().'</td>')); |
||
| 362 | // Field Key |
||
| 363 | $fieldKeySelect = new \XoopsFormSelect(_AM_TDMCREATE_FIELD_KEY, 'field_key['.$id.']', $field->getVar('field_key')); |
||
| 364 | $fieldKeySelect->addOptionArray($helper->getHandler('Fieldkey')->getList()); |
||
| 365 | $form->addElement(new Tdmcreate\Html\FormLabel('<td class="center">'.$fieldKeySelect->render().'</td>')); |
||
| 366 | // Field Void |
||
| 367 | if ((1 == $id) && (1 == $tableAutoincrement)) { |
||
| 368 | $form->addElement(new Tdmcreate\Html\FormLabel('<td> </td></tr>')); |
||
| 369 | } else { |
||
| 370 | // Box header row |
||
| 371 | $parametersTray = new \XoopsFormElementTray('', '<br>'); |
||
| 372 | // Field Elements |
||
| 373 | $crElement = new \CriteriaCompo(); |
||
| 374 | $crElement->add(new \Criteria('fieldelement_tid', 0)); |
||
| 375 | $crTable = new \CriteriaCompo(); |
||
| 376 | $crTable->add(new \Criteria('fieldelement_mid', $fieldMid)); |
||
| 377 | $fieldElementsSelect = new \XoopsFormSelect(_AM_TDMCREATE_FIELD_ELEMENT_NAME, 'field_element['.$id.']', $field->getVar('field_element')); |
||
| 378 | $fieldElementsSelect->addOptionArray($helper->getHandler('Fieldelements')->getList($crElement)); |
||
| 379 | $fieldElementsSelect->addOptionArray($helper->getHandler('Fieldelements')->getList($crTable)); |
||
| 380 | unset($crElement, $crTable); |
||
| 381 | $parametersTray->addElement($fieldElementsSelect); |
||
| 382 | |||
| 383 | $checkFieldParent = new \XoopsFormCheckBox(' ', 'field_parent['.$id.']', $field->getVar('field_parent')); |
||
| 384 | $checkFieldParent->addOption(1, _AM_TDMCREATE_FIELD_PARENT); |
||
| 385 | $parametersTray->addElement($checkFieldParent); |
||
| 386 | |||
| 387 | $checkFieldAdmin = new \XoopsFormCheckBox(' ', 'field_admin['.$id.']', $field->getVar('field_admin')); |
||
| 388 | $checkFieldAdmin->addOption(1, _AM_TDMCREATE_FIELD_ADMIN); |
||
| 389 | $parametersTray->addElement($checkFieldAdmin); |
||
| 390 | |||
| 391 | $checkFieldInList = new \XoopsFormCheckBox(' ', 'field_inlist['.$id.']', $field->getVar('field_inlist')); |
||
| 392 | $checkFieldInList->addOption(1, _AM_TDMCREATE_FIELD_INLIST); |
||
| 393 | $parametersTray->addElement($checkFieldInList); |
||
| 394 | |||
| 395 | $checkFieldInForm = new \XoopsFormCheckBox(' ', 'field_inform['.$id.']', $field->getVar('field_inform')); |
||
| 396 | $checkFieldInForm->addOption(1, _AM_TDMCREATE_FIELD_INFORM); |
||
| 397 | $parametersTray->addElement($checkFieldInForm); |
||
| 398 | |||
| 399 | $checkFieldUser = new \XoopsFormCheckBox(' ', 'field_user['.$id.']', $field->getVar('field_user')); |
||
| 400 | $checkFieldUser->addOption(1, _AM_TDMCREATE_FIELD_USER); |
||
| 401 | $parametersTray->addElement($checkFieldUser); |
||
| 402 | |||
| 403 | $checkFieldThead = new \XoopsFormCheckBox(' ', 'field_thead['.$id.']', $field->getVar('field_thead')); |
||
| 404 | $checkFieldThead->addOption(1, _AM_TDMCREATE_FIELD_THEAD); |
||
| 405 | $parametersTray->addElement($checkFieldThead); |
||
| 406 | |||
| 407 | $checkFieldTbody = new \XoopsFormCheckBox(' ', 'field_tbody['.$id.']', $field->getVar('field_tbody')); |
||
| 408 | $checkFieldTbody->addOption(1, _AM_TDMCREATE_FIELD_TBODY); |
||
| 409 | $parametersTray->addElement($checkFieldTbody); |
||
| 410 | |||
| 411 | $checkFieldTfoot = new \XoopsFormCheckBox(' ', 'field_tfoot['.$id.']', $field->getVar('field_tfoot')); |
||
| 412 | $checkFieldTfoot->addOption(1, _AM_TDMCREATE_FIELD_TFOOT); |
||
| 413 | $parametersTray->addElement($checkFieldTfoot); |
||
| 414 | |||
| 415 | $checkFieldBlock = new \XoopsFormCheckBox('', 'field_block['.$id.']', $field->getVar('field_block')); |
||
| 416 | $checkFieldBlock->addOption(1, _AM_TDMCREATE_FIELD_BLOCK); |
||
| 417 | $parametersTray->addElement($checkFieldBlock); |
||
| 418 | |||
| 419 | $check_field_search = new \XoopsFormCheckBox(' ', 'field_search['.$id.']', $field->getVar('field_search')); |
||
| 420 | $check_field_search->addOption(1, _AM_TDMCREATE_FIELD_SEARCH); |
||
| 421 | $parametersTray->addElement($check_field_search); |
||
| 422 | |||
| 423 | $checkFieldRequired = new \XoopsFormCheckBox(' ', 'field_required['.$id.']', $field->getVar('field_required')); |
||
| 424 | $checkFieldRequired->addOption(1, _AM_TDMCREATE_FIELD_REQUIRED); |
||
| 425 | $parametersTray->addElement($checkFieldRequired); |
||
| 426 | |||
| 427 | $fieldMain = (1 == $field->getVar('field_main')) ? $id : 1; |
||
| 428 | $checkFieldMain = new Tdmcreate\Form\FormRadio('', 'field_main', $fieldMain); |
||
| 429 | $checkFieldMain->addOption($id, _AM_TDMCREATE_FIELD_MAIN); |
||
| 430 | $parametersTray->addElement($checkFieldMain); |
||
| 431 | |||
| 432 | $form->addElement(new Tdmcreate\Html\FormLabel('<td><div class="portlet"><div class="portlet-header">'._AM_TDMCREATE_FIELD_PARAMETERS_LIST.'</div><div class="portlet-content">'.$parametersTray->render().'</div></div></td></tr>')); |
||
| 433 | } |
||
| 434 | } |
||
| 435 | ++$id; |
||
| 436 | } |
||
| 437 | // If you change number fields in tables, |
||
| 438 | // adding missing fields or delete unnecessary fields |
||
| 439 | // By goffy |
||
| 440 | for ($i = $id; $i <= $fieldNumb; ++$i) { |
||
| 441 | $class = ('even' === $class) ? 'odd' : 'even'; |
||
| 442 | $this->getFormNewLine($form, $class, $i, $fieldMid, $fieldTid, $fName, $tableAutoincrement); |
||
| 443 | } |
||
| 444 | unset($id); |
||
| 445 | |||
| 446 | // Footer form |
||
| 447 | return $fieldsForm->getFooterForm($form); |
||
| 448 | } |
||
| 499 |
Loading history...