Issues (496)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/Common/FilesManagement.php (9 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php namespace XoopsModules\Smartobject\Common;
2
3
/*
4
 You may not change or alter any portion of this comment or credits
5
 of supporting developers from this source code or any supporting source code
6
 which is considered copyrighted (c) material of the original comment or credit authors.
7
8
 This program is distributed in the hope that it will be useful,
9
 but WITHOUT ANY WARRANTY; without even the implied warranty of
10
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11
 */
12
13
/**
14
 * @copyright   XOOPS Project (https://xoops.org)
15
 * @license     http://www.fsf.org/copyleft/gpl.html GNU public license
16
 * @author      mamba <[email protected]>
17
 */
18
trait FilesManagement
19
{
20
    /**
21
     * Function responsible for checking if a directory exists, we can also write in and create an index.html file
22
     *
23
     * @param string $folder The full path of the directory to check
24
     *
25
     * @return void
26
     * @throws \RuntimeException
27
     */
28
    public static function createFolder($folder)
29
    {
30
        try {
31
            if (!file_exists($folder)) {
32
                if (!is_dir($folder) && !mkdir($folder) && !is_dir($folder)) {
33
                    throw new \RuntimeException(sprintf('Unable to create the %s directory', $folder));
34
                }
35
36
                file_put_contents($folder . '/index.html', '<script>history.go(-1);</script>');
37
            }
38
        } catch (\Exception $e) {
39
            echo 'Caught exception: ', $e->getMessage(), "\n", '<br>';
40
        }
41
    }
42
43
    /**
44
     * @param $file
45
     * @param $folder
46
     * @return bool
47
     */
48
    public static function copyFile($file, $folder)
49
    {
50
        return copy($file, $folder);
51
    }
52
53
    /**
54
     * @param $src
55
     * @param $dst
56
     */
57
    public static function recurseCopy($src, $dst)
58
    {
59
        $dir = opendir($src);
60
        //        @mkdir($dst);
61
        if (!mkdir($dst) && !is_dir($dst)) {
62
            while (false !== ($file = readdir($dir))) {
63
                if (('.' !== $file) && ('..' !== $file)) {
64
                    if (is_dir($src . '/' . $file)) {
65
                        self::recurseCopy($src . '/' . $file, $dst . '/' . $file);
66
                    } else {
67
                        copy($src . '/' . $file, $dst . '/' . $file);
68
                    }
69
                }
70
            }
71
        }
72
        closedir($dir);
73
    }
74
75
    /**
76
     *
77
     * Remove files and (sub)directories
78
     *
79
     * @param string $src source directory to delete
80
     *
81
     * @uses \Xmf\Module\Helper::getHelper()
82
     * @uses \Xmf\Module\Helper::isUserAdmin()
83
     *
84
     * @return bool true on success
85
     */
86
    public static function deleteDirectory($src)
87
    {
88
        // Only continue if user is a 'global' Admin
89
        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
0 ignored issues
show
The class XoopsUser does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
90
            return false;
91
        }
92
93
        $success = true;
94
        // remove old files
95
        $dirInfo = new \SplFileInfo($src);
96
        // validate is a directory
97
        if ($dirInfo->isDir()) {
98
            $fileList = array_diff(scandir($src, SCANDIR_SORT_NONE), ['..', '.']);
99
            foreach ($fileList as $k => $v) {
100
                $fileInfo = new \SplFileInfo("{$src}/{$v}");
101
                if ($fileInfo->isDir()) {
102
                    // recursively handle subdirectories
103
                    if (!$success = self::deleteDirectory($fileInfo->getRealPath())) {
104
                        break;
105
                    }
106
                } else {
107
                    // delete the file
108
                    if (!($success = unlink($fileInfo->getRealPath()))) {
109
                        break;
110
                    }
111
                }
112
            }
113
            // now delete this (sub)directory if all the files are gone
114
            if ($success) {
115
                $success = rmdir($dirInfo->getRealPath());
116
            }
117
        } else {
118
            // input is not a valid directory
119
            $success = false;
120
        }
121
        return $success;
122
    }
123
124
    /**
125
     *
126
     * Recursively remove directory
127
     *
128
     * @todo currently won't remove directories with hidden files, should it?
129
     *
130
     * @param string $src directory to remove (delete)
131
     *
132
     * @return bool true on success
133
     */
134
    public static function rrmdir($src)
135
    {
136
        // Only continue if user is a 'global' Admin
137
        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
0 ignored issues
show
The class XoopsUser does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
138
            return false;
139
        }
140
141
        // If source is not a directory stop processing
142
        if (!is_dir($src)) {
143
            return false;
144
        }
145
146
        $success = true;
0 ignored issues
show
$success is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
147
148
        // Open the source directory to read in files
149
        $iterator = new \DirectoryIterator($src);
150
        foreach ($iterator as $fObj) {
151
            if ($fObj->isFile()) {
152
                $filename = $fObj->getPathname();
153
                $fObj     = null; // clear this iterator object to close the file
154
                if (!unlink($filename)) {
155
                    return false; // couldn't delete the file
156
                }
157
            } elseif (!$fObj->isDot() && $fObj->isDir()) {
158
                // Try recursively on directory
159
                self::rrmdir($fObj->getPathname());
160
            }
161
        }
162
        $iterator = null;   // clear iterator Obj to close file/directory
0 ignored issues
show
$iterator is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
163
        return rmdir($src); // remove the directory & return results
164
    }
165
166
    /**
167
     * Recursively move files from one directory to another
168
     *
169
     * @param string $src  - Source of files being moved
170
     * @param string $dest - Destination of files being moved
171
     *
172
     * @return bool true on success
173
     */
174 View Code Duplication
    public static function rmove($src, $dest)
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
175
    {
176
        // Only continue if user is a 'global' Admin
177
        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
0 ignored issues
show
The class XoopsUser does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
178
            return false;
179
        }
180
181
        // If source is not a directory stop processing
182
        if (!is_dir($src)) {
183
            return false;
184
        }
185
186
        // If the destination directory does not exist and could not be created stop processing
187
        if (!is_dir($dest) && !mkdir($dest) && !is_dir($dest)) {
188
            return false;
189
        }
190
191
        // Open the source directory to read in files
192
        $iterator = new \DirectoryIterator($src);
193
        foreach ($iterator as $fObj) {
194
            if ($fObj->isFile()) {
195
                rename($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
196
            } elseif (!$fObj->isDot() && $fObj->isDir()) {
197
                // Try recursively on directory
198
                self::rmove($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
199
                //                rmdir($fObj->getPath()); // now delete the directory
200
            }
201
        }
202
        $iterator = null;   // clear iterator Obj to close file/directory
0 ignored issues
show
$iterator is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
203
        return rmdir($src); // remove the directory & return results
204
    }
205
206
    /**
207
     * Recursively copy directories and files from one directory to another
208
     *
209
     * @param string $src  - Source of files being moved
210
     * @param string $dest - Destination of files being moved
211
     *
212
     * @uses \Xmf\Module\Helper::getHelper()
213
     * @uses \Xmf\Module\Helper::isUserAdmin()
214
     *
215
     * @return bool true on success
216
     */
217 View Code Duplication
    public static function rcopy($src, $dest)
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
218
    {
219
        // Only continue if user is a 'global' Admin
220
        if (!($GLOBALS['xoopsUser'] instanceof \XoopsUser) || !$GLOBALS['xoopsUser']->isAdmin()) {
0 ignored issues
show
The class XoopsUser does not exist. Did you forget a USE statement, or did you not list all dependencies?

This error could be the result of:

1. Missing dependencies

PHP Analyzer uses your composer.json file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the composer.json to be in the root folder of your repository.

Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the require or require-dev section?

2. Missing use statement

PHP does not complain about undefined classes in ìnstanceof checks. For example, the following PHP code will work perfectly fine:

if ($x instanceof DoesNotExist) {
    // Do something.
}

If you have not tested against this specific condition, such errors might go unnoticed.

Loading history...
221
            return false;
222
        }
223
224
        // If source is not a directory stop processing
225
        if (!is_dir($src)) {
226
            return false;
227
        }
228
229
        // If the destination directory does not exist and could not be created stop processing
230
        if (!is_dir($dest) && !mkdir($dest) && !is_dir($dest)) {
231
            return false;
232
        }
233
234
        // Open the source directory to read in files
235
        $iterator = new \DirectoryIterator($src);
236
        foreach ($iterator as $fObj) {
237
            if ($fObj->isFile()) {
238
                copy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
239
            } elseif (!$fObj->isDot() && $fObj->isDir()) {
240
                self::rcopy($fObj->getPathname(), "{$dest}/" . $fObj->getFilename());
241
            }
242
        }
243
        return true;
244
    }
245
}
246